shaka-player 4.6.16 → 4.6.17

package/docs/tutorials/faq.md

@@ -245,6 +245,19 @@ the following configuration:
 player.configure('manifest.hls.liveSegmentsDelay', 1);
 ```
 
+<hr>
+
+**Q:** Why can I not find the new version of Shaka Player on
+ajax.googleapis.com?
+
+**A:** When a new version of Shaka Player is released on GitHub, it has to
+undergo a brief manual review process before it can be uploaded to Google's
+servers. After approval, the upload process then usually takes several hours.
+Therefore it is not unusual for a day or two to pass before a new version of
+Shaka Player is hosted on Google's ajax.googleapis.com website. We ask for your
+patience in these matters.
+
+
 [386]: https://github.com/shaka-project/shaka-player/issues/386#issuecomment-227898001
 [489]: https://github.com/shaka-project/shaka-player/issues/489#issuecomment-240466224
 [743]: https://github.com/shaka-project/shaka-player/issues/743

package/docs/tutorials/offline.md

@@ -340,6 +340,9 @@ you want.
 At this point, the content is now stored offline and it's ready to be played.
 Next we will add functionality to play offline content.
 
+Note: If you call `storage.store` twice with the same manifestUri as input,
+you'll download the same manifestUri twice.
+
 ## Playing Offline Content
 
 Now that we have stored some content, we want to play it. To do this, resolve

package/lib/media/playhead.js

@@ -382,10 +382,10 @@ shaka.media.MediaSourcePlayhead = class {
       seekStart = seekEnd - this.minSeekRange_;
     }
 
-    if (currentTime < seekStart) {
-      // The seek range has moved past the playhead.  Move ahead to catch up.
+    if (currentTime < seekStart || currentTime > seekEnd) {
+      // playhead is outside of the seekrange.  Move playhead to catch up.
       const targetTime = this.reposition_(currentTime);
-      shaka.log.info('Jumping forward ' + (targetTime - currentTime) +
+      shaka.log.info('Jumping by ' + (targetTime - currentTime) +
                      ' seconds to catch up with the seek range.');
       this.mediaElement_.currentTime = targetTime;
     }

package/lib/media/streaming_engine.js

@@ -878,7 +878,6 @@ shaka.media.StreamingEngine = class {
       // The playhead might be seeking on startup, if a start time is set, so
       // start "seeked" as true.
       seeked: true,
-      needsResync: false,
       recovering: false,
       hasError: false,
       operation: null,
@@ -1245,11 +1244,6 @@ shaka.media.StreamingEngine = class {
       shaka.log.v1(
           logPrefix, 'looking up segment from new stream endTime:', time);
 
-      // Using a new iterator means we need to resync the stream in sequence
-      // mode.  The buffered range might not align perfectly with the last
-      // segment end time, so we may end up repeating a segment.  Resyncing
-      // makes this safe to do.
-      mediaState.needsResync = true;
       mediaState.segmentIterator =
           mediaState.stream.segmentIndex.getIteratorForTime(time);
       const ref = mediaState.segmentIterator &&
@@ -1869,9 +1863,7 @@ shaka.media.StreamingEngine = class {
       // Across discontinuity bounds, we should resync timestamps for
       // sequence mode playbacks.  The next segment appended should
       // land at its theoretical timestamp from the segment index.
-      if (reference.discontinuitySequence != lastDiscontinuitySequence ||
-          mediaState.needsResync) {
-        mediaState.needsResync = false;
+      if (reference.discontinuitySequence != lastDiscontinuitySequence) {
         operations.push(this.playerInterface_.mediaSourceEngine.resync(
             mediaState.type, reference.startTime));
       }
@@ -2541,7 +2533,6 @@ shaka.media.StreamingEngine.PlayerInterface;
  *   clearBufferSafeMargin: number,
  *   clearingBuffer: boolean,
  *   seeked: boolean,
- *   needsResync: boolean,
  *   adaptation: boolean,
  *   recovering: boolean,
  *   hasError: boolean,
@@ -2596,9 +2587,6 @@ shaka.media.StreamingEngine.PlayerInterface;
  *   True indicates that the presentation just seeked.
  * @property {boolean} adaptation
  *   True indicates that the presentation just automatically switched variants.
- * @property {boolean} needsResync
- *   True indicates that the stream needs to be resynced in sequence mode,
- *   regardless of discontinuity sequence.
  * @property {boolean} recovering
  *   True indicates that the last segment was not appended because it could not
  *   fit in the buffer.

package/lib/player.js

@@ -3544,12 +3544,16 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
         const currentTime = this.video_.currentTime;
         const seekRange = this.seekRange();
         const safeSeekOffset = this.config_.streaming.safeSeekOffset;
+
+        // Cancel trick play if we hit the beginning or end of the seekable
+        // (Sub-second accuracy not required here)
         if (rate > 0) {
-          if (currentTime >= seekRange.end) {
+          if (Math.floor(currentTime) >= Math.floor(seekRange.end)) {
             this.cancelTrickPlay();
           }
         } else {
-          if (currentTime <= (seekRange.start + safeSeekOffset)) {
+          if (Math.floor(currentTime) <=
+              Math.floor(seekRange.start + safeSeekOffset)) {
             this.cancelTrickPlay();
           }
         }
@@ -6850,7 +6854,7 @@ shaka.Player.TYPICAL_BUFFERING_THRESHOLD_ = 0.5;
  * @export
  */
 // eslint-disable-next-line no-useless-concat
-shaka.Player.version = 'v4.6.16' + '-uncompiled';  // x-release-please-version
+shaka.Player.version = 'v4.6.17' + '-uncompiled';  // x-release-please-version
 
 // Initialize the deprecation system using the version string we just set
 // on the player.

package/lib/util/stream_utils.js

@@ -1321,8 +1321,6 @@ shaka.util.StreamUtils = class {
    * @return {shaka.extern.Track}
    */
   static html5TextTrackToTrack(textTrack) {
-    const CLOSED_CAPTION_MIMETYPE =
-        shaka.util.MimeUtils.CEA608_CLOSED_CAPTION_MIMETYPE;
     const StreamUtils = shaka.util.StreamUtils;
 
     /** @type {shaka.extern.Track} */
@@ -1331,7 +1329,8 @@ shaka.util.StreamUtils = class {
     track.type = 'text';
     track.originalTextId = textTrack.id;
     if (textTrack.kind == 'captions') {
-      track.mimeType = CLOSED_CAPTION_MIMETYPE;
+      // See: https://github.com/shaka-project/shaka-player/issues/6233
+      track.mimeType = 'unknown';
     }
     if (textTrack.kind == 'subtitles') {
       track.mimeType = 'text/vtt';

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "shaka-player",
   "description": "DASH/EME video player library",
-  "version": "4.6.16",
+  "version": "4.6.17",
   "homepage": "https://github.com/shaka-project/shaka-player",
   "author": "Google",
   "maintainers": [

package/test/media/playhead_unit.js

@@ -683,7 +683,7 @@ describe('Playhead', () => {
 
     // It should allow a small buffer around the seek range.
     seekCount = 0;
-    currentTime = 1030.062441;
+    currentTime = 1030;
     jasmine.clock().tick(500);
     currentTime = 1027.9233;
     jasmine.clock().tick(500);