shaka-player 4.5.0 → 4.6.0

package/test/player_unit.js

@@ -48,7 +48,7 @@ describe('Player', () => {
   /** @type {!shaka.test.FakeVideo} */
   let video;
 
-  beforeEach(() => {
+  beforeEach(async () => {
     // By default, errors are a failure.
     logErrorSpy = jasmine.createSpy('shaka.log.error');
     logErrorSpy.calls.reset();
@@ -124,6 +124,7 @@ describe('Player', () => {
         open: jasmine.createSpy('open').and.returnValue(Promise.resolve()),
         destroy:
             jasmine.createSpy('destroy').and.returnValue(Promise.resolve()),
+        setTextDisplayer: jasmine.createSpy('setTextDisplayer'),
         setUseEmbeddedText: jasmine.createSpy('setUseEmbeddedText'),
         getUseEmbeddedText: jasmine.createSpy('getUseEmbeddedText'),
         setSegmentRelativeVttTiming:
@@ -151,7 +152,8 @@ describe('Player', () => {
     }
 
     video = new shaka.test.FakeVideo(20);
-    player = new shaka.Player(video, dependencyInjector);
+    player = new shaka.Player(null, dependencyInjector);
+    await player.attach(video);
     player.configure({
       // Ensures we don't get a warning about missing preference.
       preferredAudioLanguage: 'en',
@@ -170,6 +172,7 @@ describe('Player', () => {
     try {
       await player.destroy();
     } finally {
+      player.releaseAllMutexes();
       shaka.log.error = originalLogError;
       shaka.log.alwaysError = originalLogError;
       shaka.log.warning = originalLogWarn;
@@ -234,31 +237,6 @@ describe('Player', () => {
       expect(mediaSourceEngine.destroy).toHaveBeenCalled();
       expect(drmEngine.destroy).toHaveBeenCalled();
     });
-
-    // TODO(vaage): Re-enable once the parser is integrated into the load graph
-    //              better.
-    xit('destroys parser first when interrupting load', async () => {
-      const p = shaka.test.Util.shortDelay();
-      /** @type {!shaka.test.FakeManifestParser} */
-      const parser = new shaka.test.FakeManifestParser(manifest);
-      parser.start.and.returnValue(p);
-      parser.stop.and.callFake(() => {
-        expect(abrManager.stop).not.toHaveBeenCalled();
-        expect(abrManager.release).not.toHaveBeenCalled();
-        expect(networkingEngine.destroy).not.toHaveBeenCalled();
-      });
-      shaka.media.ManifestParser.registerParserByMime(
-          fakeMimeType, () => parser);
-
-      const load = player.load(fakeManifestUri, 0, fakeMimeType);
-      await shaka.test.Util.shortDelay();
-      await player.destroy();
-      expect(abrManager.stop).toHaveBeenCalled();
-      expect(abrManager.release).toHaveBeenCalled();
-      expect(networkingEngine.destroy).toHaveBeenCalled();
-      expect(parser.stop).toHaveBeenCalled();
-      await expectAsync(load).toBeRejected();
-    });
   });
 
   describe('load/unload', () => {
@@ -1503,6 +1481,7 @@ describe('Player', () => {
           frameRate: 1000000 / 42000,
           pixelAspectRatio: '59:54',
           hdr: null,
+          videoLayout: null,
           mimeType: 'video/mp4',
           audioMimeType: 'audio/mp4',
           videoMimeType: 'video/mp4',
@@ -1541,6 +1520,7 @@ describe('Player', () => {
           frameRate: 24,
           pixelAspectRatio: '59:54',
           hdr: null,
+          videoLayout: null,
           mimeType: 'video/mp4',
           audioMimeType: 'audio/mp4',
           videoMimeType: 'video/mp4',
@@ -1579,6 +1559,7 @@ describe('Player', () => {
           frameRate: 1000000 / 42000,
           pixelAspectRatio: '59:54',
           hdr: null,
+          videoLayout: null,
           mimeType: 'video/mp4',
           audioMimeType: 'audio/mp4',
           videoMimeType: 'video/mp4',
@@ -1617,6 +1598,7 @@ describe('Player', () => {
           frameRate: 24,
           pixelAspectRatio: '59:54',
           hdr: null,
+          videoLayout: null,
           mimeType: 'video/mp4',
           audioMimeType: 'audio/mp4',
           videoMimeType: 'video/mp4',
@@ -1655,6 +1637,7 @@ describe('Player', () => {
           frameRate: 1000000 / 42000,
           pixelAspectRatio: '59:54',
           hdr: null,
+          videoLayout: null,
           mimeType: 'video/mp4',
           audioMimeType: 'audio/mp4',
           videoMimeType: 'video/mp4',
@@ -1693,6 +1676,7 @@ describe('Player', () => {
           frameRate: 24,
           pixelAspectRatio: '59:54',
           hdr: null,
+          videoLayout: null,
           mimeType: 'video/mp4',
           audioMimeType: 'audio/mp4',
           videoMimeType: 'video/mp4',
@@ -1731,6 +1715,7 @@ describe('Player', () => {
           frameRate: 1000000 / 42000,
           pixelAspectRatio: '59:54',
           hdr: null,
+          videoLayout: null,
           mimeType: 'video/mp4',
           audioMimeType: 'audio/mp4',
           videoMimeType: 'video/mp4',
@@ -1769,6 +1754,7 @@ describe('Player', () => {
           frameRate: 24,
           pixelAspectRatio: '59:54',
           hdr: null,
+          videoLayout: null,
           mimeType: 'video/mp4',
           audioMimeType: 'audio/mp4',
           videoMimeType: 'video/mp4',
@@ -1826,6 +1812,7 @@ describe('Player', () => {
           frameRate: null,
           pixelAspectRatio: null,
           hdr: null,
+          videoLayout: null,
           videoId: null,
           audioId: null,
           originalAudioId: null,
@@ -1864,6 +1851,7 @@ describe('Player', () => {
           frameRate: null,
           pixelAspectRatio: null,
           hdr: null,
+          videoLayout: null,
           videoId: null,
           audioId: null,
           originalAudioId: null,
@@ -1902,6 +1890,7 @@ describe('Player', () => {
           frameRate: null,
           pixelAspectRatio: null,
           hdr: null,
+          videoLayout: null,
           videoId: null,
           audioId: null,
           originalAudioId: null,
@@ -1943,6 +1932,7 @@ describe('Player', () => {
           frameRate: null,
           pixelAspectRatio: null,
           hdr: null,
+          videoLayout: null,
           videoId: null,
           audioId: null,
           originalAudioId: null,
@@ -4179,6 +4169,69 @@ describe('Player', () => {
         expect(thumbnail8.duration).toBe(10);
       });
     });
+
+    describe('getAllThumbnails', () => {
+      it('returns all thumbnails', async () => {
+        const uris = () => ['thumbnail'];
+        const ref = new shaka.media.SegmentReference(
+            0, 60, uris, 0, null, null, 0, 0, Infinity, [],
+        );
+        const index = new shaka.media.SegmentIndex([ref]);
+
+        manifest = shaka.test.ManifestGenerator.generate((manifest) => {
+          manifest.addVariant(0, (variant) => {
+            variant.addVideo(1);
+          });
+          manifest.addImageStream(5, (stream) => {
+            stream.originalId = 'thumbnail';
+            stream.width = 200;
+            stream.height = 150;
+            stream.mimeType = 'image/jpeg';
+            stream.tilesLayout = '2x3';
+            stream.segmentIndex = index;
+          });
+        });
+
+        await player.load(fakeManifestUri, 0, fakeMimeType);
+
+        expect(player.getImageTracks()[0].width).toBe(100);
+        expect(player.getImageTracks()[0].height).toBe(50);
+        const thumbnails = await player.getAllThumbnails(5);
+        expect(thumbnails.length).toBe(6);
+        expect(thumbnails[0]).toEqual(jasmine.objectContaining({
+          imageHeight: 150,
+          imageWidth: 200,
+          positionX: 0,
+          positionY: 0,
+          width: 100,
+          height: 50,
+        }));
+        expect(thumbnails[1]).toEqual(jasmine.objectContaining({
+          imageHeight: 150,
+          imageWidth: 200,
+          positionX: 100,
+          positionY: 0,
+          width: 100,
+          height: 50,
+        }));
+        expect(thumbnails[2]).toEqual(jasmine.objectContaining({
+          imageHeight: 150,
+          imageWidth: 200,
+          positionX: 0,
+          positionY: 50,
+          width: 100,
+          height: 50,
+        }));
+        expect(thumbnails[5]).toEqual(jasmine.objectContaining({
+          imageHeight: 150,
+          imageWidth: 200,
+          positionX: 100,
+          positionY: 100,
+          width: 100,
+          height: 50,
+        }));
+      });
+    });
   });
 
   describe('config streaming.startAtSegmentBoundary', () => {

package/test/test/util/fake_media_source_engine.js

@@ -147,6 +147,11 @@ shaka.test.FakeMediaSourceEngine = class {
     return Promise.resolve();
   }
 
+  /** @override */
+  isStreamingAllowed() {
+    return true;
+  }
+
   /**
    * @param {string} type
    * @return {?number}

package/test/test/util/fake_networking_engine.js

@@ -49,6 +49,9 @@ shaka.test.FakeNetworkingEngine = class {
     /** @type {!jasmine.Spy} */
     this.setForceHTTPS = jasmine.createSpy('setForceHTTPS').and.stub();
 
+    /** @private {number} */
+    this.maxUris_ = 1;
+
     // The prototype has already been applied; create spies for the
     // methods but still call it by default.
     spyOn(this, 'destroy').and.callThrough();
@@ -67,7 +70,7 @@ shaka.test.FakeNetworkingEngine = class {
    */
   requestImpl_(type, request) {
     expect(request).toBeTruthy();
-    expect(request.uris.length).toBe(1);
+    expect(request.uris.length).toBeLessThanOrEqual(this.maxUris_);
 
     const requestedUri = request.uris[0];
 
@@ -288,6 +291,11 @@ shaka.test.FakeNetworkingEngine = class {
     return this;
   }
 
+  setMaxUris(maxUris) {
+    this.maxUris_ = maxUris;
+    return this;
+  }
+
   /**
    * Expects that a request for the given segment has occurred.
    *

package/test/test/util/fake_segment_prefetch.js

@@ -78,4 +78,7 @@ shaka.test.FakeSegmentPrefetch = class {
     }
     return null;
   }
+
+  /** @override */
+  prefetchInitSegment(reference) {}
 };

package/test/test/util/manifest_generator.js

@@ -556,11 +556,15 @@ shaka.test.ManifestGenerator.Stream = class {
       /** @type {(string|undefined)} */
       this.hdr = undefined;
       /** @type {(string|undefined)} */
+      this.videoLayout = undefined;
+      /** @type {(string|undefined)} */
       this.tilesLayout = undefined;
       /** @type {?shaka.media.ManifestParser.AccessibilityPurpose} */
       this.accessibilityPurpose;
       /** @type {boolean} */
       this.external = false;
+      /** @type {boolean} */
+      this.fastSwitching = false;
     }
 
     /** @type {shaka.extern.Stream} */

package/test/test/util/manifest_parser_util.js

@@ -42,7 +42,7 @@ shaka.test.ManifestParser = class {
   /**
    * Creates a segment reference using a relative URI.
    *
-   * @param {string} uri A relative URI to http://example.com
+   * @param {string|Array.<string>} uri A relative URI to http://example.com
    * @param {number} start
    * @param {number} end
    * @param {string=} baseUri
@@ -57,7 +57,19 @@ shaka.test.ManifestParser = class {
   static makeReference(uri, start, end, baseUri = '',
       startByte = 0, endByte = null, timestampOffset = 0,
       partialReferences = [], tilesLayout = '', syncTime = null) {
-    const getUris = () => uri.length ? [baseUri + uri] : [];
+    const getUris = () => {
+      const uris = [];
+      if (uri instanceof Array) {
+        for (const url of uri) {
+          if (url.length) {
+            uris.push(baseUri + url);
+          }
+        }
+      } else if (uri.length) {
+        uris.push(baseUri + uri);
+      }
+      return uris;
+    };
 
     // If a test wants to verify these, they can be set explicitly after
     // makeReference is called.

package/test/test/util/offline_utils.js

@@ -59,6 +59,7 @@ shaka.test.OfflineUtils = class {
       spatialAudio: false,
       closedCaptions: null,
       external: false,
+      fastSwitching: false,
     };
   }
 

package/test/test/util/simple_fakes.js

@@ -529,7 +529,7 @@ shaka.test.FakeTransmuxer = class {
         jasmine.createSpy('transmux').and.returnValue(Promise.resolve(output));
 
     /** @type {!jasmine.Spy} */
-    this.getOrginalMimeType =
-        jasmine.createSpy('getOrginalMimeType').and.returnValue('mimeType');
+    this.getOriginalMimeType =
+        jasmine.createSpy('getOriginalMimeType').and.returnValue('mimeType');
   }
 };

package/test/test/util/streaming_engine_util.js

@@ -417,6 +417,7 @@ shaka.test.StreamingEngineUtil = class {
       spatialAudio: false,
       accessibilityPurpose: null,
       external: false,
+      fastSwitching: false,
     };
   }
 
@@ -459,6 +460,7 @@ shaka.test.StreamingEngineUtil = class {
       spatialAudio: false,
       accessibilityPurpose: null,
       external: false,
+      fastSwitching: false,
     };
   }
 
@@ -498,6 +500,7 @@ shaka.test.StreamingEngineUtil = class {
       spatialAudio: false,
       accessibilityPurpose: null,
       external: false,
+      fastSwitching: false,
     };
   }
 };

package/test/test/util/test_scheme.js

@@ -763,6 +763,12 @@ shaka.test.TestScheme.ManifestParser = class {
 
   /** @override */
   onExpirationUpdated() {}
+
+  /** @override */
+  onInitialVariantChosen() {}
+
+  /** @override */
+  banLocation() {}
 };
 
 

package/test/test/util/ui_utils.js

@@ -9,10 +9,11 @@ shaka.test.UiUtils = class {
    * @param {!HTMLElement} videoContainer
    * @param {!HTMLMediaElement} video
    * @param {!Object=} config
-   * @return {!shaka.ui.Overlay}
+   * @return {!Promise.<!shaka.ui.Overlay>}
    */
-  static createUIThroughAPI(videoContainer, video, config) {
-    const player = new shaka.Player(video);
+  static async createUIThroughAPI(videoContainer, video, config) {
+    const player = new shaka.Player();
+    await player.attach(video);
     // Create UI
     config = config || {};
     const ui = new shaka.ui.Overlay(player, videoContainer, video);

package/test/text/mp4_ttml_parser_unit.js

@@ -43,7 +43,7 @@ describe('Mp4TtmlParser', () => {
     parser.parseInit(ttmlInitSegment);
     const time =
         {periodStart: 0, segmentStart: 0, segmentEnd: 60, vttOffset: 0};
-    const ret = parser.parseMedia(ttmlSegmentMultipleMDAT, time);
+    const ret = parser.parseMedia(ttmlSegmentMultipleMDAT, time, null);
     // Bodies.
     expect(ret.length).toBe(2);
     // Divs.
@@ -63,10 +63,10 @@ describe('Mp4TtmlParser', () => {
     const parser = new shaka.text.Mp4TtmlParser();
     parser.parseInit(ttmlInitSegment);
 
-    const ret1 = parser.parseMedia(ttmlSegment, time1);
+    const ret1 = parser.parseMedia(ttmlSegment, time1, null);
     expect(ret1.length).toBeGreaterThan(0);
 
-    const ret2 = parser.parseMedia(ttmlSegment, time2);
+    const ret2 = parser.parseMedia(ttmlSegment, time2, null);
     expect(ret2.length).toBeGreaterThan(0);
 
     expect(ret2[0].startTime).toBe(ret1[0].startTime + 7);
@@ -164,7 +164,7 @@ describe('Mp4TtmlParser', () => {
     parser.parseInit(ttmlInitSegment);
     const time =
         {periodStart: 0, segmentStart: 0, segmentEnd: 60, vttOffset: 0};
-    const result = parser.parseMedia(ttmlSegment, time);
+    const result = parser.parseMedia(ttmlSegment, time, null);
     shaka.test.TtmlUtils.verifyHelper(
         cues, result, {startTime: 23, endTime: 53.5});
   });

package/test/text/srt_text_parser_unit.js

@@ -149,7 +149,7 @@ describe('SrtTextParser', () => {
     const data = BufferUtils.toUint8(StringUtils.toUTF8(text));
 
     const parser = new shaka.text.SrtTextParser();
-    const result = parser.parseMedia(data, time);
+    const result = parser.parseMedia(data, time, null);
 
     const expected = cues.map((cue) => {
       if (cue.nestedCues) {

package/test/text/text_displayer_layout_unit.js

@@ -37,7 +37,7 @@ filterDescribe('Cue layout', shaka.test.TextLayoutTests.supported, () => {
         // Set up UI controls.  The video element is in a paused state by
         // default, so the controls should be shown.  The video is not in the
         // DOM and is purely temporary.
-        const player = new shaka.Player(null);
+        const player = new shaka.Player();
         ui = new shaka.ui.Overlay(
             player, /** @type {!HTMLElement} */(helper.videoContainer),
             shaka.test.UiUtils.createVideoElement());

package/test/text/text_engine_unit.js

@@ -105,6 +105,7 @@ describe('TextEngine', () => {
       expect(mockParseMedia).toHaveBeenCalledOnceMoreWith([
         dummyData,
         {periodStart: 0, segmentStart: 0, segmentEnd: 3, vttOffset: 0},
+        undefined,
       ]);
 
       expect(mockDisplayer.appendSpy).toHaveBeenCalledOnceMoreWith([
@@ -120,6 +121,7 @@ describe('TextEngine', () => {
       expect(mockParseMedia).toHaveBeenCalledOnceMoreWith([
         dummyData,
         {periodStart: 0, segmentStart: 3, segmentEnd: 5, vttOffset: 0},
+        undefined,
       ]);
 
       expect(mockDisplayer.appendSpy).toHaveBeenCalledOnceMoreWith([
@@ -272,6 +274,7 @@ describe('TextEngine', () => {
       expect(mockParseMedia).toHaveBeenCalledOnceMoreWith([
         dummyData,
         {periodStart: 0, segmentStart: 0, segmentEnd: 3, vttOffset: 0},
+        undefined,
       ]);
       expect(mockDisplayer.appendSpy).toHaveBeenCalledOnceMoreWith([
         [
@@ -286,6 +289,7 @@ describe('TextEngine', () => {
       expect(mockParseMedia).toHaveBeenCalledOnceMoreWith([
         dummyData,
         {periodStart: 4, segmentStart: 4, segmentEnd: 7, vttOffset: 4},
+        undefined,
       ]);
       expect(mockDisplayer.appendSpy).toHaveBeenCalledOnceMoreWith([
         [
@@ -316,6 +320,7 @@ describe('TextEngine', () => {
       expect(mockParseMedia).toHaveBeenCalledOnceMoreWith([
         dummyData,
         {periodStart: 0, segmentStart: 0, segmentEnd: 3, vttOffset: 0},
+        undefined,
       ]);
 
       textEngine.setTimestampOffset(8);
@@ -325,6 +330,7 @@ describe('TextEngine', () => {
       expect(mockParseMedia).toHaveBeenCalledOnceMoreWith([
         dummyData,
         {periodStart: 8, segmentStart: 4, segmentEnd: 7, vttOffset: 4},
+        undefined,
       ]);
     });
   });

package/test/text/ttml_text_parser_unit.js

@@ -1263,6 +1263,35 @@ describe('TtmlTextParser', () => {
         });
   });
 
+  it('supports smpte:backgroundImage attribute with url', () => {
+    verifyHelper(
+        [
+          {
+            startTime: 62.05,
+            endTime: 3723.2,
+            payload: '',
+          },
+        ],
+        '<tt ' +
+        'xmlns:ttm="http://www.w3.org/ns/ttml#metadata" ' +
+        'xmlns:smpte="http://www.smpte-ra.org/schemas/2052-1/2010/smpte-tt">' +
+        '<metadata>' +
+        '<smpte:image imageType="PNG" encoding="Base64" xml:id="img_0">' +
+        'base64EncodedImage</smpte:image>' +
+        '</metadata>' +
+        '<body><div smpte:backgroundImage="img_0.png">' +
+        '<p begin="01:02.05" end="01:02:03.200"></p>' +
+        '</div></body></tt>',
+        {periodStart: 0, segmentStart: 60, segmentEnd: 3730, vttOffset: 0},
+        {startTime: 62.05, endTime: 3723.2},
+        {
+          startTime: 62.05,
+          endTime: 3723.2,
+          backgroundImage: 'foo://bar/img_0.png',
+          isContainer: false,
+        });
+  });
+
   it('supports smpte:backgroundImage attribute in div element', () => {
     verifyHelper(
         [],
@@ -2112,7 +2141,8 @@ describe('TtmlTextParser', () => {
   function verifyHelper(cues, text, time, bodyProperties, divProperties) {
     const data =
         shaka.util.BufferUtils.toUint8(shaka.util.StringUtils.toUTF8(text));
-    const result = new shaka.text.TtmlTextParser().parseMedia(data, time);
+    const result = new shaka.text.TtmlTextParser()
+        .parseMedia(data, time, 'foo://bar');
     shaka.test.TtmlUtils.verifyHelper(
         cues, result, bodyProperties, divProperties);
   }
@@ -2139,7 +2169,8 @@ describe('TtmlTextParser', () => {
     expect(() => {
       new shaka.text.TtmlTextParser().parseMedia(
           shaka.util.BufferUtils.toUint8(data),
-          {periodStart: 0, segmentStart: 0, segmentEnd: 10, vttOffset: 0});
+          {periodStart: 0, segmentStart: 0, segmentEnd: 10, vttOffset: 0},
+          'foo://bar');
     }).toThrow(error);
   }
 });

package/test/transmuxer/transmuxer_engine_integration.js

@@ -56,5 +56,14 @@ describe('TransmuxerEngine', () => {
           ContentType.VIDEO, 'video/MP2T; codecs="avc1.420001"'))
           .toBe('video/mp4; codecs="avc1.420001"');
     });
+
+    it('converts legacy avc1 codec strings', () => {
+      expect(convertCodecs(
+          ContentType.VIDEO, 'video/mp2t; codecs="avc1.100.42"'))
+          .toBe('video/mp4; codecs="avc1.64002a"');
+      expect(convertCodecs(
+          ContentType.VIDEO, 'video/mp2t; codecs="avc1.66.1"'))
+          .toBe('video/mp4; codecs="avc1.420001"');
+    });
   });
 });

package/test/transmuxer/transmuxer_integration.js

@@ -4,7 +4,36 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-describe('Transmuxer Player', () => {
+/**
+ * For unknown reasons, these tests fail in the test labs for Edge on Windows,
+ * in ways that do not seem to be unrelated to transmuxers.
+ * Practical testing has not found any sign that playback is actually broken in
+ * Edge, so these tests are disabled on Edge for the time being.
+ * TODO(#5834): Remove this filter once the tests are fixed.
+ * @return {boolean}
+ */
+function checkNoBrokenEdge() {
+  const chromeVersion = shaka.util.Platform.chromeVersion();
+  if (shaka.util.Platform.isWindows() && shaka.util.Platform.isEdge() &&
+      chromeVersion && chromeVersion <= 118) {
+    // When the tests fail, it's due to the manifest parser failing to find a
+    // factory. Attempt to find a factory first, to avoid filtering the tests
+    // when running in a non-broken Edge environment.
+    const uri = 'fakeuri.m3u8';
+    const mimeType = 'application/x-mpegurl';
+    /* eslint-disable no-restricted-syntax */
+    try {
+      shaka.media.ManifestParser.getFactory(uri, mimeType);
+      return true;
+    } catch (error) {
+      return false;
+    }
+    /* eslint-enable no-restricted-syntax */
+  }
+  return true;
+}
+
+filterDescribe('Transmuxer Player', checkNoBrokenEdge, () => {
   const Util = shaka.test.Util;
 
   /** @type {!jasmine.Spy} */
@@ -73,7 +102,8 @@ describe('Transmuxer Player', () => {
 
   beforeEach(async () => {
     await shaka.test.TestScheme.createManifests(compiledShaka, '_compiled');
-    player = new compiledShaka.Player(video);
+    player = new compiledShaka.Player();
+    await player.attach(video);
 
     player.configure('mediaSource.forceTransmux', true);
     player.configure('streaming.useNativeHlsOnSafari', false);
@@ -161,7 +191,7 @@ describe('Transmuxer Player', () => {
         pending('Codec EC-3 is not supported by the platform.');
       }
 
-      await player.load('/base/test/test/assets/hls-raw-ac3/prog_index.m3u8');
+      await player.load('/base/test/test/assets/hls-raw-ec3/prog_index.m3u8');
       await video.play();
       expect(player.isLive()).toBe(false);
 

package/test/ui/ad_ui_unit.js

@@ -25,14 +25,14 @@ describe('Ad UI', () => {
     shaka.Player.setAdManagerFactory(() => new shaka.test.FakeAdManager());
   });
 
-  beforeEach(() => {
+  beforeEach(async () => {
     container =
       /** @type {!HTMLElement} */ (document.createElement('div'));
     document.body.appendChild(container);
 
     video = shaka.test.UiUtils.createVideoElement();
     container.appendChild(video);
-    UiUtils.createUIThroughAPI(container, video);
+    await UiUtils.createUIThroughAPI(container, video);
     adManager = video['ui'].getControls().getPlayer().getAdManager();
   });