shaka-player 4.4.3 → 4.6.0

package/roadmap.md

@@ -9,22 +9,42 @@ The goals of future milestones are fluid until we begin that development cycle,
 so the exact milestone for future features is not pre-determined.
 
 Candidate features for future release cycles:
- - Preload API
-   https://github.com/shaka-project/shaka-player/issues/880
  - Official TypeScript defs, generated from source
    https://github.com/shaka-project/shaka-player/issues/1030
  - Background fetch for offline storage
    https://github.com/shaka-project/shaka-player/issues/879
+ - A method to stitch together clips
+   https://github.com/shaka-project/shaka-player/issues/764
+ - Predict next segment in DASH SegmentTimeline
+   https://github.com/shaka-project/shaka-player/issues/898
  - Smaller, more modular binary
 
-v4.5 - 2023 Q4 or 2024 Q1
+v5.0 - 2024 Q1
+ - Preload API
+   https://github.com/shaka-project/shaka-player/issues/880
+ - Common Media Server Data (CMSD)
+   https://github.com/shaka-project/shaka-player/issues/5890
+
+=====
+
+v4.6 - 2023 Q4
+ - Content Steering
+   https://github.com/shaka-project/shaka-player/issues/5704
+ - New DASH protocol for Low Latency.
+ - ManagedMediaSource
+   https://github.com/shaka-project/shaka-player/issues/5271
+ - Add thumbnails support in src=
+ - Remove state engine
+
+v4.5 - 2023 Q4
  - Built-in transmuxer support for muxed content streams (audio+video)
  - Built-in transmuxer support for H265 streams
  - Remove optional mux.js dependency
  - Codec switching
    https://github.com/shaka-project/shaka-player/issues/1528
-
-=====
+ - AES-128 in DASH.
+   https://github.com/shaka-project/shaka-player/issues/5622
+ - AWS Elemental MediaTailor
 
 v4.4 - 2023 Q3
  - Built-in transmuxer for common cases, no mux.js required:

package/shaka-player.uncompiled.js

@@ -50,7 +50,6 @@ goog.require('shaka.polyfill.VTTCue');
 goog.require('shaka.polyfill.VideoPlayPromise');
 goog.require('shaka.polyfill.VideoPlaybackQuality');
 goog.require('shaka.polyfill');
-goog.require('shaka.routing.Walker');
 goog.require('shaka.text.Cue');
 goog.require('shaka.text.LrcTextParser');
 goog.require('shaka.text.Mp4TtmlParser');
@@ -72,12 +71,12 @@ goog.require('shaka.transmuxer.ADTS');
 goog.require('shaka.transmuxer.Ec3');
 goog.require('shaka.transmuxer.Ec3Transmuxer');
 goog.require('shaka.transmuxer.H264');
+goog.require('shaka.transmuxer.H265');
 goog.require('shaka.transmuxer.Mp3Transmuxer');
 goog.require('shaka.transmuxer.MpegAudio');
 goog.require('shaka.transmuxer.MpegTsTransmuxer');
 goog.require('shaka.transmuxer.TransmuxerEngine');
 goog.require('shaka.transmuxer.MssTransmuxer');
-goog.require('shaka.transmuxer.MuxjsTransmuxer');
 goog.require('shaka.transmuxer.TsTransmuxer');
 goog.require('shaka.ui.Controls');
 goog.require('shaka.ui.PlayButton');
@@ -100,6 +99,7 @@ goog.require('shaka.ui.Overlay');
 goog.require('shaka.ui.PipButton');
 goog.require('shaka.ui.PlaybackRateSelection');
 goog.require('shaka.ui.PresentationTimeTracker');
+goog.require('shaka.ui.RemoteButton');
 goog.require('shaka.ui.ResolutionSelection');
 goog.require('shaka.ui.RewindButton');
 goog.require('shaka.ui.SkipAdButton');

package/support.html

@@ -38,7 +38,6 @@
 }
 
     </style>
-    <script defer src="node_modules/mux.js/dist/mux.min.js"></script>
     <script src="dist/shaka-player.compiled.js"></script>
     <script>
       function whenLoaded(fn) {

package/test/abr/simple_abr_manager_unit.js

@@ -145,14 +145,14 @@ describe('SimpleAbrManager', () => {
       abrManager.setVariants(variants);
       abrManager.chooseVariant();
 
-      abrManager.segmentDownloaded(1000, bytesPerSecond);
-      abrManager.segmentDownloaded(1000, bytesPerSecond);
+      abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+      abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
       abrManager.enable();
 
       // Make another call to segmentDownloaded() so switchCallback() is
       // called.
-      abrManager.segmentDownloaded(1000, bytesPerSecond);
+      abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
       // Expect variants 2 to be chosen for bandwidth = 5e5
       // and variant 5 - for bandwidth = 6e5
@@ -173,12 +173,12 @@ describe('SimpleAbrManager', () => {
     abrManager.chooseVariant();
 
     // 0 duration segment shouldn't cause us to get stuck on the lowest variant
-    abrManager.segmentDownloaded(0, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(0, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     abrManager.enable();
 
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     expect(abrManager.getBandwidthEstimate()).toBeTruthy();
   });
@@ -193,14 +193,14 @@ describe('SimpleAbrManager', () => {
     // bandwidth.
     const bytesPerSecond = sufficientBWMultiplier * bandwidth / 8.0;
 
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     abrManager.enable();
 
     // Make another call to segmentDownloaded() so switchCallback() is
     // called.
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     // Expect variants 4 to be chosen
     const expectedVariant = variants[3];
@@ -216,9 +216,9 @@ describe('SimpleAbrManager', () => {
     abrManager.chooseVariant();
 
     // Don't enable AbrManager.
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
     expect(switchCallback).not.toHaveBeenCalled();
   });
 
@@ -229,12 +229,12 @@ describe('SimpleAbrManager', () => {
     abrManager.setVariants(variants);
     abrManager.chooseVariant();
 
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     abrManager.enable();
 
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
     expect(switchCallback).toHaveBeenCalled();
     switchCallback.calls.reset();
 
@@ -242,23 +242,23 @@ describe('SimpleAbrManager', () => {
     bandwidth = 2e6;
     bytesPerSecond = sufficientBWMultiplier * bandwidth / 8.0;
 
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     // Stay inside switch interval.
     Date.now = () => (config.switchInterval - 2) * 1e3;
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     expect(switchCallback).not.toHaveBeenCalled();
 
     // Move outside switch interval.
     Date.now = () => (config.switchInterval + 2) * 1e3;
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     expect(switchCallback).toHaveBeenCalled();
   });
@@ -272,14 +272,14 @@ describe('SimpleAbrManager', () => {
     abrManager.setVariants(variants);
     abrManager.chooseVariant();
 
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     abrManager.enable();
 
     // Make another call to segmentDownloaded(). switchCallback() will be
     // called to upgrade.
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     // The second parameter is missing to indicate that the buffer should not be
     // cleared.
@@ -300,14 +300,14 @@ describe('SimpleAbrManager', () => {
     abrManager.setVariants(variants);
     abrManager.chooseVariant();
 
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     abrManager.enable();
 
     // Make another call to segmentDownloaded(). switchCallback() will be
     // called to upgrade.
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     // The second parameter is missing to indicate that the buffer should not be
     // cleared.
@@ -327,14 +327,14 @@ describe('SimpleAbrManager', () => {
     abrManager.setVariants(variants);
     abrManager.chooseVariant();
 
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     abrManager.enable();
 
     // Make another call to segmentDownloaded(). switchCallback() will be
     // called to downgrade.
-    abrManager.segmentDownloaded(1000, bytesPerSecond);
+    abrManager.segmentDownloaded(1000, bytesPerSecond, true);
 
     // The second parameter is missing to indicate that the buffer should not be
     // cleared.

package/test/ads/ad_manager_unit.js

@@ -16,10 +16,11 @@ describe('Ad manager', () => {
   /** @type {google.ima.AdsRenderingSettings} */
   let adsRenderingSettings;
 
-  beforeEach(() => {
+  beforeEach(async () => {
     window['google'] = null;
     mockVideo = new shaka.test.FakeVideo();
-    player = new shaka.Player(mockVideo);
+    player = new shaka.Player();
+    await player.attach(mockVideo, /* initializeMediaSource= */ false);
     adManager = player.getAdManager();
     expect(adManager instanceof shaka.ads.AdManager).toBe(true);
 

package/test/cast/cast_receiver_integration.js

@@ -65,7 +65,7 @@ filterDescribe('CastReceiver', castReceiverIntegrationSupport, () => {
     support = await shaka.media.DrmEngine.probeSupport();
   });
 
-  beforeEach(() => {
+  beforeEach(async () => {
     mockReceiverApi = createMockReceiverApi();
 
     const mockCanDisplayType = jasmine.createSpy('canDisplayType');
@@ -87,7 +87,8 @@ filterDescribe('CastReceiver', castReceiverIntegrationSupport, () => {
 
     document.body.appendChild(video);
 
-    player = new shaka.Player(video);
+    player = new shaka.Player();
+    await player.attach(video);
     receiver = new CastReceiver(video, player);
 
     toRestore = [];
@@ -139,6 +140,53 @@ filterDescribe('CastReceiver', castReceiverIntegrationSupport, () => {
     }
   });
 
+  describe('state changed event', () => {
+    it('does not trigger a stack overflow', async () => {
+      const p = waitForLoadedData();
+
+      // We had a regression in which polling attributes eventually triggered a
+      // stack overflow because of a state change event that fired every time
+      // we checked the state.  The error itself got swallowed and hidden
+      // inside CastReceiver, but would cause tests to disconnect in some
+      // environments (consistently in GitHub Actions VMs, inconsistently
+      // elsewhere).
+      //
+      // Testing for this is subtle: if we try to catch the error, it will be
+      // caught at a point when the stack has already or is about to overflow.
+      // Then if we call "fail", Jasmine will grow the stack further,
+      // triggering *another* overflow inside of fail(), causing our test to
+      // *pass*.  So we need to fail fast.  The best way I have found is to
+      // catch the very first recursion of pollAttributes_, long before we
+      // overflow, fail, then return early to avoid the actual recursion.
+      const original = /** @type {?} */(receiver).pollAttributes_;
+      let numRecursions = 0;
+      // eslint-disable-next-line no-restricted-syntax
+      /** @type {?} */(receiver).pollAttributes_ = function() {
+        try {
+          if (numRecursions > 0) {
+            fail('Found recursion in pollAttributes_!');
+            return undefined;
+          }
+
+          numRecursions++;
+          return original.apply(receiver, arguments);
+        } finally {
+          numRecursions--;
+        }
+      };
+
+      // Start the process of loading by sending a fake init message.
+      fakeConnectedSenders(1);
+      fakeIncomingMessage({
+        type: 'init',
+        initState: fakeInitState,
+        appData: {},
+      }, mockShakaMessageBus);
+
+      await p;
+    });
+  });
+
   describe('without drm', () => {
     it('sends reasonably-sized updates', async () => {
       // Use an unencrypted asset.
@@ -273,8 +321,6 @@ filterDescribe('CastReceiver', castReceiverIntegrationSupport, () => {
     // Add wrappers to various methods along player.load to make sure that,
     // at each stage, the cast receiver can form an update message without
     // causing an error.
-    waitForUpdateMessageWrapper(
-        shaka.media.ManifestParser, 'ManifestParser', 'getFactory');
     waitForUpdateMessageWrapper(
         // eslint-disable-next-line no-restricted-syntax
         shaka.test.TestScheme.ManifestParser.prototype, 'ManifestParser',

package/test/cast/cast_utils_unit.js

@@ -21,11 +21,13 @@ describe('CastUtils', () => {
       'getMediaElement',  // Handled specially
       'setMaxHardwareResolution',
       'destroy',  // Should use CastProxy.destroy instead
+      'getAllThumbnails', // Too large to proxy.
       'drmInfo',  // Too large to proxy
       'getManifest', // Too large to proxy
       'getManifestParserFactory',  // Would not serialize.
       'setVideoContainer',
       'getActiveSessionsMetadata',
+      'releaseAllMutexes', // Very specific to the inner workings of the player.
 
       // Test helper methods (not @export'd)
       'createDrmEngine',

package/test/cea/cea_decoder_unit.js

@@ -519,6 +519,13 @@ describe('CeaDecoder', () => {
 
       expect(decoder.reset).toHaveBeenCalledTimes(1);
     });
+
+    it('does not attempt to extract SEI packet that is too short', () => {
+      const badData = new Uint8Array([0xb5]);
+      decoder.extract(badData, 0);
+      const captions = decoder.decode();
+      expect(captions.length).toBe(0);
+    });
   });
 
   describe('decodes CEA-708', () => {

package/test/codec_switching/codec_switching_integration.js

@@ -0,0 +1,182 @@
+/*! @license
+ * Shaka Player
+ * Copyright 2016 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+describe('Codec Switching', () => {
+  /** @type {!HTMLVideoElement} */
+  let video;
+  /** @type {shaka.Player} */
+  let player;
+  /** @type {!shaka.util.EventManager} */
+  let eventManager;
+
+  let compiledShaka;
+
+  /** @type {!shaka.test.Waiter} */
+  let waiter;
+
+  beforeAll(async () => {
+    video = shaka.test.UiUtils.createVideoElement();
+    document.body.appendChild(video);
+    compiledShaka =
+          await shaka.test.Loader.loadShaka(getClientArg('uncompiled'));
+  });
+
+  beforeEach(async () => {
+    await shaka.test.TestScheme.createManifests(compiledShaka, '_compiled');
+    player = new compiledShaka.Player();
+    await player.attach(video);
+
+    // Disable stall detection, which can interfere with playback tests.
+    player.configure('streaming.stallEnabled', false);
+
+    eventManager = new shaka.util.EventManager();
+    waiter = new shaka.test.Waiter(eventManager);
+    waiter.setPlayer(player);
+  });
+
+  afterEach(async () => {
+    eventManager.release();
+    await player.destroy();
+  });
+
+  afterAll(() => {
+    document.body.removeChild(video);
+  });
+
+  describe('for audio and only-audio content', () => {
+    it('can switch codecs RELOAD', async () => {
+      if (!MediaSource.isTypeSupported('audio/webm; codecs="opus"')) {
+        pending('Codec OPUS in WEBM is not supported by the platform.');
+      }
+      const preferredAudioLanguage = 'en';
+      player.configure({preferredAudioLanguage: preferredAudioLanguage});
+      player.configure('manifest.disableVideo', true);
+      player.configure('streaming.mediaSource.codecSwitchingStrategy',
+          shaka.config.CodecSwitchingStrategy.RELOAD);
+
+      await player.load('/base/test/test/assets/dash-multi-codec/dash.mpd', 9);
+      await video.play();
+      await waiter.waitForMovementOrFailOnTimeout(video, 10);
+
+      expect(player.isLive()).toBe(false);
+
+      let variants = player.getVariantTracks();
+
+      expect(variants.length).toBe(2);
+      expect(variants.find((v) => !!v.active).language).toBe('en');
+
+      player.selectAudioLanguage('es');
+      await waiter.waitUntilPlayheadReachesOrFailOnTimeout(video, 10, 45);
+
+      variants = player.getVariantTracks();
+
+      expect(variants.find((v) => !!v.active).language).toBe('es');
+
+      await player.unload();
+    });
+
+    it('can switch codecs SMOOTH', async () => {
+      if (!shaka.util.Platform.supportsSmoothCodecSwitching()) {
+        pending('Mediasource.ChangeType is not considered ' +
+          'reliable on this device');
+      }
+      if (!MediaSource.isTypeSupported('audio/webm; codecs="opus"')) {
+        pending('Codec OPUS in WEBM is not supported by the platform.');
+      }
+      const preferredAudioLanguage = 'en';
+      player.configure({preferredAudioLanguage: preferredAudioLanguage});
+      player.configure('manifest.disableVideo', true);
+      player.configure('streaming.mediaSource.codecSwitchingStrategy',
+          shaka.config.CodecSwitchingStrategy.SMOOTH);
+
+      await player.load('/base/test/test/assets/dash-multi-codec/dash.mpd', 9);
+      await video.play();
+      await waiter.waitForMovementOrFailOnTimeout(video, 10);
+
+      expect(player.isLive()).toBe(false);
+
+      let variants = player.getVariantTracks();
+
+      expect(variants.length).toBe(2);
+      expect(variants.find((v) => !!v.active).language).toBe('en');
+
+      player.selectAudioLanguage('es');
+      await waiter.waitUntilPlayheadReachesOrFailOnTimeout(video, 10, 45);
+
+      variants = player.getVariantTracks();
+
+      expect(variants.find((v) => !!v.active).language).toBe('es');
+
+      await player.unload();
+    });
+  });
+
+  describe('for audio', () => {
+    it('can switch codecs RELOAD', async () => {
+      if (!MediaSource.isTypeSupported('audio/webm; codecs="opus"')) {
+        pending('Codec OPUS in WEBM is not supported by the platform.');
+      }
+      const preferredAudioLanguage = 'en';
+      player.configure({preferredAudioLanguage: preferredAudioLanguage});
+      player.configure('streaming.mediaSource.codecSwitchingStrategy',
+          shaka.config.CodecSwitchingStrategy.RELOAD);
+
+      await player.load('/base/test/test/assets/dash-multi-codec/dash.mpd', 9);
+      await video.play();
+      await waiter.waitForMovementOrFailOnTimeout(video, 10);
+
+      expect(player.isLive()).toBe(false);
+
+      let variants = player.getVariantTracks();
+
+      expect(variants.length).toBe(2);
+      expect(variants.find((v) => !!v.active).language).toBe('en');
+
+      player.selectAudioLanguage('es');
+      await waiter.waitUntilPlayheadReachesOrFailOnTimeout(video, 10, 45);
+
+      variants = player.getVariantTracks();
+
+      expect(variants.find((v) => !!v.active).language).toBe('es');
+
+      await player.unload();
+    });
+
+    it('can switch codecs SMOOTH', async () => {
+      if (!shaka.util.Platform.supportsSmoothCodecSwitching()) {
+        pending('Mediasource.ChangeType is not considered ' +
+          'reliable on this device');
+      }
+      if (!MediaSource.isTypeSupported('audio/webm; codecs="opus"')) {
+        pending('Codec OPUS in WEBM is not supported by the platform.');
+      }
+      const preferredAudioLanguage = 'en';
+      player.configure({preferredAudioLanguage: preferredAudioLanguage});
+      player.configure('streaming.mediaSource.codecSwitchingStrategy',
+          shaka.config.CodecSwitchingStrategy.SMOOTH);
+
+      await player.load('/base/test/test/assets/dash-multi-codec/dash.mpd', 9);
+      await video.play();
+      await waiter.waitForMovementOrFailOnTimeout(video, 10);
+
+      expect(player.isLive()).toBe(false);
+
+      let variants = player.getVariantTracks();
+
+      expect(variants.length).toBe(2);
+      expect(variants.find((v) => !!v.active).language).toBe('en');
+
+      player.selectAudioLanguage('es');
+      await waiter.waitUntilPlayheadReachesOrFailOnTimeout(video, 10, 45);
+
+      variants = player.getVariantTracks();
+
+      expect(variants.find((v) => !!v.active).language).toBe('es');
+
+      await player.unload();
+    });
+  });
+});

package/test/dash/dash_parser_content_protection_unit.js

@@ -45,6 +45,8 @@ describe('DashParser ContentProtection', () => {
       enableLowLatencyMode: () => {},
       updateDuration: () => {},
       newDrmInfo: (stream) => {},
+      onManifestUpdated: () => {},
+      getBandwidthEstimate: () => 1e6,
     };
 
     const actual = await dashParser.start(

package/test/dash/dash_parser_integration.js

@@ -0,0 +1,74 @@
+/*! @license
+ * Shaka Player
+ * Copyright 2016 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+describe('DashParser', () => {
+  const Util = shaka.test.Util;
+
+  /** @type {!jasmine.Spy} */
+  let onErrorSpy;
+
+  /** @type {!HTMLVideoElement} */
+  let video;
+  /** @type {shaka.Player} */
+  let player;
+  /** @type {!shaka.util.EventManager} */
+  let eventManager;
+
+  let compiledShaka;
+
+  /** @type {!shaka.test.Waiter} */
+  let waiter;
+
+  beforeAll(async () => {
+    video = shaka.test.UiUtils.createVideoElement();
+    document.body.appendChild(video);
+    compiledShaka =
+        await shaka.test.Loader.loadShaka(getClientArg('uncompiled'));
+  });
+
+  beforeEach(async () => {
+    await shaka.test.TestScheme.createManifests(compiledShaka, '_compiled');
+    player = new compiledShaka.Player();
+    await player.attach(video);
+
+    // Disable stall detection, which can interfere with playback tests.
+    player.configure('streaming.stallEnabled', false);
+
+    // Grab event manager from the uncompiled library:
+    eventManager = new shaka.util.EventManager();
+    waiter = new shaka.test.Waiter(eventManager);
+    waiter.setPlayer(player);
+
+    onErrorSpy = jasmine.createSpy('onError');
+    onErrorSpy.and.callFake((event) => fail(event.detail));
+    eventManager.listen(player, 'error', Util.spyFunc(onErrorSpy));
+  });
+
+  afterEach(async () => {
+    eventManager.release();
+    await player.destroy();
+  });
+
+  afterAll(() => {
+    document.body.removeChild(video);
+  });
+
+  it('supports AES-128 streaming', async () => {
+    await player.load('/base/test/test/assets/dash-aes-128/dash.mpd');
+    await video.play();
+    expect(player.isLive()).toBe(false);
+
+    // Wait for the video to start playback.  If it takes longer than 10
+    // seconds, fail the test.
+    await waiter.waitForMovementOrFailOnTimeout(video, 10);
+
+    // Play for 10 seconds, but stop early if the video ends.  If it takes
+    // longer than 30 seconds, fail the test.
+    await waiter.waitUntilPlayheadReachesOrFailOnTimeout(video, 10, 30);
+
+    await player.unload();
+  });
+});

package/test/dash/dash_parser_live_unit.js

@@ -36,6 +36,8 @@ describe('DashParser Live', () => {
       enableLowLatencyMode: () => {},
       updateDuration: () => {},
       newDrmInfo: (stream) => {},
+      onManifestUpdated: () => {},
+      getBandwidthEstimate: () => 1e6,
     };
   });
 
@@ -659,25 +661,6 @@ describe('DashParser Live', () => {
     expect(delay).toBe(updateTime);
   });
 
-  it('still updates when @minimumUpdatePeriod is zero', async () => {
-    const lines = [
-      '<SegmentTemplate startNumber="1" media="s$Number$.mp4" duration="2" />',
-    ];
-    // updateTime parameter sets @minimumUpdatePeriod in the manifest.
-    const manifestText = makeSimpleLiveManifestText(lines, /* updateTime= */ 0);
-
-    /** @type {!jasmine.Spy} */
-    const tickAfter = updateTickSpy();
-    Date.now = () => 0;
-
-    fakeNetEngine.setResponseText('dummy://foo', manifestText);
-    await parser.start('dummy://foo', playerInterface);
-
-    expect(tickAfter).toHaveBeenCalledTimes(1);
-    const delay = tickAfter.calls.mostRecent().args[0];
-    expect(delay).toBe(0);
-  });
-
   it('does not update when @minimumUpdatePeriod is missing', async () => {
     const lines = [
       '<SegmentTemplate startNumber="1" media="s$Number$.mp4" duration="2" />',