shaka-player 4.4.1 → 4.4.2

package/lib/transmuxer/ts_transmuxer.js

@@ -170,17 +170,7 @@ shaka.transmuxer.TsTransmuxer = class {
 
     const uint8ArrayData = shaka.util.BufferUtils.toUint8(data);
 
-    let timestamp = reference.endTime * 1000;
-
     const tsParser = this.tsParser_.parse(uint8ArrayData);
-    const startTime = tsParser.getStartTime();
-
-    if (startTime.audio != null) {
-      timestamp = startTime.audio;
-    }
-    if (startTime.video != null) {
-      timestamp = startTime.video;
-    }
     const streamInfos = [];
     const codecs = tsParser.getCodecs();
     try {
@@ -189,8 +179,7 @@ shaka.transmuxer.TsTransmuxer = class {
         switch (codecs.video) {
           case 'avc':
             streamInfo =
-              this.getAvcStreamInfo_(
-                  tsParser, timestamp, stream, duration);
+              this.getAvcStreamInfo_(tsParser, stream, duration);
             break;
         }
         if (streamInfo) {
@@ -202,23 +191,19 @@ shaka.transmuxer.TsTransmuxer = class {
         switch (codecs.audio) {
           case 'aac':
             streamInfo =
-              this.getAacStreamInfo_(
-                  tsParser, timestamp, stream, duration);
+              this.getAacStreamInfo_(tsParser, stream, duration);
             break;
           case 'ac3':
             streamInfo =
-              this.getAc3StreamInfo_(
-                  tsParser, timestamp, stream, duration);
+              this.getAc3StreamInfo_(tsParser, stream, duration);
             break;
           case 'ec3':
             streamInfo =
-              this.getEc3StreamInfo_(
-                  tsParser, timestamp, stream, duration);
+              this.getEc3StreamInfo_(tsParser, stream, duration);
             break;
           case 'mp3':
             streamInfo =
-              this.getMp3StreamInfo_(
-                  tsParser, timestamp, stream, duration);
+              this.getMp3StreamInfo_(tsParser, stream, duration);
             break;
         }
         if (streamInfo) {
@@ -255,20 +240,22 @@ shaka.transmuxer.TsTransmuxer = class {
 
   /**
    * @param {shaka.util.TsParser} tsParser
-   * @param {number} timestamp
    * @param {shaka.extern.Stream} stream
    * @param {number} duration
    * @return {shaka.util.Mp4Generator.StreamInfo}
    * @private
    */
-  getAacStreamInfo_(tsParser, timestamp, stream, duration) {
+  getAacStreamInfo_(tsParser, stream, duration) {
     const ADTS = shaka.transmuxer.ADTS;
+    const timescale = shaka.util.TsParser.Timescale;
 
     /** @type {!Array.<shaka.util.Mp4Generator.Mp4Sample>} */
     const samples = [];
 
     let info;
 
+    let firstPts = null;
+
     for (const audioData of tsParser.getAudioData()) {
       const data = audioData.data;
       if (!data) {
@@ -284,7 +271,9 @@ shaka.transmuxer.TsTransmuxer = class {
       }
       stream.audioSamplingRate = info.sampleRate;
       stream.channelsCount = info.channelCount;
-
+      if (firstPts == null && audioData.pts !== null) {
+        firstPts = audioData.pts;
+      }
       while (offset < data.length) {
         const header = ADTS.parseHeader(data, offset);
         if (!header) {
@@ -316,7 +305,7 @@ shaka.transmuxer.TsTransmuxer = class {
       }
     }
 
-    if (!info) {
+    if (!info || firstPts == null) {
       throw new shaka.util.Error(
           shaka.util.Error.Severity.CRITICAL,
           shaka.util.Error.Category.MEDIA,
@@ -326,7 +315,7 @@ shaka.transmuxer.TsTransmuxer = class {
     /** @type {number} */
     const sampleRate = info.sampleRate;
     /** @type {number} */
-    const baseMediaDecodeTime = Math.floor(timestamp * sampleRate / 1000);
+    const baseMediaDecodeTime = firstPts / timescale * sampleRate;
 
     return {
       id: stream.id,
@@ -350,14 +339,14 @@ shaka.transmuxer.TsTransmuxer = class {
 
   /**
    * @param {shaka.util.TsParser} tsParser
-   * @param {number} timestamp
    * @param {shaka.extern.Stream} stream
    * @param {number} duration
    * @return {shaka.util.Mp4Generator.StreamInfo}
    * @private
    */
-  getAc3StreamInfo_(tsParser, timestamp, stream, duration) {
+  getAc3StreamInfo_(tsParser, stream, duration) {
     const Ac3 = shaka.transmuxer.Ac3;
+    const timescale = shaka.util.TsParser.Timescale;
 
     /** @type {!Array.<shaka.util.Mp4Generator.Mp4Sample>} */
     const samples = [];
@@ -368,8 +357,13 @@ shaka.transmuxer.TsTransmuxer = class {
     /** @type {!Uint8Array} */
     let audioConfig = new Uint8Array([]);
 
+    let firstPts = null;
+
     for (const audioData of tsParser.getAudioData()) {
       const data = audioData.data;
+      if (firstPts == null && audioData.pts !== null) {
+        firstPts = audioData.pts;
+      }
       let offset = 0;
       while (offset < data.length) {
         const frame = Ac3.parseFrame(data, offset);
@@ -403,7 +397,7 @@ shaka.transmuxer.TsTransmuxer = class {
       }
     }
 
-    if (sampleRate == 0 || audioConfig.byteLength == 0) {
+    if (sampleRate == 0 || audioConfig.byteLength == 0 || firstPts == null) {
       throw new shaka.util.Error(
           shaka.util.Error.Severity.CRITICAL,
           shaka.util.Error.Category.MEDIA,
@@ -412,7 +406,7 @@ shaka.transmuxer.TsTransmuxer = class {
 
 
     /** @type {number} */
-    const baseMediaDecodeTime = Math.floor(timestamp * sampleRate / 1000);
+    const baseMediaDecodeTime = firstPts / timescale * sampleRate;
 
     return {
       id: stream.id,
@@ -436,14 +430,14 @@ shaka.transmuxer.TsTransmuxer = class {
 
   /**
    * @param {shaka.util.TsParser} tsParser
-   * @param {number} timestamp
    * @param {shaka.extern.Stream} stream
    * @param {number} duration
    * @return {shaka.util.Mp4Generator.StreamInfo}
    * @private
    */
-  getEc3StreamInfo_(tsParser, timestamp, stream, duration) {
+  getEc3StreamInfo_(tsParser, stream, duration) {
     const Ec3 = shaka.transmuxer.Ec3;
+    const timescale = shaka.util.TsParser.Timescale;
 
     /** @type {!Array.<shaka.util.Mp4Generator.Mp4Sample>} */
     const samples = [];
@@ -454,8 +448,13 @@ shaka.transmuxer.TsTransmuxer = class {
     /** @type {!Uint8Array} */
     let audioConfig = new Uint8Array([]);
 
+    let firstPts = null;
+
     for (const audioData of tsParser.getAudioData()) {
       const data = audioData.data;
+      if (firstPts == null && audioData.pts !== null) {
+        firstPts = audioData.pts;
+      }
       let offset = 0;
       while (offset < data.length) {
         const frame = Ec3.parseFrame(data, offset);
@@ -489,7 +488,7 @@ shaka.transmuxer.TsTransmuxer = class {
       }
     }
 
-    if (sampleRate == 0 || audioConfig.byteLength == 0) {
+    if (sampleRate == 0 || audioConfig.byteLength == 0 || firstPts == null) {
       throw new shaka.util.Error(
           shaka.util.Error.Severity.CRITICAL,
           shaka.util.Error.Category.MEDIA,
@@ -498,7 +497,7 @@ shaka.transmuxer.TsTransmuxer = class {
 
 
     /** @type {number} */
-    const baseMediaDecodeTime = Math.floor(timestamp * sampleRate / 1000);
+    const baseMediaDecodeTime = firstPts / timescale * sampleRate;
 
     return {
       id: stream.id,
@@ -522,25 +521,30 @@ shaka.transmuxer.TsTransmuxer = class {
 
   /**
    * @param {shaka.util.TsParser} tsParser
-   * @param {number} timestamp
    * @param {shaka.extern.Stream} stream
    * @param {number} duration
    * @return {shaka.util.Mp4Generator.StreamInfo}
    * @private
    */
-  getMp3StreamInfo_(tsParser, timestamp, stream, duration) {
+  getMp3StreamInfo_(tsParser, stream, duration) {
     const MpegAudio = shaka.transmuxer.MpegAudio;
+    const timescale = shaka.util.TsParser.Timescale;
 
     /** @type {!Array.<shaka.util.Mp4Generator.Mp4Sample>} */
     const samples = [];
 
     let firstHeader;
 
+    let firstPts = null;
+
     for (const audioData of tsParser.getAudioData()) {
       const data = audioData.data;
       if (!data) {
         continue;
       }
+      if (firstPts == null && audioData.pts !== null) {
+        firstPts = audioData.pts;
+      }
       let offset = 0;
       while (offset < data.length) {
         const header = MpegAudio.parseHeader(data, offset);
@@ -570,7 +574,7 @@ shaka.transmuxer.TsTransmuxer = class {
         offset += header.frameLength;
       }
     }
-    if (!firstHeader) {
+    if (!firstHeader || firstPts == null) {
       throw new shaka.util.Error(
           shaka.util.Error.Severity.CRITICAL,
           shaka.util.Error.Category.MEDIA,
@@ -579,7 +583,7 @@ shaka.transmuxer.TsTransmuxer = class {
     /** @type {number} */
     const sampleRate = firstHeader.sampleRate;
     /** @type {number} */
-    const baseMediaDecodeTime = Math.floor(timestamp * sampleRate / 1000);
+    const baseMediaDecodeTime = firstPts / timescale * sampleRate;
 
     return {
       id: stream.id,
@@ -603,13 +607,12 @@ shaka.transmuxer.TsTransmuxer = class {
 
   /**
    * @param {shaka.util.TsParser} tsParser
-   * @param {number} timestamp
    * @param {shaka.extern.Stream} stream
    * @param {number} duration
    * @return {shaka.util.Mp4Generator.StreamInfo}
    * @private
    */
-  getAvcStreamInfo_(tsParser, timestamp, stream, duration) {
+  getAvcStreamInfo_(tsParser, stream, duration) {
     const H264 = shaka.transmuxer.H264;
     const timescale = shaka.util.TsParser.Timescale;
 
@@ -620,9 +623,7 @@ shaka.transmuxer.TsTransmuxer = class {
     let baseMediaDecodeTime = null;
 
     let nalus = [];
-    const videoData = tsParser.getVideoData().filter((pes) => {
-      return pes.pts != null && pes.dts != null;
-    });
+    const videoData = tsParser.getVideoData();
     for (let i = 0; i < videoData.length; i++) {
       const pes = videoData[i];
       let nextPes;
@@ -635,7 +636,7 @@ shaka.transmuxer.TsTransmuxer = class {
       if (!frame) {
         continue;
       }
-      if (baseMediaDecodeTime == null && pes.dts != null) {
+      if (baseMediaDecodeTime == null) {
         baseMediaDecodeTime = pes.dts;
       }
       let duration;

package/lib/util/error.js

@@ -63,8 +63,11 @@ shaka.util.Error = class {
      */
     this.handled = false;
 
-    // This improves the formatting of Errors in failure messages in the tests.
+    // A basic message for compiled mode.
+    let formattedMessage = 'Shaka Error ' + this.code;
     if (goog.DEBUG) {
+      // This improves the formatting of Errors in failure messages in the
+      // tests in debug mode.
       let categoryName = 'UNKNOWN';
       let codeName = 'UNKNOWN';
 
@@ -79,17 +82,20 @@ shaka.util.Error = class {
         }
       }
 
-      /**
-       * A human-readable version of the category and code.
-       * <i>(Only available in uncompiled mode.)</i>
-       *
-       * @const {string}
-       * @exportDoc
-       */
-      this.message = 'Shaka Error ' + categoryName + '.' + codeName +
-                     ' (' + this.data.toString() + ')';
+      formattedMessage = 'Shaka Error ' + categoryName + '.' + codeName +
+                         ' (' + this.data.toString() + ')';
     }
 
+    /**
+     * In compiled mode, contains a basic message string with the error code.
+     * In uncompiled and debug modes, contains a human-readable version of the
+     * category and code as enums.
+     *
+     * @const {string}
+     * @exportDoc
+     */
+    this.message = formattedMessage;
+
     if (shaka.util.Error.createStack) {
       try {
         throw new Error(this.message || 'Shaka Error');

package/lib/util/player_configuration.js

@@ -71,8 +71,8 @@ shaka.util.PlayerConfiguration = class {
       persistentSessionOnlinePlayback: false,
       persistentSessionsMetadata: [],
       initDataTransform: (initData, initDataType, drmInfo) => {
-        const keySystem = drmInfo.keySystem;
-        if (keySystem == 'com.apple.fps.1_0' && initDataType == 'skd') {
+        if (shaka.util.Platform.isMediaKeysPolyfilled() &&
+            initDataType == 'skd') {
           const cert = drmInfo.serverCertificate;
           const contentId =
               shaka.util.FairPlayUtils.defaultGetContentId(initData);

package/lib/util/stream_utils.js

@@ -1543,22 +1543,23 @@ shaka.util.StreamUtils = class {
 
   /**
    * Chooses streams according to the given config.
+   * Works both for Stream and Track types due to their similarities.
    *
-   * @param {!Array.<shaka.extern.Stream>} streams
+   * @param {!Array<!shaka.extern.Stream>|!Array<!shaka.extern.Track>} streams
    * @param {string} preferredLanguage
    * @param {string} preferredRole
    * @param {boolean} preferredForced
-   * @return {!Array.<!shaka.extern.Stream>}
+   * @return {!Array<!shaka.extern.Stream>|!Array<!shaka.extern.Track>}
    */
   static filterStreamsByLanguageAndRole(
       streams, preferredLanguage, preferredRole, preferredForced) {
     const LanguageUtils = shaka.util.LanguageUtils;
 
-    /** @type {!Array.<!shaka.extern.Stream>} */
+    /** @type {!Array<!shaka.extern.Stream>|!Array<!shaka.extern.Track>} */
     let chosen = streams;
 
     // Start with the set of primary streams.
-    /** @type {!Array.<!shaka.extern.Stream>} */
+    /** @type {!Array<!shaka.extern.Stream>|!Array<!shaka.extern.Track>} */
     const primary = streams.filter((stream) => {
       return stream.primary;
     });
@@ -1598,7 +1599,7 @@ shaka.util.StreamUtils = class {
 
     // Now refine the choice based on role preference.
     if (preferredRole) {
-      const roleMatches = shaka.util.StreamUtils.filterTextStreamsByRole_(
+      const roleMatches = shaka.util.StreamUtils.filterStreamsByRole_(
           chosen, preferredRole);
       if (roleMatches.length) {
         return roleMatches;
@@ -1626,20 +1627,21 @@ shaka.util.StreamUtils = class {
     if (!allRoles.length) {
       return chosen;
     }
-    return shaka.util.StreamUtils.filterTextStreamsByRole_(chosen, allRoles[0]);
+    return shaka.util.StreamUtils.filterStreamsByRole_(chosen, allRoles[0]);
   }
 
 
   /**
-   * Filter text Streams by role.
+   * Filter Streams by role.
+   * Works both for Stream and Track types due to their similarities.
    *
-   * @param {!Array.<shaka.extern.Stream>} textStreams
+   * @param {!Array<!shaka.extern.Stream>|!Array<!shaka.extern.Track>} streams
    * @param {string} preferredRole
-   * @return {!Array.<shaka.extern.Stream>}
+   * @return {!Array<!shaka.extern.Stream>|!Array<!shaka.extern.Track>}
    * @private
    */
-  static filterTextStreamsByRole_(textStreams, preferredRole) {
-    return textStreams.filter((stream) => {
+  static filterStreamsByRole_(streams, preferredRole) {
+    return streams.filter((stream) => {
       return stream.roles.includes(preferredRole);
     });
   }

package/lib/util/ts_parser.js

@@ -6,6 +6,7 @@
 
 goog.provide('shaka.util.TsParser');
 
+goog.require('shaka.Deprecate');
 goog.require('shaka.log');
 goog.require('shaka.util.ExpGolomb');
 goog.require('shaka.util.Id3Utils');
@@ -361,6 +362,12 @@ shaka.util.TsParser = class {
       dts: null,
     };
 
+    // if PES parsed length is not zero and greater than total received length,
+    // stop parsing. PES might be truncated. minus 6 : PES header size
+    if (pes.packetLength && pes.packetLength > data.byteLength - 6) {
+      return null;
+    }
+
     // PES packets may be annotated with a PTS value, or a PTS value
     // and a DTS value. Determine what combination of values is
     // available to work with.
@@ -395,10 +402,15 @@ shaka.util.TsParser = class {
           (data[18] & 0xfe) / 2;
       }
     }
-    // the data section starts immediately after the PES header.
-    // pes_header_data_length specifies the number of header bytes
-    // that follow the last byte of the field.
-    pes.data = data.subarray(9 + data[8]);
+
+    const pesHdrLen = data[8];
+    // 9 bytes : 6 bytes for PES header + 3 bytes for PES extension
+    const payloadStartOffset = pesHdrLen + 9;
+    if (data.byteLength <= payloadStartOffset) {
+      return null;
+    }
+
+    pes.data = data.subarray(payloadStartOffset);
 
     return pes;
   }
@@ -450,6 +462,10 @@ shaka.util.TsParser = class {
         // previous Nalu and don't scan for more nalus.
         const startCodeSize = numZeros > 3 ? 3 : numZeros;
         const lastByteToKeep = i - startCodeSize;
+        // Optimization
+        if (lastByteToKeep == 0) {
+          break;
+        }
         infoOfLastNalu.data = shaka.util.Uint8ArrayUtils.concat(
             infoOfLastNalu.data, data.subarray(0, lastByteToKeep));
         infoOfLastNalu.fullData = shaka.util.Uint8ArrayUtils.concat(
@@ -575,11 +591,21 @@ shaka.util.TsParser = class {
    * @export
    */
   getVideoData() {
+    const Uint8ArrayUtils = shaka.util.Uint8ArrayUtils;
     const video = [];
     for (const videoData of this.videoData_) {
       const pes = this.parsePES_(videoData);
-      if (pes) {
+      if (pes && pes.pts != null && pes.dts != null) {
         video.push(pes);
+      } else if (video.length) {
+        const data = pes ? pes.data : videoData;
+        if (!data) {
+          continue;
+        }
+        const previousPes = video.pop();
+        previousPes.data =
+            Uint8ArrayUtils.concat(previousPes.data, data);
+        video.push(previousPes);
       }
     }
     return video;
@@ -660,29 +686,47 @@ shaka.util.TsParser = class {
    * @export
    */
   getVideoResolution() {
+    shaka.Deprecate.deprecateFeature(5,
+        'TsParser',
+        'Please use getVideoInfo function instead.');
+    const videoInfo = this.getVideoInfo();
+    return {
+      height: videoInfo.height,
+      width: videoInfo.width,
+    };
+  }
+
+  /**
+   * Return the video information
+   *
+   * @return {{height: ?string, width: ?string, codec: ?string}}
+   * @export
+   */
+  getVideoInfo() {
     const TsParser = shaka.util.TsParser;
-    const resolution = {
+    const videoInfo = {
       height: null,
       width: null,
+      codec: null,
     };
     const videoNalus = this.getVideoNalus();
     if (!videoNalus.length) {
-      return resolution;
+      return videoInfo;
     }
     const spsNalu = videoNalus.find((nalu) => {
       return nalu.type == TsParser.H264_NALU_TYPE_SPS_;
     });
     if (!spsNalu) {
-      return resolution;
+      return videoInfo;
     }
 
     const expGolombDecoder = new shaka.util.ExpGolomb(spsNalu.data);
     // profile_idc
     const profileIdc = expGolombDecoder.readUnsignedByte();
     // constraint_set[0-5]_flag
-    expGolombDecoder.readUnsignedByte();
+    const profileCompatibility = expGolombDecoder.readUnsignedByte();
     // level_idc u(8)
-    expGolombDecoder.readUnsignedByte();
+    const levelIdc = expGolombDecoder.readUnsignedByte();
     // seq_parameter_set_id
     expGolombDecoder.skipExpGolomb();
 
@@ -768,13 +812,26 @@ shaka.util.TsParser = class {
       frameCropBottomOffset = expGolombDecoder.readUnsignedExpGolomb();
     }
 
-    resolution.height = String(((2 - frameMbsOnlyFlag) *
+    videoInfo.height = String(((2 - frameMbsOnlyFlag) *
         (picHeightInMapUnitsMinus1 + 1) * 16) - (frameCropTopOffset * 2) -
         (frameCropBottomOffset * 2));
-    resolution.width = String(((picWidthInMbsMinus1 + 1) * 16) -
+    videoInfo.width = String(((picWidthInMbsMinus1 + 1) * 16) -
         frameCropLeftOffset * 2 - frameCropRightOffset * 2);
+    videoInfo.codec = 'avc1.' + this.byteToHex_(profileIdc) +
+        this.byteToHex_(profileCompatibility) + this.byteToHex_(levelIdc);
 
-    return resolution;
+    return videoInfo;
+  }
+
+  /**
+   * Convert a byte to 2 digits of hex.  (Only handles values 0-255.)
+   *
+   * @param {number} x
+   * @return {string}
+   * @private
+   */
+  byteToHex_(x) {
+    return ('0' + x.toString(16).toUpperCase()).slice(-2);
   }
 
   /**

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "shaka-player",
   "description": "DASH/EME video player library",
-  "version": "4.4.1",
+  "version": "4.4.2",
   "homepage": "https://github.com/shaka-project/shaka-player",
   "author": "Google",
   "maintainers": [
@@ -43,7 +43,7 @@
     "karma-coverage": "^2.2.0",
     "karma-jasmine": "^4.0.1",
     "karma-jasmine-ajax": "^0.1.13",
-    "karma-local-wd-launcher": "^1.6.4",
+    "karma-local-wd-launcher": "^1.6.6",
     "karma-opera-launcher": "^1.0.0",
     "karma-sourcemap-loader": "^0.3.8",
     "karma-spec-reporter": "^0.0.34",

package/test/text/text_engine_unit.js

@@ -49,7 +49,8 @@ describe('TextEngine', () => {
     textEngine.initParser(
         dummyMimeType,
         /* sequenceMode= */ false,
-        /* segmentRelativeVttTiming= */ false);
+        /* segmentRelativeVttTiming= */ false,
+        shaka.media.ManifestParser.UNKNOWN);
   });
 
   afterEach(() => {
@@ -298,7 +299,8 @@ describe('TextEngine', () => {
       textEngine.initParser(
           dummyMimeType,
           /* sequenceMode= */ false,
-          /* segmentRelativeVttTiming= */ true);
+          /* segmentRelativeVttTiming= */ true,
+          shaka.media.ManifestParser.UNKNOWN);
 
       mockParseMedia.and.callFake((data, time) => {
         return [

package/test/text/ttml_text_parser_unit.js

@@ -1866,9 +1866,8 @@ describe('TtmlTextParser', () => {
             endTime: 60,
             payload: '',
             fontSize: '15px',
-            // Styles from regionStyle should apply only to the nested cue.
-            backgroundColor: '',
-            color: '',
+            backgroundColor: 'transparent',
+            color: 'blue',
             displayAlign: Cue.displayAlign.CENTER,
             textAlign: Cue.textAlign.CENTER,
 
@@ -1970,7 +1969,7 @@ describe('TtmlTextParser', () => {
             startTime: 0,
             endTime: 60,
             payload: '',
-            fontSize: '',
+            fontSize: '16px',
             nestedCues: [
               {
                 startTime: 0,

package/test/text/vtt_text_parser_unit.js

@@ -198,15 +198,30 @@ describe('VttTextParser', () => {
           {
             startTime: 40,
             endTime: 50,
-            payload: 'Test2',
+            payload: '',
             writingMode: Cue.writingMode.VERTICAL_LEFT_TO_RIGHT,
+            nestedCues: [
+              {
+                startTime: 40,
+                endTime: 50,
+                payload: 'Test',
+                writingMode: Cue.writingMode.VERTICAL_LEFT_TO_RIGHT,
+              },
+              {
+                startTime: 40,
+                endTime: 50,
+                payload: '2',
+                fontWeight: Cue.fontWeight.BOLD,
+                writingMode: Cue.writingMode.VERTICAL_LEFT_TO_RIGHT,
+              },
+            ],
           },
         ],
         'WEBVTT\n\n' +
         '00:00:20.000 --> 00:00:40.000 vertical:rl\n' +
         'Test\n\n' +
         '00:00:40.000 --> 00:00:50.000 vertical:lr\n' +
-        'Test2',
+        'Test<b>2</b>',
         {periodStart: 0, segmentStart: 0, segmentEnd: 0, vttOffset: 0});
   });
 

package/test/text/web_vtt_layout_integration.js

@@ -213,7 +213,6 @@ filterDescribe('WebVTT layout', shaka.test.TextLayoutTests.supported, () => {
       await helper.checkScreenshot('line-negative-2');
     });
 
-    // FIXME: UI version is wrong: not positioned by line
     it('line 0', async () => {
       parseAndDisplay([
         'WEBVTT\n',