shaka-player 4.3.9 → 4.4.0

package/.github/workflows/build-and-test.yaml

@@ -45,7 +45,7 @@ jobs:
           # coverage instrumentation on full-stack player integration tests.
           - os: ubuntu-latest
             browser: Chrome
-            extra_flags: "--use-xvfb --html-coverage-report --uncompiled"
+            extra_flags: "--use-xvfb"
           - os: ubuntu-latest
             browser: Firefox
             extra_flags: "--use-xvfb"
@@ -70,6 +70,7 @@ jobs:
             browser: Firefox
           - os: windows-latest
             browser: Edge
+            extra_flags: "--html-coverage-report --uncompiled"
 
       # Disable fail-fast so that one matrix-job failing doesn't make the other
       # ones end early.
@@ -87,19 +88,6 @@ jobs:
         if: matrix.os == 'ubuntu-latest' && matrix.browser == 'Firefox'
         run: sudo apt -y update && sudo apt -y install ffmpeg
 
-      # Edge 107 fails DRM tests due to an outdated Widevine CDM.  Force Edge
-      # to update to 108+.
-      - name: Upgrade Edge
-        if: matrix.os == 'ubuntu-latest' && matrix.browser == 'Edge'
-        run: |
-          # If it's Edge 107, update it.  Otherwise, don't.  This way, we don't
-          # break something later when Edge 108+ is available by default in
-          # GitHub Actions.
-          if apt show microsoft-edge-stable | grep -q '^Version: 107'; then
-            wget https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_108.0.1462.46-1_amd64.deb
-            sudo dpkg -i microsoft-edge-stable_108.0.1462.46-1_amd64.deb
-          fi
-
       - name: Checkout code
         uses: actions/checkout@v3
         with:
@@ -125,13 +113,18 @@ jobs:
           # Install a launcher that can execute a shell script to launch this
           npm install karma-script-launcher --save-dev
 
-      # When "Chrome for Testing" is installed on Mac, it gets invoked instead
-      # of simply "Chrome".  This other copy of Chrome, however, doesn't seem
-      # to have basic codecs like AAC and H264 available, causing many of our
-      # test scenarios to fail.  Deleting "Chrome for Testing" fixes this.
+      # When "Chrome for Testing" is installed on Mac or Windows, it gets
+      # invoked instead of simply "Chrome".  This other copy of Chrome,
+      # however, doesn't seem to have basic codecs like AAC and H264 available,
+      # causing many of our test scenarios to fail.  Deleting "Chrome for
+      # Testing" fixes this.
       - name: 'Delete "Chrome for Testing" on Mac'
         if: matrix.os == 'macos-latest' && matrix.browser == 'Chrome'
         run: sudo rm -rf /Applications/Google\ Chrome\ for\ Testing.app
+      - name: 'Overwrite "Chrome for Testing" on Windows'
+        if: matrix.os == 'windows-latest' && matrix.browser == 'Chrome'
+        shell: bash
+        run: choco install -y googlechrome --ignore-checksums
 
       # Some CI images (self-hosted or otherwise) don't have the minimum Java
       # version necessary for the compiler (Java 11).

package/.github/workflows/compute-incremental-coverage.py

@@ -24,6 +24,9 @@ import zipfile
 
 # TODO(joeyparrish): Figure out how to get karma to output relative paths only.
 def StripGitDir(path):
+  # Convert Windows-style paths to Unix-style paths so we can read coverage
+  # data from Windows runners, too.
+  path = path.replace('\\', '/')
   # Strip the path to the git clone, leaving only the source path within the
   # repo.
   return re.sub(r'.*?/(lib|ui)/', r'\1/', path)

package/.github/workflows/release-please.yaml

@@ -17,6 +17,13 @@ jobs:
       - uses: google-github-actions/release-please-action@v3
         id: release
         with:
+          # This command instructs the tool to use the config and manifest
+          # files below to decide the next version and the SHA of the previous
+          # release (used to compute the changelog).  This is necessary if
+          # there are more than 250 commits between main branch releases.
+          command: manifest
+          config-file: .release-please-config.json
+          manifest-file: .release-please-manifest.json
           # Required input to specify the release type (node package).
           release-type: node
           # Make sure we create the PR against the correct branch.

package/.github/workflows/selenium-lab-tests.yaml

@@ -148,6 +148,30 @@ jobs:
       - name: Build Player
         run: python3 build/all.py
 
+      - name: Preprocess with Babel
+        run: |
+          # Run the test preprocessor without running the actual tests.
+          # This lets us cache Babel's output and run it only once.
+          # Ignore the exit code, since you get an error code if the filter
+          # excludes all tests.
+          ./build/test.py \
+              --use-xvfb --browsers Chrome \
+              --filter ThisFilterMatchesNoTests || true
+
+      - name: Cache dependencies
+        uses: actions/cache@v3
+        id: npm-cache
+        with:
+          path: node_modules/
+          key: node-${{ hashFiles('package-lock.json') }}
+
+      - name: Cache Babel output
+        uses: actions/cache@v3
+        id: babel-cache
+        with:
+          path: .babel-cache
+          key: babel-${{ hashFiles('*.js', 'demo/**.js', 'lib/**.js', 'ui/**.js', 'test/**.js', 'third_party/**.js') }}
+
       - name: Store Player build
         uses: actions/upload-artifact@v3
         with:
@@ -206,6 +230,17 @@ jobs:
         with:
           path: node_modules/
           key: node-${{ hashFiles('package-lock.json') }}
+          fail-on-cache-miss: true  # Cached by the build-shaka job above
+          enableCrossOsArchive: true  # Share archives from Linux to Windows
+
+      - name: Cache Babel output
+        uses: actions/cache@v3
+        id: babel-cache
+        with:
+          path: .babel-cache
+          key: babel-${{ hashFiles('*.js', 'demo/**.js', 'lib/**.js', 'ui/**.js', 'test/**.js', 'third_party/**.js') }}
+          fail-on-cache-miss: true  # Cached by the build-shaka job above
+          enableCrossOsArchive: true  # Share archives from Linux to Windows
 
       - name: Install dependencies
         if: steps.npm-cache.outputs.cache-hit != 'true'
@@ -221,9 +256,9 @@ jobs:
 
       # Run tests on the Selenium grid in our lab.  This uses a private
       # hostname and TLS cert to get EME tests working on all platforms
-      # (since EME only works on https or localhost).  The variable KARMA_PORT
-      # must be defined by the self-hosted runner, and mapped from the host to
-      # the container.
+      # (since EME only works on https or localhost).  The variable
+      # ALLOCATED_PORT must be defined by the self-hosted runner, and mapped
+      # from the host to the container.
       - name: Test Player
         run: |
           # Use of an array keeps elements intact, and allows an element to
@@ -234,7 +269,7 @@ jobs:
           # Generate a coverage report from uncompiled code on ChromeLinux.
           # It should be the uncompiled build, or else we won't execute any
           # coverage instrumentation on full-stack player integration tests.
-          if [[ "${{ matrix.browser }}" == "ChromeLinux" ]]; then
+          if [[ "${{ matrix.browser }}" == "Edge" ]]; then
             extra_flags+=(--html-coverage-report --uncompiled)
           fi
 
@@ -254,7 +289,7 @@ jobs:
               --tls-key /etc/letsencrypt/live/karma.shakalab.rocks/privkey.pem \
               --tls-cert /etc/letsencrypt/live/karma.shakalab.rocks/fullchain.pem \
               --hostname karma.shakalab.rocks \
-              --port $KARMA_PORT \
+              --port $ALLOCATED_PORT \
               --grid-config build/shaka-lab.yaml \
               --grid-address selenium-grid.lab.shaka:4444 \
               --browsers ${{ matrix.browser }} \
@@ -271,10 +306,10 @@ jobs:
           # Report the captured (and possibly overridden) exit status.
           exit $exit_code
 
-      - name: Find coverage report (ChromeLinux only)
+      - name: Find coverage report (Edge only)
         id: coverage
-        # Run even if an earlier step fails, but only on ChromeLinux.
-        if: ${{ always() && matrix.browser == 'ChromeLinux' }}
+        # Run even if an earlier step fails, but only on Edge.
+        if: ${{ always() && matrix.browser == 'Edge' }}
         shell: bash
         run: |
           # Find the path to the coverage report specifically for Chrome on
@@ -282,7 +317,7 @@ jobs:
           # will vary.  Having a single path will make the artifact zip
           # simpler, whereas using a wildcard in the upload step will result
           # in a zip file with internal directories.
-          coverage_report="$( (ls coverage/Chrome*Linux*/coverage.json || true) | head -1 )"
+          coverage_report="$( (ls coverage/Edge*/coverage.json || true) | head -1 )"
 
           # Show what's there, for debugging purposes.
           ls -l coverage/
@@ -295,7 +330,7 @@ jobs:
             exit 1
           fi
 
-      - name: Upload coverage report (ChromeLinux only)
+      - name: Upload coverage report (Edge only)
         uses: actions/upload-artifact@v3
         # If there's a coverage report, upload it, even if a previous step
         # failed.

package/AUTHORS

@@ -15,6 +15,7 @@
 
 Adrián Gómez Llorente <adgllorente@gmail.com>
 AdsWizz <*@adswizz.com>
+Albin Larsson <albin.larsson@eyevinn.se>
 Alex Jones <alexedwardjones@gmail.com>
 Alugha GmbH <*@alugha.com>
 Alvaro Velad Galvan <ladvan91@hotmail.com>
@@ -27,11 +28,14 @@ Charter Communications Inc <*@charter.com>
 Code It <*@code-it.fr>
 Damien Deis <developer.deis@gmail.com>
 Dany L'Hébreux <danylhebreux@gmail.com>
+Dave Nicholas <davenicholasuk@gmail.com>
+Davide Zordan <mail@davide.dev>
 Dl Dador <dldador@gmail.com>
 Edgeware AB <*@edgeware.tv>
 Enson Choy <enson.choy@harmonicinc.com>
 Esteban Dosztal <edosztal@gmail.com>
 Fadomire <fadomire@gmail.com>
+Fernando Neira <slocomber@gmail.com>
 Gerardo Meola <meola.gerardo@gmail.com>
 Gil Gonen <gil.gonen@gmail.com>
 Giorgio Gamberoni <giorgio.gamberoni@gmail.com>
@@ -40,6 +44,7 @@ Google Inc. <*@google.com>
 Itay Kinnrot <Itay.Kinnrot@Kaltura.com>
 Jaeseok Lee <devsunb@gmail.com>
 Jason Palmer <jason@jason-palmer.com>
+Jean-alexandre Iragne <jairagne@gmail.com>
 Jesper Haug Karsrud <jesper.karsrud@gmail.com>
 Johan Sundström <oyasumi@gmail.com>
 Jonas Birmé <jonas.birme@eyevinn.se>
@@ -47,6 +52,7 @@ Jozef Chúťka <jozefchutka@gmail.com>
 Jun Hong Chong <chongjunhong@gmail.com>
 Jürgen Kartnaller <kartnaller@lovelysystems.com>
 JW Player <*@jwplayer.com>
+Konstantin Grushetsky <github@grushetsky.net>
 Lucas Gabriel Sánchez <unkiwii@gmail.com>
 Martin Stark <martin.stark@eyevinn.se>
 Matthias Van Parijs <matvp91@gmail.com>
@@ -78,6 +84,7 @@ Seongryun Jo <ocipap0531@gmail.com>
 Swank Motion Pictures Inc. <*@swankmp.com>
 TalkTalk Plc <*@talktalkplc.com>
 Tatsiana Gelahova <tatsiana.gelahova@gmail.com>
+Tian Shao <tyrelltle@gmail.com>
 Tomas Tichy <mr.tichyt@gmail.com>
 Tomohiro Matsuzawa <thmatuza75@hotmail.com>
 Toshihiro Suzuki <t.suzuki326@gmail.com>
@@ -87,6 +94,8 @@ ViacomCBS <*@viacomcbs.com>
 Vincent Valot <valot.vince@gmail.com>
 V-Nova Limited <*@v-nova.com>
 Wayne Morgan <wayne.morgan.dev@gmail.com>
+Wen Ren <renwen0615@gmail.com>
+Wojciech Tyczyński <tykus160@gmail.com>
 Raymond Cheng <raycheng100@gmail.com>
 Blue Billywig <*@bluebillywig.com>
 João Nabais <jlnabais@gmail.com>