shaka-player 4.3.8 → 4.3.9

package/.github/ISSUE_TEMPLATE/bug_report.md

@@ -12,7 +12,16 @@ assignees: ''
 **Have you read the [FAQ](https://bit.ly/ShakaFAQ) and checked for duplicate open issues?**
 
 
+**If the problem is related to FairPlay, have you read the tutorial?**
+<!-- NOTE: https://shaka-player-demo.appspot.com/docs/api/tutorial-fairplay.html -->
+
+
 **What version of Shaka Player are you using?**
+<!-- NOTE:
+  Only some versions of the application are maintained, if your version
+  is older, first update to a newer one. See:
+  https://github.com/shaka-project/shaka-player/blob/main/maintained-branches.md
+--->
 
 
 **Can you reproduce the issue with our latest release version?**
@@ -41,6 +50,8 @@ assignees: ''
   enough to reproduce your issue, and we **will** ask you to send a
   URI instead.  You can copy the URI of the demo app to send us the
   exact asset, licence server, and settings you have selected there.
+  If you send the URIs to email, the response time and resolution
+  will be much higher.
 -->
 
 

package/.github/workflows/build-and-test.yaml

@@ -125,6 +125,14 @@ jobs:
           # Install a launcher that can execute a shell script to launch this
           npm install karma-script-launcher --save-dev
 
+      # When "Chrome for Testing" is installed on Mac, it gets invoked instead
+      # of simply "Chrome".  This other copy of Chrome, however, doesn't seem
+      # to have basic codecs like AAC and H264 available, causing many of our
+      # test scenarios to fail.  Deleting "Chrome for Testing" fixes this.
+      - name: 'Delete "Chrome for Testing" on Mac'
+        if: matrix.os == 'macos-latest' && matrix.browser == 'Chrome'
+        run: sudo rm -rf /Applications/Google\ Chrome\ for\ Testing.app
+
       # Some CI images (self-hosted or otherwise) don't have the minimum Java
       # version necessary for the compiler (Java 11).
       - uses: actions/setup-java@v3

package/.github/workflows/selenium-lab-tests.yaml

@@ -251,11 +251,12 @@ jobs:
           python3 build/test.py \
               --no-build \
               --reporters spec --spec-hide-passed \
-              --lets-encrypt-folder /etc/shakalab.rocks \
+              --tls-key /etc/letsencrypt/live/karma.shakalab.rocks/privkey.pem \
+              --tls-cert /etc/letsencrypt/live/karma.shakalab.rocks/fullchain.pem \
               --hostname karma.shakalab.rocks \
               --port $KARMA_PORT \
               --grid-config build/shaka-lab.yaml \
-              --grid-address selenium-grid.lab:4444 \
+              --grid-address selenium-grid.lab.shaka:4444 \
               --browsers ${{ matrix.browser }} \
               "${extra_flags[@]}"
           # Capture the test exit code immediately after running the tests.

package/.github/workflows/update-issues.yaml

@@ -10,6 +10,7 @@ on:
 
 permissions:
   issues: write
+  pull-requests: write
 
 jobs:
   update-issues:

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # Changelog
 
+## [4.3.9](https://github.com/shaka-project/shaka-player/compare/v4.3.8...v4.3.9) (2023-08-21)
+
+
+### Bug Fixes
+
+* add MIME type for HTML5 tracks ([#5452](https://github.com/shaka-project/shaka-player/issues/5452)) ([5fb44db](https://github.com/shaka-project/shaka-player/commit/5fb44dba6d7670e24e8df90fe96588ce2a48c92b))
+* Default language to 'und' for native tracks ([#5464](https://github.com/shaka-project/shaka-player/issues/5464)) ([c31f3db](https://github.com/shaka-project/shaka-player/commit/c31f3db9c3efe44dfd28e03db64628827fdf9b5f))
+* Fix exiting fullscreen on Safari ([#5439](https://github.com/shaka-project/shaka-player/issues/5439)) ([81626b2](https://github.com/shaka-project/shaka-player/commit/81626b20ada137305cbaae808315244eaa84906d)), closes [#5437](https://github.com/shaka-project/shaka-player/issues/5437)
+* Fix memory leak on SimpleAbrManager ([#5478](https://github.com/shaka-project/shaka-player/issues/5478)) ([f8cb6ef](https://github.com/shaka-project/shaka-player/commit/f8cb6ef50a5501a92a94e13099a80690fb7b046d))
+* Fix playRangeEnd does not work with HLS streams ([#5494](https://github.com/shaka-project/shaka-player/issues/5494)) ([899eb07](https://github.com/shaka-project/shaka-player/commit/899eb0725f842df21f927a8c63a02e40986bd7fc))
+* gettting maxWidth and maxHeight for restrictToElementSize option ([#5481](https://github.com/shaka-project/shaka-player/issues/5481)) ([053da3b](https://github.com/shaka-project/shaka-player/commit/053da3b7ad60abb2848ad8848cd017d83a4316c6))
+* **HLS:** Fix external subtitles out of sync in HLS ([#5491](https://github.com/shaka-project/shaka-player/issues/5491)) ([38c8a88](https://github.com/shaka-project/shaka-player/commit/38c8a88a9c04e25b02784c00117f6a3ff11e007d))
+* Remove duplicate adaptation event before init ([#5492](https://github.com/shaka-project/shaka-player/issues/5492)) ([75a55b5](https://github.com/shaka-project/shaka-player/commit/75a55b580baebf35a1e26e8cd7920025bc3e1b8a))
+* Support fLaC and Opus codec strings in HLS ([#5454](https://github.com/shaka-project/shaka-player/issues/5454)) ([09bdd61](https://github.com/shaka-project/shaka-player/commit/09bdd61f6e47f4239bf5fbc3d60754f61ec5be94)), closes [#5453](https://github.com/shaka-project/shaka-player/issues/5453)
+* **UI:** Disable right click on range elements ([#5497](https://github.com/shaka-project/shaka-player/issues/5497)) ([1c55e89](https://github.com/shaka-project/shaka-player/commit/1c55e89586e1eb6be620af86061d981349643a28))
+* Update karma-local-wd-launcher to fix Chromedriver >= 115, fix M1 mac ([#5489](https://github.com/shaka-project/shaka-player/issues/5489)) ([1ce673b](https://github.com/shaka-project/shaka-player/commit/1ce673b0442ea401037fc084342a3cd3ff801f21))
+* Update karma-local-wd-launcher to fix Edge >= 115 ([#5506](https://github.com/shaka-project/shaka-player/issues/5506)) ([4a9bc9b](https://github.com/shaka-project/shaka-player/commit/4a9bc9b2cef1f5c352eeebf6998162260a2973db))
+* **WebVTT:** Fix text-shadow in WebVTT not working ([#5499](https://github.com/shaka-project/shaka-player/issues/5499)) ([d78547a](https://github.com/shaka-project/shaka-player/commit/d78547a79b8356b6040dbc73d922b1b87822b541))
+
 ## [4.3.8](https://github.com/shaka-project/shaka-player/compare/v4.3.7...v4.3.8) (2023-07-21)
 
 

package/dist/deps.js

@@ -122,7 +122,7 @@ goog.addDependency('../../../../lib/polyfill/encryption_scheme.js', ['shaka.poly
 goog.addDependency('../../../../lib/polyfill/fullscreen.js', ['shaka.polyfill.Fullscreen'], ['shaka.polyfill'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/polyfill/media_capabilities.js', ['shaka.polyfill.MediaCapabilities'], ['shaka.log', 'shaka.media.Capabilities', 'shaka.polyfill', 'shaka.util.Platform'], {'lang': 'es8'});
 goog.addDependency('../../../../lib/polyfill/mediasource.js', ['shaka.polyfill.MediaSource'], ['shaka.log', 'shaka.polyfill', 'shaka.util.MimeUtils', 'shaka.util.Platform'], {'lang': 'es6'});
-goog.addDependency('../../../../lib/polyfill/orientation.js', ['shaka.polyfill.Orientation'], ['shaka.polyfill', 'shaka.util.FakeEvent', 'shaka.util.FakeEventTarget'], {'lang': 'es6'});
+goog.addDependency('../../../../lib/polyfill/orientation.js', ['shaka.polyfill.Orientation'], ['shaka.log', 'shaka.polyfill', 'shaka.util.FakeEvent', 'shaka.util.FakeEventTarget'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/polyfill/patchedmediakeys_apple.js', ['shaka.polyfill.PatchedMediaKeysApple'], ['goog.asserts', 'shaka.log', 'shaka.media.DrmEngine', 'shaka.polyfill', 'shaka.util.BufferUtils', 'shaka.util.EventManager', 'shaka.util.FakeEvent', 'shaka.util.FakeEventTarget', 'shaka.util.MediaReadyState', 'shaka.util.PublicPromise', 'shaka.util.StringUtils'], {'lang': 'es8'});
 goog.addDependency('../../../../lib/polyfill/patchedmediakeys_nop.js', ['shaka.polyfill.PatchedMediaKeysNop'], ['goog.asserts', 'shaka.log', 'shaka.polyfill'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/polyfill/patchedmediakeys_webkit.js', ['shaka.polyfill.PatchedMediaKeysWebkit'], ['goog.asserts', 'shaka.log', 'shaka.media.DrmEngine', 'shaka.polyfill', 'shaka.util.BufferUtils', 'shaka.util.EventManager', 'shaka.util.FakeEvent', 'shaka.util.FakeEventTarget', 'shaka.util.PublicPromise', 'shaka.util.StringUtils', 'shaka.util.Timer', 'shaka.util.Uint8ArrayUtils'], {'lang': 'es6'});

package/dist/locales.js

@@ -721,45 +721,45 @@ shaka.ui.Locales.addTo = function(localization) {
  * @const
  */
 shaka.ui.Locales.Ids = {
-  SKIP_AD: 'SKIP_AD',
-  PLAY: 'PLAY',
-  LIVE: 'LIVE',
-  UNDETERMINED_LANGUAGE: 'UNDETERMINED_LANGUAGE',
   VOLUME: 'VOLUME',
-  AD_DURATION: 'AD_DURATION',
+  REPLAY: 'REPLAY',
+  EXIT_PICTURE_IN_PICTURE: 'EXIT_PICTURE_IN_PICTURE',
+  LANGUAGE: 'LANGUAGE',
   MUTE: 'MUTE',
-  SEEK: 'SEEK',
-  SKIP_TO_LIVE: 'SKIP_TO_LIVE',
-  PLAYBACK_RATE: 'PLAYBACK_RATE',
+  SKIP_AD: 'SKIP_AD',
+  BACK: 'BACK',
   AIRPLAY: 'AIRPLAY',
-  PAUSE: 'PAUSE',
-  AD_PROGRESS: 'AD_PROGRESS',
-  AD_TIME: 'AD_TIME',
-  CAPTIONS: 'CAPTIONS',
+  SKIP_TO_LIVE: 'SKIP_TO_LIVE',
+  UNMUTE: 'UNMUTE',
   MULTIPLE_LANGUAGES: 'MULTIPLE_LANGUAGES',
-  FAST_FORWARD: 'FAST_FORWARD',
-  RESOLUTION: 'RESOLUTION',
-  PICTURE_IN_PICTURE: 'PICTURE_IN_PICTURE',
-  LANGUAGE: 'LANGUAGE',
+  LOOP: 'LOOP',
+  STATISTICS: 'STATISTICS',
+  SEEK: 'SEEK',
   OFF: 'OFF',
-  ENTER_LOOP_MODE: 'ENTER_LOOP_MODE',
-  REWIND: 'REWIND',
+  ENTER_PICTURE_IN_PICTURE: 'ENTER_PICTURE_IN_PICTURE',
+  AD_PROGRESS: 'AD_PROGRESS',
   CAST: 'CAST',
-  AUTO_QUALITY: 'AUTO_QUALITY',
-  UNRECOGNIZED_LANGUAGE: 'UNRECOGNIZED_LANGUAGE',
-  EXIT_LOOP_MODE: 'EXIT_LOOP_MODE',
-  EXIT_PICTURE_IN_PICTURE: 'EXIT_PICTURE_IN_PICTURE',
-  REPLAY: 'REPLAY',
-  SUBTITLE_FORCED: 'SUBTITLE_FORCED',
+  RESOLUTION: 'RESOLUTION',
+  CAPTIONS: 'CAPTIONS',
   NOT_APPLICABLE: 'NOT_APPLICABLE',
+  PLAY: 'PLAY',
+  QUALITY: 'QUALITY',
+  FAST_FORWARD: 'FAST_FORWARD',
+  AD_TIME: 'AD_TIME',
   FULL_SCREEN: 'FULL_SCREEN',
+  PICTURE_IN_PICTURE: 'PICTURE_IN_PICTURE',
+  UNRECOGNIZED_LANGUAGE: 'UNRECOGNIZED_LANGUAGE',
+  AD_DURATION: 'AD_DURATION',
   ON: 'ON',
-  QUALITY: 'QUALITY',
-  STATISTICS: 'STATISTICS',
+  ENTER_LOOP_MODE: 'ENTER_LOOP_MODE',
+  AUTO_QUALITY: 'AUTO_QUALITY',
+  PAUSE: 'PAUSE',
+  PLAYBACK_RATE: 'PLAYBACK_RATE',
+  UNDETERMINED_LANGUAGE: 'UNDETERMINED_LANGUAGE',
   MORE_SETTINGS: 'MORE_SETTINGS',
-  ENTER_PICTURE_IN_PICTURE: 'ENTER_PICTURE_IN_PICTURE',
-  UNMUTE: 'UNMUTE',
-  BACK: 'BACK',
-  LOOP: 'LOOP',
+  LIVE: 'LIVE',
+  REWIND: 'REWIND',
+  EXIT_LOOP_MODE: 'EXIT_LOOP_MODE',
   EXIT_FULL_SCREEN: 'EXIT_FULL_SCREEN',
+  SUBTITLE_FORCED: 'SUBTITLE_FORCED',
 };

package/dist/shaka-player.compiled.d.ts

@@ -3694,7 +3694,7 @@ declare namespace shaka.extern {
 }
 // Generated from /home/runner/work/shaka-player/shaka-player/externs/shaka/manifest.js
 declare namespace shaka.extern {
-  type Stream = { audioSamplingRate : number | null , bandwidth ? : number , channelsCount : number | null , closeSegmentIndex ? : ( ) => any , closedCaptions : Map < string , string > | null , codecs : string , createSegmentIndex : shaka.extern.CreateSegmentIndexFunction , drmInfos : shaka.extern.DrmInfo [] , emsgSchemeIdUris : string [] | null , encrypted : boolean , forced : boolean , frameRate ? : number , hdr ? : string , height ? : number , id : number , keyIds : Set < string > , kind ? : string , label : string | null , language : string , matchedStreams ? : any [] , mimeType : string , originalId : string | null , pixelAspectRatio ? : string , primary : boolean , roles : string [] , segmentIndex : shaka.media.SegmentIndex | null , spatialAudio : boolean , tilesLayout ? : string , trickModeVideo : any , type : string , width ? : number } ;
+  type Stream = { audioSamplingRate : number | null , bandwidth ? : number , channelsCount : number | null , closeSegmentIndex ? : ( ) => any , closedCaptions : Map < string , string > | null , codecs : string , createSegmentIndex : shaka.extern.CreateSegmentIndexFunction , drmInfos : shaka.extern.DrmInfo [] , emsgSchemeIdUris : string [] | null , encrypted : boolean , external : boolean , forced : boolean , frameRate ? : number , hdr ? : string , height ? : number , id : number , keyIds : Set < string > , kind ? : string , label : string | null , language : string , matchedStreams ? : any [] , mimeType : string , originalId : string | null , pixelAspectRatio ? : string , primary : boolean , roles : string [] , segmentIndex : shaka.media.SegmentIndex | null , spatialAudio : boolean , tilesLayout ? : string , trickModeVideo : any , type : string , width ? : number } ;
 }
 // Generated from /home/runner/work/shaka-player/shaka-player/externs/shaka/manifest.js
 declare namespace shaka.extern {
@@ -3994,7 +3994,7 @@ declare namespace shaka.extern {
 }
 // Generated from /home/runner/work/shaka-player/shaka-player/externs/shaka/offline.js
 declare namespace shaka.extern {
-  type StreamDB = { audioSamplingRate : number | null , channelsCount : number | null , closedCaptions : Map < string , string > | null , codecs : string , encrypted : boolean , forced : boolean , frameRate ? : number , hdr ? : string , height : number | null , id : number , keyIds : Set < string > , kind ? : string , label : string | null , language : string , mimeType : string , originalId : string | null , pixelAspectRatio ? : string , primary : boolean , roles : string [] , segments : shaka.extern.SegmentDB [] , spatialAudio : boolean , tilesLayout ? : string , type : string , variantIds : number [] , width : number | null } ;
+  type StreamDB = { audioSamplingRate : number | null , channelsCount : number | null , closedCaptions : Map < string , string > | null , codecs : string , encrypted : boolean , external : boolean , forced : boolean , frameRate ? : number , hdr ? : string , height : number | null , id : number , keyIds : Set < string > , kind ? : string , label : string | null , language : string , mimeType : string , originalId : string | null , pixelAspectRatio ? : string , primary : boolean , roles : string [] , segments : shaka.extern.SegmentDB [] , spatialAudio : boolean , tilesLayout ? : string , type : string , variantIds : number [] , width : number | null } ;
 }
 // Generated from /home/runner/work/shaka-player/shaka-player/externs/shaka/offline_compat_v1.js
 declare namespace shaka.extern {

package/dist/shaka-player.compiled.debug.d.ts

@@ -3694,7 +3694,7 @@ declare namespace shaka.extern {
 }
 // Generated from /home/runner/work/shaka-player/shaka-player/externs/shaka/manifest.js
 declare namespace shaka.extern {
-  type Stream = { audioSamplingRate : number | null , bandwidth ? : number , channelsCount : number | null , closeSegmentIndex ? : ( ) => any , closedCaptions : Map < string , string > | null , codecs : string , createSegmentIndex : shaka.extern.CreateSegmentIndexFunction , drmInfos : shaka.extern.DrmInfo [] , emsgSchemeIdUris : string [] | null , encrypted : boolean , forced : boolean , frameRate ? : number , hdr ? : string , height ? : number , id : number , keyIds : Set < string > , kind ? : string , label : string | null , language : string , matchedStreams ? : any [] , mimeType : string , originalId : string | null , pixelAspectRatio ? : string , primary : boolean , roles : string [] , segmentIndex : shaka.media.SegmentIndex | null , spatialAudio : boolean , tilesLayout ? : string , trickModeVideo : any , type : string , width ? : number } ;
+  type Stream = { audioSamplingRate : number | null , bandwidth ? : number , channelsCount : number | null , closeSegmentIndex ? : ( ) => any , closedCaptions : Map < string , string > | null , codecs : string , createSegmentIndex : shaka.extern.CreateSegmentIndexFunction , drmInfos : shaka.extern.DrmInfo [] , emsgSchemeIdUris : string [] | null , encrypted : boolean , external : boolean , forced : boolean , frameRate ? : number , hdr ? : string , height ? : number , id : number , keyIds : Set < string > , kind ? : string , label : string | null , language : string , matchedStreams ? : any [] , mimeType : string , originalId : string | null , pixelAspectRatio ? : string , primary : boolean , roles : string [] , segmentIndex : shaka.media.SegmentIndex | null , spatialAudio : boolean , tilesLayout ? : string , trickModeVideo : any , type : string , width ? : number } ;
 }
 // Generated from /home/runner/work/shaka-player/shaka-player/externs/shaka/manifest.js
 declare namespace shaka.extern {
@@ -3994,7 +3994,7 @@ declare namespace shaka.extern {
 }
 // Generated from /home/runner/work/shaka-player/shaka-player/externs/shaka/offline.js
 declare namespace shaka.extern {
-  type StreamDB = { audioSamplingRate : number | null , channelsCount : number | null , closedCaptions : Map < string , string > | null , codecs : string , encrypted : boolean , forced : boolean , frameRate ? : number , hdr ? : string , height : number | null , id : number , keyIds : Set < string > , kind ? : string , label : string | null , language : string , mimeType : string , originalId : string | null , pixelAspectRatio ? : string , primary : boolean , roles : string [] , segments : shaka.extern.SegmentDB [] , spatialAudio : boolean , tilesLayout ? : string , type : string , variantIds : number [] , width : number | null } ;
+  type StreamDB = { audioSamplingRate : number | null , channelsCount : number | null , closedCaptions : Map < string , string > | null , codecs : string , encrypted : boolean , external : boolean , forced : boolean , frameRate ? : number , hdr ? : string , height : number | null , id : number , keyIds : Set < string > , kind ? : string , label : string | null , language : string , mimeType : string , originalId : string | null , pixelAspectRatio ? : string , primary : boolean , roles : string [] , segments : shaka.extern.SegmentDB [] , spatialAudio : boolean , tilesLayout ? : string , type : string , variantIds : number [] , width : number | null } ;
 }
 // Generated from /home/runner/work/shaka-player/shaka-player/externs/shaka/offline_compat_v1.js
 declare namespace shaka.extern {