shaka-player 4.3.2 → 4.3.4

package/.github/workflows/selenium-lab-tests.yaml

@@ -8,6 +8,9 @@ on:
       pr:
         description: "A PR number to build and test in the lab.  If empty, will build and test from main."
         required: false
+      test_filter:
+        description: "A filter to run a subset of the tests.  If empty, all tests will run."
+        required: false
   schedule:
     # Runs every night at 2am PST / 10am UTC, testing against the main branch.
     - cron: '0 10 * * *'
@@ -191,6 +194,11 @@ jobs:
             extra_flags=""
           fi
 
+          filter="${{ github.event.inputs.test_filter }}"
+          if [[ "$filter" != "" ]]; then
+            extra_flags="$extra_flags --filter $filter"
+          fi
+
           python3 build/test.py \
               --no-build \
               --reporters spec --spec-hide-passed \
@@ -241,6 +249,20 @@ jobs:
           # there.
           if-no-files-found: error
 
+      # Upload new screenshots and diffs on failure; ignore if missing
+      - name: Upload screenshots
+        uses: actions/upload-artifact@v3
+        if: ${{ failure() }}
+        with:
+          # In this workflow, "browser" is the selenium node name, which can
+          # contain both browser and OS, such as "ChromeLinux".
+          name: screenshots-${{ matrix.browser }}
+          path: |
+            test/test/assets/screenshots/*/*.png-new
+            test/test/assets/screenshots/*/*.png-diff
+          if-no-files-found: ignore
+          retention-days: 5
+
       - name: Report final commit status
         # Will run on success or failure, but not if the workflow is cancelled.
         if: ${{ success() || failure() }}

package/CHANGELOG.md

@@ -1,5 +1,42 @@
 # Changelog
 
+## [4.3.4](https://github.com/shaka-project/shaka-player/compare/v4.3.3...v4.3.4) (2023-01-31)
+
+
+### Bug Fixes
+
+* Add mux.js to support.html ([#4923](https://github.com/shaka-project/shaka-player/issues/4923)) ([fde895e](https://github.com/shaka-project/shaka-player/commit/fde895e13c4a935b39aa9bf2bc0c5dce77add0b0))
+* **DASH:** Fix dynamic manifests from edgeware ([#4914](https://github.com/shaka-project/shaka-player/issues/4914)) ([983dea3](https://github.com/shaka-project/shaka-player/commit/983dea3c87796384d9b7f876e73c47545d97e980))
+* Fix MediaCapabilities polyfill on Hisense ([#4927](https://github.com/shaka-project/shaka-player/issues/4927)) ([d36677f](https://github.com/shaka-project/shaka-player/commit/d36677f0db52bff2fef967e787954e8f25889d2f))
+* Fix WebVTT parser failure on REGION blocks ([#4915](https://github.com/shaka-project/shaka-player/issues/4915)) ([f57a954](https://github.com/shaka-project/shaka-player/commit/f57a9541cdff50de63f41247e258673fbed0cf78))
+* **HLS:** Fix detection of WebVTT subtitles in HLS by extension ([#4928](https://github.com/shaka-project/shaka-player/issues/4928)) ([86c58ee](https://github.com/shaka-project/shaka-player/commit/86c58ee1d4f6e0fe56a5aaebf9771024193a9efe)), closes [#4929](https://github.com/shaka-project/shaka-player/issues/4929)
+* **HLS:** IMSC1 subtitles not working in a HLS stream ([#4942](https://github.com/shaka-project/shaka-player/issues/4942)) ([8a9156f](https://github.com/shaka-project/shaka-player/commit/8a9156fa14cd6646900bdf534714ead775fccb15))
+* **VTT:** Fix combining style selectors ([#4934](https://github.com/shaka-project/shaka-player/issues/4934)) ([bd04cf1](https://github.com/shaka-project/shaka-player/commit/bd04cf15223d026bb880ab0cca2a3e6332e8f485))
+* **WebVTT:** Add support to  , ‎ and ‏ ([#4920](https://github.com/shaka-project/shaka-player/issues/4920)) ([d2e2d49](https://github.com/shaka-project/shaka-player/commit/d2e2d49da0593d2ee2e0e4da7e2ce9acae0798af))
+* **WebVTT:** Add support to voice tag styles ([#4845](https://github.com/shaka-project/shaka-player/issues/4845)) ([4fb19fb](https://github.com/shaka-project/shaka-player/commit/4fb19fb075a89ae6a401c236b65c82d899a069d8))
+* **WebVTT:** Fix horizontal positioning with cue box size ([#4949](https://github.com/shaka-project/shaka-player/issues/4949)) ([cefbe08](https://github.com/shaka-project/shaka-player/commit/cefbe083b684fc1295483e938a8576d9de81a359))
+* **WebVTT:** Fix voices with styles and support to multiple styles ([#4922](https://github.com/shaka-project/shaka-player/issues/4922)) ([981bceb](https://github.com/shaka-project/shaka-player/commit/981bceb233b029b6e77499439627455913a1784d))
+
+## [4.3.3](https://github.com/shaka-project/shaka-player/compare/v4.3.2...v4.3.3) (2023-01-13)
+
+
+### Bug Fixes
+
+* Fix exception enabling captions on HLS ([#4894](https://github.com/shaka-project/shaka-player/issues/4894)) ([1d0ad52](https://github.com/shaka-project/shaka-player/commit/1d0ad529e7e38be07df2ed08fb14a2b88098b7fc)), closes [#4889](https://github.com/shaka-project/shaka-player/issues/4889)
+* Fix flattenedCues in WebVttGenerator ([#4867](https://github.com/shaka-project/shaka-player/issues/4867)) ([e062175](https://github.com/shaka-project/shaka-player/commit/e0621753a5b1342df34a87db462cc4dd18657c3b))
+* Fix legacy codec support by rewriting codec metadata ([#4858](https://github.com/shaka-project/shaka-player/issues/4858)) ([92abfbc](https://github.com/shaka-project/shaka-player/commit/92abfbcca3e0288c4d2a31ef0771a4c0ed2d4405))
+* Fix media source duration when using sequence mode ([#4848](https://github.com/shaka-project/shaka-player/issues/4848)) ([c9db2a0](https://github.com/shaka-project/shaka-player/commit/c9db2a073c096a7a97afc99fb10301aedbc96a87))
+* Fix parsing error on Chromecast when resyncing HLS ([#4869](https://github.com/shaka-project/shaka-player/issues/4869)) ([6dfa6d7](https://github.com/shaka-project/shaka-player/commit/6dfa6d7abbc98c1d1bc18cf70cb6cf1ad80a83f4)), closes [#4589](https://github.com/shaka-project/shaka-player/issues/4589)
+* Fix potential AV sync issues after seek or adaptation ([#4886](https://github.com/shaka-project/shaka-player/issues/4886)) ([72396b0](https://github.com/shaka-project/shaka-player/commit/72396b019dfe69a50526361be7bc5273786424c0)), closes [#4589](https://github.com/shaka-project/shaka-player/issues/4589)
+* Fix potential duplicate segments, AV sync issues ([#4884](https://github.com/shaka-project/shaka-player/issues/4884)) ([0ac5d7e](https://github.com/shaka-project/shaka-player/commit/0ac5d7ef2ad50bbd61d183566888227e4a1dca78)), closes [#4589](https://github.com/shaka-project/shaka-player/issues/4589)
+* **HLS:** Fix discontinuity tracking ([#4881](https://github.com/shaka-project/shaka-player/issues/4881)) ([2a0ab01](https://github.com/shaka-project/shaka-player/commit/2a0ab012ee11778b9e666014afd92dda2343a780)), closes [#4589](https://github.com/shaka-project/shaka-player/issues/4589)
+* **HLS:** Fix support for mixed AES-128/NONE decryption ([#4847](https://github.com/shaka-project/shaka-player/issues/4847)) ([d495255](https://github.com/shaka-project/shaka-player/commit/d495255523aef39b3f6abd1aa3e5196e976c338f))
+* Make encoding problem detection more robust ([#4885](https://github.com/shaka-project/shaka-player/issues/4885)) ([b1f5c9a](https://github.com/shaka-project/shaka-player/commit/b1f5c9af69dba7ba7eac352e444bd75a0d4f2ae6)), closes [#4589](https://github.com/shaka-project/shaka-player/issues/4589)
+* Release region timeline when unloading ([#4871](https://github.com/shaka-project/shaka-player/issues/4871)) ([8795a66](https://github.com/shaka-project/shaka-player/commit/8795a66edaa5b9c26b687cb28dc194db56e63a9f)), closes [#4850](https://github.com/shaka-project/shaka-player/issues/4850)
+* Sync each segment against EXT-X-PROGRAM-DATE-TIME ([#4870](https://github.com/shaka-project/shaka-player/issues/4870)) ([8f9162f](https://github.com/shaka-project/shaka-player/commit/8f9162f154cd63404bbe95667396a9b12fe73ca6)), closes [#4589](https://github.com/shaka-project/shaka-player/issues/4589)
+* Treat regions uniquely ([#4841](https://github.com/shaka-project/shaka-player/issues/4841)) ([36a3a44](https://github.com/shaka-project/shaka-player/commit/36a3a442cffd2067a48759ad03d05d76efc5accf)), closes [#4839](https://github.com/shaka-project/shaka-player/issues/4839)
+* **ui:** Avoid submitting form if player is inside form ([#4866](https://github.com/shaka-project/shaka-player/issues/4866)) ([fc98e1d](https://github.com/shaka-project/shaka-player/commit/fc98e1d90643ead45632e8a0fb43e5c18aa0a267)), closes [#4861](https://github.com/shaka-project/shaka-player/issues/4861)
+
 ## [4.3.2](https://github.com/shaka-project/shaka-player/compare/v4.3.1...v4.3.2) (2022-12-14)
 
 

package/dist/deps.js

@@ -81,7 +81,7 @@ goog.addDependency('../../../../lib/media/quality_observer.js', ['shaka.media.Qu
 goog.addDependency('../../../../lib/media/region_observer.js', ['shaka.media.RegionObserver'], ['shaka.media.IPlayheadObserver', 'shaka.media.RegionTimeline', 'shaka.util.EventManager', 'shaka.util.FakeEvent', 'shaka.util.FakeEventTarget'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/media/region_timeline.js', ['shaka.media.RegionTimeline'], ['shaka.util.FakeEvent', 'shaka.util.FakeEventTarget', 'shaka.util.IReleasable', 'shaka.util.Timer'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/media/segment_index.js', ['shaka.media.MetaSegmentIndex', 'shaka.media.SegmentIndex', 'shaka.media.SegmentIterator'], ['goog.asserts', 'shaka.media.SegmentReference', 'shaka.util.IReleasable', 'shaka.util.Timer'], {'lang': 'es8'});
-goog.addDependency('../../../../lib/media/segment_reference.js', ['shaka.media.InitSegmentReference', 'shaka.media.SegmentReference'], ['goog.asserts', 'shaka.util.ArrayUtils'], {'lang': 'es6'});
+goog.addDependency('../../../../lib/media/segment_reference.js', ['shaka.media.InitSegmentReference', 'shaka.media.SegmentReference'], ['goog.asserts', 'shaka.log', 'shaka.util.ArrayUtils'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/media/stall_detector.js', ['shaka.media.StallDetector', 'shaka.media.StallDetector.Implementation', 'shaka.media.StallDetector.MediaElementImplementation'], ['shaka.media.TimeRangesUtils', 'shaka.util.FakeEvent', 'shaka.util.IReleasable'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/media/streaming_engine.js', ['shaka.media.StreamingEngine'], ['goog.asserts', 'shaka.log', 'shaka.media.InitSegmentReference', 'shaka.media.MediaSourceEngine', 'shaka.media.SegmentIterator', 'shaka.media.SegmentReference', 'shaka.net.Backoff', 'shaka.net.NetworkingEngine', 'shaka.util.DelayedTick', 'shaka.util.Destroyer', 'shaka.util.Error', 'shaka.util.FakeEvent', 'shaka.util.IDestroyable', 'shaka.util.Id3Utils', 'shaka.util.ManifestParserUtils', 'shaka.util.MimeUtils', 'shaka.util.Mp4Parser', 'shaka.util.Networking'], {'lang': 'es8'});
 goog.addDependency('../../../../lib/media/time_ranges_utils.js', ['shaka.media.TimeRangesUtils'], [], {'lang': 'es6'});
@@ -141,14 +141,15 @@ goog.addDependency('../../../../lib/text/lrc_text_parser.js', ['shaka.text.LrcTe
 goog.addDependency('../../../../lib/text/mp4_ttml_parser.js', ['shaka.text.Mp4TtmlParser'], ['shaka.text.TextEngine', 'shaka.text.TtmlTextParser', 'shaka.util.Error', 'shaka.util.Mp4Parser'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/text/mp4_vtt_parser.js', ['shaka.text.Mp4VttParser'], ['goog.asserts', 'shaka.log', 'shaka.text.Cue', 'shaka.text.TextEngine', 'shaka.text.VttTextParser', 'shaka.util.DataViewReader', 'shaka.util.Error', 'shaka.util.Functional', 'shaka.util.Mp4BoxParsers', 'shaka.util.Mp4Parser', 'shaka.util.StringUtils', 'shaka.util.TextParser'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/text/sbv_text_parser.js', ['shaka.text.SbvTextParser'], ['goog.asserts', 'shaka.text.Cue', 'shaka.text.TextEngine', 'shaka.util.Error', 'shaka.util.StringUtils', 'shaka.util.TextParser'], {'lang': 'es6'});
-goog.addDependency('../../../../lib/text/simple_text_displayer.js', ['shaka.text.SimpleTextDisplayer'], ['goog.asserts', 'shaka.log', 'shaka.text.Cue'], {'lang': 'es6'});
+goog.addDependency('../../../../lib/text/simple_text_displayer.js', ['shaka.text.SimpleTextDisplayer'], ['goog.asserts', 'shaka.log', 'shaka.text.Cue', 'shaka.text.Utils'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/text/srt_text_parser.js', ['shaka.text.SrtTextParser'], ['goog.asserts', 'shaka.text.TextEngine', 'shaka.text.VttTextParser', 'shaka.util.BufferUtils', 'shaka.util.StringUtils'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/text/ssa_text_parser.js', ['shaka.text.SsaTextParser'], ['goog.asserts', 'shaka.log', 'shaka.text.Cue', 'shaka.text.TextEngine', 'shaka.util.StringUtils'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/text/text_engine.js', ['shaka.text.TextEngine'], ['goog.asserts', 'shaka.log', 'shaka.text.Cue', 'shaka.util.BufferUtils', 'shaka.util.IDestroyable', 'shaka.util.MimeUtils'], {'lang': 'es8'});
+goog.addDependency('../../../../lib/text/text_utils.js', ['shaka.text.Utils'], ['shaka.text.Cue'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/text/ttml_text_parser.js', ['shaka.text.TtmlTextParser'], ['goog.asserts', 'shaka.log', 'shaka.text.Cue', 'shaka.text.CueRegion', 'shaka.text.TextEngine', 'shaka.util.ArrayUtils', 'shaka.util.Error', 'shaka.util.StringUtils', 'shaka.util.XmlUtils'], {'lang': 'es8'});
 goog.addDependency('../../../../lib/text/ui_text_displayer.js', ['shaka.text.UITextDisplayer'], ['goog.asserts', 'shaka.text.Cue', 'shaka.text.CueRegion', 'shaka.util.Dom', 'shaka.util.EventManager', 'shaka.util.Timer'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/text/vtt_text_parser.js', ['shaka.text.VttTextParser'], ['goog.asserts', 'shaka.log', 'shaka.text.Cue', 'shaka.text.CueRegion', 'shaka.text.TextEngine', 'shaka.util.Error', 'shaka.util.StringUtils', 'shaka.util.TextParser', 'shaka.util.XmlUtils'], {'lang': 'es6'});
-goog.addDependency('../../../../lib/text/web_vtt_generator.js', ['shaka.text.WebVttGenerator'], ['shaka.text.Cue'], {'lang': 'es6'});
+goog.addDependency('../../../../lib/text/web_vtt_generator.js', ['shaka.text.WebVttGenerator'], ['shaka.text.Cue', 'shaka.text.Utils'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/util/abortable_operation.js', ['shaka.util.AbortableOperation'], ['shaka.util.Error', 'shaka.util.PublicPromise'], {'lang': 'es6'});
 goog.addDependency('../../../../lib/util/array_utils.js', ['shaka.util.ArrayUtils'], [], {'lang': 'es6'});
 goog.addDependency('../../../../lib/util/buffer_utils.js', ['shaka.util.BufferUtils'], [], {'lang': 'es6'});

package/dist/locales.js

@@ -721,45 +721,45 @@ shaka.ui.Locales.addTo = function(localization) {
  * @const
  */
 shaka.ui.Locales.Ids = {
-  REWIND: 'REWIND',
-  AD_DURATION: 'AD_DURATION',
-  PLAYBACK_RATE: 'PLAYBACK_RATE',
-  VOLUME: 'VOLUME',
-  SKIP_TO_LIVE: 'SKIP_TO_LIVE',
-  SKIP_AD: 'SKIP_AD',
   AUTO_QUALITY: 'AUTO_QUALITY',
-  LANGUAGE: 'LANGUAGE',
-  OFF: 'OFF',
-  FULL_SCREEN: 'FULL_SCREEN',
-  UNMUTE: 'UNMUTE',
-  RESOLUTION: 'RESOLUTION',
-  FAST_FORWARD: 'FAST_FORWARD',
-  LIVE: 'LIVE',
-  ENTER_LOOP_MODE: 'ENTER_LOOP_MODE',
-  MORE_SETTINGS: 'MORE_SETTINGS',
-  ENTER_PICTURE_IN_PICTURE: 'ENTER_PICTURE_IN_PICTURE',
-  SUBTITLE_FORCED: 'SUBTITLE_FORCED',
-  STATISTICS: 'STATISTICS',
-  MUTE: 'MUTE',
-  EXIT_FULL_SCREEN: 'EXIT_FULL_SCREEN',
   UNRECOGNIZED_LANGUAGE: 'UNRECOGNIZED_LANGUAGE',
-  BACK: 'BACK',
-  CAPTIONS: 'CAPTIONS',
-  EXIT_LOOP_MODE: 'EXIT_LOOP_MODE',
-  AIRPLAY: 'AIRPLAY',
-  REPLAY: 'REPLAY',
+  VOLUME: 'VOLUME',
+  STATISTICS: 'STATISTICS',
   LOOP: 'LOOP',
-  EXIT_PICTURE_IN_PICTURE: 'EXIT_PICTURE_IN_PICTURE',
-  QUALITY: 'QUALITY',
   NOT_APPLICABLE: 'NOT_APPLICABLE',
-  PAUSE: 'PAUSE',
-  PLAY: 'PLAY',
+  UNDETERMINED_LANGUAGE: 'UNDETERMINED_LANGUAGE',
+  CAPTIONS: 'CAPTIONS',
+  MUTE: 'MUTE',
+  EXIT_PICTURE_IN_PICTURE: 'EXIT_PICTURE_IN_PICTURE',
+  SEEK: 'SEEK',
   CAST: 'CAST',
-  MULTIPLE_LANGUAGES: 'MULTIPLE_LANGUAGES',
+  PAUSE: 'PAUSE',
+  FAST_FORWARD: 'FAST_FORWARD',
+  LANGUAGE: 'LANGUAGE',
+  SUBTITLE_FORCED: 'SUBTITLE_FORCED',
+  FULL_SCREEN: 'FULL_SCREEN',
+  AD_TIME: 'AD_TIME',
+  OFF: 'OFF',
+  AD_DURATION: 'AD_DURATION',
+  ENTER_LOOP_MODE: 'ENTER_LOOP_MODE',
+  REPLAY: 'REPLAY',
   AD_PROGRESS: 'AD_PROGRESS',
+  SKIP_AD: 'SKIP_AD',
+  AIRPLAY: 'AIRPLAY',
+  MORE_SETTINGS: 'MORE_SETTINGS',
+  MULTIPLE_LANGUAGES: 'MULTIPLE_LANGUAGES',
+  QUALITY: 'QUALITY',
   PICTURE_IN_PICTURE: 'PICTURE_IN_PICTURE',
-  SEEK: 'SEEK',
-  AD_TIME: 'AD_TIME',
-  UNDETERMINED_LANGUAGE: 'UNDETERMINED_LANGUAGE',
+  PLAY: 'PLAY',
+  BACK: 'BACK',
+  SKIP_TO_LIVE: 'SKIP_TO_LIVE',
+  REWIND: 'REWIND',
+  UNMUTE: 'UNMUTE',
+  PLAYBACK_RATE: 'PLAYBACK_RATE',
+  LIVE: 'LIVE',
+  RESOLUTION: 'RESOLUTION',
+  EXIT_FULL_SCREEN: 'EXIT_FULL_SCREEN',
+  ENTER_PICTURE_IN_PICTURE: 'ENTER_PICTURE_IN_PICTURE',
   ON: 'ON',
+  EXIT_LOOP_MODE: 'EXIT_LOOP_MODE',
 };

package/dist/shaka-player.compiled.d.ts

@@ -1202,10 +1202,20 @@ declare namespace shaka.media {
      * Mark the reference as unavailable.
      */
     markAsUnavailable ( ) : any ;
+    /**
+     * Offset the segment reference by a fixed amount.
+     * @param offset The amount to add to the segment's start and end times.
+     */
+    offset (offset : number ) : any ;
     /**
      * Set the segment's thumbnail sprite.
      */
     setThumbnailSprite (thumbnailSprite : shaka.media.SegmentReference.ThumbnailSprite ) : any ;
+    /**
+     * Sync this segment against a particular sync time that will serve as "0" in
+     * the presentation timeline.
+     */
+    syncAgainst (lowestSyncTime : number ) : any ;
   }
 }
 // Generated from /home/runner/work/shaka-player/shaka-player/dist/shaka-player.compiled.externs.js

package/dist/shaka-player.compiled.debug.d.ts

@@ -1202,10 +1202,20 @@ declare namespace shaka.media {
      * Mark the reference as unavailable.
      */
     markAsUnavailable ( ) : any ;
+    /**
+     * Offset the segment reference by a fixed amount.
+     * @param offset The amount to add to the segment's start and end times.
+     */
+    offset (offset : number ) : any ;
     /**
      * Set the segment's thumbnail sprite.
      */
     setThumbnailSprite (thumbnailSprite : shaka.media.SegmentReference.ThumbnailSprite ) : any ;
+    /**
+     * Sync this segment against a particular sync time that will serve as "0" in
+     * the presentation timeline.
+     */
+    syncAgainst (lowestSyncTime : number ) : any ;
   }
 }
 // Generated from /home/runner/work/shaka-player/shaka-player/dist/shaka-player.compiled.debug.externs.js

package/dist/shaka-player.compiled.debug.externs.js

@@ -1797,6 +1797,18 @@ shaka.media.SegmentReference = class {
    * @return {?shaka.media.SegmentReference.ThumbnailSprite}
    */
   getThumbnailSprite() {}
+  /**
+   * Offset the segment reference by a fixed amount.
+   * @param {number} offset The amount to add to the segment's start and end
+   *   times.
+   */
+  offset(offset) {}
+  /**
+   * Sync this segment against a particular sync time that will serve as "0" in
+   * the presentation timeline.
+   * @param {number} lowestSyncTime
+   */
+  syncAgainst(lowestSyncTime) {}
 };
 /**
  * Rather than using booleans to communicate what the state of the reference,