shaka-player 3.3.10 → 3.3.11

package/.github/workflows/build-and-test.yaml

@@ -41,9 +41,11 @@ jobs:
         include:
           # Run Linux browsers with xvfb, so they're in a headless X session.
           # Additionally, generate a code coverage report from Linux Chrome.
+          # It should be the uncompiled build, or else we won't execute any
+          # coverage instrumentation on full-stack player integration tests.
           - os: ubuntu-latest
             browser: Chrome
-            extra_flags: "--use-xvfb --html-coverage-report"
+            extra_flags: "--use-xvfb --html-coverage-report --uncompiled"
           - os: ubuntu-latest
             browser: Firefox
             extra_flags: "--use-xvfb"
@@ -57,7 +59,7 @@ jobs:
           - os: macos-latest
             browser: Safari
           - os: macos-latest
-            browser: Safari-14
+            browser: Safari-old
 
           - os: windows-latest
             browser: Chrome
@@ -87,21 +89,22 @@ jobs:
         with:
           ref: ${{ github.event.inputs.ref || github.ref }}
 
-      # Safari 14 can be installed, but not to the root, and it can't replace
-      # the standard version, at least not on GitHub's VMs.  If you try to
-      # install directly to the root with sudo, it will appear to succeed, but
-      # will have no effect.  If you try to script it explicitly with rm -rf
-      # and cp, this will fail.  Safari may be on a read-only filesystem.
-      - name: Install Safari 14 to home directory
-        if: matrix.os == 'macos-latest' && matrix.browser == 'Safari-14'
+      # Older versions of Safari can be installed, but not to the root, and it
+      # can't replace the standard version, at least not on GitHub's VMs.  If
+      # you try to install directly to the root with sudo, it will appear to
+      # succeed, but will have no effect.  If you try to script it explicitly
+      # with rm -rf and cp, this will fail.  Safari may be on a read-only
+      # filesystem.
+      - name: Install old Safari to home directory
+        if: matrix.os == 'macos-latest' && matrix.browser == 'Safari-old'
         run: |
-          # Download Safari 14
-          # See also https://www.macupdate.com/app/mac/15675/apple-safari/old-versions
-          curl -Lv https://www.macupdate.com/action/download/62946 > Safari14.0CatalinaAuto.pkg.zip
+          # Download Safari 15
+          # This URL discovered through the seed files listed at
+          # https://github.com/zhangyoufu/swscan.apple.com/blob/master/url.txt
+          curl -Lv http://swcdn.apple.com/content/downloads/42/33/012-57329-A_41P2VU6UHN/5fw5vna27fdw4mqfak5adj3pjpxvo9hgh7/Safari15.6.1CatalinaAuto.pkg > Safari.pkg
 
-          # Install Safari 14 to homedir specifically.
-          unzip Safari14.0CatalinaAuto.pkg.zip
-          installer -pkg Safari14.0CatalinaAuto.pkg -target CurrentUserHomeDirectory
+          # Install older Safari to homedir specifically.
+          installer -pkg Safari.pkg -target CurrentUserHomeDirectory
 
           # Install a launcher that can execute a shell script to launch this
           npm install karma-script-launcher --save-dev
@@ -114,7 +117,7 @@ jobs:
         run: |
           browser=${{ matrix.browser }}
 
-          if [[ "$browser" == "Safari-14" ]]; then
+          if [[ "$browser" == "Safari-old" ]]; then
             # Replace the browser name with a script that can launch this
             # browser from the command line.
             browser="$PWD/.github/workflows/safari-homedir-launcher.sh"
@@ -165,6 +168,18 @@ jobs:
           # an environment variable set, the file should definitely be there.
           if-no-files-found: error
 
+      # Upload new screenshots and diffs on failure; ignore if missing
+      - name: Upload screenshots
+        uses: actions/upload-artifact@v3
+        if: ${{ failure() }}
+        with:
+          name: screenshots-${{ matrix.browser }}
+          path: |
+            test/test/assets/screenshots/*/*.png-new
+            test/test/assets/screenshots/*/*.png-diff
+          if-no-files-found: ignore
+          retention-days: 5
+
   build_in_docker:
     # Don't waste time doing a full matrix of test runs when there was an
     # obvious linter error.

package/.github/workflows/custom-actions/set-commit-status/action.yaml

@@ -11,10 +11,6 @@ inputs:
   state:
     description: Either "pending", "error", "success", or "failure".
     required: true
-  ref:
-    description: A git ref for which to set the commit status.  For PRs, use the head commit, not the merge commit.  Defaults to HEAD.
-    required: false
-    default: HEAD
   token:
     description: A GitHub access token.
     required: true
@@ -30,7 +26,7 @@ runs:
         # next to the status on the PR, it will link to this run where they can
         # see the logs.
         RUN_URL="https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}"
-        SHA1=$(git rev-parse "${{ inputs.ref }}")
+        SHA1=$(git rev-parse HEAD)
 
         GITHUB_TOKEN=${{ inputs.token }} \
         gh api \

package/.github/workflows/deflake.yaml

@@ -0,0 +1,28 @@
+name: Deflake Tests
+
+# Runs when the Selenum nightly test workflow completes.  This will run with
+# full privileges, even if the other workflow doesn't.  That allows us to
+# trigger re-runs if we think the results might be flaky.
+on:
+  workflow_run:
+    workflows: [Selenium Lab Tests]
+    types: [completed]
+
+jobs:
+  deflake:
+    if: ${{ github.event.workflow_run.event == 'schedule' && github.event.workflow_run.conclusion == 'failure' }}
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check run count and re-run workflow
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh api /repos/${{ github.repository }}/actions/runs/${{ github.event.workflow_run.id }} > run.json
+          RUNS=$(jq -r .run_attempt < run.json)
+          if [[ "$RUNS" -lt 3 ]]; then
+            echo "$RUNS failed runs so far; re-running workflow."
+            gh run rerun ${{ github.event.workflow_run.id }} --failed -R ${{ github.repository }}
+          else
+            echo "$RUNS failed runs so far; not re-running workflow."
+          fi

package/.github/workflows/selenium-lab-tests.yaml

@@ -47,7 +47,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
         with:
-          ref: ${{ needs.compute-ref.REF }}
+          ref: ${{ needs.compute-ref.outputs.REF }}
 
       - name: Install dependencies
         run: npm ci
@@ -92,7 +92,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
         with:
-          ref: ${{ needs.compute-ref.REF }}
+          ref: ${{ needs.compute-ref.outputs.REF }}
 
       - name: Set commit status to pending
         uses: ./.github/workflows/custom-actions/set-commit-status
@@ -134,7 +134,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
         with:
-          ref: ${{ needs.compute-ref.REF }}
+          ref: ${{ needs.compute-ref.outputs.REF }}
 
       - name: Set commit status to pending
         uses: ./.github/workflows/custom-actions/set-commit-status
@@ -180,6 +180,15 @@ jobs:
       # the container.
       - name: Test Player
         run: |
+          # Generate a coverage report from uncompiled code on ChromeLinux.
+          # It should be the uncompiled build, or else we won't execute any
+          # coverage instrumentation on full-stack player integration tests.
+          if [[ "${{ matrix.browser }}" == "ChromeLinux" ]]; then
+            extra_flags="--html-coverage-report --uncompiled"
+          else
+            extra_flags=""
+          fi
+
           python3 build/test.py \
               --no-build \
               --reporters spec --spec-hide-passed \
@@ -189,7 +198,7 @@ jobs:
               --grid-config build/shaka-lab.yaml \
               --grid-address selenium-grid.lab:4444 \
               --browsers ${{ matrix.browser }} \
-              --html-coverage-report
+              $extra_flags
 
       - name: Find coverage report (ChromeLinux only)
         id: coverage

package/AUTHORS

@@ -68,6 +68,8 @@ Rostislav Hejduk <Ross-cz@users.noreply.github.com>
 SameGoal Inc. <*@samegoal.com>
 Sanborn Hilland <sanbornh@rogers.com>
 Sander Saares <sander@saares.eu>
+Sanil Raut <sr1990003@gmail.com>
+Seongryun Jo <ocipap0531@gmail.com>
 Swank Motion Pictures Inc. <*@swankmp.com>
 TalkTalk Plc <*@talktalkplc.com>
 Tatsiana Gelahova <tatsiana.gelahova@gmail.com>
@@ -80,3 +82,4 @@ ViacomCBS <*@viacomcbs.com>
 Vincent Valot <valot.vince@gmail.com>
 Wayne Morgan <wayne.morgan.dev@gmail.com>
 Raymond Cheng <raycheng100@gmail.com>
+Blue Billywig <*@bluebillywig.com>

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## [3.3.11](https://github.com/shaka-project/shaka-player/compare/v3.3.10...v3.3.11) (2022-10-07)
+
+
+### Bug Fixes
+
+* allow build without text ([#4506](https://github.com/shaka-project/shaka-player/issues/4506)) ([5014c1d](https://github.com/shaka-project/shaka-player/commit/5014c1d50d2b612bf741f2736cf5f86522f4285b))
+* allow the playback on platforms when low latency APIs are not supported ([#4485](https://github.com/shaka-project/shaka-player/issues/4485)) ([c0fc0b4](https://github.com/shaka-project/shaka-player/commit/c0fc0b4dcaa8d3d6db2782a987e74ebe9064ea53))
+* check for negative rows before moving ([#4510](https://github.com/shaka-project/shaka-player/issues/4510)) ([359b63e](https://github.com/shaka-project/shaka-player/commit/359b63e5c9665a1884daf95aa1cba7c8470ed7bb)), closes [#4508](https://github.com/shaka-project/shaka-player/issues/4508)
+* Filter unsupported H.264 streams in Xbox ([#4493](https://github.com/shaka-project/shaka-player/issues/4493)) ([21ee94f](https://github.com/shaka-project/shaka-player/commit/21ee94fce4daa624561989600f47170c468bf962))
+* Fix hang when seeking to the last segment ([#4537](https://github.com/shaka-project/shaka-player/issues/4537)) ([2868e12](https://github.com/shaka-project/shaka-player/commit/2868e122eb5bc2db57ca96c429ad8178f7f5e3f4))
+* Respect existing app usage of Cast SDK ([#4523](https://github.com/shaka-project/shaka-player/issues/4523)) ([d2258d6](https://github.com/shaka-project/shaka-player/commit/d2258d60fab218738bfa6f80b675e65b9a7994dc)), closes [#4521](https://github.com/shaka-project/shaka-player/issues/4521)
+* **ttml:** Default TTML background color to transparent if unspecified ([#4496](https://github.com/shaka-project/shaka-player/issues/4496)) ([862ee42](https://github.com/shaka-project/shaka-player/commit/862ee42f770b6fbd19e33fd04e98882d203caf4b)), closes [#4468](https://github.com/shaka-project/shaka-player/issues/4468)
+
 ## [3.3.10](https://github.com/shaka-project/shaka-player/compare/v3.3.9...v3.3.10) (2022-08-31)
 
 

package/CONTRIBUTORS

@@ -102,6 +102,7 @@ Sander Saares <sander@saares.eu>
 Sandra Lokshina <ismena@google.com>
 Satheesh Velmurugan <satheesh@philo.com>
 Semih Gokceoglu <semih.gkcoglu@gmail.com>
+Seongryun Jo <ocipap0531@gmail.com>
 Seth Madison <seth@philo.com>
 Tatsiana Gelahova <tatsiana.gelahova@gmail.com>
 Theodore Abshire <theodab@google.com>
@@ -119,3 +120,4 @@ Vincent Valot <valot.vince@gmail.com>
 Wayne Morgan <wayne.morgan.dev@gmail.com>
 Yohann Connell <robinconnell@google.com>
 Raymond Cheng <raycheng100@gmail.com>
+Janroel Koppen <j.koppen@bluebillywig.com>

package/dist/locales.js

@@ -720,44 +720,44 @@ shaka.ui.Locales.addTo = function(localization) {
  * @const
  */
 shaka.ui.Locales.Ids = {
+  LANGUAGE: 'LANGUAGE',
+  MULTIPLE_LANGUAGES: 'MULTIPLE_LANGUAGES',
   PLAYBACK_RATE: 'PLAYBACK_RATE',
-  CAPTIONS: 'CAPTIONS',
-  FULL_SCREEN: 'FULL_SCREEN',
-  UNDETERMINED_LANGUAGE: 'UNDETERMINED_LANGUAGE',
-  CAST: 'CAST',
-  OFF: 'OFF',
-  EXIT_FULL_SCREEN: 'EXIT_FULL_SCREEN',
   FAST_FORWARD: 'FAST_FORWARD',
-  AD_TIME: 'AD_TIME',
-  PLAY: 'PLAY',
-  EXIT_LOOP_MODE: 'EXIT_LOOP_MODE',
-  ENTER_PICTURE_IN_PICTURE: 'ENTER_PICTURE_IN_PICTURE',
+  AUTO_QUALITY: 'AUTO_QUALITY',
+  UNDETERMINED_LANGUAGE: 'UNDETERMINED_LANGUAGE',
   STATISTICS: 'STATISTICS',
-  SKIP_AD: 'SKIP_AD',
-  UNMUTE: 'UNMUTE',
-  SEEK: 'SEEK',
+  LIVE: 'LIVE',
+  PLAY: 'PLAY',
+  LOOP: 'LOOP',
+  ENTER_LOOP_MODE: 'ENTER_LOOP_MODE',
+  OFF: 'OFF',
+  REWIND: 'REWIND',
   AD_PROGRESS: 'AD_PROGRESS',
   UNRECOGNIZED_LANGUAGE: 'UNRECOGNIZED_LANGUAGE',
-  RESOLUTION: 'RESOLUTION',
   MORE_SETTINGS: 'MORE_SETTINGS',
   PAUSE: 'PAUSE',
-  AUTO_QUALITY: 'AUTO_QUALITY',
-  MULTIPLE_LANGUAGES: 'MULTIPLE_LANGUAGES',
-  NOT_APPLICABLE: 'NOT_APPLICABLE',
-  REWIND: 'REWIND',
+  SKIP_TO_LIVE: 'SKIP_TO_LIVE',
+  RESOLUTION: 'RESOLUTION',
+  FULL_SCREEN: 'FULL_SCREEN',
   VOLUME: 'VOLUME',
+  NOT_APPLICABLE: 'NOT_APPLICABLE',
+  ON: 'ON',
+  SEEK: 'SEEK',
   AIRPLAY: 'AIRPLAY',
-  SUBTITLE_FORCED: 'SUBTITLE_FORCED',
+  ENTER_PICTURE_IN_PICTURE: 'ENTER_PICTURE_IN_PICTURE',
+  MUTE: 'MUTE',
   EXIT_PICTURE_IN_PICTURE: 'EXIT_PICTURE_IN_PICTURE',
-  SKIP_TO_LIVE: 'SKIP_TO_LIVE',
-  AD_DURATION: 'AD_DURATION',
-  LOOP: 'LOOP',
+  CAPTIONS: 'CAPTIONS',
   PICTURE_IN_PICTURE: 'PICTURE_IN_PICTURE',
-  ON: 'ON',
-  LANGUAGE: 'LANGUAGE',
-  MUTE: 'MUTE',
+  EXIT_FULL_SCREEN: 'EXIT_FULL_SCREEN',
+  CAST: 'CAST',
+  UNMUTE: 'UNMUTE',
+  SKIP_AD: 'SKIP_AD',
+  AD_DURATION: 'AD_DURATION',
+  SUBTITLE_FORCED: 'SUBTITLE_FORCED',
   REPLAY: 'REPLAY',
-  LIVE: 'LIVE',
-  ENTER_LOOP_MODE: 'ENTER_LOOP_MODE',
+  EXIT_LOOP_MODE: 'EXIT_LOOP_MODE',
+  AD_TIME: 'AD_TIME',
   BACK: 'BACK',
 };