shaka-player 3.2.4 → 3.2.7

package/lib/text/ttml_text_parser.js

@@ -536,8 +536,10 @@ shaka.text.TtmlTextParser = class {
 
       cue.textAlign = Cue.textAlign[align.toUpperCase()];
     } else {
-      // Default value is START: https://bit.ly/32OGmvo
-      cue.textAlign = Cue.textAlign.START;
+      // Default value is START in the TTML spec: https://bit.ly/32OGmvo
+      // But to make the subtitle render consitent with other players and the
+      // shaka.text.Cue we use CENTER
+      cue.textAlign = Cue.textAlign.CENTER;
     }
 
     const displayAlign = TtmlTextParser.getStyleAttribute_(
@@ -559,7 +561,7 @@ shaka.text.TtmlTextParser = class {
     // Background color should not be set on a container.  If this is a nested
     // cue, you can set the background.  If it's a top-level that happens to
     // also be a leaf, you can set the background.
-    // See https://github.com/google/shaka-player/issues/2623
+    // See https://github.com/shaka-project/shaka-player/issues/2623
     // This used to be handled in the displayer, but that is confusing.  The Cue
     // structure should reflect what you want to happen in the displayer, and
     // the displayer shouldn't have to know about TTML.
@@ -919,8 +921,9 @@ shaka.text.TtmlTextParser = class {
     let ret = null;
     const XmlUtils = shaka.util.XmlUtils;
     while (element) {
-      ret = nsName ? XmlUtils.getAttributeNS(element, nsName, attributeName)
-                   : element.getAttribute(attributeName);
+      ret = nsName ?
+          XmlUtils.getAttributeNS(element, nsName, attributeName) :
+          element.getAttribute(attributeName);
       if (ret) {
         break;
       }

package/lib/text/ui_text_displayer.js

@@ -108,7 +108,7 @@ shaka.text.UITextDisplayer = class {
   append(cues) {
     // Clone the cues list for performace optimization. We can avoid the cues
     // list growing during the comparisons for duplicate cues.
-    // See: https://github.com/google/shaka-player/issues/3018
+    // See: https://github.com/shaka-project/shaka-player/issues/3018
     const cuesList = [...this.cues_];
     for (const cue of cues) {
       // When a VTT cue spans a segment boundary, the cue will be duplicated

package/lib/util/buffer_utils.js

@@ -6,8 +6,6 @@
 
 goog.provide('shaka.util.BufferUtils');
 
-goog.require('shaka.util.Iterables');
-
 
 /**
  * @summary A set of BufferSource utility functions.
@@ -45,7 +43,7 @@ shaka.util.BufferUtils = class {
 
     const uint8A = shaka.util.BufferUtils.toUint8(arr1);
     const uint8B = shaka.util.BufferUtils.toUint8(arr2);
-    for (const i of shaka.util.Iterables.range(arr1.byteLength)) {
+    for (let i = 0; i < arr1.byteLength; i++) {
       if (uint8A[i] != uint8B[i]) {
         return false;
       }

package/lib/util/config_utils.js

@@ -127,4 +127,29 @@ shaka.util.ConfigUtils = class {
     last[fieldName.substring(nameStart).replace(/\\\./g, '.')] = value;
     return configObject;
   }
+
+  /**
+   * Reference the input parameters so the compiler doesn't remove them from
+   * the calling function.  Return whatever value is specified.
+   *
+   * This allows an empty or default implementation of a config callback that
+   * still bears the complete function signature even in compiled mode.
+   *
+   * The caller should look something like this:
+   *
+   *   const callback = (a, b, c, d) => {
+   *     return referenceParametersAndReturn(
+             [a, b, c, d],
+             a);  // Can be anything, doesn't need to be one of the parameters
+   *   };
+   *
+   * @param {!Array.<?>} parameters
+   * @param {T} returnValue
+   * @return {T}
+   * @template T
+   * @noinline
+   */
+  static referenceParametersAndReturn(parameters, returnValue) {
+    return parameters && returnValue;
+  }
 };

package/lib/util/ebml_parser.js

@@ -11,7 +11,6 @@ goog.require('goog.asserts');
 goog.require('shaka.util.BufferUtils');
 goog.require('shaka.util.DataViewReader');
 goog.require('shaka.util.Error');
-goog.require('shaka.util.Iterables');
 
 
 /**
@@ -157,7 +156,8 @@ shaka.util.EbmlParser = class {
     }
 
     let value = 0;
-    for (const {item, i} of shaka.util.Iterables.enumerate(vint)) {
+    for (let i = 0; i < vint.length; i++) {
+      const item = vint[i];
       if (i == 0) {
         // Mask out the first few bits of |vint|'s first byte to get the most
         // significant bits of |vint|'s value. If |vint| is 8 bytes wide then
@@ -267,7 +267,7 @@ shaka.util.EbmlElement = class {
 
     let value = 0;
 
-    for (const i of shaka.util.Iterables.range(this.dataView_.byteLength)) {
+    for (let i = 0; i < this.dataView_.byteLength; i++) {
       const chunk = this.dataView_.getUint8(i);
       value = (256 * value) + chunk;
     }

package/lib/util/error.js

@@ -345,6 +345,13 @@ shaka.util.Error.Code = {
    */
   'MISSING_TEXT_PLUGIN': 2014,
 
+  /**
+   * The chapters track failed to load.  The browser does not provide any
+   * information in this case to identify why it failed, but there may be
+   * details in the JavaScript console.
+   */
+  'CHAPTERS_TRACK_FAILED': 2015,
+
   /**
    * Some component tried to read past the end of a buffer.  The segment index,
    * init segment, or PSSH may be malformed.
@@ -467,7 +474,7 @@ shaka.util.Error.Code = {
    * Content transformations required by the platform could not be performed for
    * some reason (unsupported container, etc.)
    *
-   * @see https://github.com/google/shaka-player/issues/2759
+   * @see https://github.com/shaka-project/shaka-player/issues/2759
    */
   'CONTENT_TRANSFORMATION_FAILED': 3019,
 

package/lib/util/iterables.js

@@ -75,50 +75,4 @@ shaka.util.Iterables = class {
     }
     return out;
   }
-
-  /**
-   * Returns an iterable that contains numbers in the range [0, end).
-   *
-   * @param {number} end The exclusive end of the list.
-   * @return {!Iterable.<number>}
-   */
-  static* range(end) {
-    for (let i = 0; i < end; i++) {
-      yield i;
-    }
-  }
-
-  /**
-   * Iterates over an iterable object and includes additional info about each
-   * item:
-   * - The zero-based index of the element.
-   * - The next item in the list, if it exists.
-   * - The previous item in the list, if it exists.
-   *
-   * @param {!Iterable.<T>} iterable
-   * @return {!Iterable.<
-   *     {i: number, item: T, prev: (T|undefined), next: (T|undefined)}>}
-   * @template T
-   */
-  static* enumerate(iterable) {
-    // Since we want the "next" item, we need to skip the first item and return
-    // elements one in the past.  So as we iterate, we are getting the "next"
-    // element and yielding the one from the previous iteration.
-    let i = -1;
-    let prev = undefined;
-    let item = undefined;
-    for (const next of iterable) {
-      if (i >= 0) {
-        yield {i, item, prev, next};
-      }
-      i++;
-      prev = item;
-      item = next;
-    }
-    if (i != -1) {
-      // If it's still -1, there were no items.  Otherwise we need to yield
-      // the last item.
-      yield {i, prev, item, next: undefined};
-    }
-  }
 };

package/lib/util/manifest_parser_utils.js

@@ -167,7 +167,7 @@ shaka.util.ManifestParserUtils.VIDEO_CODEC_REGEXPS_ = [
   /^hev/,
   /^hvc/,
   /^vp0?[89]/,
-  /^av1$/,
+  /^av01/,
 ];
 
 

package/lib/util/mime_utils.js

@@ -94,6 +94,53 @@ shaka.util.MimeUtils = class {
     return codecs.split(',');
   }
 
+  /**
+   * Get the normalized codec from a codec string,
+   * independently of their container.
+   *
+   * @param {string} codecString
+   * @return {string}
+   */
+  static getNormalizedCodec(codecString) {
+    const parts =
+      shaka.util.MimeUtils.getCodecParts_(codecString);
+    const base = parts[0];
+    const profile = parts[1].toLowerCase();
+    switch (true) {
+      case base === 'mp4a' && profile === '69':
+      case base === 'mp4a' && profile === '6b':
+        return 'mp3';
+      case base === 'mp4a' && profile === '66':
+      case base === 'mp4a' && profile === '67':
+      case base === 'mp4a' && profile === '68':
+      case base === 'mp4a' && profile === '40.2':
+      case base === 'mp4a' && profile === '40.02':
+      case base === 'mp4a' && profile === '40.5':
+      case base === 'mp4a' && profile === '40.05':
+      case base === 'mp4a' && profile === '40.29':
+      case base === 'mp4a' && profile === '40.42': // Extended HE-AAC
+        return 'aac';
+      case base === 'mp4a' && profile === 'a5':
+        return 'ac-3'; // Dolby Digital
+      case base === 'mp4a' && profile === 'a6':
+        return 'ec-3'; // Dolby Digital Plus
+      case base === 'mp4a' && profile === 'b2':
+        return 'dtsx'; // DTS:X
+      case base === 'mp4a' && profile === 'a9':
+        return 'dtsc'; // DTS Digital Surround
+      case base === 'avc1':
+      case base === 'avc3':
+        return 'avc'; // H264
+      case base === 'hvc1':
+      case base === 'hev1':
+        return 'hevc'; // H265
+      case base === 'dvh1':
+      case base === 'dvhe':
+        return 'dovi'; // Dolby Vision
+    }
+    return base;
+  }
+
   /**
    * Get the base codec from a codec string.
    *
@@ -150,7 +197,7 @@ shaka.util.MimeUtils = class {
 
     const base = parts[0];
 
-    parts.pop();
+    parts.shift();
     const profile = parts.join('.');
 
     // Make sure that we always return a "base" and "profile".

package/lib/util/mp4_box_parsers.js

@@ -7,8 +7,6 @@
 goog.provide('shaka.util.Mp4BoxParsers');
 
 goog.require('shaka.util.DataViewReader');
-goog.require('shaka.util.Functional');
-goog.require('shaka.util.Iterables');
 
 shaka.util.Mp4BoxParsers = class {
   /**
@@ -125,8 +123,7 @@ shaka.util.Mp4BoxParsers = class {
       reader.skip(4);
     }
 
-    for (const _ of shaka.util.Iterables.range(sampleCount)) {
-      shaka.util.Functional.ignored(_);
+    for (let i = 0; i < sampleCount; i++) {
       /** @type {shaka.util.ParsedTRUNSample} */
       const sample = {
         sampleDuration: null,

package/lib/util/mp4_parser.js

@@ -9,8 +9,6 @@ goog.provide('shaka.util.Mp4Parser');
 goog.require('goog.asserts');
 goog.require('shaka.log');
 goog.require('shaka.util.DataViewReader');
-goog.require('shaka.util.Functional');
-goog.require('shaka.util.Iterables');
 
 
 /**
@@ -229,8 +227,7 @@ shaka.util.Mp4Parser = class {
     // start position.  The header size varies.
     const headerSize = shaka.util.Mp4Parser.headerSize(box);
     const count = box.reader.readUint32();
-    for (const _ of shaka.util.Iterables.range(count)) {
-      shaka.util.Functional.ignored(_);
+    for (let i = 0; i < count; i++) {
       box.parser.parseNext(box.start + headerSize, box.reader, box.partialOkay);
       if (box.parser.done_) {
         break;
@@ -302,9 +299,10 @@ shaka.util.Mp4Parser = class {
    * @export
    */
   static headerSize(box) {
-    return /* basic header */ 8
-        + /* additional 64-bit size field */ (box.has64BitSize ? 8 : 0)
-        + /* version and flags for a "full" box */ (box.flags != null ? 4 : 0);
+    const basicHeaderSize = 8;
+    const _64BitFieldSize = box.has64BitSize ? 8 : 0;
+    const versionAndFlagsSize = box.flags != null ? 4 : 0;
+    return basicHeaderSize + _64BitFieldSize + versionAndFlagsSize;
   }
 };
 

package/lib/util/periods.js

@@ -14,7 +14,6 @@ goog.require('shaka.media.SegmentIndex');
 goog.require('shaka.util.ArrayUtils');
 goog.require('shaka.util.Error');
 goog.require('shaka.util.IReleasable');
-goog.require('shaka.util.Iterables');
 goog.require('shaka.util.LanguageUtils');
 goog.require('shaka.util.ManifestParserUtils');
 goog.require('shaka.util.MapUtils');
@@ -98,7 +97,6 @@ shaka.util.PeriodCombiner = class {
    */
   async combinePeriods(periods, isDynamic) {
     const ContentType = shaka.util.ManifestParserUtils.ContentType;
-    const Iterables = shaka.util.Iterables;
 
     shaka.util.PeriodCombiner.filterOutAudioStreamDuplicates_(periods);
     shaka.util.PeriodCombiner.filterOutVideoStreamDuplicates_(periods);
@@ -118,7 +116,8 @@ shaka.util.PeriodCombiner = class {
       // Find the first period we haven't seen before.  Tag all the periods we
       // see now as "used".
       let firstNewPeriodIndex = -1;
-      for (const {i, item: period} of Iterables.enumerate(periods)) {
+      for (let i = 0; i < periods.length; i++) {
+        const period = periods[i];
         if (this.usedPeriodIds_.has(period.id)) {
           // This isn't new.
         } else {
@@ -301,6 +300,7 @@ shaka.util.PeriodCombiner = class {
             t1.label == t2.label &&
             t1.codecs == t2.codecs &&
             t1.mimeType == t2.mimeType &&
+            t1.bandwidth == t2.bandwidth &&
             ArrayUtils.hasSameElements(t1.roles, t2.roles)) {
             duplicate = true;
           }
@@ -510,13 +510,12 @@ shaka.util.PeriodCombiner = class {
   static async combine_(
       outputStreams, streamsPerPeriod, firstNewPeriodIndex, clone, concat) {
     const ContentType = shaka.util.ManifestParserUtils.ContentType;
-    const Iterables = shaka.util.Iterables;
 
     const unusedStreamsPerPeriod = [];
-    for (const {i, item: streams} of Iterables.enumerate(streamsPerPeriod)) {
+    for (let i = 0; i < streamsPerPeriod.length; i++) {
       if (i >= firstNewPeriodIndex) {
         // This periods streams are all new.
-        unusedStreamsPerPeriod.push(new Set(streams));
+        unusedStreamsPerPeriod.push(new Set(streamsPerPeriod[i]));
       } else {
         // This period's streams have all been used already.
         unusedStreamsPerPeriod.push(new Set());
@@ -575,8 +574,8 @@ shaka.util.PeriodCombiner = class {
         // TODO(#1528): Consider changing this when we support codec switching.
         const hasCodec = outputStreams.some((s) => {
           return s.mimeType == stream.mimeType &&
-                shaka.util.MimeUtils.getCodecBase(s.codecs) ==
-                    shaka.util.MimeUtils.getCodecBase(stream.codecs);
+                shaka.util.MimeUtils.getNormalizedCodec(s.codecs) ==
+                    shaka.util.MimeUtils.getNormalizedCodec(stream.codecs);
         });
         if (!hasCodec) {
           continue;
@@ -747,9 +746,9 @@ shaka.util.PeriodCombiner = class {
 
     // Concatenate the new matches onto the stream, starting at the first new
     // period.
-    const Iterables = shaka.util.Iterables;
-    for (const {i, item: match} of Iterables.enumerate(matches)) {
+    for (let i = 0; i < matches.length; i++) {
       if (i >= firstNewPeriodIndex) {
+        const match = matches[i];
         concat(outputStream, match);
 
         // We only consider an audio stream "used" if its language is related to
@@ -1017,10 +1016,11 @@ shaka.util.PeriodCombiner = class {
    * @private
    */
   static areAVStreamsCompatible_(outputStream, candidate) {
-    const getCodecBase = (codecs) => shaka.util.MimeUtils.getCodecBase(codecs);
+    const getCodec = (codecs) =>
+      shaka.util.MimeUtils.getNormalizedCodec(codecs);
     // Check MIME type and codecs, which should always be the same.
     if (candidate.mimeType != outputStream.mimeType ||
-        getCodecBase(candidate.codecs) != getCodecBase(outputStream.codecs)) {
+        getCodec(candidate.codecs) != getCodec(outputStream.codecs)) {
       return false;
     }
 
@@ -1176,7 +1176,7 @@ shaka.util.PeriodCombiner = class {
         // [r1, r2, r3, r4].
         // If we match stream1 with stream3 due to the same role overlap,
         // stream2 is likely to be left unmatched and error out later.
-        // See https://github.com/google/shaka-player/issues/2542 for
+        // See https://github.com/shaka-project/shaka-player/issues/2542 for
         // more details.
         return candidate.roles.length < best.roles.length;
       }

package/lib/util/platform.js

@@ -174,8 +174,8 @@ shaka.util.Platform = class {
    * @return {boolean}
    */
   static isApple() {
-    return !!navigator.vendor && navigator.vendor.includes('Apple')
-            && !shaka.util.Platform.isTizen();
+    return !!navigator.vendor && navigator.vendor.includes('Apple') &&
+        !shaka.util.Platform.isTizen();
   }
 
   /**
@@ -312,7 +312,7 @@ shaka.util.Platform = class {
    * initialization segments.
    *
    * @return {boolean}
-   * @see https://github.com/google/shaka-player/issues/2759
+   * @see https://github.com/shaka-project/shaka-player/issues/2759
    */
   static requiresEncryptionInfoInAllInitSegments() {
     const Platform = shaka.util.Platform;

package/lib/util/player_configuration.js

@@ -17,14 +17,6 @@ goog.require('shaka.util.ManifestParserUtils');
 goog.require('shaka.util.Platform');
 
 
-// TODO(vaage): Many times in our configs, we need to create an empty
-//  implementation of a method, but to avoid closure from removing unused
-//  parameters (and breaking our merge config code) we need to use each
-//  parameter. Is there a better solution to this problem than what we are
-//  doing now?
-//
-//  NOTE: Chrome App Content Security Policy prohibits usage of new Function()
-
 /**
  * @final
  * @export
@@ -109,11 +101,10 @@ shaka.util.PlayerConfiguration = class {
           'urn:uuid:f239e769-efa3-4850-9c16-a903c6932efb':
             'com.adobe.primetime',
         },
-        // Need some operation in the callback or else closure may remove calls
-        // to the function as it would be a no-op.  The operation can't just be
-        // a log message, because those are stripped in the compiled build.
         manifestPreprocessor: (element) => {
-          return element;
+          return shaka.util.ConfigUtils.referenceParametersAndReturn(
+              [element],
+              element);
         },
       },
       hls: {
@@ -130,7 +121,9 @@ shaka.util.PlayerConfiguration = class {
       // log message, because those are stripped in the compiled build.
       failureCallback: (error) => {
         shaka.log.error('Unhandled streaming error', error);
-        return [error];
+        return shaka.util.ConfigUtils.referenceParametersAndReturn(
+            [error],
+            undefined);
       },
       // When low latency streaming is enabled, rebufferingGoal will default to
       // 0.01 if not specified.
@@ -206,7 +199,9 @@ shaka.util.PlayerConfiguration = class {
       // to the function as it would be a no-op.  The operation can't just be a
       // log message, because those are stripped in the compiled build.
       progressCallback: (content, progress) => {
-        return [content, progress];
+        return shaka.util.ConfigUtils.referenceParametersAndReturn(
+            [content, progress],
+            undefined);
       },
 
       // By default we use persistent licenses as forces errors to surface if

package/lib/util/pssh.js

@@ -9,8 +9,6 @@ goog.provide('shaka.util.Pssh');
 goog.require('goog.asserts');
 goog.require('shaka.log');
 goog.require('shaka.util.BufferUtils');
-goog.require('shaka.util.Functional');
-goog.require('shaka.util.Iterables');
 goog.require('shaka.util.Mp4Parser');
 goog.require('shaka.util.Uint8ArrayUtils');
 
@@ -83,8 +81,7 @@ shaka.util.Pssh = class {
         shaka.util.Uint8ArrayUtils.toHex(box.reader.readBytes(16)));
     if (box.version > 0) {
       const numKeyIds = box.reader.readUint32();
-      for (const _ of shaka.util.Iterables.range(numKeyIds)) {
-        shaka.util.Functional.ignored(_);
+      for (let i = 0; i < numKeyIds; i++) {
         const keyId =
             shaka.util.Uint8ArrayUtils.toHex(box.reader.readBytes(16));
         this.cencKeyIds.push(keyId);

package/lib/util/stream_utils.js

@@ -283,12 +283,14 @@ shaka.util.StreamUtils = class {
     // both be considered the same codec: avc1.42c01e, avc1.4d401f
     let baseVideoCodec = '';
     if (variant.video) {
-      baseVideoCodec = shaka.util.MimeUtils.getCodecBase(variant.video.codecs);
+      baseVideoCodec =
+        shaka.util.MimeUtils.getNormalizedCodec(variant.video.codecs);
     }
 
     let baseAudioCodec = '';
     if (variant.audio) {
-      baseAudioCodec = shaka.util.MimeUtils.getCodecBase(variant.audio.codecs);
+      baseAudioCodec =
+        shaka.util.MimeUtils.getNormalizedCodec(variant.audio.codecs);
     }
 
     return baseVideoCodec + '-' + baseAudioCodec;
@@ -425,7 +427,7 @@ shaka.util.StreamUtils = class {
     await shaka.util.StreamUtils.getDecodingInfosForVariants(
         manifest.variants, usePersistentLicenses, /* srcEquals= */ false);
     manifest.variants = manifest.variants.filter((variant) => {
-      // See: https://github.com/google/shaka-player/issues/3860
+      // See: https://github.com/shaka-project/shaka-player/issues/3860
       const video = variant.video;
       const ContentType = shaka.util.ManifestParserUtils.ContentType;
       if (video) {
@@ -461,7 +463,7 @@ shaka.util.StreamUtils = class {
         }
       }
 
-      // See: https://github.com/google/shaka-player/issues/3380
+      // See: https://github.com/shaka-project/shaka-player/issues/3380
       if (shaka.util.Platform.isXboxOne() && video &&
           ((video.width && video.width > 1920) ||
           (video.height && video.height > 1080)) &&
@@ -720,7 +722,8 @@ shaka.util.StreamUtils = class {
   static getCorrectAudioCodecs_(codecs) {
     // Some Tizen devices seem to misreport AC-3 support, but correctly
     // report EC-3 support.  So query EC-3 as a fallback for AC-3.
-    // See https://github.com/google/shaka-player/issues/2989 for details.
+    // See https://github.com/shaka-project/shaka-player/issues/2989 for
+    // details.
     if (shaka.util.Platform.isTizen()) {
       return codecs.toLowerCase() == 'ac-3' ? 'ec-3' : codecs;
     } else {

package/lib/util/string_utils.js

@@ -10,7 +10,6 @@ goog.require('goog.asserts');
 goog.require('shaka.log');
 goog.require('shaka.util.BufferUtils');
 goog.require('shaka.util.Error');
-goog.require('shaka.util.Iterables');
 goog.require('shaka.util.Lazy');
 
 
@@ -81,7 +80,7 @@ shaka.util.StringUtils = class {
     const length = Math.floor(data.byteLength / 2);
     const arr = new Uint16Array(length);
     const dataView = shaka.util.BufferUtils.toDataView(data);
-    for (const i of shaka.util.Iterables.range(length)) {
+    for (let i = 0; i < length; i++) {
       arr[i] = dataView.getUint16(i * 2, littleEndian);
     }
     return shaka.util.StringUtils.fromCharCode(arr);
@@ -158,9 +157,8 @@ shaka.util.StringUtils = class {
   static toUTF16(str, littleEndian) {
     const result = new ArrayBuffer(str.length * 2);
     const view = new DataView(result);
-    const enumerate = (it) => shaka.util.Iterables.enumerate(it);
-    for (const {i, item} of enumerate(str)) {
-      const value = item.charCodeAt(0);
+    for (let i = 0; i < str.length; ++i) {
+      const value = str.charCodeAt(i);
       view.setUint16(/* position= */ i * 2, value, littleEndian);
     }
     return result;

package/lib/util/uint8array_utils.js

@@ -8,7 +8,6 @@ goog.provide('shaka.util.Uint8ArrayUtils');
 
 goog.require('shaka.Deprecate');
 goog.require('shaka.util.BufferUtils');
-goog.require('shaka.util.Iterables');
 goog.require('shaka.util.StringUtils');
 
 
@@ -74,9 +73,8 @@ shaka.util.Uint8ArrayUtils = class {
     // byte.
     const bytes = window.atob(str.replace(/-/g, '+').replace(/_/g, '/'));
     const result = new Uint8Array(bytes.length);
-    const enumerate = (it) => shaka.util.Iterables.enumerate(it);
-    for (const {i, item} of enumerate(bytes)) {
-      result[i] = item.charCodeAt(0);
+    for (let i = 0; i < bytes.length; ++i) {
+      result[i] = bytes.charCodeAt(i);
     }
     return result;
   }
@@ -91,7 +89,7 @@ shaka.util.Uint8ArrayUtils = class {
   static fromHex(str) {
     const size = str.length / 2;
     const arr = new Uint8Array(size);
-    for (const i of shaka.util.Iterables.range(size)) {
+    for (let i = 0; i < size; i++) {
       arr[i] = window.parseInt(str.substr(i * 2, 2), 16);
     }
     return arr;

package/lib/util/xml_utils.js

@@ -57,9 +57,13 @@ shaka.util.XmlUtils = class {
    * @return {!Array.<!Element>} The child XML elements.
    */
   static findChildren(elem, name) {
-    return Array.from(elem.childNodes).filter((child) => {
-      return child instanceof Element && child.tagName == name;
-    });
+    const found = [];
+    for (const child of elem.childNodes) {
+      if (child instanceof Element && child.tagName == name) {
+        found.push(child);
+      }
+    }
+    return found;
   }
 
 
@@ -82,10 +86,14 @@ shaka.util.XmlUtils = class {
    * @return {!Array.<!Element>} The child XML elements.
    */
   static findChildrenNS(elem, ns, name) {
-    return Array.from(elem.childNodes).filter((child) => {
-      return child instanceof Element && child.localName == name &&
-          child.namespaceURI == ns;
-    });
+    const found = [];
+    for (const child of elem.childNodes) {
+      if (child instanceof Element && child.localName == name &&
+          child.namespaceURI == ns) {
+        found.push(child);
+      }
+    }
+    return found;
   }