shaka-player 3.2.1 → 3.2.2

package/lib/text/ui_text_displayer.js

@@ -167,9 +167,14 @@ shaka.text.UITextDisplayer = class {
     }
 
     // Remove the cues out of the time range.
+    const oldNumCues = this.cues_.length;
     this.cues_ = this.cues_.filter(
         (cue) => cue.startTime < start || cue.endTime >= end);
-    this.updateCaptions_();
+    // If anything was actually removed in this process, force the captions to
+    // update. This makes sure that the currently-displayed cues will stop
+    // displaying if removed (say, due to the user changing languages).
+    const forceUpdate = oldNumCues > this.cues_.length;
+    this.updateCaptions_(forceUpdate);
 
     return true;
   }
@@ -192,13 +197,13 @@ shaka.text.UITextDisplayer = class {
   }
 
   /**
-   * @param {!Array.<!shaka.text.Cue>} cues
+   * @param {!Array.<!shaka.extern.Cue>} cues
    * @param {!HTMLElement} container
    * @param {number} currentTime
-   * @param {boolean} isNested
+   * @param {!Array.<!shaka.extern.Cue>} parents
    * @private
    */
-  updateCuesRecursive_(cues, container, currentTime, isNested) {
+  updateCuesRecursive_(cues, container, currentTime, parents) {
     // Set to true if the cues have changed in some way, which will require
     // DOM changes. E.g. if a cue was added or removed.
     let updateDOM = false;
@@ -214,10 +219,12 @@ shaka.text.UITextDisplayer = class {
      * The cues whose corresponding elements should be in the DOM.
      * Some of these might be new, some might have been displayed beforehand.
      * These will only be added if updateDOM is true.
-     * @type {!Array.<!shaka.text.Cue>}
+     * @type {!Array.<!shaka.extern.Cue>}
      */
     const toPlant = [];
     for (const cue of cues) {
+      parents.push(cue);
+
       let cueRegistry = this.currentCuesMap_.get(cue);
       const shouldBeDisplayed =
           cue.startTime <= currentTime && cue.endTime > currentTime;
@@ -241,7 +248,7 @@ shaka.text.UITextDisplayer = class {
         toPlant.push(cue);
         if (!cueRegistry) {
           // The cue has to be made!
-          this.createCue_(cue, isNested);
+          this.createCue_(cue, parents);
           cueRegistry = this.currentCuesMap_.get(cue);
           wrapper = cueRegistry.wrapper;
           updateDOM = true;
@@ -255,8 +262,11 @@ shaka.text.UITextDisplayer = class {
       // guaranteed that the children will neither need to be added nor removed.
       if (cue.nestedCues.length > 0 && wrapper) {
         this.updateCuesRecursive_(
-            cue.nestedCues, wrapper, currentTime, /* isNested= */ true);
+            cue.nestedCues, wrapper, currentTime, parents);
       }
+
+      const topCue = parents.pop();
+      goog.asserts.assert(topCue == cue, 'Parent cues should be kept in order');
     }
     if (updateDOM) {
       for (const cueElement of toUproot) {
@@ -304,7 +314,7 @@ shaka.text.UITextDisplayer = class {
 
       // Update the cues.
       this.updateCuesRecursive_(
-          this.cues_, this.textContainer_, currentTime, false);
+          this.cues_, this.textContainer_, currentTime, /* parents= */ []);
 
       if (goog.DEBUG) {
         // Previously, we had an issue (#2076) where cues sometimes were not
@@ -327,10 +337,11 @@ shaka.text.UITextDisplayer = class {
    * Creates the object for a cue.
    *
    * @param {!shaka.extern.Cue} cue
-   * @param {boolean} isNested
+   * @param {!Array.<!shaka.extern.Cue>} parents
    * @private
    */
-  createCue_(cue, isNested) {
+  createCue_(cue, parents) {
+    const isNested = parents.length > 1;
     let type = isNested ? 'span' : 'div';
     if (cue.lineBreak || cue.spacer) {
       if (cue.spacer) {
@@ -344,7 +355,7 @@ shaka.text.UITextDisplayer = class {
     // Nested cues are inline elements.  Top-level cues are block elements.
     const cueElement = shaka.util.Dom.createHTMLElement(type);
     if (type != 'br') {
-      this.setCaptionStyles_(cueElement, cue, isNested);
+      this.setCaptionStyles_(cueElement, cue, parents);
     }
 
     let wrapper = cueElement;
@@ -363,13 +374,16 @@ shaka.text.UITextDisplayer = class {
   /**
    * @param {!HTMLElement} cueElement
    * @param {!shaka.extern.Cue} cue
-   * @param {boolean} isNested
+   * @param {!Array.<!shaka.extern.Cue>} parents
    * @private
    */
-  setCaptionStyles_(cueElement, cue, isNested) {
+  setCaptionStyles_(cueElement, cue, parents) {
     const Cue = shaka.text.Cue;
-    let style = cueElement.style;
+    const inherit =
+        (cb) => shaka.text.UITextDisplayer.inheritProperty_(parents, cb);
+    const style = cueElement.style;
     const isLeaf = cue.nestedCues.length == 0;
+    const isNested = parents.length > 1;
 
     // TODO: wrapLine is not yet supported.  Lines always wrap.
 
@@ -388,16 +402,6 @@ shaka.text.UITextDisplayer = class {
       const nonBreakingSpace = '\xa0';
       return nonBreakingSpace.repeat(match.length);
     });
-    if (isNested) {
-      cueElement.textContent = text;
-    } else if (text.length) {
-      // If a top-level cue has text, move to a <span> so the background is
-      // styled correctly.
-      const span = shaka.util.Dom.createHTMLElement('span');
-      span.textContent = text;
-      cueElement.appendChild(span);
-      style = span.style;
-    }
 
     style.backgroundColor = cue.backgroundColor;
     style.border = cue.border;
@@ -406,20 +410,40 @@ shaka.text.UITextDisplayer = class {
     style.opacity = cue.opacity;
     style.paddingLeft = shaka.text.UITextDisplayer.convertLengthValue_(
         cue.linePadding, cue, this.videoContainer_);
-    style.paddingRight = shaka.text.UITextDisplayer.convertLengthValue_(
-        cue.linePadding, cue, this.videoContainer_);
+    style.paddingRight =
+        shaka.text.UITextDisplayer.convertLengthValue_(
+            cue.linePadding, cue, this.videoContainer_);
 
     if (cue.backgroundImage) {
       style.backgroundImage = 'url(\'' + cue.backgroundImage + '\')';
       style.backgroundRepeat = 'no-repeat';
       style.backgroundSize = 'contain';
       style.backgroundPosition = 'center';
+    } else {
+      // If we have both text and nested cues, then style everything; otherwise
+      // place the text in its own <span> so the background doesn't fill the
+      // whole region.
+      let elem;
+      if (cue.nestedCues.length) {
+        elem = cueElement;
+      } else {
+        elem = shaka.util.Dom.createHTMLElement('span');
+        cueElement.appendChild(elem);
+      }
 
-      if (cue.backgroundColor == '') {
-        // In text-based cues, background color can default in CSS.
-        // In bitmap-based cues, we default to a transparent background color,
-        // so that the bitmap can be the only background.
-        style.backgroundColor = 'transparent';
+      if (cue.border) {
+        elem.style.border = cue.border;
+      }
+      const bgColor = inherit((c) => c.backgroundColor);
+      if (bgColor) {
+        elem.style.backgroundColor = bgColor;
+      } else if (text) {
+        // If there is no background, default to a semi-transparent black.
+        // Only do this for the text itself.
+        elem.style.backgroundColor = 'rgba(0, 0, 0, 0.8)';
+      }
+      if (text) {
+        elem.textContent = text;
       }
     }
 
@@ -472,20 +496,28 @@ shaka.text.UITextDisplayer = class {
     // TODO: Implement lineAlignment of 'CENTER'.
     if (cue.line) {
       if (cue.lineInterpretation == Cue.lineInterpretation.PERCENTAGE) {
+        // When setting absolute positioning, you need to set x/y/width/height
+        // so the element is positioned correctly.  Set these as default and
+        // other settings will override them.
         style.position = 'absolute';
+        style.left = '0';
+        style.top = '0';
         if (cue.writingMode == Cue.writingMode.HORIZONTAL_TOP_TO_BOTTOM) {
+          style.width = '100%';
           if (cue.lineAlign == Cue.lineAlign.START) {
             style.top = cue.line + '%';
           } else if (cue.lineAlign == Cue.lineAlign.END) {
             style.bottom = cue.line + '%';
           }
         } else if (cue.writingMode == Cue.writingMode.VERTICAL_LEFT_TO_RIGHT) {
+          style.height = '100%';
           if (cue.lineAlign == Cue.lineAlign.START) {
             style.left = cue.line + '%';
           } else if (cue.lineAlign == Cue.lineAlign.END) {
             style.right = cue.line + '%';
           }
         } else {
+          style.height = '100%';
           if (cue.lineAlign == Cue.lineAlign.START) {
             style.right = cue.line + '%';
           } else if (cue.lineAlign == Cue.lineAlign.END) {
@@ -493,12 +525,7 @@ shaka.text.UITextDisplayer = class {
           }
         }
       }
-    } else if (cue.region && cue.region.id &&
-      ((!isNested && !isLeaf) || (cue.backgroundImage))) {
-      // In text-base cues, regions are only applied to block container
-      // (!isNested && !isLeaf).
-      // In bitmap-based cues, region settings are used to specify the size and
-      // position of the backgroundImage.
+    } else if (cue.region && cue.region.id) {
       const percentageUnit = shaka.text.CueRegion.units.PERCENTAGE;
       const heightUnit = cue.region.heightUnits == percentageUnit ? '%' : 'px';
       const widthUnit = cue.region.widthUnits == percentageUnit ? '%' : 'px';
@@ -631,4 +658,25 @@ shaka.text.UITextDisplayer = class {
 
     return (containerHeight * value / cue.cellResolution.rows) + 'px';
   }
+
+  /**
+   * Inherits a property from the parent Cue elements.  If the value is falsy,
+   * it is assumed to be inherited from the parent. This returns null if the
+   * value isn't found.
+   *
+   * @param {!Array.<!shaka.extern.Cue>} parents
+   * @param {function(!shaka.extern.Cue):?T} cb
+   * @return {?T}
+   * @template T
+   * @private
+   */
+  static inheritProperty_(parents, cb) {
+    for (let i = parents.length - 1; i >= 0; i--) {
+      const val = cb(parents[i]);
+      if (val || val === 0) {
+        return val;
+      }
+    }
+    return null;
+  }
 };

package/lib/util/fake_event.js

@@ -6,6 +6,8 @@
 
 goog.provide('shaka.util.FakeEvent');
 
+goog.require('goog.asserts');
+
 
 /**
  * @summary Create an Event work-alike object based on the provided dictionary.
@@ -16,18 +18,62 @@ goog.provide('shaka.util.FakeEvent');
  */
 shaka.util.FakeEvent = class {
   /**
-   * @param {string} type
-   * @param {Object=} dict
+   * @param {!Event} event
+   * @return {!shaka.util.FakeEvent}
    */
-  constructor(type, dict = {}) {
-    // Take properties from dict if present.
-    for (const key in dict) {
-      Object.defineProperty(this, key, {
-        value: dict[key],
+  static fromRealEvent(event) {
+    const fakeEvent = new shaka.util.FakeEvent(event.type);
+    for (const key in event) {
+      Object.defineProperty(fakeEvent, key, {
+        value: event[key],
         writable: true,
         enumerable: true,
       });
     }
+    return fakeEvent;
+  }
+
+  /**
+   * Allows us to tell the compiler that the dictionary "map" is actually a
+   * generic object, for backwards compatibility.
+   * @param {!Map.<string, Object>} dict
+   * @return {!Object}
+   * @suppress {invalidCasts}
+   * @private
+   */
+  static recastDictAsObject_(dict) {
+    goog.asserts.assert(!(dict instanceof Map), 'dict should not be a map');
+    return /** @type {!Object} */ (dict);
+  }
+
+  /**
+   * @param {string} type
+   * @param {Map.<string, Object>=} dict
+   */
+  constructor(type, dict) {
+    if (dict) {
+      if (dict instanceof Map) {
+        // Take properties from dict if present.
+        for (const key of dict.keys()) {
+          Object.defineProperty(this, key, {
+            value: dict.get(key),
+            writable: true,
+            enumerable: true,
+          });
+        }
+      } else {
+        // For backwards compatibility with external apps that may make use of
+        // this public constructor, this should still accept generic objects.
+        const obj = shaka.util.FakeEvent.recastDictAsObject_(dict);
+        for (const key in obj) {
+          Object.defineProperty(this, key, {
+            value: obj[key],
+            writable: true,
+            enumerable: true,
+          });
+        }
+      }
+    }
 
     // The properties below cannot be set by the dict.  They are all provided
     // for compatibility with native events.

package/lib/util/periods.js

@@ -80,7 +80,10 @@ shaka.util.PeriodCombiner = class {
 
   /** @return {!Array.<shaka.extern.Stream>} */
   getTextStreams() {
-    return this.textStreams_;
+    // Return a copy of the array because makeTextStreamsForClosedCaptions
+    // may make changes to the contents of the array. Those changes should not
+    // propagate back to the PeriodCombiner.
+    return this.textStreams_.slice();
   }
 
   /** @return {!Array.<shaka.extern.Stream>} */

package/lib/util/platform.js

@@ -163,7 +163,6 @@ shaka.util.Platform = class {
            !shaka.util.Platform.isEdge();
   }
 
-
   /**
    * Check if the current platform is from Apple.
    *
@@ -179,6 +178,19 @@ shaka.util.Platform = class {
             && !shaka.util.Platform.isTizen();
   }
 
+  /**
+   * Check if the current platform is Playstation 5.
+   *
+   * Returns true on Playstation 5 browsers.
+   *
+   * Returns false for Playstation 5 browsers
+   *
+   * @return {boolean}
+   */
+  static isPS5() {
+    return shaka.util.Platform.userAgentContains_('PlayStation 5');
+  }
+
   /**
    * Returns a major version number for Safari, or Safari-based iOS browsers.
    *

package/lib/util/stream_utils.js

@@ -547,6 +547,19 @@ shaka.util.StreamUtils = class {
         // framerate must be greater than 0, otherwise the config is invalid.
         framerate: video.frameRate || 1,
       };
+      if (video.hdr) {
+        switch (video.hdr) {
+          case 'SDR':
+            mediaDecodingConfig.video.transferFunction = 'srgb';
+            break;
+          case 'PQ':
+            mediaDecodingConfig.video.transferFunction = 'pq';
+            break;
+          case 'HLG':
+            mediaDecodingConfig.video.transferFunction = 'hlg';
+            break;
+        }
+      }
     }
     if (audio) {
       // Some Tizen devices seem to misreport AC-3 support, but correctly

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "shaka-player",
   "description": "DASH/EME video player library",
-  "version": "3.2.1",
+  "version": "3.2.2",
   "homepage": "https://github.com/google/shaka-player",
   "author": "Google",
   "maintainers": [

package/test/cast/cast_proxy_unit.js

@@ -297,7 +297,8 @@ describe('CastProxy', () => {
             'timeupdate', Util.spyFunc(proxyListener));
 
         expect(proxyListener).not.toHaveBeenCalled();
-        const fakeEvent = new FakeEvent('timeupdate', {detail: 8675309});
+        const fakeEvent = new FakeEvent(
+            'timeupdate', (new Map()).set('detail', 8675309));
         mockVideo.on['timeupdate'](fakeEvent);
         expect(proxyListener).toHaveBeenCalledWith(jasmine.objectContaining({
           type: 'timeupdate',
@@ -315,7 +316,8 @@ describe('CastProxy', () => {
         mockSender.hasRemoteProperties.and.returnValue(true);
 
         expect(proxyListener).not.toHaveBeenCalled();
-        const fakeEvent = new FakeEvent('timeupdate', {detail: 8675309});
+        const fakeEvent = new FakeEvent(
+            'timeupdate', (new Map()).set('detail', 8675309));
         mockVideo.on['timeupdate'](fakeEvent);
         expect(proxyListener).not.toHaveBeenCalled();
       });
@@ -332,7 +334,8 @@ describe('CastProxy', () => {
         mockSender.hasRemoteProperties.and.returnValue(true);
 
         expect(proxyListener).not.toHaveBeenCalled();
-        const fakeEvent = new FakeEvent('timeupdate', {detail: 8675309});
+        const fakeEvent = new FakeEvent(
+            'timeupdate', (new Map()).set('detail', 8675309));
         mockSender.onRemoteEvent('video', fakeEvent);
         expect(proxyListener).toHaveBeenCalledWith(jasmine.objectContaining({
           type: 'timeupdate',
@@ -446,7 +449,8 @@ describe('CastProxy', () => {
             'buffering', Util.spyFunc(proxyListener));
 
         expect(proxyListener).not.toHaveBeenCalled();
-        const fakeEvent = new FakeEvent('buffering', {detail: 8675309});
+        const fakeEvent = new FakeEvent(
+            'buffering', (new Map()).set('detail', 8675309));
         mockPlayer.listeners['buffering'](fakeEvent);
         expect(proxyListener).toHaveBeenCalledWith(jasmine.objectContaining({
           type: 'buffering',
@@ -464,7 +468,8 @@ describe('CastProxy', () => {
         mockSender.hasRemoteProperties.and.returnValue(true);
 
         expect(proxyListener).not.toHaveBeenCalled();
-        const fakeEvent = new FakeEvent('buffering', {detail: 8675309});
+        const fakeEvent = new FakeEvent(
+            'buffering', (new Map()).set('detail', 8675309));
         mockPlayer.listeners['buffering'](fakeEvent);
         expect(proxyListener).not.toHaveBeenCalled();
       });
@@ -481,7 +486,8 @@ describe('CastProxy', () => {
         mockSender.hasRemoteProperties.and.returnValue(true);
 
         expect(proxyListener).not.toHaveBeenCalled();
-        const fakeEvent = new FakeEvent('buffering', {detail: 8675309});
+        const fakeEvent = new FakeEvent(
+            'buffering', (new Map()).set('detail', 8675309));
         mockSender.onRemoteEvent('player', fakeEvent);
         expect(proxyListener).toHaveBeenCalledWith(jasmine.objectContaining({
           type: 'buffering',

package/test/cast/cast_utils_unit.js

@@ -123,7 +123,7 @@ describe('CastUtils', () => {
       expect(typeof deserialized).toBe('object');
 
       // The object can be used to construct a FakeEvent.
-      const fakeEvent = new FakeEvent(deserialized['type'], deserialized);
+      const fakeEvent = FakeEvent.fromRealEvent(deserialized);
 
       // The fake event has the same type and properties as the original.
       const asObj = /** @type {!Object} */ (fakeEvent);