sh3-server 0.6.0 → 0.7.5

package/dist/shell-shard/session-manager.js

@@ -80,6 +80,13 @@ export class ShellSession {
         // Claim the start slot synchronously so a concurrent submit during
         // the `await runner.start()` below cannot slip past the lock check.
         this.starting = true;
+        // Track whether the runner already exited before we latched `running`.
+        // Sync-failure paths (empty cmd, tokenize throw, Node 24's EINVAL for
+        // .cmd/.bat on Windows) can fire onExit via setImmediate BEFORE the
+        // await continuation runs — so we must not assign `this.running = handle`
+        // for a process that's already dead, or subsequent submits get wedged
+        // by the running-guard above. See runner.ts for the full race writeup.
+        let exited = false;
         try {
             this.history.append(line);
             // Emit a prompt event so every attached client echoes the line
@@ -94,24 +101,33 @@ export class ShellSession {
                 cmd: line,
                 cwd: this.cwd,
                 env: this.env,
+                // Callback listeners — attached synchronously inside start() BEFORE
+                // any emit can fire. Do NOT switch back to `handle.events.on(...)`
+                // after await: that re-opens the race the callbacks exist to close.
+                onStdout: (data) => {
+                    this.broadcast({ kind: 'stdout', data, ts: Date.now(), seq: 0 });
+                },
+                onStderr: (data) => {
+                    this.broadcast({ kind: 'stderr', data, ts: Date.now(), seq: 0 });
+                },
+                onExit: (info) => {
+                    this.broadcast({
+                        kind: 'exit',
+                        code: info.code,
+                        signal: info.signal,
+                        ts: Date.now(),
+                        seq: 0,
+                    });
+                    exited = true;
+                    this.running = null;
+                },
             });
-            this.running = handle;
-            handle.events.on('stdout', (data) => {
-                this.broadcast({ kind: 'stdout', data, ts: Date.now(), seq: 0 });
-            });
-            handle.events.on('stderr', (data) => {
-                this.broadcast({ kind: 'stderr', data, ts: Date.now(), seq: 0 });
-            });
-            handle.events.on('exit', (info) => {
-                this.broadcast({
-                    kind: 'exit',
-                    code: info.code,
-                    signal: info.signal,
-                    ts: Date.now(),
-                    seq: 0,
-                });
-                this.running = null;
-            });
+            // Only latch `running` if the process hasn't already died during the
+            // await boundary. Otherwise we'd resurrect a dead handle and wedge
+            // every subsequent submit.
+            if (!exited) {
+                this.running = handle;
+            }
         }
         finally {
             this.starting = false;

package/package.json

@@ -1,9 +1,9 @@
 {
   "name": "sh3-server",
-  "version": "0.6.0",
+  "version": "0.7.5",
   "type": "module",
   "bin": {
-    "sh3-server": "./dist/cli.js"
+    "sh3-server": "dist/cli.js"
   },
   "exports": {
     ".": {
@@ -39,7 +39,7 @@
     "@types/node": "^20.0.0",
     "esbuild": "^0.21.5",
     "postject": "^1.0.0-alpha.6",
-    "sh3-core": "0.6.0",
+    "sh3-core": "0.7.0",
     "svelte": "^5.0.0",
     "tsx": "^4.0.0",
     "typescript": "^5.6.0",