session-orchestrator 4.0.1 → 4.2.0

package/scripts/lib/owner-config-loader.mjs

@@ -1,170 +0,0 @@
-/**
- * owner-config-loader.mjs — File-system loader for owner.yaml (Issue #174).
- *
- * Companion to the pure schema/validator in `owner-config.mjs`. Resolves the
- * canonical config path (XDG-spec aware), reads the YAML, parses it, runs it
- * through the validator, and returns a `{ok, value, errors, source, path}`
- * envelope.
- *
- * ── PATH RESOLUTION ──────────────────────────────────────────────────────
- *
- *   Default path (#1223 — delegated to the single resolver
- *   `config/private-config-dir.mjs`; `SO_CONFIG_HOME` names the private dir
- *   ITSELF and wins):
- *   `${SO_CONFIG_HOME ?? ${XDG_CONFIG_HOME ?? ${HOME}/.config}/session-orchestrator}/owner.yaml`
- *   - macOS / Linux: `~/.config/session-orchestrator/owner.yaml`
- *   - Windows:       `%APPDATA%\session-orchestrator\owner.yaml` when
- *                    APPDATA is set and XDG_CONFIG_HOME is not (Node uses
- *                    USERPROFILE for os.homedir() — falls back gracefully).
- *
- *   Callers may pass an explicit `{path}` override (used by tests + D4
- *   baseline-propagation when the canonical path is overridden by env).
- *
- * ── RETURN SHAPE ─────────────────────────────────────────────────────────
- *
- *   {
- *     ok: boolean,                    // false on any failure
- *     value: object|null,             // normalized config when ok=true
- *     errors: string[],               // populated on any failure
- *     source: 'file'|'missing'|'parse-error'|'validation-error',
- *     path: string,                   // resolved absolute path
- *   }
- *
- *   `source: 'missing'` is NOT an error — owner.yaml is opt-in (the bootstrap
- *   interview in D2 creates it). Callers should treat `source: 'missing'` as
- *   "no owner persona configured; fall back to plugin defaults".
- *
- * ── PLATFORM PORTABILITY ─────────────────────────────────────────────────
- *
- *   - Uses `os.homedir()` (Node-stdlib, OS-aware) rather than $HOME so the
- *     Windows path resolves correctly even when only USERPROFILE is set.
- *   - File reads are UTF-8 only. Owner.yaml is ASCII-safe by spec; non-UTF-8
- *     content yields `source: 'parse-error'`.
- *   - YAML parsing via `js-yaml` (devDep already pulled in by W2 quality-fix).
- */
-
-import { readFile } from 'node:fs/promises';
-import { existsSync } from 'node:fs';
-import { join } from 'node:path';
-import yaml from 'js-yaml';
-
-import { validate } from './owner-config.mjs';
-import { resolvePrivateConfigDir } from './config/private-config-dir.mjs';
-
-// ---------------------------------------------------------------------------
-// Path resolution
-// ---------------------------------------------------------------------------
-
-/**
- * Resolve the canonical owner.yaml path on disk: the ONE private-config-dir
- * resolver (#1223) plus the file's basename — precedence `SO_CONFIG_HOME` (the
- * private dir itself) > `XDG_CONFIG_HOME` (its parent) > `${HOME}/.config`, each
- * `.trim()`ed so a whitespace-only value falls through instead of
- * short-circuiting (`.claude/rules/development.md` § Error Handling).
- *
- * Reaches the leaf DIRECTLY rather than through `owner-yaml.mjs`'s
- * `resolveOwnerYamlPath()`: that hop exists only to append the same basename and
- * drags a `js-yaml`-importing module in with it. The precedence — the part #1223
- * consolidated — still lives in exactly one place; only the literal `'owner.yaml'`
- * is stated twice.
- *
- * Before #1223 this function knew only `XDG_CONFIG_HOME` and did not trim, so
- * `SO_CONFIG_HOME=<sandbox>` still read the operator's real home.
- *
- * Returns an absolute path string. Does NOT touch the filesystem.
- *
- * @returns {string} absolute path to owner.yaml
- */
-export function resolveOwnerConfigPath() {
-  return join(resolvePrivateConfigDir(), 'owner.yaml');
-}
-
-// ---------------------------------------------------------------------------
-// Loader
-// ---------------------------------------------------------------------------
-
-/**
- * Load and validate the owner.yaml config from disk.
- *
- * Defensive — never throws. Distinguishes four outcomes via the `source`
- * field so callers can react differently to "missing file" (opt-in feature
- * not yet enabled by the user) vs "malformed YAML" (broken state, surface
- * to user).
- *
- * @param {{path?: string}} [opts]
- * @returns {Promise<{ok: boolean, value: object|null, errors: string[], source: string, path: string}>}
- */
-export async function loadOwnerConfig(opts = {}) {
-  const path = opts.path ?? resolveOwnerConfigPath();
-
-  if (!existsSync(path)) {
-    return {
-      ok: false,
-      value: null,
-      errors: [],
-      source: 'missing',
-      path,
-    };
-  }
-
-  let raw;
-  try {
-    raw = await readFile(path, 'utf8');
-  } catch (err) {
-    return {
-      ok: false,
-      value: null,
-      errors: [`failed to read owner config: ${err.message}`],
-      source: 'parse-error',
-      path,
-    };
-  }
-
-  let parsed;
-  try {
-    // js-yaml's default schema (CORE_SCHEMA) is safe — it explicitly excludes
-    // the !!js/function and !!js/regexp tags from the legacy DEFAULT_SCHEMA
-    // that would let a malicious YAML file execute code or pollute prototypes.
-    parsed = yaml.load(raw);
-  } catch (err) {
-    return {
-      ok: false,
-      value: null,
-      errors: [`YAML parse error: ${err.message}`],
-      source: 'parse-error',
-      path,
-    };
-  }
-
-  // Empty file or YAML "null" → treat as parse-error so the caller knows
-  // there's nothing to merge (vs a missing file which opts the user out
-  // entirely).
-  if (parsed === null || parsed === undefined) {
-    return {
-      ok: false,
-      value: null,
-      errors: ['owner config is empty'],
-      source: 'parse-error',
-      path,
-    };
-  }
-
-  const validation = validate(parsed);
-  if (!validation.ok) {
-    return {
-      ok: false,
-      value: null,
-      errors: validation.errors,
-      source: 'validation-error',
-      path,
-    };
-  }
-
-  return {
-    ok: true,
-    value: validation.value,
-    errors: [],
-    source: 'file',
-    path,
-  };
-}

package/scripts/lib/owner-config.mjs

@@ -1,28 +0,0 @@
-/**
- * owner-config.mjs — Owner Persona schema + validator (Issue #174, Sub-Epic #161).
- *
- * Thin re-export wrapper. All logic lives in `./owner-config/` submodules:
- *   constants.mjs  — frozen enum arrays + schema version
- *   error.mjs      — OwnerConfigError class
- *   defaults.mjs   — defaults() factory
- *   validate.mjs   — validate() + 7 section helpers
- *   coerce.mjs     — coerce() strict-mode wrapper
- *   merge.mjs      — merge() deep-merge
- *   index.mjs      — re-export hub (aggregates all 10 public symbols)
- *
- * For the full schema contract and module DAG see `./owner-config/index.mjs`.
- * The loader (which does touch the disk) lives in `owner-config-loader.mjs`.
- */
-
-export {
-  CURRENT_OWNER_SCHEMA_VERSION,
-  VALID_TONE_STYLES,
-  VALID_OUTPUT_LEVELS,
-  VALID_PREAMBLE_LEVELS,
-  VALID_COMMENTS_LEVELS,
-  OwnerConfigError,
-  defaults,
-  validate,
-  coerce,
-  merge,
-} from './owner-config/index.mjs';

package/scripts/lib/soul-resolve.mjs

@@ -1,130 +0,0 @@
-/**
- * soul-resolve.mjs — Template resolver for soul.md files (Issue #176, D3).
- *
- * Resolves `{{slot}}` placeholders in soul.md templates using owner persona
- * config loaded via `owner-yaml.mjs` (D1). Pure at the `resolveSoul` level;
- * `loadAndResolveSoul` performs disk I/O.
- *
- * ── NO RUNTIME CALLER — read this before assuming a soul.md is resolved ──────
- *
- * Nothing in `scripts/`, `hooks/`, or any skill body calls either export. Skill
- * bodies instruct the coordinator to read soul.md DIRECTLY, so whatever is in
- * the file on disk is what the coordinator sees — an unsubstituted `{{slot}}`
- * reaches the model verbatim and instructs nothing. `skills/session-start/soul.md`
- * is therefore authored pre-resolved: it carries no slots, and the operator's
- * `efficiency.output-level` selects one of its literal `### output-level: <value>`
- * blocks (see that file's § Output Levels; the skill body performs the lookup).
- * Slots that remain in other soul.md files are inert for the same reason.
- * Do not add a slot to a soul.md expecting substitution — wire a caller first.
- *
- * ── Slot syntax ──────────────────────────────────────────────────────────────
- *
- *   {{owner.language}}          → 'de' | 'en'
- *   {{tone.style}}              → 'direct' | 'neutral' | 'friendly'
- *   {{efficiency.output-level}} → 'lite' | 'full' | 'ultra'
- *   {{efficiency.preamble}}     → 'minimal' | 'verbose'
- *
- * ── Resolution rules ─────────────────────────────────────────────────────────
- *
- *   - Known slot path present in ownerConfig  → replaced with the value
- *   - Known slot path missing in ownerConfig  → replaced with default (silent)
- *   - Unknown slot path                       → left as-is; warning added to result
- *
- * ── Exports ───────────────────────────────────────────────────────────────────
- *
- *   resolveSoul(templateContent, ownerConfig)    → { resolved: string, warnings: string[] }
- *   loadAndResolveSoul(soulPath, opts?)          → { resolved: string, warnings: string[], source: string }
- */
-
-import { readFileSync } from 'node:fs';
-import { loadOwnerConfig, getDefaults } from './owner-yaml.mjs';
-
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-
-/**
- * Look up a dot-notation path such as "efficiency.output-level" in a nested
- * object. Returns `undefined` if any segment is missing.
- *
- * @param {object} obj
- * @param {string} dotPath
- * @returns {unknown}
- */
-function getByPath(obj, dotPath) {
-  const segments = dotPath.split('.');
-  let cursor = obj;
-  for (const seg of segments) {
-    if (cursor === null || cursor === undefined || typeof cursor !== 'object') {
-      return undefined;
-    }
-    cursor = cursor[seg];
-  }
-  return cursor;
-}
-
-/**
- * Set of slot paths explicitly documented / known by this module.
- * Any slot NOT in this set is considered unknown and left in place with a warning.
- */
-const KNOWN_SLOTS = new Set([
-  'owner.language',
-  'tone.style',
-  'efficiency.output-level',
-  'efficiency.preamble',
-]);
-
-// ---------------------------------------------------------------------------
-// Public API
-// ---------------------------------------------------------------------------
-
-/**
- * Resolve `{{slot}}` placeholders in `templateContent` using `ownerConfig`.
- *
- * Pure function — no I/O, no side-effects.
- *
- * @param {string} templateContent  Raw soul.md template text.
- * @param {object} ownerConfig      Owner persona config (from loadOwnerConfig or getDefaults).
- * @returns {{ resolved: string, warnings: string[] }}
- */
-export function resolveSoul(templateContent, ownerConfig) {
-  const defaults = getDefaults();
-  const warnings = [];
-
-  const resolved = templateContent.replace(/\{\{\s*([\w.-]+)\s*\}\}/g, (_match, path) => {
-    if (!KNOWN_SLOTS.has(path)) {
-      warnings.push(`Unknown slot path: {{${path}}} — left in place`);
-      return `{{${path}}}`;
-    }
-
-    // Try ownerConfig first, then fall back to defaults
-    let value = getByPath(ownerConfig, path);
-    if (value === undefined || value === null || value === '') {
-      value = getByPath(defaults, path);
-    }
-
-    return String(value ?? '');
-  });
-
-  return { resolved, warnings };
-}
-
-/**
- * Read a soul.md template from `soulPath`, load owner config (from
- * `ownerConfigPath` or the default location), and return the resolved content.
- *
- * @param {string} soulPath                    Absolute path to the soul.md template.
- * @param {{ ownerConfigPath?: string }} [opts]
- * @returns {{ resolved: string, warnings: string[], source: 'file'|'defaults'|'partial' }}
- */
-export function loadAndResolveSoul(soulPath, opts = {}) {
-  const templateContent = readFileSync(soulPath, 'utf8');
-
-  const { config, source } = loadOwnerConfig(
-    opts.ownerConfigPath ? { path: opts.ownerConfigPath } : {},
-  );
-
-  const { resolved, warnings } = resolveSoul(templateContent, config);
-
-  return { resolved, warnings, source };
-}

package/scripts/lib/vault-mirror/render.mjs

@@ -1,8 +0,0 @@
-/**
- * render.mjs — Re-export barrel for vault-mirror render modules (Issue #283 split).
- *
- * Consumers can import from this file or directly from render-learnings.mjs / render-sessions.mjs.
- */
-
-export { detectLearningSchema, generateLearningNote, generateLearningNoteV2 } from './render-learnings.mjs';
-export { detectSessionSchema, generateSessionNote, generateSessionNoteV2, generateSessionNoteV3 } from './render-sessions.mjs';