session-orchestrator 3.24.0 → 4.0.1

package/scripts/lib/config/block-preprocess.mjs

@@ -0,0 +1,177 @@
+/**
+ * block-preprocess.mjs — THE line-preprocessing contract for the block parsers
+ * under `scripts/lib/config/` (#1162).
+ *
+ * Every block parser here begins with `content.split(/\r?\n/)`, then walks lines
+ * looking for its own header and the indented sub-keys under it. Two markdown
+ * shapes that are ordinary in a CLAUDE.md / AGENTS.md were invisible to that
+ * walk, and both failed in the dangerous direction:
+ *
+ *   (a) A block commented OUT with a multi-line `<!-- … -->` was read as LIVE
+ *       config. Commenting a key out is the most ordinary way to disable it; it
+ *       must not arm it. (`_extractConfigSection` learned this in #1097 — the
+ *       block parsers never did.)
+ *   (b) The bold-bullet rendering of a SUB-key (`- **enabled:** true`) matched
+ *       no sub-key regex, so the key was absent and its DEFAULT applied. For a
+ *       boolean that default is `false`, which reads exactly like a deliberately
+ *       disabled block — no error, in any log. #823 fixed this for the block
+ *       HEADER only (see `block-header.mjs`); this fixes it for the body.
+ *
+ * ZERO IMPORTS beyond the sibling `section-extractor.mjs` skipper, stdlib only —
+ * `tests/lib/config/cycle-guard.test.mjs` forbids any `scripts/lib/config/*.mjs`
+ * from importing `../config.mjs`, and the RAW-PARITY constraint (block-header.mjs
+ * docblock) requires the normalisation to live in the helper each parser calls,
+ * never in a preprocessing step in `config.mjs`.
+ *
+ * DELIBERATE NON-GOAL — fenced code blocks. These parsers are fence-UNAWARE, and
+ * that is a pinned contract, not an oversight. Two tests, cited by NAME because
+ * line numbers rot: `tests/lib/config/frontend-slop-hook.test.mjs` — "parses a
+ * block wrapped in a fenced code block — the parser is fence-unaware", and
+ * `tests/lib/config/dispatcher-autonomy-capture.test.mjs` — "treats a header
+ * inside a fenced code block as PRESENT". Both assert that a ```-fenced block IS
+ * parsed. Teaching this module about
+ * fences would flip ~36 parsers at once and break those pins, so it does not.
+ * Revisit only as its own change, with those two tests as the blast radius.
+ */
+
+import { htmlCommentSkipper } from './section-extractor.mjs';
+
+/**
+ * Drop every line that lies inside — or opens — a multi-line `<!-- … -->` HTML
+ * comment (#1162a).
+ *
+ * Wraps `htmlCommentSkipper()` from `section-extractor.mjs` rather than
+ * re-deriving the state machine, so the block parsers and the Session Config
+ * KV extractor share ONE definition of "this line is commented-out
+ * documentation" by construction. A fresh closure is built per call: the skipper
+ * carries per-document state, and a shared instance would leak an unterminated
+ * comment from one document into the next.
+ *
+ * Inherits the skipper's deliberate ceiling: the opener must be at the START of
+ * a line (`/^\s*<!--/`), so `waves: 5 <!-- note` does NOT swallow the following
+ * lines — the trailing single-line comment form this repo's own convention
+ * encourages keeps working.
+ *
+ * Never touches `- ` list markers, indentation, or line content.
+ *
+ * FAIL-CLOSED on an UNTERMINATED comment. A stray `<!--` with no `-->` after it
+ * puts the skipper in the swallowing state for the REST of the document, so
+ * every later block silently disappears and each parser falls back to its
+ * defaults — for `config-protection` that is `strict` → `warn`, i.e. a guard
+ * disarmed by a typo, with no error anywhere. When the skipper would still be
+ * inside a comment at EOF, this returns the INPUT lines unfiltered (the
+ * pre-#1162 behaviour: the opener is treated as literal text), so nothing can
+ * vanish. The condition is reported via `onUnterminated` and is separately
+ * observable through {@link findUnterminatedComment}.
+ *
+ * @param {string[]} lines
+ * @param {(lineNo: number) => void} [onUnterminated] — called with the 1-based
+ *   line number of the unterminated opener when stripping is disabled.
+ * @returns {string[]} a new array; the input is not mutated.
+ */
+export function stripHtmlCommentBlocks(lines, onUnterminated) {
+  if (!Array.isArray(lines)) return [];
+  const unterminatedAt = findUnterminatedComment(lines);
+  if (unterminatedAt !== null) {
+    if (typeof onUnterminated === 'function') onUnterminated(unterminatedAt);
+    return lines.slice();
+  }
+  const skip = htmlCommentSkipper();
+  return lines.filter((line) => !skip(typeof line === 'string' ? line : ''));
+}
+
+/**
+ * The 1-based line number of an `<!--` that is never closed, or `null` when
+ * every comment in `lines` is terminated.
+ *
+ * Derived from the SAME `htmlCommentSkipper()` state machine rather than a
+ * second copy of it (the RAW-PARITY constraint): the skipper swallows the
+ * closing `-->` line too, so the document ends inside a comment exactly when
+ * the LAST swallowed line carries no `-->`. A swallowed line that follows a
+ * closing line (or the first one of all) is an opener, which is how the
+ * reported line number is obtained.
+ *
+ * @param {string[]} lines
+ * @returns {number|null}
+ */
+export function findUnterminatedComment(lines) {
+  if (!Array.isArray(lines)) return null;
+  const skip = htmlCommentSkipper();
+  let openerLine = null;
+  /** @type {string|null} */
+  let lastSwallowed = null;
+  for (let i = 0; i < lines.length; i += 1) {
+    const line = typeof lines[i] === 'string' ? lines[i] : '';
+    if (!skip(line)) continue;
+    if (lastSwallowed === null || lastSwallowed.includes('-->')) openerLine = i + 1;
+    lastSwallowed = line;
+  }
+  if (lastSwallowed === null || lastSwallowed.includes('-->')) return null;
+  return openerLine;
+}
+
+/**
+ * `- **key:** value` / `- **key**: value` / `**key:** value` → `key: value`,
+ * preserving the leading indentation EXACTLY (#1162b).
+ *
+ * The indent is load-bearing: every block parser ends its block at the first
+ * non-empty non-indented line, so an indent-eating rewrite would truncate the
+ * block one line early. Only the `**` markers and the optional `- ` bullet
+ * immediately around the `key:` token at line start are removed; the value
+ * portion (including any literal `**` inside it) is untouched — same rule as the
+ * `_matchKVLine` Format-1 branch and the #823 header tolerance.
+ *
+ * A line that is not a bold key/value pair is returned byte-identical.
+ *
+ * @internal — exported for this module's own tests. Production callers use
+ * {@link preprocessBlockLines} / {@link preprocessBlockLinesNoDash}.
+ *
+ * NAMED RISK — dash-record blocks. In any block whose body uses `- ` as a RECORD
+ * boundary, de-dashing the first key of a record merges it into the PREVIOUS
+ * record, silently producing one record where two were written. Those parsers
+ * must use
+ * `preprocessBlockLinesNoDash` instead. `tests/lib/config/block-preprocess.test.mjs`
+ * demonstrates the merge so the next reader sees why the NoDash variant exists.
+ *
+ * @param {string[]} lines
+ * @returns {string[]} a new array; the input is not mutated.
+ */
+export function normalizeBoldSubkeys(lines) {
+  if (!Array.isArray(lines)) return [];
+  return lines.map((line) => {
+    if (typeof line !== 'string') return line;
+    // (1) indent  (2) optional bullet  (3) **key:**  or  **key**:  (4) rest
+    const m = line.match(/^(\s*)(?:-\s+)?\*\*([^*:]+?)(?::\*\*|\*\*:)\s*(.*)$/);
+    if (!m) return line;
+    const value = m[3];
+    return value === '' ? `${m[1]}${m[2]}:` : `${m[1]}${m[2]}: ${value}`;
+  });
+}
+
+/**
+ * THE drop-in replacement for `content.split(/\r?\n/)` in a flat or
+ * nested-OBJECT block parser: strip commented-out lines, then normalise bold
+ * sub-keys.
+ *
+ * @param {string} content — full file contents
+ * @returns {string[]} preprocessed lines (empty array for non-string input)
+ */
+export function preprocessBlockLines(content) {
+  if (typeof content !== 'string') return [];
+  return normalizeBoldSubkeys(stripHtmlCommentBlocks(content.split(/\r?\n/)));
+}
+
+/**
+ * THE drop-in for every dash-RECORD parser — any parser whose block body uses
+ * `- ` as a record boundary, so the dash must survive: HTML-comment stripping
+ * only, no bold-subkey normalisation. (Enumerating them here goes stale; the
+ * rule is the criterion. `grep -l preprocessBlockLinesNoDash scripts/lib/config/`
+ * lists the current set.)
+ *
+ * @param {string} content — full file contents
+ * @returns {string[]} preprocessed lines (empty array for non-string input)
+ */
+export function preprocessBlockLinesNoDash(content) {
+  if (typeof content !== 'string') return [];
+  return stripHtmlCommentBlocks(content.split(/\r?\n/));
+}

package/scripts/lib/config/broken-window.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * broken-window.mjs — Parser for the top-level `broken-window-budget:` YAML block
@@ -48,7 +49,7 @@ export function _parseBrokenWindow(content) {
     'due-days': 7,
   };
 
-  const lines = String(content ?? '').split(/\r?\n/);
+  const lines = preprocessBlockLines(String(content ?? ''));
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/cold-start.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * cold-start.mjs — Parser for the top-level `cold-start:` YAML block (PRD F1.3 /
@@ -30,7 +31,7 @@ export function _parseColdStart(content) {
     'silence-after-sessions': 1,
   };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/config-protection.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { findUnterminatedComment, preprocessBlockLines, preprocessBlockLinesNoDash } from './block-preprocess.mjs';
 import { isSessionConfigHeading } from './section-extractor.mjs';
 
 /**
@@ -45,7 +46,7 @@ export function _parseConfigProtection(content) {
 
   if (typeof content !== 'string' || content.length === 0) return defaults;
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 
@@ -107,7 +108,26 @@ export function _parseConfigProtection(content) {
 export function _isConfigWeakeningAllowed(content) {
   if (typeof content !== 'string' || content.length === 0) return false;
 
-  const lines = content.split(/\r?\n/);
+  // HTML-comment stripping ONLY (`preprocessBlockLinesNoDash`), never the full
+  // `preprocessBlockLines`: bold-subkey normalisation would make
+  // `- **allow-config-weakening:** true` arm the bypass, and
+  // `tests/lib/config/config-protection.test.mjs` pins the opposite — only the
+  // plain form is the supported bypass. Fail-closed beats markdown tolerance there.
+  // The comment strip is the OTHER direction and is mandatory (W4/F1): with a raw
+  // `content.split(/\r?\n/)` a COMMENTED-OUT `<!--\nallow-config-weakening: true\n-->`
+  // inside `## Session Config` ARMED the bypass — commenting a key out is the most
+  // ordinary way to disable it and must never enable it (same class as #1162a).
+  //
+  // UNTERMINATED `<!--` — the fail-closed direction INVERTS for a bypass scan.
+  // `stripHtmlCommentBlocks` returns the lines UNFILTERED when a comment is never
+  // closed, which is right for a block PARSER (nothing may silently vanish) and
+  // wrong here: it hands the commented-out bypass line straight back and re-arms
+  // the guard's own off switch. For this scan "I cannot tell where the comments
+  // end" must mean NOT ARMED — the bypass is opt-in, so refusing to grant it is
+  // the safe reading in every ambiguous document.
+  if (findUnterminatedComment(content.split(/\r?\n/)) !== null) return false;
+
+  const lines = preprocessBlockLinesNoDash(content);
   let inConfig = false;
   for (const line of lines) {
     if (isSessionConfigHeading(line)) { inConfig = true; continue; }

package/scripts/lib/config/context-coverage.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * context-coverage.mjs — Parser for the top-level `context-coverage:` YAML block.
@@ -37,7 +38,7 @@ import { matchBlockHeader } from './block-header.mjs';
 export function _parseContextCoverage(content) {
   const defaults = { enabled: false, mode: 'warn' };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/cross-repo.mjs

@@ -20,6 +20,7 @@ import { homedir } from 'node:os';
 import { join } from 'node:path';
 import { readConfigFile } from './io.mjs';
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * Resolve the cross-repo confinement root. Defaults to ~/Projects.
@@ -47,7 +48,7 @@ const SAFE_PATH_RE = /^[A-Za-z0-9._~/-]+$/;
  * @returns {string[]} list of project paths, or [] when absent/empty/none/null
  */
 export function _parseCrossRepo(content) {
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
 
   for (const rawLine of lines) {

package/scripts/lib/config/custom-phases.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLinesNoDash } from './block-preprocess.mjs';
 
 /**
  * custom-phases.mjs — Parser for the `custom-phases:` Session Config block (#637).
@@ -65,7 +66,7 @@ const SAFE_PATH_RE = /^[A-Za-z0-9._~/-]+$/;
  * @returns {Array<{name: string, when: string, command: string, mode: string, review: string|null}>}
  */
 export function _parseCustomPhases(content) {
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLinesNoDash(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/dialectic.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * dialectic.mjs — Parser for top-level `dialectic:` YAML block (#506).
@@ -30,7 +31,7 @@ const ALLOWED_MODELS = new Set(['haiku', 'sonnet', 'opus']);
 export function _parseDialectic(content) {
   const defaults = { cadence: 5, model: 'haiku', 'budget-tokens': 8000 };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/discovery-validator.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * discovery-validator.mjs — Parser for the top-level `discovery-validator:`
@@ -36,7 +37,7 @@ export function _parseDiscoveryValidator(content) {
     enabled: false,
   };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/dispatcher-autonomy-capture.mjs

@@ -39,6 +39,7 @@
 import { readFileSync, writeFileSync } from 'node:fs';
 
 import { hasBlockHeader } from './block-header.mjs';
+import { preprocessBlockLinesNoDash } from './block-preprocess.mjs';
 
 const ALLOWED_AUTONOMY = ['off', 'advisory', 'autonomous-gated'];
 const DEFAULT_CONFIDENCE_FLOOR = 0.5;
@@ -113,6 +114,18 @@ export function getDispatcherAutonomyQuestion() {
  * the shared `matchBlockHeader()` matcher (block-header.mjs). `hasBlockHeader()`
  * splits on `/\r?\n/` and tests each line, so `\r` and trailing whitespace are
  * eaten by the `\s*$` tail and the identical set of inputs matches.
+ *
+ * PARSER PARITY, both halves (#1222): the parser preprocesses its content with
+ * `preprocessBlockLines()` — it STRIPS `<!-- … -->` HTML comments and is
+ * fence-BLIND. This guard therefore preprocesses too, with
+ * `preprocessBlockLinesNoDash()` (comment-strip only; the full
+ * `preprocessBlockLines` additionally de-dashes bold sub-keys, which this
+ * whole-file presence scan has no use for), and stays fence-blind as well. Before
+ * that, a block commented OUT (`<!--\ndispatcher-autonomy:\n  autonomy: off\n-->`)
+ * parsed to DEFAULTS while being reported PRESENT — so the one-time capture AUQ
+ * never fired and the operator was never asked. The two halves must move
+ * together: teach one about comments or fences and the other follows in
+ * lock-step, or the guard and the parser disagree again.
  * Verified-equivalent edge cases:
  *   - CRLF line endings (`dispatcher-autonomy:\r\n`) → PRESENT (`\s*$` eats the `\r`).
  *   - Trailing spaces / tabs on the header line → PRESENT (`\s*$`).
@@ -130,6 +143,15 @@ export function getDispatcherAutonomyQuestion() {
  *   - Header present but BODY malformed (garbage non-yaml lines) → PRESENT. A
  *     malformed block is the operator's to fix, never a re-prompt trigger — the
  *     parser tolerantly falls back to defaults, and capture must not re-ask.
+ *   - Header inside a `<!-- … -->` comment → ABSENT (#1222), matching the parser.
+ *   - Header inside a comment that is never closed (a stray `<!--` with no
+ *     `-->`) → PRESENT. `stripHtmlCommentBlocks()` returns the lines UNFILTERED
+ *     in that case, so nothing silently vanishes, and the parser — which uses the
+ *     same helper — sees the header too. Unlike `_isConfigWeakeningAllowed()` in
+ *     config-protection.mjs, this scan does NOT invert that direction: there the
+ *     scanned line ARMS a bypass, so ambiguity must mean "not armed"; here the
+ *     only cost of a stray PRESENT is one un-asked question, while diverging from
+ *     the parser would re-open exactly the bug this fix closes.
  *
  * No-throw: null / non-string / empty → false.
  *
@@ -138,7 +160,8 @@ export function getDispatcherAutonomyQuestion() {
  */
 export function isDispatcherAutonomyBlockPresent(claudeMdContent) {
   if (typeof claudeMdContent !== 'string' || claudeMdContent.length === 0) return false;
-  return hasBlockHeader(claudeMdContent, 'dispatcher-autonomy');
+  const preprocessed = preprocessBlockLinesNoDash(claudeMdContent).join('\n');
+  return hasBlockHeader(preprocessed, 'dispatcher-autonomy');
 }
 
 /**

package/scripts/lib/config/dispatcher-autonomy.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * dispatcher-autonomy.mjs — Parser + resolver for the top-level
@@ -40,7 +41,7 @@ export function _parseDispatcherAutonomy(content) {
     'confidence-floor': 0.5,
   };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/docs-orchestrator.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * docs-orchestrator.mjs — Parser for the top-level `docs-orchestrator:` YAML block.
@@ -13,7 +14,7 @@ import { matchBlockHeader } from './block-header.mjs';
 export function _parseDocsOrchestrator(content) {
   const defaults = { enabled: false, audiences: ['user', 'dev', 'vault'], mode: 'warn' };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/docs-staleness.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * docs-staleness.mjs — Parser for the top-level `docs-staleness:` YAML block.
@@ -29,7 +30,7 @@ export function _parseDocsStaleness(content) {
     mode: 'warn',
   };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/drift-check.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * drift-check.mjs — Parser for the top-level `drift-check:` YAML block.
@@ -39,7 +40,7 @@ export function _parseDriftCheck(content) {
     'check-docs-parity': true,
   };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/eval.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * eval.mjs — Parser for the top-level `eval:` YAML block (#809, Epic #803).
@@ -51,7 +52,7 @@ const ALLOWED_REPORT = new Set(['html', 'none']);
 export function _parseEval(content) {
   const defaults = { enabled: false, mode: 'warn', judge: 'off', report: 'html', handle: null };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/events-rotation.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * events-rotation.mjs — Parser for the top-level `events-rotation:` YAML block.
@@ -17,7 +18,7 @@ import { matchBlockHeader } from './block-header.mjs';
 export function _parseEventsRotation(content) {
   const defaults = { enabled: true, 'max-size-mb': 10, 'max-backups': 5 };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/evolve.mjs

@@ -35,6 +35,7 @@
 import pathModule from 'node:path';
 
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines, preprocessBlockLinesNoDash } from './block-preprocess.mjs';
 
 /** Per-entry defaults (none beyond the required field-set; documented for symmetry). */
 export const EVOLVE_EXTRA_SOURCE_DEFAULTS = Object.freeze({
@@ -67,7 +68,9 @@ const SAFE_PATH_RE = /^[A-Za-z0-9._~/-]+$/;
  * @returns {Array<{path: string, kind: string, 'learning-type': string}>}
  */
 export function _parseEvolve(content) {
-  const lines = content.split(/\r?\n/);
+  // NoDash: `- ` is the RECORD boundary under `extra-sources:` — de-dashing the
+  // first key of a record would merge it into the previous one (#1162).
+  const lines = preprocessBlockLinesNoDash(content);
   let inEvolve = false;
   let inExtraSources = false;
   const blockLines = [];
@@ -254,7 +257,10 @@ export function _parseEvolveDecay(content) {
     'floor-factor': EVOLVE_DECAY_DEFAULTS['floor-factor'],
   };
 
-  const lines = content.split(/\r?\n/);
+  // Standard variant: this parser reads only FLAT `decay-*` sub-keys and builds
+  // no records, so bold-subkey normalisation is safe here even though the same
+  // `evolve:` block also carries the `extra-sources:` dash records (#1162).
+  const lines = preprocessBlockLines(content);
   let inEvolve = false;
   const blockLines = [];
 

package/scripts/lib/config/frontend-slop-hook.mjs

@@ -18,8 +18,9 @@
 import { promises as fs } from 'node:fs';
 import path from 'node:path';
 
-import { SO_PROJECT_DIR } from '../platform.mjs';
+import { getProjectDir } from '../platform.mjs';
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * Parse the top-level `frontend-slop-hook:` YAML block from markdown content.
@@ -35,7 +36,7 @@ import { matchBlockHeader } from './block-header.mjs';
 export function _parseFrontendSlopHook(content) {
   const defaults = { enabled: false };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 
@@ -86,7 +87,10 @@ export function _parseFrontendSlopHook(content) {
  * @returns {Promise<{ enabled: boolean }>}
  */
 export async function loadFrontendSlopHookConfig(opts = {}) {
-  const root = opts.repoRoot || SO_PROJECT_DIR;
+  // Called at USE time, never at module load: the deprecated `SO_PROJECT_DIR`
+  // named export is a live binding that stays `undefined` until some getter has
+  // run in the process, so a bare call resolved the root to undefined (#1153 P5).
+  const root = opts.repoRoot || getProjectDir();
   const candidates = [
     path.join(root, 'CLAUDE.md'),
     path.join(root, 'AGENTS.md'),

package/scripts/lib/config/gitlab-portfolio.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * gitlab-portfolio.mjs — Parser for the top-level `gitlab-portfolio:` YAML block.
@@ -66,7 +67,7 @@ export function coerceGitlabPortfolio(raw) {
  * @returns {{ enabled: boolean, mode: 'warn'|'strict'|'off', 'stale-days': number, 'critical-labels': string[] }}
  */
 export function _parseGitlabPortfolio(content) {
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/handover-gate.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * handover-gate.mjs — Parser for the top-level `handover-gate:` YAML block
@@ -43,7 +44,7 @@ export function _parseHandoverGate(content) {
     'max-open-questions': 3,
   };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
 

package/scripts/lib/config/health-endpoints.mjs

@@ -63,6 +63,7 @@
  */
 
 import { matchBlockHeader, matchBlockHeaderDetailed } from './block-header.mjs';
+import { preprocessBlockLines, preprocessBlockLinesNoDash } from './block-preprocess.mjs';
 import { _coerceBoolean } from './coercers.mjs';
 
 /**
@@ -315,7 +316,9 @@ function assignKV(entry, text) {
 export function _parseHealthEndpoints(content) {
   if (typeof content !== 'string' || content === '') return null;
 
-  const lines = content.split(/\r?\n/);
+  // NoDash: `- name:` / `- url:` / `- {name, url}` list items are RECORD
+  // boundaries here — de-dashing would merge two endpoints into one (#1162).
+  const lines = preprocessBlockLinesNoDash(content);
   for (let i = 0; i < lines.length; i++) {
     const line = lines[i].replace(/\r$/, '');
     const m = matchBlockHeaderDetailed(line, 'health-endpoints');
@@ -353,7 +356,9 @@ export function _parseHealthEndpoints(content) {
 export function _parseEcosystemHealthBlockEnabled(content) {
   if (typeof content !== 'string' || content === '') return null;
 
-  const lines = content.split(/\r?\n/);
+  // Standard variant: this parser reads only the flat `enabled:` sub-key and
+  // builds no records (#1162).
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];
   for (const rawLine of lines) {

package/scripts/lib/config/host-paths.mjs

@@ -40,17 +40,33 @@ const ENV_KEYS = /** @type {const} */ ({
  * merged with defaults, so a real owner.yaml without a `paths:` section yields
  * `ownerConfig.paths === undefined`. Callers must read defensively.
  *
- * @param {{ env?: Record<string, string|undefined>, ownerLoader?: () => { config: object } }} [opts]
- * @returns {{ ownerConfig: object|undefined, env: Record<string, string|undefined> }}
+ * HEALTH PASSTHROUGH (#1251): the owner loader reports HOW its result came about
+ * (`source`, `reason`, `droppedSections`). Discarding those forced callers that
+ * need them — CP11 in check-owner-leakage.mjs is the live one — to load owner.yaml
+ * a SECOND time just to see the health of the load this function already did. They
+ * are passed through verbatim; `ownerConfig` and `env` keep their exact prior
+ * meaning, so callers reading only those two (scripts/lib/config.mjs,
+ * scripts/lib/vault-mirror/namespace.mjs) are unaffected. On a throwing loader all
+ * three health fields stay `undefined`, exactly like `ownerConfig`.
+ *
+ * @param {{ env?: Record<string, string|undefined>, ownerLoader?: () => { config: object, source?: string, reason?: string, droppedSections?: Array<{section: string, errors: string[]}> } }} [opts]
+ * @returns {{ ownerConfig: object|undefined, env: Record<string, string|undefined>, source: string|undefined, reason: string|undefined, droppedSections: Array<{section: string, errors: string[]}>|undefined }}
  */
 export function loadHostPaths({ env = process.env, ownerLoader = loadOwnerConfig } = {}) {
   let ownerConfig;
+  let source;
+  let reason;
+  let droppedSections;
   try {
-    ownerConfig = ownerLoader().config;
+    const loaded = ownerLoader();
+    ownerConfig = loaded?.config;
+    source = loaded?.source;
+    reason = loaded?.reason;
+    droppedSections = loaded?.droppedSections;
   } catch {
     ownerConfig = undefined;
   }
-  return { ownerConfig, env };
+  return { ownerConfig, env, source, reason, droppedSections };
 }
 
 /**

package/scripts/lib/config/issue-budget.mjs

@@ -1,4 +1,5 @@
 import { matchBlockHeader } from './block-header.mjs';
+import { preprocessBlockLines } from './block-preprocess.mjs';
 
 /**
  * issue-budget.mjs — Parser for the `issue-budget:` block-style Session Config key.
@@ -65,7 +66,7 @@ export function _parseIssueBudget(content) {
 
   if (typeof content !== 'string' || content === '') return { ...defaults };
 
-  const lines = content.split(/\r?\n/);
+  const lines = preprocessBlockLines(content);
   let inBlock = false;
   const blockLines = [];