session-orchestrator 3.21.0 → 3.23.0

package/skills/vault-sync/tests/fixtures/missing-field-vault/missing-id.md

@@ -1,7 +0,0 @@
----
-type: note
-created: 2026-04-13
-updated: 2026-04-13
----
-
-Missing `id`.

package/skills/vault-sync/tests/fixtures/nested-tag-vault/03-daily/daily-2026-04-13.md

@@ -1,9 +0,0 @@
----
-id: daily-2026-04-13
-type: daily
-created: 2026-04-13
-updated: 2026-04-13
-tags: [area/infrastructure/cleanup, meta/session-log]
----
-
-Daily note using deep-nested Obsidian tags.

package/skills/vault-sync/tests/fixtures/nested-tag-vault/nested-tags-note.md

@@ -1,11 +0,0 @@
----
-id: nested-tags-note
-type: note
-created: 2026-04-13
-updated: 2026-04-13
-title: Nested Tags Note
-tags: [meta/schema, status/in-progress, area/infrastructure, session/2026-04-13]
-status: active
----
-
-A note that uses Obsidian nested-tag conventions (slash-separated hierarchy).

package/skills/vault-sync/tests/fixtures/no-frontmatter-vault/README.md

@@ -1,3 +0,0 @@
-# README only
-
-No frontmatter. Must be counted as `files_skipped_no_frontmatter` and not error.

package/skills/vault-sync/tests/fixtures/no-frontmatter-vault/_MOC.md

@@ -1,3 +0,0 @@
-# Map of Content
-
-No frontmatter — this is a plain index.

package/skills/vault-sync/tests/fixtures/with-moc-vault/_MOC.md

@@ -1,11 +0,0 @@
----
-title: Map of Content
----
-
-# Map of Content
-
-This is an index file that intentionally lacks the full note frontmatter
-(no `id`, `type`, `created`, or `updated`). Validator should report errors
-unless this file is excluded via `--exclude "**/_MOC.md"`.
-
-- [[hello-world]]

package/skills/vault-sync/tests/fixtures/with-moc-vault/hello-world.md

@@ -1,11 +0,0 @@
----
-id: hello-world
-type: note
-created: 2026-04-13
-updated: 2026-04-13
-title: Hello World
-tags: [meta, intro]
-status: active
----
-
-A valid note that coexists with a broken `_MOC.md` index file.

package/skills/vault-sync/tests/schema-drift.test.mjs

@@ -1,133 +0,0 @@
-/**
- * schema-drift.test.mjs — Integration tests for sync-vault-schema.mjs
- *
- * Verifies that the vendored schema block in validator.mjs stays in lockstep
- * with the canonical TypeScript source. Tests run the actual script against
- * actual files — no mocks.
- *
- * Run from session-orchestrator root:
- *   pnpm exec vitest run skills/vault-sync/tests/schema-drift.test.mjs
- */
-
-import { describe, it, expect } from 'vitest';
-import { execFileSync } from 'node:child_process';
-import { readFileSync, writeFileSync, mkdirSync, rmSync, existsSync } from 'node:fs';
-import { join, dirname } from 'node:path';
-import { fileURLToPath } from 'node:url';
-import { tmpdir } from 'node:os';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-
-// Paths relative to this test file
-const SYNC_SCRIPT = join(__dirname, '../../../scripts/sync-vault-schema.mjs');
-const VALIDATOR_MJS = join(__dirname, '../validator.mjs');
-const CANONICAL = join(
-  __dirname,
-  '../../../../projects-baseline/packages/zod-schemas/src/vault-frontmatter.ts',
-);
-// Tests below shell out to sync-vault-schema.mjs, which by default reads
-// the canonical schema from a sibling projects-baseline checkout. In CI
-// (and on any contributor machine without that checkout) the canonical
-// file is absent, so we skip these integration tests. The schema-drift
-// CI stage runs the script directly against a freshly cloned canonical.
-const HAS_CANONICAL = existsSync(CANONICAL);
-
-const SENTINEL_BEGIN = 'BEGIN GENERATED SCHEMA';
-const SENTINEL_END = 'END GENERATED SCHEMA';
-
-/**
- * Run sync-vault-schema.mjs with given args.
- * Returns { status, stdout, stderr }.
- * Never throws — captures non-zero exits via try/catch.
- */
-function runScript(args = []) {
-  try {
-    const stdout = execFileSync(process.execPath, [SYNC_SCRIPT, ...args], {
-      encoding: 'utf-8',
-      stdio: ['ignore', 'pipe', 'pipe'],
-    });
-    return { status: 0, stdout, stderr: '' };
-  } catch (err) {
-    return {
-      status: err.status ?? 1,
-      stdout: err.stdout ?? '',
-      stderr: err.stderr ?? '',
-    };
-  }
-}
-
-describe.skipIf(!HAS_CANONICAL)('sync-vault-schema.mjs', () => {
-  it('idempotency — running --write twice produces no diff between runs', () => {
-    // Read validator.mjs before any writes
-    const before = readFileSync(VALIDATOR_MJS, 'utf-8');
-
-    // First --write
-    const first = runScript(['--write']);
-    expect(first.status, `first --write failed: ${first.stderr}`).toBe(0);
-
-    // Read after first write
-    const afterFirst = readFileSync(VALIDATOR_MJS, 'utf-8');
-    expect(afterFirst).toBe(before);
-
-    // Second --write
-    const second = runScript(['--write']);
-    expect(second.status, `second --write failed: ${second.stderr}`).toBe(0);
-
-    // Read after second write
-    const afterSecond = readFileSync(VALIDATOR_MJS, 'utf-8');
-    expect(afterSecond).toBe(before);
-  });
-
-  it('check-mode-clean — --check exits 0 when canonical and vendored are in sync', () => {
-    const result = runScript(['--check']);
-    expect(result.status, `--check failed unexpectedly: ${result.stderr}`).toBe(0);
-    expect(result.stdout).toContain('no drift');
-  });
-
-  it('check-mode-detects-drift — --check exits 1 with diff when canonical differs', () => {
-    // Build a temporary fake canonical with a different max for the id field
-    const rand = Math.random().toString(36).slice(2);
-    const tmpDir = join(tmpdir(), `sync-vault-schema-test-${rand}`);
-    mkdirSync(tmpDir, { recursive: true });
-    const fakeCanonical = join(tmpDir, 'vault-frontmatter.ts');
-
-    // Read the real canonical and alter it: change .max(128) to .max(256) for id
-    const realCanonical = readFileSync(CANONICAL, 'utf-8');
-    const altered = realCanonical.replace('.max(128)', '.max(256)');
-    writeFileSync(fakeCanonical, altered, 'utf-8');
-
-    try {
-      const result = runScript(['--check', '--canonical', fakeCanonical]);
-      expect(result.status, 'expected exit 1 for drift').toBe(1);
-      // Diff should mention the changed value
-      expect(result.stderr).toMatch(/256|drift/);
-    } finally {
-      rmSync(tmpDir, { recursive: true, force: true });
-    }
-  });
-
-  it('failure-mode-missing-canonical — exits 2 with clear message when canonical not found', () => {
-    const rand = Math.random().toString(36).slice(2);
-    const fakePath = join(tmpdir(), `does-not-exist-${rand}.ts`);
-
-    const result = runScript(['--check', '--canonical', fakePath]);
-    expect(result.status, 'expected exit 2 for missing file').toBe(2);
-    expect(result.stderr).toContain(fakePath);
-  });
-
-  it('sentinel-presence — validator.mjs contains both sentinel markers exactly once in correct order', () => {
-    const content = readFileSync(VALIDATOR_MJS, 'utf-8');
-
-    // Count occurrences
-    const beginCount = (content.match(/BEGIN GENERATED SCHEMA/g) ?? []).length;
-    const endCount = (content.match(/END GENERATED SCHEMA/g) ?? []).length;
-
-    expect(beginCount, 'BEGIN GENERATED SCHEMA must appear exactly once').toBe(1);
-    expect(endCount, 'END GENERATED SCHEMA must appear exactly once').toBe(1);
-
-    // BEGIN must appear before END
-    const beginPos = content.indexOf(SENTINEL_BEGIN);
-    const endPos = content.indexOf(SENTINEL_END);
-    expect(beginPos, 'BEGIN sentinel must appear before END sentinel').toBeLessThan(endPos);
-  });
-});

package/templates/_shared/rules/parallel-sessions.md

@@ -1,77 +0,0 @@
-# Parallel Session Awareness (Always-on)
-
-Multiple Claude Code sessions may be active in the same working directory simultaneously. Another agent may be editing files, creating commits, or running builds right now. Treat the repo as a shared workspace, not a private sandbox.
-
-## PSA Scope Axes — Operator-Session vs In-Run
-
-PSA rules span two distinct axes. Naming them keeps the durable moat clear when
-native multi-agent primitives (the experimental `CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS`)
-overlap parts of this surface.
-
-- **Operator-session axis (the durable moat):** independent parallel operator /
-  Claude sessions in the **same working copy**. PSA-001..004, plus the per-repo
-  session lock (`scripts/lib/session-lock.mjs` `acquire()` / `session.lock`,
-  heartbeat-liveness schema v2), guard this domain. **Agent Teams structurally
-  cannot enter it** — Teams is per-process / in-run only ("one team per
-  session"), NOT per-repo. Its graduation to native affects **only the in-run
-  multi-agent coordination slice**, never the operator-session slice.
-- **In-run axis:** multiple agents coordinated inside a single session/run. Even
-  here our own machinery remains necessary because Agent Teams provides **no
-  automatic isolation**: file-scope deconfliction (`skills/session-plan/SKILL.md` —
-  "verify that NO two agents in the same wave modify the same file") plus
-  `withStateMdLock` STATE.md serialization still do the work Teams does not.
-
-PSA-005 spans **both** axes; only its session-lock half is purely
-operator-scoped. PSA-006 is **orthogonal** to both (Discovery grep-discipline).
-See ADR-0010 § Native-Overlap Refresh (Agent Teams = Adapter; PSA re-scoped).
-
-## Recognizing Parallel Work (PSA-001: Detect Before Acting)
-
-*Axis: operator-session safety — the durable moat Agent Teams structurally cannot enter (per-process / in-run only).*
-
-- **Unexpected git status changes:** Files modified or staged that are not part of your current task likely belong to another session.
-- **Unfamiliar commits:** New entries in `git log` that you did not create mean another agent (or the user manually) committed work.
-- **Spontaneous errors:** Build failures, type errors, or test failures in code you did not touch may be in-progress work from another session — not pre-existing bugs.
-- **Files changed between reads:** If a file's content differs from what you read moments ago, another session likely edited it.
-- **New untracked files:** Files appearing in `git status` that you did not create belong to someone else's work.
-
-## Behavioral Guidance (PSA-002: Ask, Don't Assume)
-
-*Axis: operator-session safety — the durable moat Agent Teams structurally cannot enter (per-process / in-run only).*
-
-- **When you detect signs of parallel work, stop and ask the user:** "I notice changes I didn't make (e.g., modified files in git status, new commits). Is another session active?"
-- **Never "fix" code outside your task scope.** Errors in files you are not working on may be intentional intermediate states from another session.
-- **Stay in your lane.** Only read, create, modify, and delete files directly relevant to your assigned task.
-- **If blocked by external changes, ask the user** rather than reverting, resetting, or working around them.
-- **Track your own footprint.** Be aware of which files you have created or modified. Your commits should contain only your changes.
-
-## Destructive Action Safeguards (PSA-003: Never Destroy What You Didn't Create)
-
-*Axis: operator-session safety — the durable moat Agent Teams structurally cannot enter (per-process / in-run only).*
-
-These commands require explicit user confirmation even in normal operation. When parallel work is suspected, they are **forbidden** without user approval:
-- **`git reset` (any form)** — destroys staged or committed work that may belong to another session.
-- **`git checkout -- <file>`** — discards uncommitted changes another session is actively building.
-- **`git clean -f`** — deletes untracked files another session created.
-- **`git stash`** — captures another session's changes into a stash they cannot find.
-- **`rm` / delete of files you did not create** — may remove work-in-progress from another session.
-- **`git revert` of commits you did not make** — undoes another session's completed work.
-- **`git push --force`** — rewrites shared history (dangerous even without parallel sessions).
-
-Before running any of the above, ask: "Did I create this file/commit/change? If not, it is not mine to touch."
-
-## Commit Discipline (PSA-004: Isolate Your Changes)
-
-*Axis: operator-session safety — the durable moat Agent Teams structurally cannot enter (per-process / in-run only).*
-
-- **Stage files individually** (`git add <file>`) rather than `git add .` or `git add -A`, which may sweep in another session's work.
-- **Review `git diff --cached` before committing** to verify every staged change is yours.
-- **If you see unfamiliar changes in the diff, unstage them** and ask the user.
-- **Never amend a commit you did not create.**
-
-## Anti-Patterns
-- Seeing unfamiliar changes and assuming they are "leftover mess" to clean up — they are likely active work.
-- Running `git reset --hard` to "start fresh" — this destroys all uncommitted work across all sessions.
-- Fixing type errors or lint issues in files outside your scope — the other session will handle their own files.
-- Using `git add .` in a shared workspace — you will commit another session's partial work.
-- Reverting "broken" commits without asking — another session may have intentionally pushed incremental progress.