serverless-ircd 0.8.0 → 0.10.0

package/packages/irc-core/tests/commands/nickserv.test.ts

@@ -283,6 +283,144 @@ describe('nickservReducer — IDENTIFY', () => {
   });
 });
 
+describe('nickservReducer — ID (alias for IDENTIFY)', () => {
+  it('sets +r and account on correct password (ID <password>)', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('ID hunter2'), ctx);
+
+    expect(conn.account).toBe('alice');
+    expect(conn.userModes.registered).toBe(true);
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :You are now identified for nick alice.',
+    );
+  });
+
+  it('is case-insensitive on the subcommand (id)', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    const ctx = makeCtx(conn, services);
+
+    nickservReducer(conn, privmsg('id hunter2'), ctx);
+
+    expect(conn.account).toBe('alice');
+    expect(conn.userModes.registered).toBe(true);
+  });
+
+  it('rejects ID with wrong password (no +r, NOTICE only)', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('ID wrongpw'), ctx);
+
+    expect(conn.account).toBeUndefined();
+    expect(conn.userModes.registered).toBe(false);
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Invalid password.',
+    );
+    expect(out.effects.filter((e) => e.tag === 'Broadcast')).toHaveLength(0);
+  });
+
+  it('sets +r and account for ID <nick> <password>', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    // Connection is using nick "bob" but identifies as "alice".
+    const conn = makeConn('c1', 'bob');
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('ID alice hunter2'), ctx);
+
+    expect(conn.account).toBe('alice');
+    expect(conn.userModes.registered).toBe(true);
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE bob :You are now identified for nick alice.',
+    );
+  });
+});
+
+// ============================================================================
+// IDENTIFY — HostServ vhost auto-apply on identify
+// ============================================================================
+
+describe('nickservReducer — IDENTIFY applies HostServ vhost', () => {
+  it('applies an assigned vhost on a successful IDENTIFY', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.setVhost('alice', 'cool.example.net');
+    const conn = makeConn();
+    conn.host = 'real.example.net';
+    const ctx = makeCtx(conn, services);
+
+    nickservReducer(conn, privmsg('IDENTIFY hunter2'), ctx);
+
+    expect(conn.account).toBe('alice');
+    expect(conn.vhostActive).toBe(true);
+    expect(conn.host).toBe('cool.example.net');
+    expect(conn.preVhostHost).toBe('real.example.net');
+  });
+
+  it('leaves the host unchanged on IDENTIFY when no vhost is assigned', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.host = 'real.example.net';
+    const ctx = makeCtx(conn, services);
+
+    nickservReducer(conn, privmsg('IDENTIFY hunter2'), ctx);
+
+    expect(conn.vhostActive).toBeUndefined();
+    expect(conn.host).toBe('real.example.net');
+  });
+
+  it('emits a CHGHOST broadcast to joined peers on a post-JOIN IDENTIFY', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.setVhost('alice', 'cool.example.net');
+    const conn = makeConn();
+    conn.user = 'aliceuser';
+    conn.host = 'real.example.net';
+    conn.joinedChannels.add('#foo');
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('IDENTIFY hunter2'), ctx);
+
+    const chghost = out.effects.filter((e) => e.tag === 'Broadcast' && e.cap === 'chghost');
+    expect(chghost).toHaveLength(1);
+    if (chghost[0]?.tag === 'Broadcast') {
+      expect(chghost[0].chan).toBe('#foo');
+      expect(chghost[0].capLines?.[0]?.text).toBe(
+        ':alice!aliceuser@real.example.net CHGHOST aliceuser :cool.example.net',
+      );
+    }
+  });
+
+  it('still emits the NickServ confirmation NOTICE and ACCOUNT broadcast alongside the vhost apply', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.setVhost('alice', 'cool.example.net');
+    const conn = makeConn();
+    conn.host = 'real.example.net';
+    conn.joinedChannels.add('#foo');
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('IDENTIFY hunter2'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :You are now identified for nick alice.',
+    );
+    const accountBcast = out.effects.find(
+      (e) => e.tag === 'Broadcast' && e.cap === 'account-notify',
+    );
+    expect(accountBcast).toBeDefined();
+  });
+});
+
 describe('nickservReducer — DROP', () => {
   it('removes the registration when the connection is identified', () => {
     const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
@@ -364,10 +502,11 @@ describe('nickservReducer — DROP', () => {
 });
 
 describe('nickservReducer — INFO', () => {
-  it('reports info for a registered nick', () => {
+  it('shows the full record (incl. Email) to the owner via INFO with no target', () => {
     const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
     services.registerNick('alice', 'hunter2', 'alice@example.com');
     const conn = makeConn();
+    conn.account = 'alice';
     const ctx = makeCtx(conn, services);
 
     const out = nickservReducer(conn, privmsg('INFO'), ctx);
@@ -378,10 +517,54 @@ describe('nickservReducer — INFO', () => {
     expect(texts).toContain(':NickServ!NickServ@services NOTICE alice :Email: alice@example.com');
   });
 
-  it('reports info for an explicitly named registered nick', () => {
+  it('withholds Email from a non-owner querying someone else nick', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('bob', 'pw', 'bob@example.com');
+    const conn = makeConn();
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('INFO bob'), ctx);
+
+    const texts = sentTexts(out.effects);
+    expect(texts).toContain(':NickServ!NickServ@services NOTICE alice :Nick: bob');
+    expect(texts).toContain(':NickServ!NickServ@services NOTICE alice :Account: bob');
+    expect(texts).not.toContain(':NickServ!NickServ@services NOTICE alice :Email: bob@example.com');
+  });
+
+  it('withholds Email from a non-owner querying their own nick when unidentified', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('INFO'), ctx);
+
+    const texts = sentTexts(out.effects);
+    expect(texts).toContain(':NickServ!NickServ@services NOTICE alice :Nick: alice');
+    expect(texts).not.toContain(
+      ':NickServ!NickServ@services NOTICE alice :Email: alice@example.com',
+    );
+  });
+
+  it('shows Email to the owner querying their own nick by name', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('bob', 'pw', 'bob@example.com');
+    const conn = makeConn('c1', 'bob');
+    conn.account = 'bob';
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('INFO bob'), ctx);
+
+    const texts = sentTexts(out.effects);
+    expect(texts).toContain(':NickServ!NickServ@services NOTICE bob :Nick: bob');
+    expect(texts).toContain(':NickServ!NickServ@services NOTICE bob :Email: bob@example.com');
+  });
+
+  it('shows Email to an oper even when not the owner', () => {
     const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
     services.registerNick('bob', 'pw', 'bob@example.com');
     const conn = makeConn();
+    conn.userModes.oper = true;
     const ctx = makeCtx(conn, services);
 
     const out = nickservReducer(conn, privmsg('INFO bob'), ctx);
@@ -439,7 +622,7 @@ describe('nickservReducer — misc', () => {
     const out = nickservReducer(conn, privmsg('FROBNICATE foo bar'), ctx);
 
     expect(sentTexts(out.effects)).toContain(
-      ':NickServ!NickServ@services NOTICE alice :Unknown command. Available: REGISTER, IDENTIFY, DROP, INFO, SET',
+      ':NickServ!NickServ@services NOTICE alice :Unknown command. Available: REGISTER, IDENTIFY, DROP, INFO, SET (ENFORCE, PASSWORD)',
     );
   });
 
@@ -674,6 +857,242 @@ describe('nickservReducer — SET ENFORCE', () => {
   });
 });
 
+// ============================================================================
+// SET PASSWORD
+// ============================================================================
+
+describe('nickservReducer — SET PASSWORD', () => {
+  it('changes the password when the caller supplies the correct old one', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('SET PASSWORD hunter2 newpassword'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Password changed.',
+    );
+    // The new password verifies, the old one no longer does.
+    expect(services.verifyNick('alice', 'newpassword').ok).toBe(true);
+    expect(services.verifyNick('alice', 'hunter2').ok).toBe(false);
+  });
+
+  it('rejects a wrong old password and leaves the credential unchanged', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('SET PASSWORD wrongold newpassword'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Invalid password.',
+    );
+    // The original password still verifies; the new one does not.
+    expect(services.verifyNick('alice', 'hunter2').ok).toBe(true);
+    expect(services.verifyNick('alice', 'newpassword').ok).toBe(false);
+  });
+
+  it('requires identification before SET PASSWORD (unidentified caller)', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    // No account / +r.
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('SET PASSWORD hunter2 newpassword'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :You must identify before changing your password.',
+    );
+    // Credential unchanged.
+    expect(services.verifyNick('alice', 'hunter2').ok).toBe(true);
+    expect(services.verifyNick('alice', 'newpassword').ok).toBe(false);
+  });
+
+  it('rejects SET PASSWORD when identified as a different account', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    // bob is identified, but is using alice's nick.
+    services.registerNick('bob', 'bobpw', 'bob@example.com');
+    const conn = makeConn('c1', 'alice');
+    conn.account = 'bob';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('SET PASSWORD hunter2 newpassword'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :You must identify before changing your password.',
+    );
+    // Credential unchanged.
+    expect(services.verifyNick('alice', 'hunter2').ok).toBe(true);
+    expect(services.verifyNick('alice', 'newpassword').ok).toBe(false);
+  });
+
+  it('emits the syntax notice when args are missing', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const noArgs = nickservReducer(conn, privmsg('SET PASSWORD'), ctx);
+    expect(sentTexts(noArgs.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Syntax: SET PASSWORD <old-password> <new-password>',
+    );
+
+    const oneArg = nickservReducer(conn, privmsg('SET PASSWORD only-one'), ctx);
+    expect(sentTexts(oneArg.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Syntax: SET PASSWORD <old-password> <new-password>',
+    );
+    // Credential unchanged.
+    expect(services.verifyNick('alice', 'hunter2').ok).toBe(true);
+  });
+
+  it('rejects a new password shorter than the default minimum (8)', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('SET PASSWORD hunter2 short'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Password is too short (minimum 8 characters).',
+    );
+    // Credential unchanged.
+    expect(services.verifyNick('alice', 'hunter2').ok).toBe(true);
+    expect(services.verifyNick('alice', 'short').ok).toBe(false);
+  });
+
+  it('honours a configured nickServ.minPasswordLength override', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx: Ctx = buildCtx({
+      serverConfig: { ...serverConfig, nickServ: { minPasswordLength: 12 } },
+      clock: new FakeClock(NOW),
+      ids: new SequentialIdFactory(),
+      motd: EmptyMotdProvider,
+      connection: conn,
+      services,
+    });
+
+    const out = nickservReducer(conn, privmsg('SET PASSWORD hunter2 elevenchars'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Password is too short (minimum 12 characters).',
+    );
+    // Credential unchanged.
+    expect(services.verifyNick('alice', 'hunter2').ok).toBe(true);
+  });
+
+  it('rejects a new password longer than the maximum (256)', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const tooLong = 'x'.repeat(257);
+    const out = nickservReducer(conn, privmsg(`SET PASSWORD hunter2 ${tooLong}`), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Password is too long (maximum 256 characters).',
+    );
+    // Credential unchanged.
+    expect(services.verifyNick('alice', 'hunter2').ok).toBe(true);
+  });
+
+  it('keeps the session +r after a successful change (no re-identify required)', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    nickservReducer(conn, privmsg('SET PASSWORD hunter2 newpassword'), ctx);
+
+    expect(conn.userModes.registered).toBe(true);
+    expect(conn.account).toBe('alice');
+  });
+
+  it('accepts a new password exactly at the minimum length boundary (8)', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('SET PASSWORD hunter2 exactly8'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Password changed.',
+    );
+    expect(services.verifyNick('alice', 'exactly8').ok).toBe(true);
+  });
+
+  it('accepts a new password exactly at the maximum length boundary (256)', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const boundary = 'x'.repeat(256);
+    const out = nickservReducer(conn, privmsg(`SET PASSWORD hunter2 ${boundary}`), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Password changed.',
+    );
+    expect(services.verifyNick('alice', boundary).ok).toBe(true);
+  });
+
+  it('is case-insensitive on the PASSWORD subkey', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('set password hunter2 newpassword'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Password changed.',
+    );
+  });
+
+  it('rejects SET PASSWORD on an unregistered nick', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = nickservReducer(conn, privmsg('SET PASSWORD hunter2 newpassword'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':NickServ!NickServ@services NOTICE alice :Nick alice is not registered.',
+    );
+  });
+});
+
 // ============================================================================
 // enforceRegisteredNick — the enforcement hook fired by the NICK path
 // ============================================================================

package/packages/irc-core/tests/commands/oper.test.ts

@@ -81,6 +81,21 @@ describe('operReducer — successful authentication', () => {
     expect(modeLines).toContain(':alice!alice@example.com MODE alice +o');
   });
 
+  it('falls back to ? / * in the MODE echo when the connection has no nick or hostmask', () => {
+    // A bare connection with no nick/user/host: hostmaskOf returns undefined
+    // and state.nick is undefined, so modeEchoLine falls back to '?' / '*'.
+    const state = createConnection({ id: 'c1', connectedSince: 0 });
+    const ctx = makeCtx(state);
+
+    const out = operReducer(state, oper('alice', 'secret'), ctx);
+
+    expect(out.state.userModes.oper).toBe(true);
+    const modeLines = out.effects
+      .filter((e): e is Extract<EffectType, { tag: 'Send' }> => e.tag === 'Send')
+      .flatMap((e) => e.lines.map((l) => l.text));
+    expect(modeLines).toContain(':? MODE * +o');
+  });
+
   it('matches the second configured credential pair', () => {
     const state = makeState();
     const ctx = makeCtx(state);