serverless-ircd 0.7.0 → 0.9.0

package/packages/irc-core/tests/commands/memoserv.test.ts

@@ -0,0 +1,654 @@
+import { describe, expect, it } from 'vitest';
+import { MEMOSERV_NICK, deliverUnreadMemos, memoservReducer } from '../../src/commands/memoserv';
+import type { Effect as EffectType } from '../../src/effects';
+import type { ServicesStore } from '../../src/ports';
+import {
+  EmptyMotdProvider,
+  FakeClock,
+  InMemoryServicesStore,
+  SequentialIdFactory,
+} from '../../src/ports';
+import type { IrcMessage } from '../../src/protocol/messages';
+import { type ConnectionState, createConnection } from '../../src/state/connection';
+import { type Ctx, type ServerConfig, buildCtx } from '../../src/types';
+
+const NOW = 1_700_000_000_000;
+
+const serverConfig: ServerConfig = {
+  serverName: 'irc.example.com',
+  networkName: 'ExampleNet',
+  maxChannelsPerUser: 30,
+  maxTargetsPerCommand: 10,
+  maxListEntries: 50,
+  nickLen: 30,
+  channelLen: 50,
+  topicLen: 390,
+  quitMessage: 'Client Quit',
+};
+
+function makeConn(id = 'c1', nick = 'alice'): ConnectionState {
+  const s = createConnection({ id, connectedSince: 0 });
+  s.nick = nick;
+  s.user = nick;
+  s.host = 'example.com';
+  s.realname = nick;
+  s.registration = 'registered';
+  return s;
+}
+
+function makeCtx(
+  state: ConnectionState,
+  services?: ServicesStore,
+  clock = new FakeClock(NOW),
+): Ctx {
+  return buildCtx({
+    serverConfig,
+    clock,
+    ids: new SequentialIdFactory(),
+    motd: EmptyMotdProvider,
+    connection: state,
+    ...(services !== undefined ? { services } : {}),
+  });
+}
+
+function privmsg(body: string): IrcMessage {
+  return { command: 'PRIVMSG', params: [MEMOSERV_NICK, body], tags: {} };
+}
+
+/** Extracts the text of every Send line emitted by the reducer. */
+function sentTexts(effects: EffectType[]): string[] {
+  return effects.flatMap((e) => (e.tag === 'Send' ? e.lines.map((l) => l.text) : []));
+}
+
+describe('memoservReducer — services availability', () => {
+  it('reports that services are unavailable when no store is bound', () => {
+    const conn = makeConn();
+    const ctx = makeCtx(conn);
+    const out = memoservReducer(conn, privmsg('SEND bob Hi'), ctx);
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Services are not available on this server.',
+    );
+  });
+});
+
+describe('memoservReducer — SEND', () => {
+  it('requires the sender to be identified', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('bob', 'hunter2', 'bob@example.com');
+    const conn = makeConn();
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('SEND bob Hi'), ctx);
+
+    expect(services.listMemos('bob')).toHaveLength(0);
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :You must identify before sending a memo.',
+    );
+  });
+
+  it('rejects SEND when the recipient nick is not registered', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('SEND ghost Hi'), ctx);
+
+    expect(services.listMemos('ghost')).toHaveLength(0);
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Nick ghost is not registered.',
+    );
+  });
+
+  it('records a memo against the recipient account and confirms via NOTICE', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.registerNick('bob', 'hunter2', 'bob@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('SEND bob Hi there'), ctx);
+
+    const memos = services.listMemos('bob');
+    expect(memos).toHaveLength(1);
+    expect(memos[0]).toMatchObject({
+      from: 'alice',
+      to: 'bob',
+      body: 'Hi there',
+      read: false,
+    });
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Memo sent to bob.',
+    );
+  });
+
+  it('uses the identified account as the sender, not the current nick', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.registerNick('bob', 'hunter2', 'bob@example.com');
+    const conn = makeConn();
+    conn.nick = 'Alice'; // different case from the account
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    memoservReducer(conn, privmsg('SEND bob Hi'), ctx);
+
+    expect(services.listMemos('bob')[0]?.from).toBe('alice');
+  });
+
+  it('rejects SEND with missing recipient', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('SEND'), ctx);
+
+    expect(services.listMemos('alice')).toHaveLength(0);
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Syntax: SEND <nick> <message>',
+    );
+  });
+
+  it('rejects SEND with a recipient but no body', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.registerNick('bob', 'hunter2', 'bob@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('SEND bob'), ctx);
+
+    expect(services.listMemos('bob')).toHaveLength(0);
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Syntax: SEND <nick> <message>',
+    );
+  });
+
+  it('records a memo body that contains spaces verbatim', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.registerNick('bob', 'hunter2', 'bob@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    memoservReducer(conn, privmsg('SEND bob one two three'), ctx);
+
+    expect(services.listMemos('bob')[0]?.body).toBe('one two three');
+  });
+
+  it('rejects SEND to self with a readable notice', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('SEND alice Hi me'), ctx);
+
+    expect(services.listMemos('alice')).toHaveLength(0);
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :You cannot send a memo to yourself.',
+    );
+  });
+
+  it('looks up the recipient case-insensitively', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.registerNick('bob', 'hunter2', 'bob@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    memoservReducer(conn, privmsg('SEND BoB Hi'), ctx);
+
+    expect(services.listMemos('bob')).toHaveLength(1);
+  });
+});
+
+describe('memoservReducer — LIST', () => {
+  it('requires the caller to be identified', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    const conn = makeConn();
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('LIST'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :You must identify before listing memos.',
+    );
+  });
+
+  it('reports an empty list when the account has no memos', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('LIST'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :You have no memos.',
+    );
+  });
+
+  it('lists unread memos with their id, sender and body', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.recordMemo({ from: 'bob', to: 'alice', body: 'first', sentAt: NOW });
+    services.recordMemo({ from: 'carol', to: 'alice', body: 'second', sentAt: NOW });
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('LIST'), ctx);
+
+    const texts = sentTexts(out.effects);
+    expect(texts).toContain(':MemoServ!MemoServ@services NOTICE alice :Memos:');
+    expect(texts).toContain(':MemoServ!MemoServ@services NOTICE alice :#1 bob: first');
+    expect(texts).toContain(':MemoServ!MemoServ@services NOTICE alice :#2 carol: second');
+  });
+
+  it('excludes already-read memos from the listing', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.recordMemo({ from: 'bob', to: 'alice', body: 'read', sentAt: NOW });
+    services.recordMemo({ from: 'carol', to: 'alice', body: 'unread', sentAt: NOW });
+    services.markMemoRead('alice', 1);
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('LIST'), ctx);
+
+    const texts = sentTexts(out.effects);
+    expect(texts).not.toContain(':MemoServ!MemoServ@services NOTICE alice :#1 bob: read');
+    expect(texts).toContain(':MemoServ!MemoServ@services NOTICE alice :#2 carol: unread');
+  });
+});
+
+describe('memoservReducer — READ', () => {
+  it('requires the caller to be identified', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    const conn = makeConn();
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('READ 1'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :You must identify before reading memos.',
+    );
+  });
+
+  it('delivers the targeted memo via MemoServ NOTICE and marks it read', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.recordMemo({ from: 'bob', to: 'alice', body: 'hello', sentAt: NOW });
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('READ 1'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :[Memo #1 from bob] hello',
+    );
+    expect(services.listMemos('alice')[0]?.read).toBe(true);
+  });
+
+  it('rejects READ with no number argument', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('READ'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Syntax: READ <number>',
+    );
+  });
+
+  it('rejects READ with a non-numeric argument', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('READ abc'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Syntax: READ <number>',
+    );
+  });
+
+  it('reports a missing memo by id', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('READ 42'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :No such memo #42.',
+    );
+  });
+
+  it('rejects a non-positive memo number', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('READ 0'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Syntax: READ <number>',
+    );
+  });
+});
+
+describe('memoservReducer — DEL', () => {
+  it('requires the caller to be identified', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    const conn = makeConn();
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('DEL 1'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :You must identify before deleting memos.',
+    );
+  });
+
+  it('removes the targeted memo and confirms via NOTICE', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.recordMemo({ from: 'bob', to: 'alice', body: 'bye', sentAt: NOW });
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('DEL 1'), ctx);
+
+    expect(services.listMemos('alice')).toEqual([]);
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Deleted memo #1.',
+    );
+  });
+
+  it('rejects DEL with no number argument', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('DEL'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Syntax: DEL <number>',
+    );
+  });
+
+  it('rejects DEL with a non-numeric argument', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('DEL foo'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Syntax: DEL <number>',
+    );
+  });
+
+  it('reports a missing memo by id', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('DEL 9'), ctx);
+
+    expect(services.listMemos('alice')).toEqual([]);
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :No such memo #9.',
+    );
+  });
+});
+
+describe('memoservReducer — misc', () => {
+  it('emits a help NOTICE on an empty body', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg(''), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Available commands: SEND, LIST, READ, DEL',
+    );
+  });
+
+  it('emits an unknown-command NOTICE for an unrecognized subcommand', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('FROBNICATE'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :Unknown command. Available: SEND, LIST, READ, DEL',
+    );
+  });
+
+  it('treats subcommand keywords case-insensitively', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.registerNick('bob', 'hunter2', 'bob@example.com');
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    memoservReducer(conn, privmsg('send bob Hi'), ctx);
+
+    expect(services.listMemos('bob')).toHaveLength(1);
+  });
+
+  it('updates lastSeen on the connection', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    conn.lastSeen = 0;
+    const ctx = makeCtx(conn, services);
+
+    memoservReducer(conn, privmsg('LIST'), ctx);
+
+    expect(conn.lastSeen).toBe(NOW);
+  });
+
+  it('uses the connection nick in the NOTICE target when no nick is set', () => {
+    const conn = makeConn();
+    // biome-ignore lint/performance/noDelete: exactOptionalPropertyTypes forbids `= undefined`.
+    delete conn.nick;
+    const ctx = makeCtx(conn);
+
+    const out = memoservReducer(conn, privmsg('LIST'), ctx);
+
+    expect(sentTexts(out.effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE * :Services are not available on this server.',
+    );
+  });
+});
+
+describe('MEMOSERV_NICK constant', () => {
+  it('equals MemoServ', () => {
+    expect(MEMOSERV_NICK).toBe('MemoServ');
+  });
+});
+
+describe('deliverUnreadMemos', () => {
+  it('delivers every unread memo for the account as MemoServ NOTICEs', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.recordMemo({ from: 'bob', to: 'alice', body: 'first', sentAt: NOW });
+    services.recordMemo({ from: 'carol', to: 'alice', body: 'second', sentAt: NOW });
+    const conn = makeConn();
+    const effects: EffectType[] = [];
+
+    deliverUnreadMemos(conn, services, 'alice', effects);
+
+    const texts = sentTexts(effects);
+    expect(texts).toContain(':MemoServ!MemoServ@services NOTICE alice :[Memo #1 from bob] first');
+    expect(texts).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :[Memo #2 from carol] second',
+    );
+  });
+
+  it('marks each delivered memo as read', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.recordMemo({ from: 'bob', to: 'alice', body: 'first', sentAt: NOW });
+    services.recordMemo({ from: 'carol', to: 'alice', body: 'second', sentAt: NOW });
+    const conn = makeConn();
+    const effects: EffectType[] = [];
+
+    deliverUnreadMemos(conn, services, 'alice', effects);
+
+    const memos = services.listMemos('alice');
+    expect(memos[0]?.read).toBe(true);
+    expect(memos[1]?.read).toBe(true);
+  });
+
+  it('skips memos that are already read', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.recordMemo({ from: 'bob', to: 'alice', body: 'read', sentAt: NOW });
+    services.recordMemo({ from: 'carol', to: 'alice', body: 'unread', sentAt: NOW });
+    services.markMemoRead('alice', 1);
+    const conn = makeConn();
+    const effects: EffectType[] = [];
+
+    deliverUnreadMemos(conn, services, 'alice', effects);
+
+    const texts = sentTexts(effects);
+    expect(texts).toHaveLength(1);
+    expect(texts[0]).toBe(':MemoServ!MemoServ@services NOTICE alice :[Memo #2 from carol] unread');
+  });
+
+  it('emits no effects when the account has no memos', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    const conn = makeConn();
+    const effects: EffectType[] = [];
+
+    deliverUnreadMemos(conn, services, 'ghost', effects);
+
+    expect(effects).toEqual([]);
+  });
+
+  it('looks up the recipient case-insensitively', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.recordMemo({ from: 'bob', to: 'alice', body: 'folded', sentAt: NOW });
+    const conn = makeConn();
+    const effects: EffectType[] = [];
+
+    deliverUnreadMemos(conn, services, 'ALICE', effects);
+
+    expect(sentTexts(effects)).toContain(
+      ':MemoServ!MemoServ@services NOTICE alice :[Memo #1 from bob] folded',
+    );
+  });
+
+  it('delivers memos in storage order (oldest-first)', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.recordMemo({ from: 'bob', to: 'alice', body: 'one', sentAt: NOW });
+    services.recordMemo({ from: 'carol', to: 'alice', body: 'two', sentAt: NOW });
+    services.recordMemo({ from: 'dave', to: 'alice', body: 'three', sentAt: NOW });
+    const conn = makeConn();
+    const effects: EffectType[] = [];
+
+    deliverUnreadMemos(conn, services, 'alice', effects);
+
+    const ids = sentTexts(effects).map((t) => t.match(/#(\d+)/u)?.[1]);
+    expect(ids).toEqual(['1', '2', '3']);
+  });
+
+  it('addresses the NOTICE to the connection nick', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.recordMemo({ from: 'bob', to: 'alice', body: 'hi', sentAt: NOW });
+    const conn = makeConn('c1', 'Alice');
+    const effects: EffectType[] = [];
+
+    deliverUnreadMemos(conn, services, 'alice', effects);
+
+    expect(sentTexts(effects)[0]).toContain('NOTICE Alice :');
+  });
+});
+
+describe('memoservReducer — Effect construction', () => {
+  it('emits Send effects addressed to the invoking connection', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    const conn = makeConn('c7');
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    const out = memoservReducer(conn, privmsg('LIST'), ctx);
+
+    expect(out.effects.every((e) => e.tag !== 'Send' || e.to === 'c7')).toBe(true);
+  });
+
+  it('does not mutate services state for read-only commands', () => {
+    const services = new InMemoryServicesStore({ clock: new FakeClock(NOW) });
+    services.registerNick('alice', 'hunter2', 'alice@example.com');
+    services.recordMemo({ from: 'bob', to: 'alice', body: 'persisted', sentAt: NOW });
+    const conn = makeConn();
+    conn.account = 'alice';
+    conn.userModes.registered = true;
+    const ctx = makeCtx(conn, services);
+
+    memoservReducer(conn, privmsg('LIST'), ctx);
+
+    expect(services.listMemos('alice')).toHaveLength(1);
+    expect(services.listMemos('alice')[0]?.read).toBe(false);
+  });
+});