serverless-ircd 0.3.0 → 0.5.0

package/packages/aws-adapter/tests/disconnect-fanout.test.ts

@@ -19,15 +19,11 @@ import {
   createConnection,
 } from '@serverless-ircd/irc-core';
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-import { AwsRuntime, cleanupConnection, type PostToConnection } from '../src/aws-runtime.js';
-import { handleDisconnect } from '../src/handlers/disconnect.js';
-import {
-  type HandlerDeps,
-  __resetHandlerCacheForTests,
-  dispatch,
-} from '../src/handlers/index.js';
+import { AwsRuntime, type PostToConnection, cleanupConnection } from '../src/aws-runtime.js';
 import { TABLE_DEFS } from '../src/cdk-table-defs.js';
 import { createDynamoDocumentClient } from '../src/dynamo.js';
+import { handleDisconnect } from '../src/handlers/disconnect.js';
+import { type HandlerDeps, __resetHandlerCacheForTests, dispatch } from '../src/handlers/index.js';
 import { marshalChannelMember, marshalConnection, marshalNick } from '../src/serialize.js';
 import type { TablesConfig } from '../src/tables.js';
 
@@ -49,6 +45,11 @@ interface Fixture {
 
 let fx: Fixture | null;
 
+function requireFx(): Fixture {
+  if (!fx) throw new Error('test fixture not initialized');
+  return fx;
+}
+
 async function makeFixture(): Promise<Fixture> {
   if (endpoint === undefined) throw new Error('DYNAMO_ENDPOINT missing');
   const prefix = `q${Date.now()}-${Math.floor(Math.random() * 1e6)}-`;
@@ -182,13 +183,13 @@ describe.skipIf(!available)('$disconnect QUIT fanout', () => {
   });
 
   it('handleDisconnect fans the QUIT line out to every other channel member', async () => {
-    await seedConnection(fx!.client, fx!.tables, 'a', 'alice', '#room');
-    await seedConnection(fx!.client, fx!.tables, 'b', 'bob', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'a', 'alice', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'b', 'bob', '#room');
 
     const mgmt = new RecordingPostToConnection();
     await handleDisconnect({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connectionId: 'a',
       managementApi: mgmt,
     });
@@ -201,14 +202,14 @@ describe.skipIf(!available)('$disconnect QUIT fanout', () => {
   });
 
   it('handleDisconnect without a managementApi performs no fanout but still cleans up', async () => {
-    await seedConnection(fx!.client, fx!.tables, 'a', 'alice', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'a', 'alice', '#room');
     await handleDisconnect({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connectionId: 'a',
       managementApi: null,
     });
-    const p = probe(fx!.client, fx!.tables);
+    const p = probe(requireFx().client, requireFx().tables);
     expect(await p.getConnectionInfo('a')).toBeNull();
     expect(await p.lookupNick('alice' as Nick)).toBeNull();
   });
@@ -216,8 +217,8 @@ describe.skipIf(!available)('$disconnect QUIT fanout', () => {
   it('a never-registered connection disconnects without fanout (no nick)', async () => {
     const mgmt = new RecordingPostToConnection();
     await handleDisconnect({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connectionId: 'nobody',
       managementApi: mgmt,
     });
@@ -225,43 +226,43 @@ describe.skipIf(!available)('$disconnect QUIT fanout', () => {
   });
 
   it('fanout to a gone peer triggers lazy cleanup instead of crashing', async () => {
-    await seedConnection(fx!.client, fx!.tables, 'a', 'alice', '#room');
-    await seedConnection(fx!.client, fx!.tables, 'b', 'bob', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'a', 'alice', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'b', 'bob', '#room');
 
     const mgmt = new RecordingPostToConnection();
     mgmt.markGone('b');
 
     await expect(
       handleDisconnect({
-        dynamo: fx!.client,
-        tables: fx!.tables,
+        dynamo: requireFx().client,
+        tables: requireFx().tables,
         connectionId: 'a',
         managementApi: mgmt,
       }),
     ).resolves.toBeUndefined();
 
     // The gone peer b was lazily cleaned up (Connection row removed).
-    const p = probe(fx!.client, fx!.tables);
+    const p = probe(requireFx().client, requireFx().tables);
     expect(await p.getConnectionInfo('b')).toBeNull();
   });
 
   it('cleanupConnection directly broadcasts QUIT when given a managementApi', async () => {
-    await seedConnection(fx!.client, fx!.tables, 'a', 'alice', '#room');
-    await seedConnection(fx!.client, fx!.tables, 'b', 'bob', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'a', 'alice', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'b', 'bob', '#room');
 
     const mgmt = new RecordingPostToConnection();
-    await cleanupConnection(fx!.client, fx!.tables, 'a', mgmt);
+    await cleanupConnection(requireFx().client, requireFx().tables, 'a', mgmt);
 
     const bobReceived = mgmt.sent.get('b') ?? [];
     expect(bobReceived).toContain(':alice!alice@x QUIT :Client Quit');
-    const p = probe(fx!.client, fx!.tables);
+    const p = probe(requireFx().client, requireFx().tables);
     expect(await p.getConnectionInfo('a')).toBeNull();
   });
 
   it('the $disconnect dispatch route fans QUIT out to peers via the management API', async () => {
     const deps: HandlerDeps = {
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       serverConfig: SERVER_CONFIG,
       motd: new StaticMotdProvider([]),
       messages: { record() {}, query: () => Promise.resolve([]) } as never,
@@ -273,11 +274,17 @@ describe.skipIf(!available)('$disconnect QUIT fanout', () => {
     await dispatch({ requestContext: { routeKey: '$connect', connectionId: 'a' } }, deps);
     await dispatch({ requestContext: { routeKey: '$connect', connectionId: 'b' } }, deps);
     await dispatch(
-      { requestContext: { routeKey: '$default', connectionId: 'a' }, body: 'NICK alice\r\nUSER alice 0 * :Alice\r\nJOIN #room\r\n' },
+      {
+        requestContext: { routeKey: '$default', connectionId: 'a' },
+        body: 'NICK alice\r\nUSER alice 0 * :Alice\r\nJOIN #room\r\n',
+      },
       deps,
     );
     await dispatch(
-      { requestContext: { routeKey: '$default', connectionId: 'b' }, body: 'NICK bob\r\nUSER bob 0 * :Bob\r\nJOIN #room\r\n' },
+      {
+        requestContext: { routeKey: '$default', connectionId: 'b' },
+        body: 'NICK bob\r\nUSER bob 0 * :Bob\r\nJOIN #room\r\n',
+      },
       deps,
     );
     mgmt.sent.clear();
@@ -289,18 +296,18 @@ describe.skipIf(!available)('$disconnect QUIT fanout', () => {
     expect(bobReceived.some((l) => /^:alice!alice\S* QUIT :/.test(l))).toBe(true);
   });
 
-  it('the send() GoneException cleanup path also broadcasts QUIT to the gone peer\'s channels', async () => {
+  it("the send() GoneException cleanup path also broadcasts QUIT to the gone peer's channels", async () => {
     // alice and carol share #room; bob shares a different channel with carol.
-    await seedConnection(fx!.client, fx!.tables, 'alice', 'alice', '#room');
-    await seedConnection(fx!.client, fx!.tables, 'carol', 'carol', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'alice', 'alice', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'carol', 'carol', '#room');
 
     // A management double where alice is "gone" (raises GoneException).
     const mgmt = new RecordingPostToConnection();
     mgmt.markGone('alice');
 
     const runtime = new AwsRuntime({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connId: 'carol',
       handlers: { send: () => {}, disconnect: () => {}, snapshot: () => undefined },
       managementApi: mgmt,
@@ -313,21 +320,21 @@ describe.skipIf(!available)('$disconnect QUIT fanout', () => {
     const carolReceived = mgmt.sent.get('carol') ?? [];
     expect(carolReceived.some((l) => l.startsWith(':alice!alice@x QUIT :'))).toBe(true);
     // alice was cleaned up.
-    const p = probe(fx!.client, fx!.tables);
+    const p = probe(requireFx().client, requireFx().tables);
     expect(await p.getConnectionInfo('alice')).toBeNull();
   });
 
   it('fanout to a peer that throws a non-Gone error rethrows (no silent swallow)', async () => {
-    await seedConnection(fx!.client, fx!.tables, 'a', 'alice', '#room');
-    await seedConnection(fx!.client, fx!.tables, 'b', 'bob', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'a', 'alice', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'b', 'bob', '#room');
 
     const mgmt = new RecordingPostToConnection();
     mgmt.markError('b', new Error('transient network failure'));
 
     await expect(
       handleDisconnect({
-        dynamo: fx!.client,
-        tables: fx!.tables,
+        dynamo: requireFx().client,
+        tables: requireFx().tables,
         connectionId: 'a',
         managementApi: mgmt,
       }),

package/packages/aws-adapter/tests/gone-exception.test.ts

@@ -42,6 +42,11 @@ interface Fixture {
 
 let fx: Fixture | null;
 
+function requireFx(): Fixture {
+  if (!fx) throw new Error('test fixture not initialized');
+  return fx;
+}
+
 async function makeFixture(): Promise<Fixture> {
   if (endpoint === undefined) throw new Error('DYNAMO_ENDPOINT missing');
   const prefix = `g${Date.now()}-${Math.floor(Math.random() * 1e6)}-`;
@@ -136,7 +141,7 @@ describe.skipIf(!available)('GoneException cleanup', () => {
   });
 
   it('send() to a gone connection triggers cleanupConnection and deletes Connections/Nicks/Members rows', async () => {
-    await seedConnection(fx!.client, fx!.tables, 'gone', 'bob', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'gone', 'bob', '#room');
 
     // A self-connection runtime that tries to `send` to 'gone'.
     const mgmt: PostToConnection = {
@@ -149,8 +154,8 @@ describe.skipIf(!available)('GoneException cleanup', () => {
     };
 
     const runtime = new AwsRuntime({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connId: 'self',
       handlers: { send: () => {}, disconnect: () => {}, snapshot: () => undefined },
       managementApi: mgmt,
@@ -159,8 +164,8 @@ describe.skipIf(!available)('GoneException cleanup', () => {
     await runtime.send('gone', [{ text: ':self PRIVMSG bob :hi' } as never]);
 
     const probe = new AwsRuntime({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connId: '__probe__',
       handlers: { send: () => {}, disconnect: () => {}, snapshot: () => undefined },
       managementApi: null,
@@ -172,15 +177,15 @@ describe.skipIf(!available)('GoneException cleanup', () => {
   });
 
   it('send() to a non-gone error rethrows', async () => {
-    await seedConnection(fx!.client, fx!.tables, 'present', 'carol', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'present', 'carol', '#room');
     const mgmt: PostToConnection = {
       async postToConnection() {
         throw new Error('network down');
       },
     };
     const runtime = new AwsRuntime({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connId: 'self',
       handlers: { send: () => {}, disconnect: () => {}, snapshot: () => undefined },
       managementApi: mgmt,
@@ -190,8 +195,8 @@ describe.skipIf(!available)('GoneException cleanup', () => {
     ).rejects.toThrow('network down');
     // The target row should NOT have been cleaned up.
     const probe = new AwsRuntime({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connId: '__probe__',
       handlers: { send: () => {}, disconnect: () => {}, snapshot: () => undefined },
       managementApi: null,
@@ -200,12 +205,12 @@ describe.skipIf(!available)('GoneException cleanup', () => {
   });
 
   it('cleanupConnection is idempotent when called twice', async () => {
-    await seedConnection(fx!.client, fx!.tables, 'gone2', 'dave', '#room');
-    await cleanupConnection(fx!.client, fx!.tables, 'gone2', null);
-    await cleanupConnection(fx!.client, fx!.tables, 'gone2', null);
+    await seedConnection(requireFx().client, requireFx().tables, 'gone2', 'dave', '#room');
+    await cleanupConnection(requireFx().client, requireFx().tables, 'gone2', null);
+    await cleanupConnection(requireFx().client, requireFx().tables, 'gone2', null);
     const probe = new AwsRuntime({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connId: '__probe__',
       handlers: { send: () => {}, disconnect: () => {}, snapshot: () => undefined },
       managementApi: null,
@@ -215,20 +220,20 @@ describe.skipIf(!available)('GoneException cleanup', () => {
 
   it('cleanupConnection is safe when the connection row is missing', async () => {
     await expect(
-      cleanupConnection(fx!.client, fx!.tables, 'never-existed', null),
+      cleanupConnection(requireFx().client, requireFx().tables, 'never-existed', null),
     ).resolves.toBeUndefined();
   });
 
   it('broadcast() skips and cleans up gone members', async () => {
-    await seedConnection(fx!.client, fx!.tables, 'gone3', 'eve', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'gone3', 'eve', '#room');
     const mgmt: PostToConnection = {
       async postToConnection() {
         throw new GoneException({ $metadata: {}, message: 'Gone' });
       },
     };
     const runtime = new AwsRuntime({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connId: 'self',
       handlers: { send: () => {}, disconnect: () => {}, snapshot: () => undefined },
       managementApi: mgmt,
@@ -236,8 +241,8 @@ describe.skipIf(!available)('GoneException cleanup', () => {
     // `broadcast` iterates ChannelMembers and skips `except`.
     await runtime.broadcast('#room' as never, [{ text: ':self PRIVMSG #room :hi' } as never]);
     const probe = new AwsRuntime({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connId: '__probe__',
       handlers: { send: () => {}, disconnect: () => {}, snapshot: () => undefined },
       managementApi: null,
@@ -246,18 +251,18 @@ describe.skipIf(!available)('GoneException cleanup', () => {
   });
 
   it('send() with managementApi=null is a silent no-op (no throw, no cleanup)', async () => {
-    await seedConnection(fx!.client, fx!.tables, 'present2', 'frank', '#room');
+    await seedConnection(requireFx().client, requireFx().tables, 'present2', 'frank', '#room');
     const runtime = new AwsRuntime({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connId: 'self',
       handlers: { send: () => {}, disconnect: () => {}, snapshot: () => undefined },
       managementApi: null,
     });
     await runtime.send('present2', [{ text: ':self PRIVMSG frank :hi' } as never]);
     const probe = new AwsRuntime({
-      dynamo: fx!.client,
-      tables: fx!.tables,
+      dynamo: requireFx().client,
+      tables: requireFx().tables,
       connId: '__probe__',
       handlers: { send: () => {}, disconnect: () => {}, snapshot: () => undefined },
       managementApi: null,