serverless-ircd 0.10.0 → 0.11.0

package/packages/irc-core/tests/commands/topic.test.ts

@@ -29,9 +29,10 @@ function makeCtx(
   conn: ConnectionState,
   clock = new FakeClock(1_000),
   services?: ServicesStore,
+  config: ServerConfig = serverConfig,
 ): Ctx {
   return buildCtx({
-    serverConfig,
+    serverConfig: config,
     clock,
     ids: new SequentialIdFactory(),
     motd: EmptyMotdProvider,
@@ -182,6 +183,21 @@ describe('topicReducer — writes', () => {
     expect(out.state.topic?.text).toBe('a'.repeat(serverConfig.topicLen));
   });
 
+  it('keeps an ASCII topic of exactly topicLen bytes unchanged (no truncation)', () => {
+    const chan = makeChan('#foo');
+    addMember(chan, 'c1', 'alice');
+    const conn = makeConn();
+    const ctx = makeCtx(conn, new FakeClock(1_000), undefined, {
+      ...serverConfig,
+      topicLen: 64,
+    });
+
+    const topic = 'a'.repeat(64);
+    const out = topicReducer(chan, { command: 'TOPIC', params: ['#foo', topic], tags: {} }, ctx);
+
+    expect(out.state.topic?.text).toBe(topic);
+  });
+
   it('emits 482 ERR_CHANOPRIVSNEEDED when +t is set and the writer is a non-op member', () => {
     const chan = makeChan('#foo');
     chan.modes.topicLock = true;
@@ -238,9 +254,91 @@ describe('topicReducer — writes', () => {
 });
 
 // ============================================================================
-// topicReducer — rejections
+// topicReducer — byte-budget truncation (TOPICLEN as a UTF-8 byte ceiling)
 // ============================================================================
 
+describe('topicReducer — byte-budget truncation', () => {
+  const byteCtx = (conn: ConnectionState): Ctx =>
+    makeCtx(conn, new FakeClock(1_000), undefined, { ...serverConfig, topicLen: 64 });
+
+  it('truncates a multi-byte Latin-1 topic to the byte budget, not the char budget', () => {
+    const chan = makeChan('#foo');
+    addMember(chan, 'c1', 'alice');
+    const conn = makeConn();
+    const ctx = byteCtx(conn);
+
+    // 50 `é` chars = 50 UTF-16 units (under the 64 char budget) but 100
+    // UTF-8 bytes (over the 64 byte budget). Char-based slicing keeps all
+    // 50; byte-based truncation must keep exactly 32 (64 bytes).
+    const out = topicReducer(
+      chan,
+      { command: 'TOPIC', params: ['#foo', 'é'.repeat(50)], tags: {} },
+      ctx,
+    );
+
+    expect(out.state.topic?.text).toBe('é'.repeat(32));
+  });
+
+  it('backs off to a complete-char boundary when the budget lands mid-CJK-char', () => {
+    const chan = makeChan('#foo');
+    addMember(chan, 'c1', 'alice');
+    const conn = makeConn();
+    const ctx = byteCtx(conn);
+
+    // `好` is 3 UTF-8 bytes. 64 bytes fits 21 whole chars (63 bytes); the
+    // 22nd would need 66 bytes, so it is dropped whole and the result is a
+    // valid-UTF-8 string 1 byte under budget — never split mid-char.
+    const out = topicReducer(
+      chan,
+      { command: 'TOPIC', params: ['#foo', '好'.repeat(30)], tags: {} },
+      ctx,
+    );
+
+    expect(out.state.topic?.text).toBe('好'.repeat(21));
+  });
+
+  it('truncates an emoji topic without splitting surrogate pairs', () => {
+    const chan = makeChan('#foo');
+    addMember(chan, 'c1', 'alice');
+    const conn = makeConn();
+    const ctx = byteCtx(conn);
+
+    // `😀` is astral: 2 UTF-16 code units and 4 UTF-8 bytes each. 20 emoji
+    // = 40 UTF-16 units (under 64 chars) but 80 bytes (over budget). The
+    // byte budget fits exactly 16 emoji (64 bytes); a naive UTF-16 slice
+    // at 64 units would keep all 20, and a naive byte slice at 64 would
+    // split a surrogate pair.
+    const out = topicReducer(
+      chan,
+      { command: 'TOPIC', params: ['#foo', '😀'.repeat(20)], tags: {} },
+      ctx,
+    );
+
+    expect(out.state.topic?.text).toBe('😀'.repeat(16));
+  });
+
+  it('broadcasts and persists the byte-truncated text', () => {
+    const chan = makeChan('#foo');
+    addMember(chan, 'c1', 'alice');
+    const conn = makeConn();
+    const ctx = byteCtx(conn);
+
+    const out = topicReducer(
+      chan,
+      { command: 'TOPIC', params: ['#foo', 'é'.repeat(50)], tags: {} },
+      ctx,
+    );
+
+    const truncated = 'é'.repeat(32);
+    expect(out.effects).toEqual<EffectType[]>([
+      Effect.applyChannelDelta('#foo', {
+        topic: { text: truncated, setter: 'alice!alice@example.com', setAt: 1_000 },
+      }),
+      Effect.broadcast('#foo', [L(`:alice!alice@example.com TOPIC #foo :${truncated}`)]),
+    ]);
+  });
+});
+
 describe('topicReducer — rejections', () => {
   it('emits 461 ERR_NEEDMOREPARAMS when no channel is supplied', () => {
     const chan = makeChan('#foo');
@@ -279,6 +377,43 @@ describe('topicReducer — rejections', () => {
     ]);
   });
 
+  it('emits 403 ERR_NOSUCHCHANNEL for a channel name containing NUL', () => {
+    const chan = makeChan('#foo');
+    const conn = makeConn();
+    const ctx = makeCtx(conn);
+
+    const out = topicReducer(chan, { command: 'TOPIC', params: ['#foo\0bar'], tags: {} }, ctx);
+
+    expect(out.effects).toEqual<EffectType[]>([
+      Effect.send('c1', [L(':irc.example.com 403 alice #foo\0bar :No such channel')]),
+    ]);
+  });
+
+  it('emits 403 ERR_NOSUCHCHANNEL for a channel name containing a control character', () => {
+    const chan = makeChan('#foo');
+    const conn = makeConn();
+    const ctx = makeCtx(conn);
+
+    const out = topicReducer(chan, { command: 'TOPIC', params: ['#foo\x1fbar'], tags: {} }, ctx);
+
+    expect(out.effects).toEqual<EffectType[]>([
+      Effect.send('c1', [L(':irc.example.com 403 alice #foo\x1fbar :No such channel')]),
+    ]);
+  });
+
+  it('emits 403 ERR_NOSUCHCHANNEL for a channel name whose UTF-8 byte size exceeds the cap', () => {
+    const long = `#${'é'.repeat(25)}`; // 51 UTF-8 bytes, only 26 UTF-16 units
+    const chan = makeChan(long);
+    const conn = makeConn();
+    const ctx = makeCtx(conn);
+
+    const out = topicReducer(chan, { command: 'TOPIC', params: [long], tags: {} }, ctx);
+
+    expect(out.effects).toEqual<EffectType[]>([
+      Effect.send('c1', [L(`:irc.example.com 403 alice ${long} :No such channel`)]),
+    ]);
+  });
+
   it('emits 403 ERR_NOSUCHCHANNEL for an empty channel name', () => {
     const chan = makeChan('#foo');
     const conn = makeConn();

package/packages/irc-core/tests/commands/unified-account.test.ts

@@ -409,6 +409,8 @@ describe('T156 unified account: scrypt-hashed credentials at rest', () => {
           createdAt: NOW,
           enforce: 'none',
           certSubjects: [],
+          identifyFailures: [],
+          pendingIdentifyFailureNotice: 0,
           // Malformed credential — empty hash, rejected by verifyHashedPassword.
           credential: { account: 'legacy', algorithm: 'scrypt', salt: 's', hash: '' },
         },