seroval 0.4.0-alpha.1 → 0.4.0-alpha.3

package/src/tree.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-use-before-define */
 /* eslint-disable guard-for-in */
 /* eslint-disable @typescript-eslint/no-for-in-array */
 /* eslint-disable no-await-in-loop */
@@ -535,35 +536,40 @@ function generateSemiPrimitiveValue(
   return undefined;
 }
 
+function serializePropertiesSync(
+  ctx: SerializationContext,
+  properties: Record<string, unknown>,
+): SerovalDictionaryNode {
+  const keys = Object.keys(properties);
+  const size = keys.length;
+  const keyNodes = new Array<string>(size);
+  const valueNodes = new Array<SerovalNode>(size);
+  const deferredKeys = new Array<string>(size);
+  const deferredValues = new Array<ServerValue>(size);
+  let deferredSize = 0;
+  let nodesSize = 0;
+  for (const key of keys) {
+    if (isIterable(properties[key])) {
+      deferredKeys[deferredSize] = key;
+      deferredValues[deferredSize] = properties[key] as ServerValue;
+      deferredSize++;
+    } else {
+      keyNodes[nodesSize] = key;
+      valueNodes[nodesSize] = generateTreeSync(ctx, properties[key] as ServerValue);
+      nodesSize++;
+    }
+  }
+  for (let i = 0; i < deferredSize; i++) {
+    keyNodes[nodesSize + i] = deferredKeys[i];
+    valueNodes[nodesSize + i] = generateTreeSync(ctx, deferredValues[i]);
+  }
+  return [keyNodes, valueNodes, size];
+}
+
 export function generateTreeSync(
   ctx: SerializationContext,
   current: ServerValue,
 ): SerovalNode {
-  function serializeProperties(
-    properties: Record<string, unknown>,
-  ): SerovalDictionaryNode {
-    const keyNodes: string[] = [];
-    const valueNodes: SerovalNode[] = [];
-    const deferredKeys: string[] = [];
-    const deferredValues: ServerValue[] = [];
-    const keys = Object.keys(properties);
-    let deferredSize = 0;
-    for (const key of keys) {
-      if (isIterable(properties[key])) {
-        deferredKeys.push(key);
-        deferredValues.push(properties[key] as ServerValue);
-        deferredSize++;
-      } else {
-        keyNodes.push(key);
-        valueNodes.push(generateTreeSync(ctx, properties[key] as ServerValue));
-      }
-    }
-    for (let i = 0; i < deferredSize; i++) {
-      keyNodes.push(deferredKeys[i]);
-      valueNodes.push(generateTreeSync(ctx, deferredValues[i]));
-    }
-    return [keyNodes, valueNodes, keys.length];
-  }
   if (isPrimitive(current)) {
     return [SerovalNodeType.Primitive, current];
   }
@@ -579,45 +585,51 @@ export function generateTreeSync(
   }
   if (constructorCheck<Set<ServerValue>>(current, Set)) {
     assert(ctx.features.has(Feature.Set), 'Unsupported type "Set"');
-    const nodes: SerovalNode[] = [];
-    const deferred: ServerValue[] = [];
+    const len = current.size;
+    const nodes = new Array<SerovalNode>(len);
+    const deferred = new Array<ServerValue>(len);
+    let deferredSize = 0;
+    let nodeSize = 0;
     for (const item of current.keys()) {
       // Iterables are lazy, so the evaluation must be deferred
       if (isIterable(item)) {
-        deferred.push(item);
+        deferred[deferredSize++] = item;
       } else {
-        nodes.push(generateTreeSync(ctx, item));
+        nodes[nodeSize++] = generateTreeSync(ctx, item);
       }
     }
     // Parse deferred items
-    for (let i = 0, len = deferred.length; i < len; i++) {
-      nodes.push(generateTreeSync(ctx, deferred[i]));
+    for (let i = 0; i < deferredSize; i++) {
+      nodes[nodeSize + i] = generateTreeSync(ctx, deferred[i]);
     }
     return [SerovalNodeType.Set, nodes, id];
   }
   if (constructorCheck<Map<ServerValue, ServerValue>>(current, Map)) {
     assert(ctx.features.has(Feature.Map), 'Unsupported type "Map"');
-    const keyNodes: SerovalNode[] = [];
-    const valueNodes: SerovalNode[] = [];
-    const deferredKey: ServerValue[] = [];
-    const deferredValue: ServerValue[] = [];
+    const len = current.size;
+    const keyNodes = new Array<SerovalNode>(len);
+    const valueNodes = new Array<SerovalNode>(len);
+    const deferredKey = new Array<ServerValue>(len);
+    const deferredValue = new Array<ServerValue>(len);
     let deferredSize = 0;
+    let nodeSize = 0;
     for (const [key, value] of current.entries()) {
       // Either key or value might be an iterable
       if (isIterable(key) || isIterable(value)) {
-        deferredKey.push(key);
-        deferredValue.push(value);
+        deferredKey[deferredSize] = key;
+        deferredValue[deferredSize] = value;
         deferredSize++;
       } else {
-        keyNodes.push(generateTreeSync(ctx, key));
-        valueNodes.push(generateTreeSync(ctx, value));
+        keyNodes[nodeSize] = generateTreeSync(ctx, key);
+        valueNodes[nodeSize] = generateTreeSync(ctx, value);
+        nodeSize++;
       }
     }
     for (let i = 0; i < deferredSize; i++) {
-      keyNodes.push(generateTreeSync(ctx, deferredKey[i]));
-      valueNodes.push(generateTreeSync(ctx, deferredValue[i]));
+      keyNodes[nodeSize + i] = generateTreeSync(ctx, deferredKey[i]);
+      valueNodes[nodeSize + i] = generateTreeSync(ctx, deferredValue[i]);
     }
-    return [SerovalNodeType.Map, [keyNodes, valueNodes, current.size], id];
+    return [SerovalNodeType.Map, [keyNodes, valueNodes, len], id];
   }
   if (Array.isArray(current)) {
     const size = current.length;
@@ -642,7 +654,7 @@ export function generateTreeSync(
   if (current instanceof AggregateError && ctx.features.has(Feature.AggregateError)) {
     const options = getErrorOptions(current);
     const optionsNode = options
-      ? serializeProperties(options)
+      ? serializePropertiesSync(ctx, options)
       : undefined;
     const errorsNode = generateTreeSync(ctx, current.errors as ServerValue);
     return [SerovalNodeType.AggregateError, [current.message, optionsNode, errorsNode], id];
@@ -650,7 +662,7 @@ export function generateTreeSync(
   if (current instanceof Error) {
     const options = getErrorOptions(current);
     const optionsNode = options
-      ? serializeProperties(options)
+      ? serializePropertiesSync(ctx, options)
       : undefined;
     return [
       SerovalNodeType.Error,
@@ -663,7 +675,7 @@ export function generateTreeSync(
     const options = getIterableOptions(current);
     return [SerovalNodeType.Iterable, [
       // Parse options first before the items
-      options ? serializeProperties(options) : undefined,
+      options ? serializePropertiesSync(ctx, options) : undefined,
       generateTreeSync(ctx, Array.from(current)),
     ], id];
   }
@@ -671,42 +683,47 @@ export function generateTreeSync(
   if (current.constructor === Object || empty) {
     return [
       empty ? SerovalNodeType.NullConstructor : SerovalNodeType.Object,
-      serializeProperties(current as Record<string, unknown>),
+      serializePropertiesSync(ctx, current as Record<string, unknown>),
       id,
     ];
   }
   throw new Error('Unsupported value');
 }
 
+async function serializePropertiesAsync(
+  ctx: SerializationContext,
+  properties: Record<string, unknown>,
+): Promise<SerovalDictionaryNode> {
+  const keys = Object.keys(properties);
+  const size = keys.length;
+  const keyNodes = new Array<string>(size);
+  const valueNodes = new Array<SerovalNode>(size);
+  const deferredKeys = new Array<string>(size);
+  const deferredValues = new Array<ServerValue>(size);
+  let deferredSize = 0;
+  let nodesSize = 0;
+  for (const key of keys) {
+    if (isIterable(properties[key])) {
+      deferredKeys[deferredSize] = key;
+      deferredValues[deferredSize] = properties[key] as ServerValue;
+      deferredSize++;
+    } else {
+      keyNodes[nodesSize] = key;
+      valueNodes[nodesSize] = await generateTreeAsync(ctx, properties[key] as ServerValue);
+      nodesSize++;
+    }
+  }
+  for (let i = 0; i < deferredSize; i++) {
+    keyNodes[nodesSize + i] = deferredKeys[i];
+    valueNodes[nodesSize + i] = await generateTreeAsync(ctx, deferredValues[i]);
+  }
+  return [keyNodes, valueNodes, size];
+}
+
 export async function generateTreeAsync(
   ctx: SerializationContext,
   current: AsyncServerValue,
 ): Promise<SerovalNode> {
-  async function serializeProperties(
-    properties: Record<string, unknown>,
-  ): Promise<SerovalDictionaryNode> {
-    const keyNodes: string[] = [];
-    const valueNodes: SerovalNode[] = [];
-    const deferredKeys: string[] = [];
-    const deferredValues: ServerValue[] = [];
-    const keys = Object.keys(properties);
-    let deferredSize = 0;
-    for (const key of keys) {
-      if (isIterable(properties[key])) {
-        deferredKeys.push(key);
-        deferredValues.push(properties[key] as ServerValue);
-        deferredSize++;
-      } else {
-        keyNodes.push(key);
-        valueNodes.push(await generateTreeAsync(ctx, properties[key] as ServerValue));
-      }
-    }
-    for (let i = 0; i < deferredSize; i++) {
-      keyNodes.push(deferredKeys[i]);
-      valueNodes.push(await generateTreeAsync(ctx, deferredValues[i]));
-    }
-    return [keyNodes, valueNodes, keys.length];
-  }
   if (isPrimitive(current)) {
     return [SerovalNodeType.Primitive, current];
   }
@@ -728,42 +745,51 @@ export async function generateTreeAsync(
   }
   if (constructorCheck<Set<AsyncServerValue>>(current, Set)) {
     assert(ctx.features.has(Feature.Set), 'Unsupported type "Set"');
-    const nodes: SerovalNode[] = [];
-    const deferred: AsyncServerValue[] = [];
+    const len = current.size;
+    const nodes = new Array<SerovalNode>(len);
+    const deferred = new Array<AsyncServerValue>(len);
+    let deferredSize = 0;
+    let nodeSize = 0;
     for (const item of current.keys()) {
+      // Iterables are lazy, so the evaluation must be deferred
       if (isIterable(item)) {
-        deferred.push(item);
+        deferred[deferredSize++] = item;
       } else {
-        nodes.push(await generateTreeAsync(ctx, item));
+        nodes[nodeSize++] = await generateTreeAsync(ctx, item);
       }
     }
-    for (let i = 0, len = deferred.length; i < len; i++) {
-      nodes.push(await generateTreeAsync(ctx, deferred[i]));
+    // Parse deferred items
+    for (let i = 0; i < deferredSize; i++) {
+      nodes[nodeSize + i] = await generateTreeAsync(ctx, deferred[i]);
     }
     return [SerovalNodeType.Set, nodes, id];
   }
   if (constructorCheck<Map<AsyncServerValue, AsyncServerValue>>(current, Map)) {
     assert(ctx.features.has(Feature.Map), 'Unsupported type "Map"');
-    const keyNodes: SerovalNode[] = [];
-    const valueNodes: SerovalNode[] = [];
-    const deferredKey: AsyncServerValue[] = [];
-    const deferredValue: AsyncServerValue[] = [];
+    const len = current.size;
+    const keyNodes = new Array<SerovalNode>(len);
+    const valueNodes = new Array<SerovalNode>(len);
+    const deferredKey = new Array<AsyncServerValue>(len);
+    const deferredValue = new Array<AsyncServerValue>(len);
     let deferredSize = 0;
+    let nodeSize = 0;
     for (const [key, value] of current.entries()) {
+      // Either key or value might be an iterable
       if (isIterable(key) || isIterable(value)) {
-        deferredKey.push(key);
-        deferredValue.push(value);
+        deferredKey[deferredSize] = key;
+        deferredValue[deferredSize] = value;
         deferredSize++;
       } else {
-        keyNodes.push(await generateTreeAsync(ctx, key));
-        valueNodes.push(await generateTreeAsync(ctx, value));
+        keyNodes[nodeSize] = await generateTreeAsync(ctx, key);
+        valueNodes[nodeSize] = await generateTreeAsync(ctx, value);
+        nodeSize++;
       }
     }
     for (let i = 0; i < deferredSize; i++) {
-      keyNodes.push(await generateTreeAsync(ctx, deferredKey[i]));
-      valueNodes.push(await generateTreeAsync(ctx, deferredValue[i]));
+      keyNodes[nodeSize + i] = await generateTreeAsync(ctx, deferredKey[i]);
+      valueNodes[nodeSize + i] = await generateTreeAsync(ctx, deferredValue[i]);
     }
-    return [SerovalNodeType.Map, [keyNodes, valueNodes, current.size], id];
+    return [SerovalNodeType.Map, [keyNodes, valueNodes, len], id];
   }
   if (Array.isArray(current)) {
     const size = current.length;
@@ -789,7 +815,7 @@ export async function generateTreeAsync(
   if (current instanceof AggregateError) {
     const options = getErrorOptions(current);
     const optionsNode = options
-      ? await serializeProperties(options)
+      ? await serializePropertiesAsync(ctx, options)
       : undefined;
     const errorsNode = await generateTreeAsync(ctx, current.errors as ServerValue);
     return [SerovalNodeType.AggregateError, [current.message, optionsNode, errorsNode], id];
@@ -797,7 +823,7 @@ export async function generateTreeAsync(
   if (current instanceof Error) {
     const options = getErrorOptions(current);
     const optionsNode = options
-      ? await serializeProperties(options)
+      ? await serializePropertiesAsync(ctx, options)
       : undefined;
     return [
       SerovalNodeType.Error,
@@ -810,7 +836,7 @@ export async function generateTreeAsync(
     const options = getIterableOptions(current);
     return [SerovalNodeType.Iterable, [
       options
-        ? await serializeProperties(options)
+        ? await serializePropertiesAsync(ctx, options)
         : undefined,
       await generateTreeAsync(ctx, Array.from(current)),
     ], id];
@@ -819,7 +845,7 @@ export async function generateTreeAsync(
   if (current.constructor === Object || empty) {
     return [
       empty ? SerovalNodeType.NullConstructor : SerovalNodeType.Object,
-      await serializeProperties(current as Record<string, unknown>),
+      await serializePropertiesAsync(ctx, current as Record<string, unknown>),
       id,
     ];
   }
@@ -863,80 +889,80 @@ export function serializePrimitive(
   return String(value);
 }
 
-export function serializeTree(
+const IDENTIFIER_CHECK = /^([$A-Z_][0-9A-Z_$]*)$/i;
+
+function serializeAssignments(
   ctx: SerializationContext,
-  [type, value, id]: SerovalNode,
-): string {
-  function serializeAssignments(
-    targetRef: number,
-    [keys, values, size]: SerovalDictionaryNode,
-  ) {
-    ctx.stack.push(targetRef);
-    const mainAssignments: Assignment[] = [];
-    for (let i = 0; i < size; i++) {
-      const parentStack = ctx.stack;
-      ctx.stack = [];
-      const refParam = serializeTree(ctx, values[i]);
-      ctx.stack = parentStack;
-      const key = keys[i];
-      const check = Number(key);
-      // Test if key is a valid number or JS identifier
-      // so that we don't have to serialize the key and wrap with brackets
-      const parentAssignment = ctx.assignments;
-      ctx.assignments = mainAssignments;
-      if (
-        check >= 0
-        || (Number.isNaN(check) && /^([$A-Z_][0-9A-Z_$]*)$/i.test(key))
-      ) {
-        if (!Number.isNaN(check)) {
-          createObjectComputedAssign(ctx, targetRef, key, refParam);
-        } else {
-          createObjectIdentifierAssign(ctx, targetRef, key, refParam);
-        }
+  targetRef: number,
+  [keys, values, size]: SerovalDictionaryNode,
+) {
+  ctx.stack.push(targetRef);
+  const mainAssignments: Assignment[] = [];
+  for (let i = 0; i < size; i++) {
+    const parentStack = ctx.stack;
+    ctx.stack = [];
+    const refParam = serializeTree(ctx, values[i]);
+    ctx.stack = parentStack;
+    const key = keys[i];
+    const check = Number(key);
+    const parentAssignment = ctx.assignments;
+    ctx.assignments = mainAssignments;
+    // Test if key is a valid number or JS identifier
+    // so that we don't have to serialize the key and wrap with brackets
+    if (IDENTIFIER_CHECK.test(key) || check >= 0) {
+      if (!Number.isNaN(check)) {
+        createObjectComputedAssign(ctx, targetRef, key, refParam);
       } else {
-        createObjectComputedAssign(ctx, targetRef, quote(key), refParam);
+        createObjectIdentifierAssign(ctx, targetRef, key, refParam);
       }
-      ctx.assignments = parentAssignment;
+    } else {
+      createObjectComputedAssign(ctx, targetRef, quote(key), refParam);
     }
-    ctx.stack.pop();
-    return resolveAssignments(mainAssignments);
+    ctx.assignments = parentAssignment;
   }
-  function serializeObject(
-    sourceID: number,
-    [keys, values, size]: SerovalDictionaryNode,
-  ) {
-    let result = '';
-    ctx.stack.push(sourceID);
-    for (let i = 0; i < size; i++) {
-      const key = keys[i];
-      const val = values[i];
-      const check = Number(key);
-      // Test if key is a valid number or JS identifier
-      // so that we don't have to serialize the key and wrap with brackets
-      if (
-        check >= 0
-        || (Number.isNaN(check) && /^([$A-Z_][0-9A-Z_$]*)$/i.test(key))
-      ) {
-        if (isReferenceInStack(ctx, val)) {
-          const refParam = getRefParam(ctx, val[1]);
-          if (!Number.isNaN(check)) {
-            createObjectComputedAssign(ctx, sourceID, key, refParam);
-          } else {
-            createObjectIdentifierAssign(ctx, sourceID, key, refParam);
-          }
+  ctx.stack.pop();
+  return resolveAssignments(mainAssignments);
+}
+
+function serializeObject(
+  ctx: SerializationContext,
+  sourceID: number,
+  [keys, values, size]: SerovalDictionaryNode,
+) {
+  let result = '';
+  ctx.stack.push(sourceID);
+  for (let i = 0; i < size; i++) {
+    const key = keys[i];
+    const val = values[i];
+    const check = Number(key);
+    // Test if key is a valid number or JS identifier
+    // so that we don't have to serialize the key and wrap with brackets
+    const isIdentifier = IDENTIFIER_CHECK.test(key) || check >= 0;
+    if (isReferenceInStack(ctx, val)) {
+      const refParam = getRefParam(ctx, val[1]);
+      if (isIdentifier) {
+        if (!Number.isNaN(check)) {
+          createObjectComputedAssign(ctx, sourceID, key, refParam);
         } else {
-          result += `${key}:${serializeTree(ctx, val)},`;
+          createObjectIdentifierAssign(ctx, sourceID, key, refParam);
         }
-      } else if (isReferenceInStack(ctx, val)) {
-        const refParam = getRefParam(ctx, val[1]);
-        createObjectComputedAssign(ctx, sourceID, quote(key), refParam);
       } else {
-        result += `${quote(key)}:${serializeTree(ctx, val)},`;
+        createObjectComputedAssign(ctx, sourceID, quote(key), refParam);
       }
+    } else if (isIdentifier) {
+      result += `${key}:${serializeTree(ctx, val)},`;
+    } else {
+      result += `${quote(key)}:${serializeTree(ctx, val)},`;
     }
-    ctx.stack.pop();
-    return `{${result.substring(0, result.length - 1)}}`;
   }
+  ctx.stack.pop();
+  return `{${result.substring(0, result.length - 1)}}`;
+}
+
+export function serializeTree(
+  ctx: SerializationContext,
+  [type, value, id]: SerovalNode,
+): string {
   switch (type) {
     case SerovalNodeType.Primitive:
       return serializePrimitive(ctx, value);
@@ -1090,11 +1116,11 @@ export function serializeTree(
       // Make sure to assign extra properties
       if (value[1]) {
         if (ctx.features.has(Feature.ObjectAssign)) {
-          const options = serializeObject(id, value[1]);
+          const options = serializeObject(ctx, id, value[1]);
           serialized = `Object.assign(${serialized},${options})`;
         } else {
           markRef(ctx, id);
-          const assignments = serializeAssignments(id, value[1]);
+          const assignments = serializeAssignments(ctx, id, value[1]);
           if (assignments) {
             const ref = getRefParam(ctx, id);
             return `(${assignRef(ctx, id, serialized)},${assignments}${ref})`;
@@ -1107,11 +1133,11 @@ export function serializeTree(
       let serialized = `new ${value[0]}(${quote(value[1])})`;
       if (value[2]) {
         if (ctx.features.has(Feature.ObjectAssign)) {
-          const options = serializeObject(id, value[2]);
+          const options = serializeObject(ctx, id, value[2]);
           serialized = `Object.assign(${serialized},${options})`;
         } else {
           markRef(ctx, id);
-          const assignments = serializeAssignments(id, value[2]);
+          const assignments = serializeAssignments(ctx, id, value[2]);
           if (assignments) {
             const ref = getRefParam(ctx, id);
             return `(${assignRef(ctx, id, serialized)},${assignments}${ref})`;
@@ -1140,11 +1166,11 @@ export function serializeTree(
       }
       if (value[0]) {
         if (ctx.features.has(Feature.ObjectAssign)) {
-          const options = serializeObject(id, value[0]);
+          const options = serializeObject(ctx, id, value[0]);
           serialized = `Object.assign(${serialized},${options})`;
         } else {
           markRef(ctx, id);
-          const assignments = serializeAssignments(id, value[0]);
+          const assignments = serializeAssignments(ctx, id, value[0]);
           if (assignments) {
             const ref = getRefParam(ctx, id);
             return `(${assignRef(ctx, id, serialized)},${assignments}${ref})`;
@@ -1156,13 +1182,13 @@ export function serializeTree(
     case SerovalNodeType.NullConstructor: {
       let serialized = 'Object.create(null)';
       if (ctx.features.has(Feature.ObjectAssign)) {
-        const fields = serializeObject(id, value);
+        const fields = serializeObject(ctx, id, value);
         if (fields !== '{}') {
           serialized = `Object.assign(${serialized},${fields})`;
         }
       } else {
         markRef(ctx, id);
-        const assignments = serializeAssignments(id, value);
+        const assignments = serializeAssignments(ctx, id, value);
         if (assignments) {
           const ref = getRefParam(ctx, id);
           return `(${assignRef(ctx, id, serialized)},${assignments}${ref})`;
@@ -1171,7 +1197,7 @@ export function serializeTree(
       return assignRef(ctx, id, serialized);
     }
     case SerovalNodeType.Object:
-      return assignRef(ctx, id, serializeObject(id, value));
+      return assignRef(ctx, id, serializeObject(ctx, id, value));
     default:
       throw new Error('Unsupported type');
   }