sequently 2.1.2 → 5.0.0

package/dist/sequently.js

@@ -1,133 +1,90 @@
-var Sequently =
-/******/ (function(modules) { // webpackBootstrap
-/******/ 	// The module cache
-/******/ 	var installedModules = {};
-/******/
-/******/ 	// The require function
-/******/ 	function __webpack_require__(moduleId) {
-/******/
-/******/ 		// Check if module is in cache
-/******/ 		if(installedModules[moduleId]) {
-/******/ 			return installedModules[moduleId].exports;
-/******/ 		}
-/******/ 		// Create a new module (and put it into the cache)
-/******/ 		var module = installedModules[moduleId] = {
-/******/ 			i: moduleId,
-/******/ 			l: false,
-/******/ 			exports: {}
-/******/ 		};
-/******/
-/******/ 		// Execute the module function
-/******/ 		modules[moduleId].call(module.exports, module, module.exports, __webpack_require__);
-/******/
-/******/ 		// Flag the module as loaded
-/******/ 		module.l = true;
-/******/
-/******/ 		// Return the exports of the module
-/******/ 		return module.exports;
-/******/ 	}
-/******/
-/******/
-/******/ 	// expose the modules object (__webpack_modules__)
-/******/ 	__webpack_require__.m = modules;
-/******/
-/******/ 	// expose the module cache
-/******/ 	__webpack_require__.c = installedModules;
-/******/
-/******/ 	// define getter function for harmony exports
-/******/ 	__webpack_require__.d = function(exports, name, getter) {
-/******/ 		if(!__webpack_require__.o(exports, name)) {
-/******/ 			Object.defineProperty(exports, name, { enumerable: true, get: getter });
+var Sequently;
+/******/ (() => { // webpackBootstrap
+/******/ 	"use strict";
+/******/ 	// The require scope
+/******/ 	const __webpack_require__ = {};
+/******/ 	
+/************************************************************************/
+/******/ 	/* webpack/runtime/define property getters */
+/******/ 	// define getter/value functions for harmony exports
+/******/ 	__webpack_require__.d = (exports, definition) => {
+/******/ 		if(Array.isArray(definition)) {
+/******/ 			var i = 0;
+/******/ 			while(i < definition.length) {
+/******/ 				var key = definition[i++];
+/******/ 				var binding = definition[i++];
+/******/ 				var descriptor = binding === 0 ? { enumerable: true, value: definition[i++] } : { enumerable: true, get: binding };
+/******/ 				if(!__webpack_require__.o(exports, key)) Object.defineProperty(exports, key, descriptor);
+/******/ 			}
+/******/ 		} else {
+/******/ 			for(var key in definition) {
+/******/ 				if(__webpack_require__.o(definition, key) && !__webpack_require__.o(exports, key)) {
+/******/ 					Object.defineProperty(exports, key, { enumerable: true, get: definition[key] });
+/******/ 				}
+/******/ 			}
 /******/ 		}
 /******/ 	};
-/******/
+/******/ 	
+/******/ 	/* webpack/runtime/hasOwnProperty shorthand */
+/******/ 	__webpack_require__.o = (obj, prop) => (Object.prototype.hasOwnProperty.call(obj, prop));
+/******/ 	
+/******/ 	/* webpack/runtime/make namespace object */
 /******/ 	// define __esModule on exports
-/******/ 	__webpack_require__.r = function(exports) {
-/******/ 		if(typeof Symbol !== 'undefined' && Symbol.toStringTag) {
-/******/ 			Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
-/******/ 		}
+/******/ 	__webpack_require__.r = (exports) => {
+/******/ 		Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
 /******/ 		Object.defineProperty(exports, '__esModule', { value: true });
 /******/ 	};
-/******/
-/******/ 	// create a fake namespace object
-/******/ 	// mode & 1: value is a module id, require it
-/******/ 	// mode & 2: merge all properties of value into the ns
-/******/ 	// mode & 4: return value when already ns object
-/******/ 	// mode & 8|1: behave like require
-/******/ 	__webpack_require__.t = function(value, mode) {
-/******/ 		if(mode & 1) value = __webpack_require__(value);
-/******/ 		if(mode & 8) return value;
-/******/ 		if((mode & 4) && typeof value === 'object' && value && value.__esModule) return value;
-/******/ 		var ns = Object.create(null);
-/******/ 		__webpack_require__.r(ns);
-/******/ 		Object.defineProperty(ns, 'default', { enumerable: true, value: value });
-/******/ 		if(mode & 2 && typeof value != 'string') for(var key in value) __webpack_require__.d(ns, key, function(key) { return value[key]; }.bind(null, key));
-/******/ 		return ns;
-/******/ 	};
-/******/
-/******/ 	// getDefaultExport function for compatibility with non-harmony modules
-/******/ 	__webpack_require__.n = function(module) {
-/******/ 		var getter = module && module.__esModule ?
-/******/ 			function getDefault() { return module['default']; } :
-/******/ 			function getModuleExports() { return module; };
-/******/ 		__webpack_require__.d(getter, 'a', getter);
-/******/ 		return getter;
-/******/ 	};
-/******/
-/******/ 	// Object.prototype.hasOwnProperty.call
-/******/ 	__webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };
-/******/
-/******/ 	// __webpack_public_path__
-/******/ 	__webpack_require__.p = "";
-/******/
-/******/
-/******/ 	// Load entry module and return exports
-/******/ 	return __webpack_require__(__webpack_require__.s = 0);
-/******/ })
+/******/ 	
 /************************************************************************/
-/******/ ([
-/* 0 */
-/***/ (function(module, __webpack_exports__, __webpack_require__) {
-
-"use strict";
+let __webpack_exports__ = {};
 __webpack_require__.r(__webpack_exports__);
 
 
-/* harmony default export */ __webpack_exports__["default"] = ({
+/* harmony default export */ const __WEBPACK_DEFAULT_EXPORT__ = ({
   sequence: function (functions, args) {
-    let function_args;
-    let function_primes = [];
+    let functionArgs;
+    let functionPrimes = [];
     let incrementers = [];
-    let prime_index = 0;
-
+    let primeIndex = 0;
+    if (!Array.isArray(functions) || functions.length === 0) {
+      return;
+    }
     if (!Array.isArray(args)) {
-      function_args = Array(functions.length).fill([]);
+      functionArgs = Array(functions.length).fill([]);
     } else {
-      function_args = args;
+      functionArgs = [];
+      for (let i = 0; i < functions.length; i += 1) {
+        if (Array.isArray(args[i])) {
+          functionArgs.push(args[i]);
+        } else {
+          functionArgs.push([]);
+        }
+      }
     }
-
     for (let index = 0; index < functions.length; index += 1) {
       let incrementer = function () {
-        prime_index += 1;
-        function_primes[prime_index](incrementers[prime_index]);
+        primeIndex += 1;
+        if (primeIndex < functionPrimes.length) {
+          functionPrimes[primeIndex](incrementers[primeIndex]);
+        }
       };
-
       incrementers.push(incrementer);
-
-      let function_prime = function (callback) {
-        if (function_args[prime_index].length === 0) {
-          functions[prime_index](callback);
+      let functionPrime = function (callback) {
+        if (functionArgs[primeIndex].length === 0) {
+          functions[primeIndex](callback);
         } else {
-          functions[prime_index](function_args[prime_index], callback);
+          functions[primeIndex](functionArgs[primeIndex], callback);
         }
       };
-
-      function_primes.push(function_prime);
+      functionPrimes.push(functionPrime);
     }
-
-    function_primes[0](incrementers[0], function_args[0]);
+    functionPrimes[0](incrementers[0], functionArgs[0]);
   }
 });
+/* harmony export */ __webpack_require__.d(__webpack_exports__, [
+/* harmony export */   "default", 0, __WEBPACK_DEFAULT_EXPORT__
+/* harmony export */ ]);
 
-/***/ })
-/******/ ]);
+Sequently = __webpack_exports__;
+/******/ })()
+;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sequently",
-  "version": "2.1.2",
+  "version": "5.0.0",
   "description": "Library for running asynchronous functions sequentially",
   "repository": {
     "type": "git",
@@ -23,15 +23,16 @@
     "@babel/preset-env": "^7.4.5",
     "babel-loader": "^8.0.6",
     "standard": "^12.0.1",
-    "webpack": "^4.35.0",
-    "webpack-cli": "^3.3.5",
-    "webpack-dev-server": "^3.7.2"
+    "webpack": "^5.97.1",
+    "webpack-cli": "^6.0.1",
+    "webpack-dev-server": "^5.2.0"
   },
   "dependencies": {
     "core-js": "3"
   },
   "scripts": {
-    "start": "webpack-dev-server --open --mode development",
-    "build": "webpack --mode production"
-  }
+    "build": "webpack --mode production",
+    "test": "node --test test/*.js"
+  },
+  "type": "module"
 }

package/src/index.js

@@ -7,16 +7,29 @@ export default {
     let incrementers = []
     let primeIndex = 0
 
+    if (!Array.isArray(functions) || functions.length === 0) {
+      return
+    }
+
     if (!Array.isArray(args)) {
       functionArgs = Array(functions.length).fill([])
     } else {
-      functionArgs = args
+      functionArgs = []
+      for (let i = 0; i < functions.length; i += 1) {
+        if (Array.isArray(args[i])) {
+          functionArgs.push(args[i])
+        } else {
+          functionArgs.push([])
+        }
+      }
     }
 
     for (let index = 0; index < functions.length; index += 1) {
       let incrementer = function () {
         primeIndex += 1
-        functionPrimes[primeIndex](incrementers[primeIndex])
+        if (primeIndex < functionPrimes.length) {
+          functionPrimes[primeIndex](incrementers[primeIndex])
+        }
       }
 
       incrementers.push(incrementer)

package/test/index.js

@@ -0,0 +1,191 @@
+'use strict'
+
+import { strict as assert } from 'node:assert'
+import { describe, it } from 'node:test'
+import seq from '../src/index.js'
+
+describe('sequence', () => {
+  it('executes functions in order', () => {
+    return new Promise((resolve, reject) => {
+      const order = []
+      seq.sequence([
+        (cb) => { order.push(1); cb() },
+        (cb) => { order.push(2); cb() },
+        (cb) => { order.push(3); cb() }
+      ])
+      // Allow async callbacks to complete
+      setTimeout(() => {
+        try {
+          assert.deepEqual(order, [1, 2, 3])
+          resolve()
+        } catch (e) {
+          reject(e)
+        }
+      }, 10)
+    })
+  })
+
+  it('passes arguments to functions when args array is provided', () => {
+    return new Promise((resolve, reject) => {
+      const results = []
+      seq.sequence([
+        (args, cb) => { results.push(args[0]); cb() },
+        (args, cb) => { results.push(args[0]); cb() }
+      ], [[10], [20]])
+      setTimeout(() => {
+        try {
+          assert.deepEqual(results, [10, 20])
+          resolve()
+        } catch (e) {
+          reject(e)
+        }
+      }, 10)
+    })
+  })
+
+  it('calls functions with no arguments when args is not an array', () => {
+    return new Promise((resolve, reject) => {
+      const results = []
+      seq.sequence([
+        (cb) => { results.push('a'); cb() },
+        (cb) => { results.push('b'); cb() }
+      ], 'not-an-array')
+      setTimeout(() => {
+        try {
+          assert.deepEqual(results, ['a', 'b'])
+          resolve()
+        } catch (e) {
+          reject(e)
+        }
+      }, 10)
+    })
+  })
+
+  it('handles a single function without throwing', () => {
+    return new Promise((resolve, reject) => {
+      let called = false
+      seq.sequence([
+        (cb) => { called = true; cb() }
+      ])
+      setTimeout(() => {
+        try {
+          assert.equal(called, true)
+          resolve()
+        } catch (e) {
+          reject(e)
+        }
+      }, 10)
+    })
+  })
+
+  it('handles empty function array', () => {
+    return new Promise((resolve, reject) => {
+      // Should not throw
+      seq.sequence([])
+      setTimeout(() => {
+        resolve()
+      }, 10)
+    })
+  })
+
+  it('passes callback as second argument when no args provided', () => {
+    return new Promise((resolve, reject) => {
+      const results = []
+      seq.sequence([
+        (cb) => { results.push('a'); cb() },
+        (cb) => { results.push('b'); cb() }
+      ])
+      setTimeout(() => {
+        try {
+          assert.deepEqual(results, ['a', 'b'])
+          resolve()
+        } catch (e) {
+          reject(e)
+        }
+      }, 10)
+    })
+  })
+
+  it('handles multiple functions with varying arg lengths', () => {
+    return new Promise((resolve, reject) => {
+      const results = []
+      seq.sequence([
+        (args, cb) => { results.push(args[0] + args[1]); cb() },
+        (args, cb) => { results.push(args[0]); cb() },
+        (cb) => { results.push('done'); cb() }
+      ], [[1, 2], [3], []])
+      setTimeout(() => {
+        try {
+          assert.deepEqual(results, [3, 3, 'done'])
+          resolve()
+        } catch (e) {
+          reject(e)
+        }
+      }, 10)
+    })
+  })
+
+  it('does not throw TypeError on last function callback (bounds check)', () => {
+    return new Promise((resolve, reject) => {
+      let lastCalled = false
+      // This was the bug: the last function's callback would increment primeIndex
+      // beyond the array length and try to call undefined as a function
+      seq.sequence([
+        (cb) => { cb() },
+        (cb) => { lastCalled = true; cb() }
+      ])
+      setTimeout(() => {
+        try {
+          assert.equal(lastCalled, true)
+          resolve()
+        } catch (e) {
+          reject(e)
+        }
+      }, 10)
+    })
+  })
+
+  it('handles short args array without throwing', () => {
+    return new Promise((resolve, reject) => {
+      const results = []
+      // Only 1 args entry for 3 functions — missing entries should default to []
+      seq.sequence([
+        (args, cb) => { results.push(args[0]); cb() },
+        (cb) => { results.push('no-args'); cb() },
+        (cb) => { results.push('no-args'); cb() }
+      ], [[42]])
+      setTimeout(() => {
+        try {
+          assert.deepEqual(results, [42, 'no-args', 'no-args'])
+          resolve()
+        } catch (e) {
+          reject(e)
+        }
+      }, 10)
+    })
+  })
+
+  it('handles null functions parameter without throwing', () => {
+    return new Promise((resolve, reject) => {
+      // Should not throw
+      assert.doesNotThrow(() => {
+        seq.sequence(null)
+      })
+      setTimeout(() => {
+        resolve()
+      }, 10)
+    })
+  })
+
+  it('handles non-array functions parameter without throwing', () => {
+    return new Promise((resolve, reject) => {
+      // Should not throw
+      assert.doesNotThrow(() => {
+        seq.sequence('not-an-array')
+      })
+      setTimeout(() => {
+        resolve()
+      }, 10)
+    })
+  })
+})