sequant 2.6.2 → 2.8.0

package/dist/marketplace/external_plugins/sequant/skills/qa/scripts/quality-checks.sh

@@ -127,6 +127,9 @@ echo ""
 # Track cache hits/misses for final report
 declare -A CACHE_STATUS
 
+# Track blocking issues
+TAUTOLOGY_BLOCKING=false
+
 # =============================================================================
 # 1. Type safety check - detect 'any' type usage
 # =============================================================================
@@ -355,7 +358,76 @@ else
 fi
 
 # =============================================================================
-# 10. Shell Script Semantic Checks (unused functions, integration)
+# 10. Test Tautology Detection (AC-1 through AC-5)
+# =============================================================================
+echo ""
+echo "🔬 Running test tautology detection..."
+
+# Check for test files in the diff
+test_files_in_diff=$(git diff main...HEAD --name-only | grep -E '\.(test|spec)\.[jt]sx?$' || true)
+
+if [[ -z "$test_files_in_diff" ]]; then
+  CACHE_STATUS["test-quality"]="SKIP"
+  echo "   ⏭️  No test files in diff, skipping tautology check"
+else
+  if cache_check "test-quality"; then
+    CACHE_STATUS["test-quality"]="HIT"
+    cached_result=$(cache_get "test-quality")
+    tautology_passed=$(echo "$cached_result" | grep -o '"passed":\s*[^,}]*' | cut -d: -f2 | tr -d ' ')
+    tautology_message=$(echo "$cached_result" | grep -o '"message":\s*"[^"]*"' | cut -d'"' -f4)
+
+    if [[ "$tautology_passed" == "true" ]]; then
+      echo "   ✅ Test tautology: $tautology_message (cached)"
+    else
+      echo "   ⚠️  Test tautology: $tautology_message (cached)"
+    fi
+  else
+    CACHE_STATUS["test-quality"]="MISS"
+
+    # Check if tautology detector script exists
+    TAUTOLOGY_CLI=""
+    if [[ -f "$SCRIPT_DIR/../../../scripts/qa/tautology-detector-cli.ts" ]]; then
+      TAUTOLOGY_CLI="$SCRIPT_DIR/../../../scripts/qa/tautology-detector-cli.ts"
+    elif [[ -f "scripts/qa/tautology-detector-cli.ts" ]]; then
+      TAUTOLOGY_CLI="scripts/qa/tautology-detector-cli.ts"
+    fi
+
+    if [[ -n "$TAUTOLOGY_CLI" ]] && command -v npx &> /dev/null; then
+      tautology_output=$(npx tsx "$TAUTOLOGY_CLI" --json 2>&1) || tautology_exit=$?
+
+      if [[ -z "$tautology_exit" ]]; then
+        tautology_exit=0
+      fi
+
+      # Parse JSON output
+      tautology_status=$(echo "$tautology_output" | grep -o '"status":"[^"]*"' | cut -d'"' -f4 || echo "none")
+      total_tests=$(echo "$tautology_output" | grep -o '"totalTests":[0-9]*' | cut -d: -f2 || echo "0")
+      total_tautological=$(echo "$tautology_output" | grep -o '"totalTautological":[0-9]*' | cut -d: -f2 || echo "0")
+
+      if [[ "$tautology_status" == "skip" ]]; then
+        echo "   ⏭️  No test blocks found in changed files"
+        cache_set "test-quality" true "No test blocks found" "{\"totalTests\":0,\"tautological\":0}"
+      elif [[ "$tautology_status" == "blocking" ]]; then
+        echo "   ❌ BLOCKER: $total_tautological/$total_tests test blocks are tautological (>50%)"
+        echo "      Tautological tests don't call production code and provide zero regression protection."
+        cache_set "test-quality" false "$total_tautological/$total_tests tests tautological (>50%)" "{\"totalTests\":$total_tests,\"tautological\":$total_tautological}"
+        TAUTOLOGY_BLOCKING=true
+      elif [[ "$tautology_status" == "warning" ]]; then
+        echo "   ⚠️  WARNING: $total_tautological/$total_tests test blocks are tautological"
+        cache_set "test-quality" true "$total_tautological/$total_tests tests tautological" "{\"totalTests\":$total_tests,\"tautological\":$total_tautological}"
+      else
+        echo "   ✅ Test tautology: All tests call production code"
+        cache_set "test-quality" true "All tests call production code" "{\"totalTests\":$total_tests,\"tautological\":0}"
+      fi
+    else
+      echo "   ⚠️  Test tautology detector not available, skipping..."
+      CACHE_STATUS["test-quality"]="SKIP"
+    fi
+  fi
+fi
+
+# =============================================================================
+# 11. Shell Script Semantic Checks (unused functions, integration)
 # =============================================================================
 echo ""
 echo "🔍 Checking shell script semantics..."
@@ -385,8 +457,7 @@ else
 fi
 
 # =============================================================================
-# =============================================================================
-# 11.5. Skill Sync Check (when skill files modified)
+# 12. Skill Sync Check (when skill files modified)
 # =============================================================================
 echo ""
 skill_files_changed=$(git diff main...HEAD --name-only | grep -E '^\.(claude/skills|skills|templates/skills)/' || true)
@@ -431,7 +502,7 @@ else
 fi
 
 # =============================================================================
-# 12. Build Verification (cacheable - expensive operation)
+# 13. Build Verification (cacheable - expensive operation)
 # =============================================================================
 
 verify_build_against_main() {
@@ -613,7 +684,7 @@ echo "=========================================="
 echo ""
 echo "| Check | Cache Status |"
 echo "|-------|--------------|"
-for check in "type-safety" "deleted-tests" "scope" "size" "security" "semgrep" "build"; do
+for check in "type-safety" "deleted-tests" "scope" "size" "security" "semgrep" "test-quality" "build"; do
   status="${CACHE_STATUS[$check]:-MISS}"
   if [[ "$status" == "HIT" ]]; then
     echo "| $check | ✅ HIT |"
@@ -629,7 +700,7 @@ echo ""
 hit_count=0
 miss_count=0
 skip_count=0
-for check in "type-safety" "deleted-tests" "scope" "size" "security" "semgrep" "build"; do
+for check in "type-safety" "deleted-tests" "scope" "size" "security" "semgrep" "test-quality" "build"; do
   status="${CACHE_STATUS[$check]:-MISS}"
   if [[ "$status" == "HIT" ]]; then
     ((hit_count++))
@@ -646,15 +717,17 @@ if [[ $hit_count -gt 0 ]]; then
 fi
 echo ""
 
-# Write structured cache metrics JSON for sequant observability (AC-7)
-# This file is read by run.ts to populate PhaseLog.cacheMetrics
+# Write structured cache metrics JSON for sequant observability (#278/AC-7)
+# This file is read by worktree-manager.ts to populate PhaseLog.cacheMetrics
+# (surfaced via `sequant logs`). Written before the blocking exit logic below so
+# metrics are always emitted, even when a check blocks.
 CACHE_METRICS_DIR=".sequant/.cache/qa"
 mkdir -p "$CACHE_METRICS_DIR"
 
 # Build JSON with per-check status
 CACHE_JSON="{\"hits\":$hit_count,\"misses\":$miss_count,\"skipped\":$skip_count,\"checks\":{"
 first=true
-for check in "type-safety" "deleted-tests" "scope" "size" "security" "semgrep" "build"; do
+for check in "type-safety" "deleted-tests" "scope" "size" "security" "semgrep" "test-quality" "build"; do
   $first || CACHE_JSON+=","
   CACHE_JSON+="\"$check\":\"${CACHE_STATUS[$check]:-MISS}\""
   first=false
@@ -664,5 +737,16 @@ echo "$CACHE_JSON" > "$CACHE_METRICS_DIR/cache-metrics.json"
 
 echo "✅ Quality checks complete"
 
-# Exit with build verification result if it indicates a problem
-exit $build_verification_result
+# Exit with appropriate code based on blocking issues
+# Priority: build verification > tautology blocking
+if [[ $build_verification_result -ne 0 ]]; then
+  exit $build_verification_result
+fi
+
+if [[ "$TAUTOLOGY_BLOCKING" == "true" ]]; then
+  echo ""
+  echo "❌ BLOCKED: >50% of test blocks are tautological (AC-4 violation)"
+  exit 1
+fi
+
+exit 0

package/dist/marketplace/external_plugins/sequant/skills/references/shared/framework-gotchas.md

@@ -0,0 +1,186 @@
+# Framework Gotchas
+
+Common framework-specific issues encountered in this project. Check this reference when encountering unexpected runtime errors or build failures.
+
+## AG Grid (v35+)
+
+### Module Registration Required
+
+AG Grid v35 changed to explicit module registration. If you see errors like "Module not registered" or grid features not working:
+
+```typescript
+import { ModuleRegistry } from 'ag-grid-community';
+import { ClientSideRowModelModule } from 'ag-grid-community';
+
+// Register before using AG Grid components
+ModuleRegistry.registerModules([ClientSideRowModelModule]);
+```
+
+**Common modules to register:**
+- `ClientSideRowModelModule` - Basic row model
+- `CsvExportModule` - CSV export functionality
+- `InfiniteRowModelModule` - Infinite scrolling
+
+**Docs:** [AG Grid v35 Migration Guide](https://www.ag-grid.com/javascript-data-grid/modules/)
+
+### CSS Import Changes
+
+Styles are now in a separate package. Update imports:
+
+```typescript
+// Before v35
+import 'ag-grid-community/styles/ag-grid.css';
+import 'ag-grid-community/styles/ag-theme-alpine.css';
+
+// v35+
+import 'ag-grid-community/styles/ag-grid.css';
+import 'ag-grid-community/styles/ag-theme-quartz.css';  // New default theme
+```
+
+---
+
+## React 19
+
+### use() Hook
+
+React 19 introduces the `use()` hook for reading resources (Promises, Context) during render:
+
+```typescript
+// Reading context with use()
+function Component() {
+  const theme = use(ThemeContext);  // Can be called conditionally
+  return <div className={theme} />;
+}
+
+// Reading promises with use()
+function UserProfile({ userPromise }) {
+  const user = use(userPromise);  // Suspends until resolved
+  return <div>{user.name}</div>;
+}
+```
+
+**Gotcha:** `use()` can be called inside loops and conditionals (unlike other hooks).
+
+**Docs:** [React 19 Release Notes](https://react.dev/blog/2024/12/05/react-19)
+
+### Concurrent Features On by Default
+
+Concurrent rendering is now the default. Watch for:
+- State updates during render (can cause infinite loops)
+- External store subscriptions (use `useSyncExternalStore`)
+- Mutable refs during render
+
+---
+
+## Next.js 15
+
+### Changed Caching Defaults
+
+Next.js 15 no longer caches `fetch()` requests by default:
+
+```typescript
+// Before Next.js 15 - cached by default
+const data = await fetch('/api/data');
+
+// Next.js 15 - NOT cached by default
+const data = await fetch('/api/data');  // Always fresh
+
+// To cache, explicitly opt-in:
+const data = await fetch('/api/data', { cache: 'force-cache' });
+
+// Or use next.revalidate:
+const data = await fetch('/api/data', { next: { revalidate: 3600 } });
+```
+
+**Docs:** [Next.js 15 Caching](https://nextjs.org/docs/app/building-your-application/caching)
+
+### Async Request APIs
+
+Dynamic APIs are now async. Update your code:
+
+```typescript
+// Before Next.js 15
+export default function Page({ params }) {
+  const { id } = params;
+  // ...
+}
+
+// Next.js 15+
+export default async function Page({ params }) {
+  const { id } = await params;
+  // ...
+}
+
+// Same for cookies, headers, searchParams
+import { cookies, headers } from 'next/headers';
+
+// Before
+const cookieStore = cookies();
+
+// After
+const cookieStore = await cookies();
+```
+
+---
+
+## Tailwind v4
+
+### CSS-First Configuration
+
+Tailwind v4 uses CSS for configuration instead of `tailwind.config.js`:
+
+```css
+/* tailwind.css */
+@import "tailwindcss";
+
+@theme {
+  --color-primary: #3b82f6;
+  --font-sans: "Inter", sans-serif;
+}
+```
+
+**Gotcha:** The `@config` directive is removed. Use `@theme` in CSS.
+
+**Docs:** [Tailwind v4 Migration](https://tailwindcss.com/docs/v4-beta)
+
+### Class Syntax Changes
+
+Some utility classes have been renamed or changed:
+
+```html
+<!-- v3 -->
+<div class="bg-opacity-50">
+
+<!-- v4 - use color modifiers -->
+<div class="bg-blue-500/50">
+```
+
+---
+
+## Adding New Gotchas
+
+When you encounter a framework-specific issue that cost debugging time, add it here following this template:
+
+```markdown
+## [Framework Name] (v[X]+)
+
+### [Issue Title]
+
+[Brief description of the problem and when it occurs]
+
+\`\`\`typescript
+// Code example showing the fix or correct approach
+\`\`\`
+
+**Gotcha:** [Key insight or common mistake]
+
+**Docs:** [Link to official documentation or changelog]
+```
+
+### Guidelines for Adding Entries
+
+1. **Version-specific:** Always include the version where the behavior changed
+2. **Code examples:** Show both "before" and "after" when applicable
+3. **Link to docs:** Include official documentation or migration guide links
+4. **Keep it brief:** Focus on the fix, not the full explanation
+5. **Update existing entries:** Prefer updating existing sections over creating duplicates