sequant 1.20.3 → 2.0.1

package/dist/src/lib/upstream/assessment.js

@@ -2,9 +2,9 @@
  * Main assessment module for upstream analysis
  * Coordinates release fetching, analysis, and output generation
  */
-import { spawn } from "node:child_process";
 import { readFile, writeFile, access, mkdir } from "node:fs/promises";
 import { dirname, join } from "node:path";
+import { GitHubProvider } from "../workflow/platforms/github.js";
 import { analyzeRelease, getActionableFindings } from "./relevance.js";
 import { calculateSummary, generateAssessmentReport, generateBatchedSummaryReport, generateLocalReport, } from "./report.js";
 import { createAssessmentIssue, createOrLinkFinding } from "./issues.js";
@@ -22,62 +22,28 @@ export function validateVersion(version) {
         throw new Error(`Invalid version format: "${version}". Expected semver format (e.g., v1.2.3 or 1.2.3-beta.1)`);
     }
 }
-/**
- * Execute a command safely using spawn with argument arrays
- * This prevents command injection by not using shell interpolation
- */
-async function execCommand(command, args) {
-    return new Promise((resolve, reject) => {
-        const proc = spawn(command, args, { stdio: ["pipe", "pipe", "pipe"] });
-        let stdout = "";
-        let stderr = "";
-        proc.stdout.on("data", (data) => {
-            stdout += data.toString();
-        });
-        proc.stderr.on("data", (data) => {
-            stderr += data.toString();
-        });
-        proc.on("close", (code) => {
-            if (code === 0) {
-                resolve({ stdout, stderr });
-            }
-            else {
-                reject(new Error(`Command failed with exit code ${code}: ${stderr}`));
-            }
-        });
-        proc.on("error", (err) => {
-            reject(err);
-        });
-    });
-}
+/** Shared GitHubProvider instance for upstream gh CLI calls. */
+const ghProvider = new GitHubProvider();
 /**
  * Check if gh CLI is available and authenticated
  * @returns Object with availability status and error message if not available
  */
 export async function checkGhCliAvailable() {
-    try {
-        // Check if gh is installed
-        await execCommand("gh", ["--version"]);
-    }
-    catch {
+    if (!ghProvider.checkGhInstalledSync()) {
         return {
             available: false,
             authenticated: false,
             error: "GitHub CLI (gh) is not installed. Install from: https://cli.github.com/",
         };
     }
-    try {
-        // Check if gh is authenticated
-        await execCommand("gh", ["auth", "status"]);
-        return { available: true, authenticated: true };
-    }
-    catch {
+    if (!ghProvider.checkAuthSync()) {
         return {
             available: true,
             authenticated: false,
             error: "GitHub CLI is not authenticated. Run: gh auth login",
         };
     }
+    return { available: true, authenticated: true };
 }
 /**
  * Default paths for upstream files
@@ -93,14 +59,8 @@ export async function fetchRelease(version) {
         if (version) {
             validateVersion(version);
         }
-        // Build args array safely - no shell interpolation
-        const args = ["release", "view"];
-        if (version) {
-            args.push(version);
-        }
-        args.push("--repo", "anthropics/claude-code", "--json", "tagName,name,body,publishedAt");
-        const { stdout } = await execCommand("gh", args);
-        return JSON.parse(stdout);
+        const data = ghProvider.fetchReleaseSync("anthropics/claude-code", version);
+        return data;
     }
     catch (error) {
         console.error("Error fetching release:", error);
@@ -116,17 +76,7 @@ export async function listReleases(limit = 50) {
         if (!Number.isInteger(limit) || limit < 1 || limit > 100) {
             throw new Error("Limit must be an integer between 1 and 100");
         }
-        const { stdout } = await execCommand("gh", [
-            "release",
-            "list",
-            "--repo",
-            "anthropics/claude-code",
-            "--limit",
-            String(limit),
-            "--json",
-            "tagName,publishedAt",
-        ]);
-        return JSON.parse(stdout);
+        return ghProvider.listReleasesSync("anthropics/claude-code", limit);
     }
     catch (error) {
         console.error("Error listing releases:", error);

package/dist/src/lib/upstream/issues.js

@@ -5,10 +5,10 @@
  * Security: All gh CLI calls use spawn() with argument arrays to prevent
  * command injection. No shell interpolation is used.
  */
-import { spawn } from "node:child_process";
 import { writeFile, unlink } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
+import { GitHubProvider } from "../workflow/platforms/github.js";
 import { generateFindingIssue } from "./report.js";
 /**
  * Regex pattern for valid GitHub owner/repo names
@@ -26,34 +26,8 @@ function validateRepoParams(owner, repo) {
         throw new Error(`Invalid repo name: "${repo}"`);
     }
 }
-/**
- * Execute a command safely using spawn with argument arrays
- * This prevents command injection by not using shell interpolation
- */
-async function execCommand(command, args) {
-    return new Promise((resolve, reject) => {
-        const proc = spawn(command, args, { stdio: ["pipe", "pipe", "pipe"] });
-        let stdout = "";
-        let stderr = "";
-        proc.stdout.on("data", (data) => {
-            stdout += data.toString();
-        });
-        proc.stderr.on("data", (data) => {
-            stderr += data.toString();
-        });
-        proc.on("close", (code) => {
-            if (code === 0) {
-                resolve({ stdout, stderr });
-            }
-            else {
-                reject(new Error(`Command failed with exit code ${code}: ${stderr}`));
-            }
-        });
-        proc.on("error", (err) => {
-            reject(err);
-        });
-    });
-}
+/** Shared GitHubProvider instance for upstream gh CLI calls. */
+const ghProvider = new GitHubProvider();
 /**
  * Check if a similar upstream issue already exists
  */
@@ -61,24 +35,8 @@ export async function checkForDuplicate(title, owner = "sequant-io", repo = "seq
     try {
         validateRepoParams(owner, repo);
         // Search for existing upstream issues with similar title
-        // Extract key terms from title for search
         const searchTerms = extractSearchTerms(title);
-        // Use spawn with argument arrays - no shell interpolation
-        const { stdout } = await execCommand("gh", [
-            "issue",
-            "list",
-            "--repo",
-            `${owner}/${repo}`,
-            "--label",
-            "upstream",
-            "--search",
-            searchTerms,
-            "--json",
-            "number,title",
-            "--limit",
-            "10",
-        ]);
-        const issues = JSON.parse(stdout);
+        const issues = ghProvider.searchIssuesSync(`${owner}/${repo}`, ["upstream"], searchTerms, 10);
         // Check for similarity
         for (const issue of issues) {
             if (isSimilarTitle(title, issue.title)) {
@@ -158,27 +116,11 @@ export async function createIssue(params, owner = "sequant-io", repo = "sequant"
     const tempFile = join(tmpdir(), `gh-issue-body-${Date.now()}.md`);
     try {
         await writeFile(tempFile, params.body, "utf-8");
-        // Build args array
-        const args = [
-            "issue",
-            "create",
-            "--repo",
-            `${owner}/${repo}`,
-            "--title",
-            params.title,
-            "--body-file",
-            tempFile,
-        ];
-        // Add labels
-        for (const label of params.labels) {
-            args.push("--label", label);
+        const result = ghProvider.createIssueWithBodyFileSync(`${owner}/${repo}`, params.title, tempFile, params.labels);
+        if (!result) {
+            throw new Error("Failed to create issue");
         }
-        const { stdout } = await execCommand("gh", args);
-        // Parse issue URL from output
-        const url = stdout.trim();
-        const numberMatch = url.match(/\/issues\/(\d+)$/);
-        const number = numberMatch ? parseInt(numberMatch[1], 10) : 0;
-        return { number, url };
+        return result;
     }
     finally {
         // Clean up temp file
@@ -203,15 +145,10 @@ export async function addIssueComment(issueNumber, comment, owner = "sequant-io"
     const tempFile = join(tmpdir(), `gh-comment-${Date.now()}.md`);
     try {
         await writeFile(tempFile, comment, "utf-8");
-        await execCommand("gh", [
-            "issue",
-            "comment",
-            String(issueNumber),
-            "--repo",
-            `${owner}/${repo}`,
-            "--body-file",
-            tempFile,
-        ]);
+        const success = ghProvider.commentOnIssueWithBodyFileSync(`${owner}/${repo}`, issueNumber, tempFile);
+        if (!success) {
+            throw new Error(`Failed to comment on issue #${issueNumber}`);
+        }
     }
     finally {
         // Clean up temp file

package/dist/src/lib/version-check.d.ts

@@ -66,8 +66,8 @@ export declare function isOutdated(currentVersion: string, latestVersion: string
 /**
  * Get the version warning message
  *
- * For local node_modules installs, recommends `npm update sequant`
- * For npx usage, recommends `npx sequant@latest`
+ * For local node_modules installs, recommends the correct update command
+ * for the project's package manager. For npx usage, recommends `npx sequant@latest`.
  */
 export declare function getVersionWarning(currentVersion: string, latestVersion: string, isLocal?: boolean): string;
 /**

package/dist/src/lib/version-check.js

@@ -7,6 +7,7 @@
 import fs from "fs";
 import path from "path";
 import { fileURLToPath } from "url";
+import { detectPackageManagerSync, getPackageManagerCommands, } from "./stacks.js";
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
 const PACKAGE_NAME = "sequant";
@@ -178,14 +179,16 @@ export function isOutdated(currentVersion, latestVersion) {
 /**
  * Get the version warning message
  *
- * For local node_modules installs, recommends `npm update sequant`
- * For npx usage, recommends `npx sequant@latest`
+ * For local node_modules installs, recommends the correct update command
+ * for the project's package manager. For npx usage, recommends `npx sequant@latest`.
  */
 export function getVersionWarning(currentVersion, latestVersion, isLocal) {
     const isLocalInstall = isLocal ?? isLocalNodeModulesInstall();
     if (isLocalInstall) {
+        const pm = detectPackageManagerSync();
+        const pmConfig = getPackageManagerCommands(pm);
         return `sequant ${latestVersion} is available (you have ${currentVersion})
-   Run: npm update sequant
+   Run: ${pmConfig.updatePkg} sequant
    Note: You have sequant as a local dependency. npx uses your node_modules version.`;
     }
     return `sequant ${latestVersion} is available (you have ${currentVersion})

package/dist/src/lib/version.d.ts

@@ -0,0 +1,4 @@
+/**
+ * Version utility - reads version from package.json
+ */
+export declare function getVersion(): string;

package/dist/src/lib/version.js

@@ -0,0 +1,25 @@
+/**
+ * Version utility - reads version from package.json
+ */
+import { fileURLToPath } from "url";
+import { dirname, resolve } from "path";
+import { readFileSync } from "fs";
+export function getVersion() {
+    const __dirname = dirname(fileURLToPath(import.meta.url));
+    let dir = __dirname;
+    while (dir !== dirname(dir)) {
+        const candidate = resolve(dir, "package.json");
+        try {
+            const content = readFileSync(candidate, "utf-8");
+            const pkg = JSON.parse(content);
+            if (pkg.name === "sequant") {
+                return pkg.version;
+            }
+        }
+        catch {
+            // Not found, continue searching
+        }
+        dir = dirname(dir);
+    }
+    return "0.0.0";
+}

package/dist/src/lib/workflow/batch-executor.d.ts

@@ -7,87 +7,30 @@
  * (including quality-loop retries, checkpoint commits, rebasing, and PR
  * creation).
  */
-import { LogWriter } from "./log-writer.js";
-import { StateManager } from "./state-manager.js";
-import { ExecutionConfig, IssueResult } from "./types.js";
-import { ShutdownManager } from "../shutdown.js";
-import type { WorktreeInfo } from "./worktree-manager.js";
-export interface RunOptions {
-    phases?: string;
-    sequential?: boolean;
-    dryRun?: boolean;
-    verbose?: boolean;
-    timeout?: number;
-    logJson?: boolean;
-    noLog?: boolean;
-    logPath?: string;
-    qualityLoop?: boolean;
-    maxIterations?: number;
-    batch?: string[];
-    smartTests?: boolean;
-    noSmartTests?: boolean;
-    testgen?: boolean;
-    autoDetectPhases?: boolean;
-    /** Enable automatic worktree creation for issue isolation */
-    worktreeIsolation?: boolean;
-    /** Reuse existing worktrees instead of creating new ones */
-    reuseWorktrees?: boolean;
-    /** Suppress version warnings and non-essential output */
-    quiet?: boolean;
-    /** Chain issues: each branches from previous (requires --sequential) */
-    chain?: boolean;
-    /**
-     * Wait for QA pass before starting next issue in chain mode.
-     * When enabled, the chain pauses if QA fails, preventing downstream issues
-     * from building on potentially broken code.
-     */
-    qaGate?: boolean;
-    /**
-     * Base branch for worktree creation.
-     * Resolution priority: this CLI flag → settings.run.defaultBase → 'main'
-     */
-    base?: string;
-    /**
-     * Disable MCP servers in headless mode.
-     * When true, MCPs are not passed to the SDK (faster/cheaper runs).
-     * Resolution priority: this CLI flag → settings.run.mcp → default (true)
-     */
-    noMcp?: boolean;
-    /**
-     * Resume from last completed phase.
-     * Reads phase markers from GitHub issue comments and skips completed phases.
-     */
-    resume?: boolean;
-    /**
-     * Disable automatic retry with MCP fallback.
-     * When true, no retry attempts are made on phase failure.
-     * Useful for debugging to see the actual failure without retry masking it.
-     */
-    noRetry?: boolean;
-    /**
-     * Skip pre-PR rebase onto the base branch.
-     * When true, branches are not rebased before creating the PR.
-     * Use when you want to preserve branch state or handle rebasing manually.
-     */
-    noRebase?: boolean;
-    /**
-     * Skip PR creation after successful QA.
-     * When true, branches are pushed but no PR is created.
-     * Useful for manual workflows where PRs are created separately.
-     */
-    noPr?: boolean;
-    /**
-     * Force re-execution of issues even if they have completed status.
-     * Bypasses the pre-flight state guard that skips ready_for_merge/merged issues.
-     */
-    force?: boolean;
-    /**
-     * Analyze run results and suggest workflow improvements.
-     * Displays observations about timing patterns, phase mismatches, and
-     * actionable suggestions after the summary output.
-     */
-    reflect?: boolean;
-}
+import { PhaseResult, IssueResult, type RunOptions, type IssueExecutionContext, type BatchExecutionContext } from "./types.js";
+export type { RunOptions, ProgressCallback, IssueExecutionContext, BatchExecutionContext, } from "./types.js";
+/**
+ * Emit a structured progress line to stderr for MCP progress notifications.
+ * Only emits when running under an orchestrator (e.g., MCP server).
+ * The MCP handler parses these lines to send `notifications/progress`.
+ *
+ * @param issue - GitHub issue number
+ * @param phase - Phase name (e.g., "spec", "exec", "qa")
+ * @param event - Phase lifecycle event: "start", "complete", or "failed"
+ * @param extra - Optional fields: durationSeconds (on complete), error (on failed)
+ */
+/**
+ * Build enriched prompt context for the /loop phase from a failed phase result (#488).
+ * Passes QA verdict, failed ACs, and error directly so the /loop skill doesn't need
+ * to reconstruct context from GitHub comments (which fails in subprocess).
+ *
+ * @internal Exported for testing only
+ */
+export declare function buildLoopContext(failedResult: PhaseResult): string;
+export declare function emitProgressLine(issue: number, phase: string, event?: "start" | "complete" | "failed", extra?: {
+    durationSeconds?: number;
+    error?: string;
+}): void;
 export declare function getIssueInfo(issueNumber: number): Promise<{
     title: string;
     labels: string[];
@@ -110,8 +53,5 @@ export declare function parseBatches(batchArgs: string[]): number[][];
  * Parse environment variables for CI configuration
  */
 export declare function getEnvConfig(): Partial<RunOptions>;
-export declare function executeBatch(issueNumbers: number[], config: ExecutionConfig, logWriter: LogWriter | null, stateManager: StateManager | null, options: RunOptions, issueInfoMap: Map<number, {
-    title: string;
-    labels: string[];
-}>, worktreeMap: Map<number, WorktreeInfo>, shutdownManager?: ShutdownManager, packageManager?: string, baseBranch?: string): Promise<IssueResult[]>;
-export declare function runIssueWithLogging(issueNumber: number, config: ExecutionConfig, logWriter: LogWriter | null, stateManager: StateManager | null, issueTitle: string, labels: string[], options: RunOptions, worktreePath?: string, branch?: string, shutdownManager?: ShutdownManager, chainMode?: boolean, packageManager?: string, isLastInChain?: boolean, baseBranch?: string): Promise<IssueResult>;
+export declare function executeBatch(issueNumbers: number[], batchCtx: BatchExecutionContext): Promise<IssueResult[]>;
+export declare function runIssueWithLogging(ctx: IssueExecutionContext): Promise<IssueResult>;