senza-sdk 4.3.1-4a01fcf.0 → 4.3.1-e113d43.0

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "senza-sdk",
-    "version": "4.3.1-4a01fcf.0",
+    "version": "4.3.1-e113d43.0",
     "main": "./src/api.js",
     "description": "API for Senza application",
     "license": "MIT",
@@ -58,7 +58,6 @@
         }
     },
     "dependencies": {
-        "shaka-player": "^4.12.5",
-        "moment": "^2.30.1"
+        "shaka-player": "^4.12.5"
     }
 }

package/src/implementation/remotePlayer.js

@@ -69,7 +69,6 @@ function setPlaybackInfo(playbackInfo) {
 * @typedef {Object} Config
 * @property {string} preferredAudioLanguage
 * @property {string} preferredSubtitlesLanguage
-* @property {number} minSuggestedPresentationDelay - minimal delay allowed for live playback in seconds
 * @property {boolean} autoPlay - (Not implemented yet) upon loading start playing automatically
 */
 
@@ -80,9 +79,9 @@ function setPlaybackInfo(playbackInfo) {
  * @fires ended
  * @fires error
  * @fires onloadmodechange
- * @fires playing
  * @fires seeking (Not implemented yet)
  * @fires seeked (Not implemented yet)
+ * @fires loadedmetadata (Not implemented yet)
  */
 class RemotePlayer extends RemotePlayerInterface {
     constructor() {
@@ -93,8 +92,7 @@ class RemotePlayer extends RemotePlayerInterface {
          */
         this._config = {
             preferredAudioLanguage: "",
-            preferredSubtitlesLanguage: "",
-            minSuggestedPresentationDelay: 0
+            preferredSubtitlesLanguage: ""
         };
         /**
          * @type {string}
@@ -527,10 +525,10 @@ class RemotePlayer extends RemotePlayerInterface {
 
     /** setting values for properties in the player configuration using an object.
      * If the config does not support a property this is a no-op.
-     * @param {Config} props the object with all the different properties to change.
+     * @param {Object} props the object with all the different properties to change
      * @example
      * remotePlayer.configure({ preferredAudioLanguage: 'en-US' })
-     * remotePlayer.configure({ minSuggestedPresentationDelay: 6 })
+     *
      * */
     configure(props) {
         Object.entries(props).forEach(([key, value]) => {
@@ -899,9 +897,6 @@ class RemotePlayer extends RemotePlayerInterface {
                 this._updateSeekListeners(video);
             }
             this._videoElement = video;
-
-            // Emit a custom event to notify about the attachment of the video element
-            this.dispatchEvent(new Event("videoelementattached"));
         }
     }
 
@@ -917,7 +912,7 @@ class RemotePlayer extends RemotePlayerInterface {
     /** Tell the remote player to load the given URL.
      * @param {string} url url to load
      * @param {number} [position] start position in seconds (if not provided, start from beginning (VOD) or current time (LTV))
-    * @returns {Promise}
+     * @returns {Promise}
      * @throws {RemotePlayerError} error object contains code & msg
      *
      * */
@@ -982,11 +977,6 @@ class RemotePlayer extends RemotePlayerInterface {
                     message.action = "load";
                     message.audioLanguage = audioLanguage;
                     message.subtitlesLanguage = subtitlesLanguage;
-                    if (this.getConfiguration().minSuggestedPresentationDelay > 0) {
-                        message.cloudPlayerParams = {
-                            "mspd": this.getConfiguration().minSuggestedPresentationDelay
-                        };
-                    }
                 } else {
                     message.type = "setPlayableUri";
                 }

package/src/implementation/senzaShakaPlayer.js

@@ -2,8 +2,6 @@ import { shaka } from "../interface/senzaShakaPlayer";
 
 import { remotePlayer, lifecycle, getPlatformInfo } from "./api";
 import { sdkLogger, iso6393to1 } from "./utils";
-import moment from "moment";
-
 
 //  Define custom error category
 shaka.util.Error.Category.SENZA_PLAYER_ERROR = 50;
@@ -74,9 +72,9 @@ export class SenzaShakaPlayer extends shaka.Player {
      * @private
      * @type {number}
      * @description Timeout in milliseconds to wait for playing event
-     * @default 4000
+     * @default 3000
      */
-    _playingTimeout = 4000;
+    _playingTimeout = 3000;
 
     /**
      * @private
@@ -91,7 +89,7 @@ export class SenzaShakaPlayer extends shaka.Player {
      * @description Whether to stop remote player on error
      * @default false
      */
-    _shouldStopOnRemotePlayerError = false;
+    _shouldStopRemotePlayerOnError = false;
 
     /**
      * @private
@@ -282,15 +280,13 @@ export class SenzaShakaPlayer extends shaka.Player {
 
 
     /**
-     * Handles errors received by remote player while waiting for the playing event.
-     * The promise returned to the call for video element play will be rejected.
+     * Handles errors for play promises and remote player events.
      * @private
      * @param {Error} error - The error object.
        */
     _handlePlayPromiseError(error) {
 
         sdkLogger.error("Error while waiting for playing event:", error);
-
         if (this._playPromiseReject) {
             this._playPromiseReject(error);
             this._playPromiseResolve = null;
@@ -300,46 +296,6 @@ export class SenzaShakaPlayer extends shaka.Player {
             clearTimeout(this._playTimeoutId);
             this._playTimeoutId = null;
         }
-
-    }
-
-    /**
-     * @private
-     * @type {number}
-     * @description Minimum suggested presentation delay in seconds
-     * @default 15
-     */
-    _minSuggestedPresentationDelay = 15;
-
-    /**
-     * Modifies the suggestedPresentationDelay in the manifest text
-     * @private
-     * @param {string} manifestText - The MPD manifest text
-     * @returns {string} - Modified manifest text , or undefined if no modification was done
-     */
-    _updateManifestDelayIfBelowMinimum(manifestText) {
-        // Look for suggestedPresentationDelay attribute
-        const match = manifestText.match(/suggestedPresentationDelay="([^"]+)"/);
-        if (match) {
-            const durationString = match[1];
-            const duration = moment.duration(durationString);
-            const currentDelay = duration.asSeconds();
-
-            sdkLogger.info(`Found suggestedPresentationDelay in manifest: ${currentDelay.toFixed(3)}s`);
-
-            if (currentDelay < this._minSuggestedPresentationDelay) {
-                // Replace the value in the manifest text with 3 decimal places
-                manifestText = manifestText.replace(
-                    /suggestedPresentationDelay="[^"]+"/,
-                    `suggestedPresentationDelay="PT${this._minSuggestedPresentationDelay.toFixed(3)}S"`
-                );
-                sdkLogger.info(`Updated manifest suggestedPresentationDelay to ${this._minSuggestedPresentationDelay.toFixed(3)}s`);
-                return manifestText;
-            }
-        } else {
-            sdkLogger.info("suggestedPresentationDelay is not defined at the manifest");
-        }
-        return undefined;
     }
 
     /**
@@ -369,38 +325,14 @@ export class SenzaShakaPlayer extends shaka.Player {
         const playTimeout = getPlatformInfo()?.sessionInfo?.settings?.["ui-streamer"]?.playingEventTimeout;
         this._playingTimeout = (playTimeout >= 0) ? playTimeout*1000 : this._playingTimeout;
 
-        // Initialize minSuggestedPresentationDelay from UI settings or use default
-        const uiSettings = getPlatformInfo()?.sessionInfo?.settings?.["ui-streamer"];
-        if (uiSettings?.minSuggestedPresentationDelay !== undefined) {
-            this._minSuggestedPresentationDelay = uiSettings.minSuggestedPresentationDelay;
-            sdkLogger.info(`Using configured minSuggestedPresentationDelay: ${this._minSuggestedPresentationDelay}s`);
-        }
-
         // if video element is provided, add the listeres here. In this case ,there is no need to call attach.
         if (videoElement) {
             this._attach(videoElement);
             sdkLogger.warn("SenzaShakaPlayer constructor Adding videoElement in the constructor is going to be deprecated in the future. Please use attach method instead.");
         }
 
-        this.configure({
-            manifest: {
-                defaultPresentationDelay: this._minSuggestedPresentationDelay // in seconds
-            }
-        });
-
-        remotePlayer.configure({
-            minSuggestedPresentationDelay: this._minSuggestedPresentationDelay
-        });
-
-        this.addEventListener("buffering", () => {
-            if (this.videoElement) {
-                sdkLogger.info("Buffering at time:", this.videoElement.currentTime);
-            }
-        });
-
     }
 
-
     _attach(videoElement) {
         this.videoElement = videoElement;
 
@@ -624,12 +556,11 @@ export class SenzaShakaPlayer extends shaka.Player {
         const isCritical = this._isErrorCritical(remotePlayerErrorCode);
         const error = this._createSenzaError(remotePlayerErrorCode, message, isCritical);
         const errorMap = new Map();
-        const shouldStopPlayback = this._shouldStopOnRemotePlayerError && this.videoElement && isCritical;
         errorMap.set("detail", error);
 
         // Check if we should stop playback - only for critical errors when configured
-
-        if (shouldStopPlayback) {
+        if (this._shouldStopRemotePlayerOnError &&
+            this.videoElement && isCritical) {
             try {
                 sdkLogger.warn("Stopping local player playback due to critical error");
                 // Stop only local playback
@@ -637,11 +568,9 @@ export class SenzaShakaPlayer extends shaka.Player {
             } catch (stopError) {
                 sdkLogger.error("Error while trying to stop video element playback:", stopError);
             }
-            // Handle error while waiting for play event. If the error is not critical or the system is configured not to stop remote player on error,
-            //  the playback timeout will start the local playback
-            this._handlePlayPromiseError(error);
         }
-
+        // Handle error while waiting for play event
+        this._handlePlayPromiseError(error);
         this.dispatchEvent(new shaka.util.FakeEvent("error", errorMap));
     }
 
@@ -679,30 +608,16 @@ export class SenzaShakaPlayer extends shaka.Player {
 
         // This callbakc will be activated when the manifest is loaded. It will trigger load of the remote player.
         // This will ensure that the remote player is loaded only after the manifest is loaded by local player.
-        const responseFilterCallback = async (type, response) => {
-            if (type === shaka.net.NetworkingEngine.RequestType.MANIFEST) {
+        const responseFilterCallback = async (type) => {
+            if (type === shaka.net.NetworkingEngine.RequestType.MANIFEST && !manifestLoadHandled) {
+                manifestLoadHandled = true;
                 try {
-                    if (response.data && this._minSuggestedPresentationDelay > 0) {
-                        const manifestText = new TextDecoder().decode(response.data);
-                        const modifiedText = this._updateManifestDelayIfBelowMinimum(manifestText);
-                        if (modifiedText) {
-                            const responseData = new TextEncoder().encode(modifiedText).buffer;
-                            response.data = responseData;
-                        }
-                    }
+                    await this._remotePlayerLoad(url, startTime);
+                    remoteLoadResolver();
                 } catch (error) {
-                    sdkLogger.error("Error processing manifest:", error);
+                    remoteLoadRejecter(error);
                 }
 
-                if (!manifestLoadHandled) {
-                    manifestLoadHandled = true;
-                    try {
-                        await this._remotePlayerLoad(url, startTime);
-                        remoteLoadResolver();
-                    } catch (error) {
-                        remoteLoadRejecter(error);
-                    }
-                }
             }
         };
 
@@ -765,14 +680,14 @@ export class SenzaShakaPlayer extends shaka.Player {
     /**
      * Override the configure method to add custom configuration handling
      * Supports the following additional configuration options:
-     * - shouldStopOnRemotePlayerError: boolean - If true, local player will be stopped on remote player error
+     * - shouldStopRemotePlayerOnError: boolean - If true, remote player will be stopped on error
      *
      * @override
      * @param {Object} config - Configuration object to be merged with existing config
-     * @param {boolean} [config.shouldStopOnRemotePlayerError=true] - Whether to stop local player on remote player error
+     * @param {boolean} [config.shouldStopRemotePlayerOnError=true] - Whether to stop remote player on error
      * @example
      * player.configure({
-     *   shouldStopOnRemotePlayerError: false,  // Don't stop local playback  on remote player error
+     *   shouldStopRemotePlayerOnError: false,  // Don't stop remote player on error
      *   // ... other shaka configurations
      * });
      */
@@ -780,12 +695,12 @@ export class SenzaShakaPlayer extends shaka.Player {
         sdkLogger.log("configure player with: ", JSON.stringify(config));
 
         // Handle custom configuration
-        if (config.shouldStopOnRemotePlayerError !== undefined) {
-            this._shouldStopOnRemotePlayerError = !!config.shouldStopOnRemotePlayerError;
+        if (config.shouldStopRemotePlayerOnError !== undefined) {
+            this._shouldStopRemotePlayerOnError = !!config.shouldStopRemotePlayerOnError;
             // Remove our custom config so it doesn't get passed to parent
             // Use rest operator without creating a named variable for the removed property
             // eslint-disable-next-line no-unused-vars
-            const { shouldStopOnRemotePlayerError, ...shakaConfig } = config;
+            const { shouldStopRemotePlayerOnError, ...shakaConfig } = config;
             config = shakaConfig;
         }
 

package/src/interface/devSequence.js

@@ -204,7 +204,6 @@ const setupSequence = (components, items) => {
     };
     methodInject(components, inject, (name) => name.startsWith("_") || name.startsWith("get"));
     handleKeys(items);
-    playersEvents(components, items);
     sdkLogger.log("Sequence initialized.");
 };
 
@@ -258,37 +257,3 @@ export const showSequence = (visible = true) => {
     }
     container.style.visibility = visible ? "visible" : "hidden";
 };
-function playersEvents(components, items) {
-    components.remotePlayer.addEventListener("videoelementattached", () => {
-        const video = components.remotePlayer._videoElement;
-        if (video && !video._devSequenceRateChangeHandler) {
-            video._devSequenceRateChangeHandler = () => {
-                items.push({
-                    component: "localPlayer",
-                    id: "ratechange=" + video.playbackRate,
-                    time: performance.now() - currentTime
-                });
-            };
-            video.addEventListener("ratechange", video._devSequenceRateChangeHandler);
-        }
-
-        if (video && !video._devSequencePlayingHandler) {
-            video._devSequencePlayingHandler = () => {
-                items.push({
-                    component: "localPlayer",
-                    id: "playing event",
-                    time: performance.now() - currentTime
-                });
-            };
-            video.addEventListener("playing", video._devSequencePlayingHandler);
-        }
-    });
-    components.remotePlayer.addEventListener("playing", () => {
-        items.push({
-            component: "remotePlayer",
-            id: "playing event",
-            time: performance.now() - currentTime
-        });
-    });
-}
-