senza-sdk 4.2.63-8d2e60f.0 → 4.2.63

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "senza-sdk",
-    "version": "4.2.63-8d2e60f.0",
+    "version": "4.2.63",
     "main": "./src/api.js",
     "description": "API for Senza application",
     "license": "MIT",
@@ -15,7 +15,7 @@
         "eslint": "eslint --max-warnings 0  src test",
         "build": "npx webpack --config webpack.config.js",
         "test": "jest --coverage --verbose",
-        "testall": "jest --coverage --verbose && npm run eslint --fix"
+        "testall" : "jest --coverage --verbose && npm run eslint --fix"
     },
     "devDependencies": {
         "@babel/cli": "^7.13.16",

package/src/alarmManager.js

@@ -66,7 +66,7 @@ class AlarmManager extends EventTarget {
                 if (isTriggering) {
                     if (!this._moveToForegroundHasBeenCalled && window.cefQuery) {
                         logger.log("Application is about to be terminated since didn't move to foreground");
-                        const message = { type: "disconnect" };
+                        const message = { type: "terminating" };
                         const request = { target:"TC", waitForResponse: false, message: JSON.stringify(message) };
                         window.cefQuery({
                             request: JSON.stringify(request),

package/src/lifecycle.js

@@ -914,7 +914,7 @@ class Lifecycle extends EventTarget {
         if (window.cefQuery) {
             const FCID = getFCID();
             const message = {
-                type: "disconnect",
+                type: "terminating",
                 fcid: FCID
             };
             const request = { target: "TC", waitForResponse: false, message: JSON.stringify(message) };

package/src/senzaShakaPlayer.js

@@ -78,7 +78,7 @@ export class SenzaShakaPlayer extends shaka.Player {
      * @description Timeout in milliseconds to wait for playing event
      * @default 3000
      */
-    _playingTimeout = 3000;
+    _playingTimeout = 4000;
 
     /**
      * @private
@@ -93,7 +93,7 @@ export class SenzaShakaPlayer extends shaka.Player {
      * @description Whether to stop remote player on error
      * @default false
      */
-    _shouldStopRemotePlayerOnError = false;
+    _shouldStopOnRemotePlayerError = false;
 
     /**
      * @private
@@ -284,13 +284,15 @@ export class SenzaShakaPlayer extends shaka.Player {
 
 
     /**
-     * Handles errors for play promises and remote player events.
+     * Handles errors received by remote player while waiting for the playing event.
+     * The promise returned to the call for video element play will be rejected.
      * @private
      * @param {Error} error - The error object.
        */
     _handlePlayPromiseError(error) {
 
         sdkLogger.error("Error while waiting for playing event:", error);
+
         if (this._playPromiseReject) {
             this._playPromiseReject(error);
             this._playPromiseResolve = null;
@@ -300,6 +302,7 @@ export class SenzaShakaPlayer extends shaka.Player {
             clearTimeout(this._playTimeoutId);
             this._playTimeoutId = null;
         }
+
     }
 
     /**
@@ -560,11 +563,12 @@ export class SenzaShakaPlayer extends shaka.Player {
         const isCritical = this._isErrorCritical(remotePlayerErrorCode);
         const error = this._createSenzaError(remotePlayerErrorCode, message, isCritical);
         const errorMap = new Map();
+        const shouldStopPlayback = this._shouldStopOnRemotePlayerError && this.videoElement && isCritical;
         errorMap.set("detail", error);
 
         // Check if we should stop playback - only for critical errors when configured
-        if (this._shouldStopRemotePlayerOnError &&
-            this.videoElement && isCritical) {
+
+        if (shouldStopPlayback) {
             try {
                 sdkLogger.warn("Stopping local player playback due to critical error");
                 // Stop only local playback
@@ -572,9 +576,11 @@ export class SenzaShakaPlayer extends shaka.Player {
             } catch (stopError) {
                 sdkLogger.error("Error while trying to stop video element playback:", stopError);
             }
+            // Handle error while waiting for play event. If the error is not critical or the system is configured not to stop remote player on error,
+            //  the playback timeout will start the local playback
+            this._handlePlayPromiseError(error);
         }
-        // Handle error while waiting for play event
-        this._handlePlayPromiseError(error);
+
         this.dispatchEvent(new shaka.util.FakeEvent("error", errorMap));
     }
 
@@ -684,14 +690,14 @@ export class SenzaShakaPlayer extends shaka.Player {
     /**
      * Override the configure method to add custom configuration handling
      * Supports the following additional configuration options:
-     * - shouldStopRemotePlayerOnError: boolean - If true, remote player will be stopped on error
+     * - shouldStopOnRemotePlayerError: boolean - If true, local player will be stopped on remote player error
      *
      * @override
      * @param {Object} config - Configuration object to be merged with existing config
-     * @param {boolean} [config.shouldStopRemotePlayerOnError=true] - Whether to stop remote player on error
+     * @param {boolean} [config.shouldStopOnRemotePlayerError=true] - Whether to stop local player on remote player error
      * @example
      * player.configure({
-     *   shouldStopRemotePlayerOnError: false,  // Don't stop remote player on error
+     *   shouldStopOnRemotePlayerError: false,  // Don't stop local playback  on remote player error
      *   // ... other shaka configurations
      * });
      */
@@ -699,12 +705,12 @@ export class SenzaShakaPlayer extends shaka.Player {
         sdkLogger.log("configure player with: ", JSON.stringify(config));
 
         // Handle custom configuration
-        if (config.shouldStopRemotePlayerOnError !== undefined) {
-            this._shouldStopRemotePlayerOnError = !!config.shouldStopRemotePlayerOnError;
+        if (config.shouldStopOnRemotePlayerError !== undefined) {
+            this._shouldStopOnRemotePlayerError = !!config.shouldStopOnRemotePlayerError;
             // Remove our custom config so it doesn't get passed to parent
             // Use rest operator without creating a named variable for the removed property
             // eslint-disable-next-line no-unused-vars
-            const { shouldStopRemotePlayerOnError, ...shakaConfig } = config;
+            const { shouldStopOnRemotePlayerError, ...shakaConfig } = config;
             config = shakaConfig;
         }