senza-sdk 4.2.54-b3a1f15.0 → 4.2.54-d09bbe7.0

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "senza-sdk",
-    "version": "4.2.54-b3a1f15.0",
+    "version": "4.2.54-d09bbe7.0",
     "main": "./src/api.js",
     "description": "API for Senza application",
     "license": "MIT",

package/src/lifecycle.js

@@ -551,10 +551,6 @@ class Lifecycle extends EventTarget {
             alarmManager._moveToForegroundCalled();
             const FCID = getFCID();
             if (this._remotePlayerApiVersion >= 2) {
-                // Only update to playing UI if we started seeking in ABR. But, if we are seeking while already paused, keep the target seek state as is.
-                if (remotePlayer._isSeekingByApplication && remotePlayer._targetSeekPlayingState === TargetPlayingState.PLAYING_ABR) {
-                    remotePlayer._targetSeekPlayingState = TargetPlayingState.PLAYING_UI;
-                }
                 return new Promise((resolve, reject) => {
                     const FCID = getFCID();
                     const logger = sdkLogger.withFields({ FCID });
@@ -622,6 +618,10 @@ class Lifecycle extends EventTarget {
 
     _moveToBackground() {
         if (window.cefQuery) {
+            if (this._inTransition || this._state === this.UiState.BACKGROUND || this._state === this.UiState.IN_TRANSITION_TO_BACKGROUND) {
+                sdkLogger.warn(`lifecycle moveToBackground: No need to transition to background, state: ${this._state} transition: ${this._inTransition}`);
+                return Promise.resolve(false);
+            }
             // If audio sync is disabled, we only need to sync before remote player starts playing
             if (!isAudioSyncConfigured()) {
                 remotePlayer._syncRemotePlayerWithLocalPlayer();
@@ -710,12 +710,12 @@ class Lifecycle extends EventTarget {
      * Failure to process the moveToBackground command will result in the promise being rejected.
      */
     moveToBackground() {
-        if (window.cefQuery) {
-            if (this._inTransition || this._state === this.UiState.BACKGROUND || this._state === this.UiState.IN_TRANSITION_TO_BACKGROUND) {
-                sdkLogger.warn(`lifecycle moveToBackground: No need to transition to background, state: ${this._state} transition: ${this._inTransition}`);
-                return Promise.resolve(false);
-            }
-            if (remotePlayer._isSeekingByApplication) {
+        if (remotePlayer._isSeekingByApplication) {
+            if (window.cefQuery) {
+                if (this._inTransition || this._state === this.UiState.BACKGROUND || this._state === this.UiState.IN_TRANSITION_TO_BACKGROUND) {
+                    sdkLogger.warn(`lifecycle moveToBackground: No need to transition to background, state: ${this._state} transition: ${this._inTransition}`);
+                    return Promise.resolve(false);
+                }
                 remotePlayer._targetSeekPlayingState = TargetPlayingState.PLAYING_ABR;
                 return Promise.resolve(true);
             }

package/src/remotePlayer.js

@@ -1434,10 +1434,12 @@ class RemotePlayer extends EventTarget {
             }
         }
 
-        if (this._remotePlayerApiVersion >= 2 && !this._isSeekingByPlatform && !this._isSeekingByApplication) {
+        // Only allow seeking in foreground. Still ignore the initialized local player seeking event above
+        if (this._remotePlayerApiVersion >= 2 && !this._isSeekingByPlatform && !this._isSeekingByApplication &&
+            (lifecycle.state === lifecycle.UiState.FOREGROUND || lifecycle.state === lifecycle.UiState.IN_TRANSITION_TO_FOREGROUND)) {
             this._atomicSeek();
         } else {
-            sdkLogger.info(`Seeking: skipping seeking event to currentTime=${this._videoElement.currentTime} internalSeek=${this._isSeekingByPlatform} localPlayerSeek=${this._isSeekingByApplication}`);
+            sdkLogger.info(`Seeking: skipping seeking event to currentTime=${playbackPosition} internalSeek=${this._isSeekingByPlatform} localPlayerSeek=${this._isSeekingByApplication} state="${lifecycle.state}"`);
         }
     }
 
@@ -1454,15 +1456,15 @@ class RemotePlayer extends EventTarget {
     async _atomicSeek() {
         sdkLogger.info("Seeking: local video element seeking start while isPLaying=", this._isPlaying);
 
-        if (this._isPlaying) {
-            if (lifecycle.state === lifecycle.UiState.BACKGROUND || lifecycle.state === lifecycle.UiState.IN_TRANSITION_TO_BACKGROUND) {
-                this._targetSeekPlayingState = TargetPlayingState.PLAYING_ABR;
-            } else {
-                this._targetSeekPlayingState = TargetPlayingState.PLAYING_UI;
-            }
-        } else {
-            this._targetSeekPlayingState = TargetPlayingState.PAUSED;
-        }
+        // Initialize the target playing state unless changed during the seek process
+        // In the future, we should allow for seeking in background. Currently, there's no
+        // way to know when the web application will call moveToForeground (i.e Before/After seek)
+        // Therefore, for now, we will assume the target is either paused or playing in ui unless
+        // specifically receiving a moveToBackground during the process.
+        // if (this._isPlaying && (lifecycle.state === lifecycle.UiState.BACKGROUND || lifecycle.state === lifecycle.UiState.IN_TRANSITION_TO_BACKGROUND)) {
+        //     this._targetSeekPlayingState = TargetPlayingState.PLAYING_ABR;
+        // }
+        this._targetSeekPlayingState = this._isPlaying ? TargetPlayingState.PLAYING_UI : TargetPlayingState.PAUSED;
 
         // The platform could be currently syncing audio/video using playback rate. Reset when performing seek.
         if (this._videoElement) {
@@ -1529,7 +1531,7 @@ class RemotePlayer extends EventTarget {
 
         // If in TargetPlayingState.PAUSE, no need to resume.
         // Resume without awaiting to avoid blocking the seek process anymore
-        // In case where we aborted (new load or unload called), we don't want to resume playback.
+        // In case where we aborted, we don't want to resume playback.
         if (!this._abortSeeking) {
             if (this._targetSeekPlayingState === TargetPlayingState.PLAYING_UI) {
                 this._play();