sentinelayer-cli 0.37.1 → 0.39.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sentinelayer-cli",
-  "version": "0.37.1",
+  "version": "0.39.0",
   "description": "Scaffold Sentinelayer spec/prompt/guide artifacts with secure browser auth and token bootstrap.",
   "type": "module",
   "scripts": {
@@ -48,6 +48,7 @@
     "url": "https://github.com/mrrCarter/create-sentinelayer/issues"
   },
   "dependencies": {
+    "@anthropic-ai/tokenizer": "0.0.4",
     "@axe-core/playwright": "4.11.2",
     "@babel/parser": "7.29.2",
     "axe-core": "4.11.3",
@@ -60,6 +61,7 @@
     "picocolors": "1.1.1",
     "playwright": "1.59.1",
     "prompts": "2.4.2",
+    "tiktoken": "1.0.22",
     "yaml": "2.8.3",
     "zod": "4.1.12"
   },

package/src/agents/code-quality/index.js

@@ -9,4 +9,5 @@ export {
   runCouplingAnalysis,
   runCycleDetect,
   runDepGraph,
+  runLayeringCheck,
 } from "./tools/index.js";

package/src/agents/code-quality/tools/index.js

@@ -4,6 +4,7 @@ import { runComplexityMeasure } from "./complexity-measure.js";
 import { runCouplingAnalysis } from "./coupling-analysis.js";
 import { runCycleDetect } from "./cycle-detect.js";
 import { runDepGraph } from "./dep-graph.js";
+import { runLayeringCheck } from "./layering-check.js";
 
 export const CODE_QUALITY_TOOLS = Object.freeze({
   "dep-graph": {
@@ -60,6 +61,20 @@ export const CODE_QUALITY_TOOLS = Object.freeze({
     },
     handler: runComplexityMeasure,
   },
+  "layering-check": {
+    id: "layering-check",
+    description:
+      "Flag lower architectural layers importing higher-level app/UI layers. Uses the dep-graph under the hood and ignores external or unknown-layer imports.",
+    schema: {
+      type: "object",
+      properties: {
+        rootPath: { type: "string" },
+        files: { type: "array", items: { type: "string" } },
+        layers: { type: "array" },
+      },
+    },
+    handler: runLayeringCheck,
+  },
 });
 
 export const CODE_QUALITY_TOOL_IDS = Object.freeze(Object.keys(CODE_QUALITY_TOOLS));
@@ -86,4 +101,5 @@ export {
   runCouplingAnalysis,
   runCycleDetect,
   runDepGraph,
+  runLayeringCheck,
 };

package/src/agents/code-quality/tools/layering-check.js

@@ -0,0 +1,195 @@
+// layering-check — flag lower architectural layers importing higher layers (#A14).
+
+import { createFinding, toPosix } from "./base.js";
+import { buildDependencyGraph } from "./dep-graph.js";
+
+const RESOLUTION_EXTENSIONS = Object.freeze([
+  ".js",
+  ".jsx",
+  ".ts",
+  ".tsx",
+  ".mjs",
+  ".cjs",
+]);
+
+export const DEFAULT_LAYER_RULES = Object.freeze([
+  Object.freeze({
+    name: "shared",
+    rank: 0,
+    prefixes: Object.freeze(["src/shared/", "src/lib/", "shared/", "lib/"]),
+  }),
+  Object.freeze({
+    name: "domain",
+    rank: 1,
+    prefixes: Object.freeze(["src/domain/", "src/core/", "domain/", "core/"]),
+  }),
+  Object.freeze({
+    name: "data",
+    rank: 2,
+    prefixes: Object.freeze([
+      "src/data/",
+      "src/db/",
+      "src/models/",
+      "data/",
+      "db/",
+      "models/",
+    ]),
+  }),
+  Object.freeze({
+    name: "services",
+    rank: 3,
+    prefixes: Object.freeze(["src/services/", "src/server/", "services/", "server/"]),
+  }),
+  Object.freeze({
+    name: "app",
+    rank: 4,
+    prefixes: Object.freeze([
+      "src/app/",
+      "src/api/",
+      "src/controllers/",
+      "src/handlers/",
+      "src/pages/",
+      "src/routes/",
+      "app/",
+      "api/",
+      "controllers/",
+      "handlers/",
+      "pages/",
+      "routes/",
+    ]),
+  }),
+  Object.freeze({
+    name: "ui",
+    rank: 5,
+    prefixes: Object.freeze(["src/components/", "src/ui/", "components/", "ui/"]),
+  }),
+]);
+
+function normalizePathKey(value) {
+  return toPosix(value).replace(/^\.\//, "").replace(/\/{2,}/g, "/");
+}
+
+function normalizePrefix(value) {
+  const normalized = normalizePathKey(value);
+  if (!normalized) {
+    return "";
+  }
+  return normalized.endsWith("/") ? normalized : `${normalized}/`;
+}
+
+function normalizeLayers(layers) {
+  const source = Array.isArray(layers) && layers.length > 0 ? layers : DEFAULT_LAYER_RULES;
+  return source
+    .map((layer, index) => ({
+      name: String(layer?.name || `layer-${index}`).trim(),
+      rank: Number.isFinite(Number(layer?.rank)) ? Number(layer.rank) : index,
+      prefixes: Array.isArray(layer?.prefixes)
+        ? layer.prefixes.map(normalizePrefix).filter(Boolean)
+        : [],
+    }))
+    .filter((layer) => layer.name && layer.prefixes.length > 0);
+}
+
+export function classifyLayer(filePath, layers = DEFAULT_LAYER_RULES) {
+  const normalized = normalizePathKey(filePath);
+  if (!normalized) {
+    return null;
+  }
+  let best = null;
+  for (const layer of normalizeLayers(layers)) {
+    for (const prefix of layer.prefixes) {
+      if (normalized.startsWith(prefix) && (!best || prefix.length > best.prefix.length)) {
+        best = { ...layer, prefix };
+      }
+    }
+  }
+  return best;
+}
+
+function isExternalEdge(edge) {
+  const normalized = normalizePathKey(edge);
+  return (
+    !normalized ||
+    normalized.startsWith("npm:") ||
+    normalized.startsWith("/") ||
+    /^[a-z][a-z0-9+.-]*:/i.test(normalized)
+  );
+}
+export function resolveLocalEdge(edge, graphKeys = []) {
+  const normalized = normalizePathKey(edge);
+  if (!normalized || isExternalEdge(normalized)) {
+    return null;
+  }
+  const keys = graphKeys instanceof Set ? graphKeys : new Set(graphKeys);
+  if (keys.size === 0 || keys.has(normalized)) {
+    return normalized;
+  }
+
+  const candidates = [];
+  const hasExtension = /\.[^/.]+$/.test(normalized);
+  if (!hasExtension) {
+    for (const ext of RESOLUTION_EXTENSIONS) {
+      candidates.push(`${normalized}${ext}`);
+    }
+    for (const ext of RESOLUTION_EXTENSIONS) {
+      candidates.push(`${normalized}/index${ext}`);
+    }
+  }
+
+  for (const candidate of candidates) {
+    if (keys.has(candidate)) {
+      return candidate;
+    }
+  }
+  return normalized;
+}
+
+export function findLayerViolations({ graph, layers = DEFAULT_LAYER_RULES } = {}) {
+  const graphKeys = new Set(Object.keys(graph || {}));
+  const violations = [];
+  for (const [source, edges] of Object.entries(graph || {}).sort(([a], [b]) =>
+    a.localeCompare(b)
+  )) {
+    const sourceLayer = classifyLayer(source, layers);
+    if (!sourceLayer || !Array.isArray(edges)) {
+      continue;
+    }
+    for (const edge of edges.slice().sort()) {
+      const target = resolveLocalEdge(edge, graphKeys);
+      if (!target) {
+        continue;
+      }
+      const targetLayer = classifyLayer(target, layers);
+      if (!targetLayer) {
+        continue;
+      }
+      if (targetLayer.rank > sourceLayer.rank) {
+        violations.push({ source, target, sourceLayer, targetLayer });
+      }
+    }
+  }
+  return violations;
+}
+
+export async function runLayeringCheck({
+  rootPath,
+  files = null,
+  layers = DEFAULT_LAYER_RULES,
+} = {}) {
+  const graph = await buildDependencyGraph({ rootPath, files });
+  return findLayerViolations({ graph, layers }).map(
+    ({ source, target, sourceLayer, targetLayer }) =>
+      createFinding({
+        tool: "layering-check",
+        kind: "code-quality.layer-violation",
+        severity: "P2",
+        file: source,
+        evidence: `${sourceLayer.name} imports higher ${targetLayer.name}: ${source} -> ${target}`,
+        rootCause:
+          "A lower-level module depends on a higher-level layer, which inverts the intended architecture boundary.",
+        recommendedFix:
+          "Move the shared contract into a lower layer or invert the dependency through an interface owned by the lower layer.",
+        confidence: 0.78,
+      })
+  );
+}

package/src/agents/mode.js

@@ -16,7 +16,7 @@
 
 // Persona tool id lists are inlined here instead of imported from each
 // persona module. Rationale: this module has to be importable before all
-// 12 persona PRs (#A13-A24) have merged to main. Once they do, a future
+// persona PRs (#A13-A24) have merged to main. Once they do, a future
 // refactor can swap these for real imports — the tool-id strings are
 // stable anyway.
 
@@ -40,11 +40,12 @@ const CODEGEN_EXTRA_TOOLS = Object.freeze([
 const DOMAIN_TOOL_IDS_BY_PERSONA = Object.freeze({
   "ai-governance": Object.freeze(["eval-regression", "hitl-audit", "prompt-drift", "provenance-check"]),
   "backend": Object.freeze(["circuit-breaker-check", "idempotency-audit", "retry-audit", "timeout-audit"]),
-  "code-quality": Object.freeze(["complexity-measure", "coupling-analysis", "cycle-detect", "dep-graph"]),
+  "code-quality": Object.freeze(["complexity-measure", "coupling-analysis", "cycle-detect", "dep-graph", "layering-check"]),
   "data-layer": Object.freeze(["index-audit", "migration-scan", "query-explain", "tenancy-scan"]),
   "documentation": Object.freeze(["api-diff", "dead-link-check", "docstring-coverage", "readme-freshness"]),
   "infrastructure": Object.freeze(["checkov-run", "drift-detect", "iam-least-priv-check", "tflint-run"]),
   "observability": Object.freeze(["alert-audit", "dashboard-gap", "log-schema-check", "span-coverage"]),
+  "performance": Object.freeze(["blocking-io-audit", "bundle-budget-check", "cache-policy-audit", "n-plus-one-detect"]),
   "release": Object.freeze(["changelog-diff", "feature-flag-audit", "rollback-verify", "semver-check"]),
   "reliability": Object.freeze(["backpressure-check", "chaos-probe", "graceful-degradation-check", "health-check-audit"]),
   "security": Object.freeze(["authz-audit", "crypto-review", "sast-scan", "secrets-scan"]),

package/src/agents/performance/index.js

@@ -0,0 +1,12 @@
+// Arjun (performance persona) - barrel export (#A16).
+
+export {
+  PERFORMANCE_TOOLS,
+  PERFORMANCE_TOOL_IDS,
+  dispatchPerformanceTool,
+  runAllPerformanceTools,
+  runBlockingIoAudit,
+  runBundleBudgetCheck,
+  runCachePolicyAudit,
+  runNPlusOneDetect,
+} from "./tools/index.js";

package/src/agents/performance/tools/base.js

@@ -0,0 +1,208 @@
+// Shared helpers for Arjun's (performance) domain tools (#A16).
+
+import fsp from "node:fs/promises";
+import path from "node:path";
+import process from "node:process";
+
+import ignore from "ignore";
+
+const DEFAULT_IGNORED_DIRS = new Set([
+  ".git",
+  "node_modules",
+  ".venv",
+  ".next",
+  "dist",
+  "build",
+  "coverage",
+  ".sentinelayer",
+  ".sentinel",
+  ".turbo",
+  ".idea",
+  ".vscode",
+  "__pycache__",
+  ".cache",
+]);
+const MAX_FILE_SIZE_BYTES = 1024 * 1024;
+const SEVERITIES = Object.freeze(["P0", "P1", "P2", "P3"]);
+
+export function toPosix(value) {
+  return String(value || "").replace(/\\/g, "/");
+}
+
+export function normalizeSeverity(value) {
+  const normalized = String(value || "").trim().toUpperCase();
+  if (SEVERITIES.includes(normalized)) {
+    return normalized;
+  }
+  return "P2";
+}
+
+export function createFinding({
+  severity,
+  kind,
+  file,
+  line = 0,
+  evidence = "",
+  rootCause = "",
+  recommendedFix = "",
+  confidence = null,
+  tool = "",
+  persona = "performance",
+} = {}) {
+  return {
+    persona,
+    tool: String(tool || "").trim(),
+    kind: String(kind || "").trim() || "performance",
+    severity: normalizeSeverity(severity),
+    file: toPosix(file || ""),
+    line: Number.isFinite(Number(line)) ? Math.max(0, Math.floor(Number(line))) : 0,
+    evidence: String(evidence || "").trim().slice(0, 400),
+    rootCause: String(rootCause || "").trim(),
+    recommendedFix: String(recommendedFix || "").trim(),
+    confidence:
+      confidence === null || confidence === undefined
+        ? null
+        : Math.max(0, Math.min(1, Number(confidence) || 0)),
+  };
+}
+
+async function readIgnorePatterns(filePath) {
+  try {
+    const raw = await fsp.readFile(filePath, "utf-8");
+    return String(raw || "")
+      .split(/\r?\n/)
+      .map((line) => line.trim())
+      .filter((line) => line && !line.startsWith("#"));
+  } catch (err) {
+    if (err && typeof err === "object" && err.code === "ENOENT") {
+      return [];
+    }
+    throw err;
+  }
+}
+
+async function createIgnoreMatcher(rootPath) {
+  const matcher = ignore();
+  const gitignore = await readIgnorePatterns(path.join(rootPath, ".gitignore"));
+  const sentinel = await readIgnorePatterns(
+    path.join(rootPath, ".sentinelayerignore")
+  );
+  matcher.add([...gitignore, ...sentinel]);
+  return (relativePath, isDirectory) => {
+    const normalized = toPosix(relativePath);
+    if (!normalized) {
+      return false;
+    }
+    const candidate = isDirectory ? `${normalized}/` : normalized;
+    return matcher.ignores(candidate);
+  };
+}
+
+export async function* walkRepoFiles({
+  rootPath = process.cwd(),
+  extensions = new Set(),
+  maxFileSize = MAX_FILE_SIZE_BYTES,
+} = {}) {
+  const resolvedRoot = path.resolve(rootPath);
+  const ignoreMatcher = await createIgnoreMatcher(resolvedRoot);
+  const wantedExtensions =
+    extensions instanceof Set
+      ? extensions
+      : new Set(Array.isArray(extensions) ? extensions : []);
+  const stack = [resolvedRoot];
+  while (stack.length > 0) {
+    const current = stack.pop();
+    let entries = [];
+    try {
+      entries = await fsp.readdir(current, { withFileTypes: true });
+    } catch {
+      continue;
+    }
+    for (const entry of entries) {
+      const fullPath = path.join(current, entry.name);
+      const relativePath = toPosix(path.relative(resolvedRoot, fullPath));
+      if (entry.isDirectory()) {
+        if (!relativePath || DEFAULT_IGNORED_DIRS.has(entry.name)) {
+          continue;
+        }
+        if (ignoreMatcher(relativePath, true)) {
+          continue;
+        }
+        stack.push(fullPath);
+        continue;
+      }
+      if (!entry.isFile()) {
+        continue;
+      }
+      if (ignoreMatcher(relativePath, false)) {
+        continue;
+      }
+      const ext = path.extname(entry.name).toLowerCase();
+      if (wantedExtensions.size > 0 && !wantedExtensions.has(ext) && !wantedExtensions.has("")) {
+        continue;
+      }
+      let stat = null;
+      try {
+        stat = await fsp.stat(fullPath);
+      } catch {
+        stat = null;
+      }
+      if (!stat || stat.size > maxFileSize) {
+        continue;
+      }
+      yield { fullPath, relativePath, sizeBytes: stat.size };
+    }
+  }
+}
+
+export function findLineMatches(content, pattern) {
+  const text = String(content || "");
+  if (!pattern) {
+    return [];
+  }
+  const global = new RegExp(
+    pattern.source,
+    pattern.flags.includes("g") ? pattern.flags : `${pattern.flags}g`
+  );
+  const matches = [];
+  let match;
+  while ((match = global.exec(text)) !== null) {
+    const lineIndex = text.slice(0, match.index).split(/\r?\n/).length;
+    matches.push({ index: match.index, line: lineIndex, match: match[0] });
+  }
+  return matches;
+}
+
+export function getLineContent(content, line) {
+  const lines = String(content || "").split(/\r?\n/);
+  return (lines[Math.max(0, (Number(line) || 1) - 1)] || "").trim();
+}
+
+export async function* iterateFiles(resolvedRoot, files, extensions) {
+  if (Array.isArray(files) && files.length > 0) {
+    for (const file of files) {
+      const trimmed = String(file || "").trim();
+      if (!trimmed) {
+        continue;
+      }
+      const fullPath = path.isAbsolute(trimmed)
+        ? trimmed
+        : path.join(resolvedRoot, trimmed);
+      const relativePath = path
+        .relative(resolvedRoot, fullPath)
+        .replace(/\\/g, "/");
+      let stat = null;
+      try {
+        stat = await fsp.stat(fullPath);
+      } catch {
+        stat = null;
+      }
+      yield { fullPath, relativePath, sizeBytes: stat?.size || 0 };
+    }
+    return;
+  }
+
+  yield* walkRepoFiles({ rootPath: resolvedRoot, extensions });
+}
+
+export { DEFAULT_IGNORED_DIRS, MAX_FILE_SIZE_BYTES, SEVERITIES };

package/src/agents/performance/tools/blocking-io-audit.js

@@ -0,0 +1,85 @@
+// blocking-io-audit - flag synchronous I/O on request/runtime paths (#A16).
+
+import fsp from "node:fs/promises";
+import path from "node:path";
+
+import { createFinding, findLineMatches, getLineContent, iterateFiles, toPosix } from "./base.js";
+
+const CODE_EXTENSIONS = new Set([
+  ".js",
+  ".jsx",
+  ".ts",
+  ".tsx",
+  ".mjs",
+  ".cjs",
+  ".py",
+  ".go",
+  ".rb",
+]);
+
+const BLOCKING_IO_RULES = Object.freeze([
+  {
+    kind: "performance.blocking-sync-fs",
+    pattern:
+      /\b(?:fs\.)?(?:readFileSync|writeFileSync|appendFileSync|readdirSync|statSync|existsSync)\s*\(/,
+    severity: "P2",
+    rootCause:
+      "Synchronous filesystem call blocks the event loop or request worker while disk I/O completes.",
+    recommendedFix:
+      "Use async filesystem APIs and move startup-only reads outside hot request paths.",
+    confidence: 0.74,
+  },
+  {
+    kind: "performance.blocking-child-process",
+    pattern: /\b(?:execSync|spawnSync|execFileSync)\s*\(/,
+    severity: "P1",
+    rootCause:
+      "Synchronous child process execution blocks the runtime and can stall all concurrent requests.",
+    recommendedFix:
+      "Use async process APIs, queue the work, or precompute the artifact before serving traffic.",
+    confidence: 0.82,
+  },
+  {
+    kind: "performance.blocking-sleep",
+    pattern: /\b(?:sleepSync|Atomics\.wait|time\.sleep)\s*\(/,
+    severity: "P2",
+    rootCause:
+      "Blocking sleep pauses the worker instead of yielding, which turns transient waits into throughput loss.",
+    recommendedFix:
+      "Use async timers, scheduled jobs, or backoff that yields to the runtime event loop.",
+    confidence: 0.7,
+  },
+]);
+
+export async function runBlockingIoAudit({ rootPath, files = null } = {}) {
+  const resolvedRoot = path.resolve(String(rootPath || "."));
+  const findings = [];
+  for await (const { fullPath, relativePath } of iterateFiles(resolvedRoot, files, CODE_EXTENSIONS)) {
+    let content;
+    try {
+      content = await fsp.readFile(fullPath, "utf-8");
+    } catch {
+      continue;
+    }
+    for (const rule of BLOCKING_IO_RULES) {
+      for (const match of findLineMatches(content, rule.pattern)) {
+        findings.push(
+          createFinding({
+            tool: "blocking-io-audit",
+            kind: rule.kind,
+            severity: rule.severity,
+            file: toPosix(relativePath),
+            line: match.line,
+            evidence: getLineContent(content, match.line),
+            rootCause: rule.rootCause,
+            recommendedFix: rule.recommendedFix,
+            confidence: rule.confidence,
+          })
+        );
+      }
+    }
+  }
+  return findings;
+}
+
+export { BLOCKING_IO_RULES };

package/src/agents/performance/tools/bundle-budget-check.js

@@ -0,0 +1,93 @@
+// bundle-budget-check - flag heavy client imports and oversized assets (#A16).
+
+import fsp from "node:fs/promises";
+import path from "node:path";
+
+import { createFinding, findLineMatches, getLineContent, iterateFiles, toPosix } from "./base.js";
+
+const CLIENT_EXTENSIONS = new Set([
+  ".js",
+  ".jsx",
+  ".ts",
+  ".tsx",
+  ".mjs",
+  ".css",
+]);
+const FRONTEND_PATH_PATTERN =
+  /(?:^|\/)(?:app|pages|components|ui|frontend|client|public)(?:\/|$)/i;
+const LARGE_SOURCE_THRESHOLD_BYTES = 150 * 1024;
+const LARGE_STYLE_THRESHOLD_BYTES = 100 * 1024;
+const HEAVY_IMPORT_PATTERN =
+  /\bimport\s+[^;]*?\bfrom\s+["'](?:moment|lodash|chart\.js(?:\/auto)?|monaco-editor|mapbox-gl|three)["']|require\s*\(\s*["'](?:moment|lodash|chart\.js(?:\/auto)?|monaco-editor|mapbox-gl|three)["']\s*\)/g;
+
+function budgetForFile(relativePath) {
+  return path.extname(relativePath).toLowerCase() === ".css"
+    ? LARGE_STYLE_THRESHOLD_BYTES
+    : LARGE_SOURCE_THRESHOLD_BYTES;
+}
+
+export async function runBundleBudgetCheck({ rootPath, files = null } = {}) {
+  const resolvedRoot = path.resolve(String(rootPath || "."));
+  const findings = [];
+  for await (const { fullPath, relativePath, sizeBytes } of iterateFiles(
+    resolvedRoot,
+    files,
+    CLIENT_EXTENSIONS
+  )) {
+    const normalizedPath = toPosix(relativePath);
+    if (!FRONTEND_PATH_PATTERN.test(normalizedPath)) {
+      continue;
+    }
+    let content = "";
+    try {
+      content = await fsp.readFile(fullPath, "utf-8");
+    } catch {
+      continue;
+    }
+
+    const budget = budgetForFile(normalizedPath);
+    if (sizeBytes > budget) {
+      findings.push(
+        createFinding({
+          tool: "bundle-budget-check",
+          kind: "performance.bundle-budget-exceeded",
+          severity: "P2",
+          file: normalizedPath,
+          line: 1,
+          evidence: `size=${sizeBytes} bytes budget=${budget} bytes`,
+          rootCause:
+            "Client-side source/style file exceeds the local budget, increasing parse, transfer, and hydration cost.",
+          recommendedFix:
+            "Split the module, lazy-load non-critical code, move static data out of the client bundle, or add an explicit budget exception.",
+          confidence: 0.72,
+        })
+      );
+    }
+
+    for (const match of findLineMatches(content, HEAVY_IMPORT_PATTERN)) {
+      findings.push(
+        createFinding({
+          tool: "bundle-budget-check",
+          kind: "performance.heavy-client-import",
+          severity: "P2",
+          file: normalizedPath,
+          line: match.line,
+          evidence: getLineContent(content, match.line),
+          rootCause:
+            "Client code imports a known heavyweight package at module scope, which can inflate initial JavaScript payloads.",
+          recommendedFix:
+            "Use scoped imports, dynamic import(), route-level code splitting, or a lighter package.",
+          confidence: 0.66,
+        })
+      );
+    }
+  }
+  return findings;
+}
+
+export {
+  FRONTEND_PATH_PATTERN,
+  HEAVY_IMPORT_PATTERN,
+  LARGE_SOURCE_THRESHOLD_BYTES,
+  LARGE_STYLE_THRESHOLD_BYTES,
+};