sen-ether-client 0.1.6 → 0.1.7

package/API.md

@@ -67,7 +67,12 @@ variable as its multicast default:
 - `SEN_ETHER_DISCOVERY_PORT`
 
 Multicast group, bind address and interface selection are explicit `sen-ether-client`
-options, not SEN environment variables.
+options, not SEN environment variables. When no `interfaceAddress` is provided,
+multicast discovery joins every local IPv4 interface visible to Node.js. If a
+SEN producer on the same host sends discovery through a physical interface that
+does not loop multicast packets back locally, discovery can still return no
+processes; in that case run the producer discovery on `lo`, pass the matching
+`interfaceAddress`, or use SEN TCP discovery.
 
 Preferred multi-session usage:
 

package/lib/discovery.js

@@ -50,6 +50,26 @@ function resolveInterfaceAddress(value) {
   return ipv4.address;
 }
 
+function multicastInterfaceCandidates(interfaceAddress) {
+  if (interfaceAddress) {
+    return [interfaceAddress];
+  }
+
+  try {
+    const addresses = [];
+    for (const candidates of Object.values(os.networkInterfaces())) {
+      for (const item of candidates ?? []) {
+        if ((item.family === 'IPv4' || item.family === 4) && item.address) {
+          addresses.push(item.address);
+        }
+      }
+    }
+    return [...new Set(addresses)];
+  } catch {
+    return [];
+  }
+}
+
 function normalizeTcpRemote(socket) {
   return {
     address: socket.remoteAddress,
@@ -149,8 +169,29 @@ export class EtherDiscoveryScanner extends EventEmitter {
       const onListening = () => {
         socket.off('error', onError);
         try {
-          socket.addMembership(this.group, this.interfaceAddress);
+          const interfaces = multicastInterfaceCandidates(this.interfaceAddress);
+          if (interfaces.length) {
+            let joined = 0;
+            /** @type {Error | undefined} */
+            let firstError;
+            for (const interfaceAddress of interfaces) {
+              try {
+                socket.addMembership(this.group, interfaceAddress);
+                joined += 1;
+              } catch (error) {
+                firstError ??= /** @type {Error} */ (error);
+              }
+            }
+            if (!joined) {
+              throw firstError ?? new Error(`could not join multicast group ${this.group}`);
+            }
+          } else {
+            socket.addMembership(this.group);
+          }
           socket.setMulticastLoopback(true);
+          if (this.interfaceAddress) {
+            socket.setMulticastInterface(this.interfaceAddress);
+          }
         } catch (error) {
           reject(error);
           return;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sen-ether-client",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "description": "Pure JavaScript SEN client for existing kernels over ether",
   "senCompatibility": {
     "kernelProtocolVersion": 9,