semantic-release 12.2.4 → 12.4.1

package/cli.js

@@ -1,6 +1,5 @@
 const program = require('commander');
 const {pickBy, isUndefined} = require('lodash');
-const logger = require('./lib/logger');
 
 function list(values) {
   return values.split(',').map(value => value.trim());
@@ -48,15 +47,13 @@ module.exports = async () => {
       program.outputHelp();
       process.exitCode = 1;
     } else {
+      const opts = program.opts();
+      // Set the `noCi` options as commander.js sets the `ci` options instead (becasue args starts with `--no`)
+      opts.noCi = opts.ci === false ? true : undefined;
       // Remove option with undefined values, as commander.js sets non defined options as `undefined`
-      await require('.')(pickBy(program.opts(), value => !isUndefined(value)));
+      await require('.')(pickBy(opts, value => !isUndefined(value)));
     }
   } catch (err) {
     process.exitCode = 1;
-    if (err.semanticRelease) {
-      logger.log(`%s ${err.message}`, err.code);
-    } else {
-      logger.error('An error occurred while running semantic-release: %O', err);
-    }
   }
 };

package/docs/recipes/travis.md

@@ -16,7 +16,9 @@ For projects that require to be tested only with a single [Node version](https:/
 
 This example is a minimal configuration for semantic-release with a build running Node 8 on Linux. See [Travis - Customizing the Build](https://docs.travis-ci.com/user/customizing-the-build) for additional configuration options.
 
-It's recommended to run the `semantic-release` command in the [Travis `script` step](https://docs.travis-ci.com/user/customizing-the-build/#The-Build-Lifecycle) so if an error happen the build will fail and Travis will send a notification.
+It's recommended to run the `semantic-release` command in the [Travis `deploy` step](https://docs.travis-ci.com/user/customizing-the-build/#The-Build-Lifecycle) so if an error occurs the build will fail and Travis will send a notification.
+
+**Note**: It's not recommended to run the `semantic-release` command in the Travis `script` step as each script in this step will be executed regardless of the outcome of the previous one. See [travis-ci/travis-ci#1066](https://github.com/travis-ci/travis-ci/issues/1066).
 
 **Note**: The`semantic-release` execution command varies depending if you are using a [local](../usage/installation.md#local-installation) or [global](../usage/installation.md#global-installation) semantic-release installation.
 
@@ -29,12 +31,14 @@ script:
   # Run tests
   - npm run test
 
-  # Only for a local semantic-release installation
-  - npm run semantic-release
-
-  # Only for a global semantic-release installation
-  - npm install -g semantic-release
-  - semantic-release
+deploy:
+  provider: script
+  skip_cleanup: true
+  script:
+    # Only for a local semantic-release installation
+    - npm run semantic-release
+    # Only for a global semantic-release installation
+    - npm install -g semantic-release && semantic-release
 ```
 
 ### `package.json` configuration for single Node job
@@ -56,7 +60,7 @@ A `package.json` is required only for [local](../usage/installation.md#local-ins
 
 For projects that require to be tested with multiple [Node versions](https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Specifying-Node.js-versions) and/or on multiple [Operating Systems](https://docs.travis-ci.com/user/multi-os).
 
-**Note**: At least one job must run a [Node >= 8 version](../support/FAQ.md#why-does-semantic-release-require-node-version--8).
+**Note**: At least one job must run a [Node >= 8 version](../support/FAQ.md#why-does-semantic-release-require-node-version--83).
 
 ### `.travis.yml` configuration for multiple Node jobs
 
@@ -64,7 +68,9 @@ This example is a minimal configuration for **semantic-release** with a build ru
 
 This example uses [`travis-deploy-once`](https://github.com/semantic-release/travis-deploy-once) in order to command [Run `semantic-release` only after all tests succeeded](../usage/ci-configuration.md#run-semantic-release-only-after-all-tests-succeeded). Alternatively you can use [Travis CI Build Stages recipe](travis-build-stages.md).
 
-It's recommended to run the `semantic-release` command in the [Travis `script` step](https://docs.travis-ci.com/user/customizing-the-build/#The-Build-Lifecycle) so if an error happen the build will fail and Travis will send a notification.
+It's recommended to run the `semantic-release` command in the [Travis `deploy` step](https://docs.travis-ci.com/user/customizing-the-build/#The-Build-Lifecycle) so if an error occurs the build will fail and Travis will send a notification.
+
+**Note**: It's not recommended to run the `semantic-release` command in the Travis `script` step as each script in this step will be executed regardless of the outcome of the previous one. See [travis-ci/travis-ci#1066](https://github.com/travis-ci/travis-ci/issues/1066).
 
 **Note**: The`semantic-release` execution command varies depending if you are using a [local](../usage/installation.md#local-installation) or [global](../usage/installation.md#global-installation) **semantic-release** installation.
 
@@ -84,12 +90,14 @@ script:
   # Run tests
   - npm run test
 
-  # Only for a local semantic-release installation
-  - npm run travis-deploy-once "npm run semantic-release"
-
-  # Only for a global semantic-release installation
-  - npm install -g travis-deploy-once semantic-release
-  - travis-deploy-once "semantic-release"
+deploy:
+  provider: script
+  skip_cleanup: true
+  script:
+    # Only for a local semantic-release installation
+    - npm run travis-deploy-once "npm run semantic-release"
+    # Only for a global semantic-release installation
+    - npm install -g travis-deploy-once semantic-release && travis-deploy-once "semantic-release"
 ```
 
 **Note**: See the `travis-deploy-once` [`pro`](https://github.com/semantic-release/travis-deploy-once#-p---pro) and [`travis-url`](https://github.com/semantic-release/travis-deploy-once#-u---travis-url) options for using with [Travis Pro](https://docs.travis-ci.com/user/travis-pro) and [Travis Enterprise](https://enterprise.travis-ci.com).
@@ -123,7 +131,9 @@ This example is a minimal configuration for semantic-release with a build runnin
 
 This example uses [`travis-deploy-once`](https://github.com/semantic-release/travis-deploy-once) in order to [run `semantic-release` only after all tests succeeded](../usage/ci-configuration.md#run-semantic-release-only-after-all-tests-succeeded). Alternatively you can use [Travis CI Build Stages recipe](travis-build-stages.md).
 
-It's recommended to run the `semantic-release` command in the [Travis `script` step](https://docs.travis-ci.com/user/customizing-the-build/#The-Build-Lifecycle) so if an error happen the build will fail and Travis will send a notification.
+It's recommended to run the `semantic-release` command in the [Travis `deploy` step](https://docs.travis-ci.com/user/customizing-the-build/#The-Build-Lifecycle) so if an error occurs the build will fail and Travis will send a notification.
+
+**Note**: It's not recommended to run the `semantic-release` command in the Travis `script` step as each script in this step will be executed regardless of the outcome of the previous one. See [travis-ci/travis-ci#1066](https://github.com/travis-ci/travis-ci/issues/1066).
 
 ```yaml
 language: go
@@ -140,12 +150,16 @@ script:
   # Run tests
   - go test -v ./...
 
-  # Use nvm to install and use the Node LTS version (nvm is installed on Travis images)
-  - nvm install lts/*
-  # Install travis-deploy-once and semantic-release
-  - npm install -g travis-deploy-once semantic-release
-  # Run semantic-release only on job, after all other are successful
-  - travis-deploy-once "semantic-release"
+deploy:
+  provider: script
+  skip_cleanup: true
+  script:
+    # Use nvm to install and use the Node LTS version (nvm is installed on all Travis images)
+    - nvm install lts/*
+    # Install travis-deploy-once and semantic-release
+    - npm install -g travis-deploy-once semantic-release
+    # Run semantic-release only on job, after all other are successful
+    - travis-deploy-once "semantic-release"
 ```
 
 **Note**: See the `travis-deploy-once` [`pro`](https://github.com/semantic-release/travis-deploy-once#-p---pro) and [`travis-url`](https://github.com/semantic-release/travis-deploy-once#-u---travis-url) options for using with [Travis Pro](https://docs.travis-ci.com/user/travis-pro) and [Travis Enterprise](https://enterprise.travis-ci.com).

package/index.js

@@ -1,21 +1,25 @@
 const marked = require('marked');
 const TerminalRenderer = require('marked-terminal');
 const envCi = require('env-ci');
+const hookStd = require('hook-std');
+const hideSensitive = require('./lib/hide-sensitive');
 const getConfig = require('./lib/get-config');
 const getNextVersion = require('./lib/get-next-version');
 const getCommits = require('./lib/get-commits');
 const logger = require('./lib/logger');
 const {gitHead: getGitHead, isGitRepo} = require('./lib/git');
 
-module.exports = async opts => {
+async function run(opts) {
   const {isCi, branch, isPr} = envCi();
+  const config = await getConfig(opts, logger);
+  const {plugins, options} = config;
 
-  if (!isCi && !opts.dryRun && !opts.noCi) {
+  if (!isCi && !options.dryRun && !options.noCi) {
     logger.log('This run was not triggered in a known CI environment, running in dry-run mode.');
-    opts.dryRun = true;
+    options.dryRun = true;
   }
 
-  if (isCi && isPr && !opts.noCi) {
+  if (isCi && isPr && !options.noCi) {
     logger.log("This run was triggered by a pull request and therefore a new version won't be published.");
     return;
   }
@@ -25,9 +29,6 @@ module.exports = async opts => {
     return;
   }
 
-  const config = await getConfig(opts, logger);
-  const {plugins, options} = config;
-
   if (branch !== options.branch) {
     logger.log(
       `This test run was triggered on the branch ${branch}, while semantic-release is configured to only publish from ${
@@ -40,7 +41,7 @@ module.exports = async opts => {
   logger.log('Run automated release from branch %s', options.branch);
 
   logger.log('Call plugin %s', 'verify-conditions');
-  await plugins.verifyConditions({options, logger});
+  await plugins.verifyConditions({options, logger}, true);
 
   logger.log('Call plugin %s', 'get-last-release');
   const {commits, lastRelease} = await getCommits(
@@ -64,7 +65,7 @@ module.exports = async opts => {
   const nextRelease = {type, version, gitHead: await getGitHead(), gitTag: `v${version}`};
 
   logger.log('Call plugin %s', 'verify-release');
-  await plugins.verifyRelease({options, logger, lastRelease, commits, nextRelease});
+  await plugins.verifyRelease({options, logger, lastRelease, commits, nextRelease}, true);
 
   const generateNotesParam = {options, logger, lastRelease, commits, nextRelease};
 
@@ -79,7 +80,7 @@ module.exports = async opts => {
     nextRelease.notes = await plugins.generateNotes(generateNotesParam);
 
     logger.log('Call plugin %s', 'publish');
-    await plugins.publish({options, logger, lastRelease, commits, nextRelease}, async prevInput => {
+    await plugins.publish({options, logger, lastRelease, commits, nextRelease}, false, async prevInput => {
       const newGitHead = await getGitHead();
       // If previous publish plugin has created a commit (gitHead changed)
       if (prevInput.nextRelease.gitHead !== newGitHead) {
@@ -94,4 +95,24 @@ module.exports = async opts => {
     logger.log('Published release: %s', nextRelease.version);
   }
   return true;
+}
+
+module.exports = async opts => {
+  const unhook = hookStd({silent: false}, hideSensitive);
+  try {
+    const result = await run(opts);
+    unhook();
+    return result;
+  } catch (err) {
+    const errors = err.name === 'AggregateError' ? Array.from(err).sort(error => !error.semanticRelease) : [err];
+    for (const error of errors) {
+      if (error.semanticRelease) {
+        logger.log(`%s ${error.message}`, error.code);
+      } else {
+        logger.error('An error occurred while running semantic-release: %O', error);
+      }
+    }
+    unhook();
+    throw err;
+  }
 };

package/lib/hide-sensitive.js

@@ -0,0 +1,8 @@
+const {escapeRegExp} = require('lodash');
+
+const toReplace = Object.keys(process.env).filter(envVar => /token|password|credential|secret|private/i.test(envVar));
+const regexp = new RegExp(toReplace.map(envVar => escapeRegExp(process.env[envVar])).join('|'), 'g');
+
+module.exports = output => {
+  return output && toReplace.length > 0 ? output.toString().replace(regexp, '[secure]') : output;
+};

package/lib/plugins/pipeline.js

@@ -1,19 +1,33 @@
 const {identity} = require('lodash');
+const pReflect = require('p-reflect');
 const pReduce = require('p-reduce');
+const AggregateError = require('aggregate-error');
 
-module.exports = steps => async (input, getNextInput = identity) => {
+module.exports = steps => async (input, settleAll = false, getNextInput = identity) => {
   const results = [];
+  const errors = [];
   await pReduce(
     steps,
     async (prevResult, nextStep) => {
-      // Call the next step with the input computed at the end of the previous iteration
-      const result = await nextStep(prevResult);
-      // Save intermediary result
-      results.push(result);
+      let result;
+
+      // Call the next step with the input computed at the end of the previous iteration and save intermediary result
+      if (settleAll) {
+        const {isFulfilled, value, reason} = await pReflect(nextStep(prevResult));
+        result = isFulfilled ? value : reason;
+        (isFulfilled ? results : errors).push(result);
+      } else {
+        result = await nextStep(prevResult);
+        results.push(result);
+      }
+
       // Prepare input for next step, passing the result of the previous iteration and the current one
       return getNextInput(prevResult, result);
     },
     input
   );
+  if (errors.length > 0) {
+    throw new AggregateError(errors);
+  }
   return results;
 };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "semantic-release",
   "description": "Automated semver compliant package publishing",
-  "version": "12.2.4",
+  "version": "12.4.1",
   "author": "Stephan Bönnemann <stephan@boennemann.me> (http://boennemann.me)",
   "bin": {
     "semantic-release": "bin/semantic-release.js"
@@ -24,6 +24,7 @@
     "@semantic-release/github": "^3.0.1",
     "@semantic-release/npm": "^2.0.0",
     "@semantic-release/release-notes-generator": "^6.0.0",
+    "aggregate-error": "^1.0.0",
     "chalk": "^2.3.0",
     "commander": "^2.11.0",
     "cosmiconfig": "^4.0.0",
@@ -32,16 +33,19 @@
     "execa": "^0.9.0",
     "get-stream": "^3.0.0",
     "git-log-parser": "^1.2.0",
+    "hook-std": "^0.4.0",
     "lodash": "^4.17.4",
     "marked": "^0.3.9",
     "marked-terminal": "^2.0.0",
     "p-reduce": "^1.0.0",
+    "p-reflect": "^1.0.0",
     "read-pkg-up": "^3.0.0",
     "resolve-from": "^4.0.0",
     "semver": "^5.4.1"
   },
   "devDependencies": {
-    "ava": "^0.24.0",
+    "ava": "^0.25.0",
+    "clear-module": "^2.1.0",
     "codecov": "^3.0.0",
     "commitizen": "^2.9.6",
     "cz-conventional-changelog": "^2.0.0",
@@ -107,7 +111,7 @@
     "trailingComma": "es5"
   },
   "publishConfig": {
-    "tag": "next"
+    "tag": "latest"
   },
   "release": {
     "branch": "caribou"