semantic-release-vsce 5.6.0 → 5.6.2

package/.github/workflows/ci.yaml

@@ -22,7 +22,7 @@ jobs:
           - 18
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: volta-cli/action@v4.0.1
         with:
           node-version: ${{ matrix.node-version }}
@@ -35,7 +35,7 @@ jobs:
     needs: test
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: volta-cli/action@v4.0.1
       - run: npm ci
       - run: npm run release

package/.github/workflows/validate-pr-title.yaml

@@ -11,6 +11,6 @@ jobs:
   validate-pr-title:
     runs-on: ubuntu-latest
     steps:
-      - uses: amannn/action-semantic-pull-request@v5.2.0
+      - uses: amannn/action-semantic-pull-request@v5.3.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

package/lib/error.js

@@ -0,0 +1,11 @@
+// @ts-check
+
+const createError = async (message, code) => {
+  const SemanticReleaseError = (await import('@semantic-release/error'))
+    .default;
+  return new SemanticReleaseError(message, code);
+};
+
+module.exports = {
+  createError,
+};

package/lib/verify-ovsx-auth.js

@@ -1,13 +1,13 @@
 // @ts-check
 
-const SemanticReleaseError = require('@semantic-release/error');
+const { createError } = require('./error');
 const execa = require('execa');
 
 module.exports = async (logger, cwd) => {
   logger.log('Verifying authentication for ovsx');
 
   if (!process.env.OVSX_PAT) {
-    throw new SemanticReleaseError(
+    throw await createError(
       'Empty ovsx personal access token (`OVSX_PAT` environment variable) specified.',
       'EEMPTYOVSXPAT',
     );
@@ -16,7 +16,7 @@ module.exports = async (logger, cwd) => {
   try {
     await execa('ovsx', ['verify-pat'], { preferLocal: true, cwd });
   } catch (e) {
-    throw new SemanticReleaseError(
+    throw await createError(
       `Invalid ovsx personal access token. Additional information:\n\n${e}`,
       'EINVALIDOVSXPAT',
     );

package/lib/verify-pkg.js

@@ -1,12 +1,12 @@
 // @ts-check
 
-const SemanticReleaseError = require('@semantic-release/error');
+const { createError } = require('./error');
 const { readJson } = require('fs-extra');
 const fs = require('fs');
 
 module.exports = async () => {
   if (!fs.existsSync('./package.json')) {
-    throw new SemanticReleaseError(
+    throw await createError(
       'The `package.json` was not found. A `package.json` is required to release with vsce.',
       'ENOPKG',
     );
@@ -17,7 +17,7 @@ module.exports = async () => {
   try {
     packageJson = await readJson('./package.json');
   } catch {
-    throw new SemanticReleaseError(
+    throw await createError(
       'The `package.json` seems to be invalid.',
       'EINVALIDPKG',
     );
@@ -26,13 +26,10 @@ module.exports = async () => {
   const { name, publisher } = packageJson;
 
   if (!name) {
-    throw new SemanticReleaseError(
-      'No `name` found in `package.json`.',
-      'ENOPKGNAME',
-    );
+    throw await createError('No `name` found in `package.json`.', 'ENOPKGNAME');
   }
   if (!publisher) {
-    throw new SemanticReleaseError(
+    throw await createError(
       'No `publisher` found in `package.json`.',
       'ENOPUBLISHER',
     );

package/lib/verify-target.js

@@ -1,6 +1,6 @@
 // @ts-check
 
-const SemanticReleaseError = require('@semantic-release/error');
+const { createError } = require('./error');
 const { isTargetEnabled } = require('./utils');
 
 module.exports = async () => {
@@ -9,7 +9,7 @@ module.exports = async () => {
   }
 
   if (!process.env.VSCE_TARGET) {
-    throw new SemanticReleaseError(
+    throw await createError(
       'Empty vsce target specified.',
       'EINVALIDVSCETARGET',
     );
@@ -20,7 +20,7 @@ module.exports = async () => {
 
     // Throw if the target is not supported
     if (!targets.has(process.env.VSCE_TARGET)) {
-      throw new SemanticReleaseError(
+      throw await createError(
         `Unsupported vsce target: ${
           process.env.VSCE_TARGET
         }. Available targets: ${Object.values(targets).join(', ')}`,

package/lib/verify-vsce-auth.js

@@ -1,13 +1,13 @@
 // @ts-check
 
-const SemanticReleaseError = require('@semantic-release/error');
+const { createError } = require('./error');
 const execa = require('execa');
 
 module.exports = async (logger, cwd) => {
   logger.log('Verifying authentication for vsce');
 
   if (!process.env.VSCE_PAT) {
-    throw new SemanticReleaseError(
+    throw await createError(
       'Empty vsce personal access token (`VSCE_PAT` environment variable) specified.',
       'EEMPTYVSCEPAT',
     );
@@ -16,7 +16,7 @@ module.exports = async (logger, cwd) => {
   try {
     await execa('vsce', ['verify-pat'], { preferLocal: true, cwd });
   } catch (e) {
-    throw new SemanticReleaseError(
+    throw await createError(
       `Invalid vsce personal access token. Additional information:\n\n${e}`,
       'EINVALIDVSCEPAT',
     );

package/lib/verify.js

@@ -1,6 +1,6 @@
 // @ts-check
 
-const SemanticReleaseError = require('@semantic-release/error');
+const { createError } = require('./error');
 const verifyPkg = require('./verify-pkg');
 const verifyVsceAuth = require('./verify-vsce-auth');
 const verifyOvsxAuth = require('./verify-ovsx-auth');
@@ -15,7 +15,7 @@ module.exports = async (pluginConfig, { logger, cwd }) => {
     const vscePublishEnabled = isVscePublishEnabled();
     const ovsxPublishEnabled = isOvsxPublishEnabled();
     if (!vscePublishEnabled && !ovsxPublishEnabled) {
-      throw new SemanticReleaseError(
+      throw await createError(
         'No personal access token was detected. Set the `VSCE_PAT` or the `OVSX_PAT` environment variable, at least one of them must be present when publish is enabled.\nLearn more at https://github.com/felipecrs/semantic-release-vsce#publishing',
         'ENOPAT',
       );

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "semantic-release-vsce",
-  "version": "5.6.0",
+  "version": "5.6.2",
   "description": "semantic-release plugin to package and publish VS Code extensions",
   "license": "MIT",
   "engines": {
@@ -43,11 +43,11 @@
     ]
   },
   "volta": {
-    "node": "18.16.1",
-    "npm": "9.8.0"
+    "node": "18.18.0",
+    "npm": "9.8.1"
   },
   "dependencies": {
-    "@semantic-release/error": "^3.0.0",
+    "@semantic-release/error": "^4.0.0",
     "@vscode/vsce": "^2.15.0",
     "execa": "^5.0.0",
     "fs-extra": "^11.1.0",
@@ -61,18 +61,18 @@
     "ava": "^5.0.1",
     "conventional-changelog-conventionalcommits": "^6.0.0",
     "eslint": "^8.7.0",
-    "eslint-config-prettier": "^8.5.0",
+    "eslint-config-prettier": "^9.0.0",
     "eslint-config-standard": "^17.0.0",
     "eslint-plugin-import": "^2.20.1",
     "eslint-plugin-n": "^16.0.0",
     "eslint-plugin-promise": "^6.0.0",
     "husky": "^8.0.2",
-    "lint-staged": "^13.0.3",
+    "lint-staged": "^14.0.0",
     "nyc": "^15.1.0",
-    "prettier": "3.0.0",
+    "prettier": "3.0.3",
     "proxyquire": "^2.1.3",
     "semantic-release": "^21.0.1",
-    "sinon": "^15.0.0"
+    "sinon": "^16.0.0"
   },
   "lint-staged": {
     "**/*": "prettier --write --ignore-unknown"

package/test/verify-ovsx-auth.test.js

@@ -1,7 +1,6 @@
 const test = require('ava').serial;
 const sinon = require('sinon');
 const proxyquire = require('proxyquire');
-const SemanticReleaseError = require('@semantic-release/error');
 
 const cwd = process.cwd();
 
@@ -37,7 +36,6 @@ test('OVSX_PAT is invalid', async (t) => {
   const verifyOvsxAuth = require('../lib/verify-ovsx-auth');
 
   await t.throwsAsync(() => verifyOvsxAuth(logger), {
-    instanceOf: SemanticReleaseError,
     code: 'EEMPTYOVSXPAT',
   });
 });
@@ -54,7 +52,6 @@ test('OVSX_PAT is invalid but not empty', async (t) => {
   const verifyOvsxAuth = require('../lib/verify-ovsx-auth');
 
   await t.throwsAsync(() => verifyOvsxAuth(logger), {
-    instanceOf: SemanticReleaseError,
     code: 'EINVALIDOVSXPAT',
   });
 });

package/test/verify-pkg.test.js

@@ -1,7 +1,6 @@
 const sinon = require('sinon');
 const test = require('ava');
 const proxyquire = require('proxyquire');
-const SemanticReleaseError = require('@semantic-release/error');
 
 test('package.json is found', async (t) => {
   const name = 'test';
@@ -39,7 +38,6 @@ test('package.json is not found', async (t) => {
   });
 
   await t.throwsAsync(() => verifyPkg(), {
-    instanceOf: SemanticReleaseError,
     code: 'ENOPKG',
   });
 });
@@ -73,7 +71,6 @@ test('package is invalid', async (t) => {
   });
 
   await t.throwsAsync(() => verifyPkg(), {
-    instanceOf: SemanticReleaseError,
     code: 'EINVALIDPKG',
   });
 });
@@ -92,7 +89,6 @@ test('package is missing name', async (t) => {
   });
 
   await t.throwsAsync(() => verifyPkg(), {
-    instanceOf: SemanticReleaseError,
     code: 'ENOPKGNAME',
   });
 });
@@ -111,7 +107,6 @@ test('package is missing publisher', async (t) => {
   });
 
   await t.throwsAsync(() => verifyPkg(), {
-    instanceOf: SemanticReleaseError,
     code: 'ENOPUBLISHER',
   });
 });

package/test/verify-target.test.js

@@ -1,7 +1,6 @@
 const sinon = require('sinon');
 const test = require('ava');
 const proxyquire = require('proxyquire');
-const SemanticReleaseError = require('@semantic-release/error');
 
 test('VSCE_TARGET is not set', async (t) => {
   const vscePackage = sinon.stub().returns({
@@ -36,7 +35,6 @@ test('VSCE_TARGET is empty', async (t) => {
   });
 
   await t.throwsAsync(() => verifyTarget(), {
-    instanceOf: SemanticReleaseError,
     code: 'EINVALIDVSCETARGET',
   });
   t.false(vscePackage.called);
@@ -49,7 +47,6 @@ test('VSCE_TARGET is unsupported', async (t) => {
   const verifyTarget = require('../lib/verify-target');
 
   await t.throwsAsync(() => verifyTarget(), {
-    instanceOf: SemanticReleaseError,
     code: 'EUNSUPPORTEDVSCETARGET',
   });
 });

package/test/verify-vsce-auth.test.js

@@ -1,7 +1,6 @@
 const test = require('ava').serial;
 const sinon = require('sinon');
 const proxyquire = require('proxyquire');
-const SemanticReleaseError = require('@semantic-release/error');
 
 const logger = {
   log: sinon.fake(),
@@ -50,7 +49,6 @@ test('VSCE_PAT is invalid', async (t) => {
   const verifyOvsxAuth = require('../lib/verify-vsce-auth');
 
   await t.throwsAsync(() => verifyOvsxAuth(logger), {
-    instanceOf: SemanticReleaseError,
     code: 'EEMPTYVSCEPAT',
   });
 });
@@ -68,7 +66,6 @@ test('VSCE_PAT is invalid but not empty', async (t) => {
   });
 
   await t.throwsAsync(() => verifyVsceAuth(logger), {
-    instanceOf: SemanticReleaseError,
     code: 'EINVALIDVSCEPAT',
   });
 });

package/test/verify.test.js

@@ -1,4 +1,3 @@
-const SemanticReleaseError = require('@semantic-release/error');
 const test = require('ava');
 const sinon = require('sinon');
 const proxyquire = require('proxyquire');
@@ -107,7 +106,9 @@ test('errors when neither vsce nor ovsx personal access token is configured', as
   });
 
   await t.throwsAsync(() => verify({}, { logger, cwd }), {
-    instanceOf: SemanticReleaseError,
+    // TODO: restore all instanceOf checks like the below when we finally
+    // upgrade to ES Modules.
+    // instanceOf: SemanticReleaseError,
     code: 'ENOPAT',
   });
   t.true(stubs.verifyVsceAuthStub.notCalled);