semantic-release-lerna 0.4.2 → 0.6.1

package/README.md

@@ -61,7 +61,6 @@ The plugin can be configured in the [**semantic-release** configuration file](ht
           "lerna.json",
           "package.json",
           "package-lock.json",
-          "lerna.json",
           "packages/*/package.json",
           "packages/*/package-lock.json"
         ]
@@ -75,20 +74,11 @@ To use legacy auth set `NPM_USERNAME`, `NPM_PASSWORD` and `NPM_EMAIL`.
 
 ## Options
 
-### `npmVerifyAuth`
-
-- Type: `boolean`
-- Default: `true`
-
-Set to `false` to disable verifying NPM registry credentials.
-
-### `latch`
-
-- Type: `"major" | "minor" | "patch" | "none"`
-- Default: `"minor"`
-
-Latches package versions together.
-If the version bump is at least the given version all packages will be bumped regardless if the package has been touched or not.
+| Option          | Description                                                                                                                                                                                             | Default   |
+| --------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------- |
+| `npmVerifyAuth` | Set to `false` to disable verifying NPM registry credentials.                                                                                                                                           | `true`    |
+| `latch`         | Latches package versions together. If the version bump is at least the given version all packages will be bumped regardless if the package has been touched or not. `"major", "minor", "patch", "none"` | `"minor"` |
+| `rootVersion`   | Allow to update version on root `package.json`.                                                                                                                                                         | `true`    |
 
 ## Troubleshooting
 

package/lib/generate-notes.js

@@ -33,7 +33,7 @@ async function generateNotes(pluginConfig, context) {
 	const { generateNotes = false } = pluginConfig;
 
 	if (!generateNotes) {
-		logger.log(`release notes scope disabled, skipping`);
+		logger.log(`Release notes scope disabled, skipping`);
 		return "";
 	}
 

package/lib/prepare.js

@@ -3,6 +3,7 @@ const fs = require("fs").promises;
 const { existsSync } = require("fs");
 const { format } = require("util");
 const execa = require("execa");
+const npmVersion = require("libnpmversion");
 const { Project } = require("@lerna/project");
 const { Package } = require("@lerna/package");
 const writeJsonFile = require("write-json-file");
@@ -47,28 +48,22 @@ async function updateLernaJson(basePath, context) {
  */
 async function updatePackage(npmrc, pkg, context, currentVersions) {
 	const {
-		env,
 		nextRelease: { version },
-		stdout,
-		stderr,
 		logger,
 	} = context;
 	logger.log("Write version %s to package.json in %s", version, pkg.location);
 
-	/* Use "npm version" to bump version for all changed packages: "lerna version"
-	 * would handle this better but lerna disagrees with the tags produced by
-	 * semantic-release and bumps all packages. */
-	const versionResult = execa(
-		"npm",
-		["version", version, "--userconfig", npmrc, "--no-git-tag-version", "--allow-same-version"],
-		{
-			cwd: pkg.location,
-			env,
-		}
-	);
-	versionResult.stdout.pipe(stdout, { end: false });
-	versionResult.stderr.pipe(stderr, { end: false });
-	await versionResult;
+	await npmVersion(version, {
+		path: pkg.location,
+		allowSameVersion: true,
+		commitHooks: false,
+		gitTagVersion: false,
+		signGitCommit: false,
+		signGitTag: false,
+		force: false,
+		ignoreScripts: false,
+		silent: false,
+	});
 
 	/* Bump dependencies */
 	if (currentVersions) {
@@ -193,6 +188,7 @@ module.exports = async (npmrc, pluginConfig, context) => {
 	} = context;
 	const basePath = pluginConfig.pkgRoot ? path.resolve(cwd, pluginConfig.pkgRoot) : cwd;
 	const rootPkg = new Package(readJson(path.join(basePath, "package.json")), basePath);
+	const { rootVersion = true } = pluginConfig;
 
 	const changed = await getChangedPackages(pluginConfig.latch, { cwd, logger, version });
 	if (changed.length === 0) {
@@ -220,8 +216,11 @@ module.exports = async (npmrc, pluginConfig, context) => {
 
 	/* Bump version in "lerna.json" */
 	await updateLernaJson(basePath, context);
-	await updatePackage(npmrc, rootPkg, context);
 
-	/* Bump version in "package-lock.json" */
-	await updateLockfile(npmrc, rootPkg, context);
+	if (rootVersion) {
+		await updatePackage(npmrc, rootPkg, context);
+		await updateLockfile(npmrc, rootPkg, context);
+	} else {
+		logger.log("Don't write version to root package.json");
+	}
 };

package/lib/prepare.test.js

@@ -146,6 +146,44 @@ it("Update lerna.json and root package.json when one or more package has changed
 	expect(context.log).toHaveBeenCalledWith("Write version %s to lerna.json in %s", "1.0.0", cwd);
 });
 
+it("Update only lerna.json when one or more package has changed when option `rootVersion` is `false`", async () => {
+	expect.assertions(4);
+	const cwd = tempy.directory();
+	const npmrc = tempy.file({ name: ".npmrc" });
+	const project = await createProject(cwd, "0.0.0");
+
+	await createPackage(cwd, "foo", "0.0.0", {
+		changed: true,
+	});
+
+	await prepare(
+		npmrc,
+		{
+			rootVersion: false,
+		},
+		{
+			cwd,
+			env: {},
+			stdout: context.stdout,
+			stderr: context.stderr,
+			nextRelease: { version: "1.0.0" },
+			logger: context.logger,
+		}
+	);
+
+	// Verify lerna.json has been updated
+	expect(await readJson(project.lernaPath)).toEqual(
+		expect.objectContaining({
+			version: "1.0.0",
+		})
+	);
+
+	// Verify the logger has been called with the version updated
+	expect(context.log).toHaveBeenCalledWith("1 package need version bump: [ 'foo' ]");
+	expect(context.log).toHaveBeenCalledWith("Write version %s to lerna.json in %s", "1.0.0", cwd);
+	expect(context.log).toHaveBeenCalledWith("Don't write version to root package.json");
+});
+
 it("Update package.json in changed packages", async () => {
 	expect.assertions(2);
 	const cwd = tempy.directory();

package/lib/publish.js

@@ -42,6 +42,7 @@ module.exports = async (npmrc, config, pkg, context) => {
 				lerna, 'publish', 'from-package',
 				'--loglevel', 'verbose',
 				'--yes',
+        '--concurrency', "1",
 				'--no-verify-access', // prepare step has already verify access and lerna doesn't properly pass authentication
 				'--dist-tag', distTag,
 				'--registry', registry,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "semantic-release-lerna",
-  "version": "0.4.2",
+  "version": "0.6.1",
   "description": "semantic-release plugin to publish lerna monorepo packages to npm",
   "keywords": [
     "npm",
@@ -46,11 +46,11 @@
     "testTimeout": 10000
   },
   "dependencies": {
-    "@lerna/child-process": "^4.0.0",
-    "@lerna/collect-updates": "^4.0.0",
-    "@lerna/package": "^4.0.0",
-    "@lerna/package-graph": "^4.0.0",
-    "@lerna/project": "^4.0.0",
+    "@lerna/child-process": "^5.0.0",
+    "@lerna/collect-updates": "^5.0.0",
+    "@lerna/package": "^5.0.0",
+    "@lerna/package-graph": "^5.0.0",
+    "@lerna/project": "^5.0.0",
     "@semantic-release/error": "^3.0.0",
     "@semantic-release/release-notes-generator": "^10.0.0",
     "aggregate-error": "^3.1.0",
@@ -61,30 +61,31 @@
     "execa": "^5.0.0",
     "get-stream": "^6.0.0",
     "into-stream": "^6.0.0",
+    "libnpmversion": "^3.0.0",
     "read-pkg-up": "^7.0.0",
     "semver": "^7.0.0",
     "tempy": "^1.0.0",
     "write-json-file": "^4.0.0"
   },
   "devDependencies": {
-    "@html-validate/eslint-config": "5.3.1",
-    "@html-validate/eslint-config-jest": "5.3.1",
-    "@html-validate/prettier-config": "2.0.0",
-    "@semantic-release/npm": "9.0.0",
-    "@types/jest": "27.4.0",
+    "@html-validate/eslint-config": "5.4.12",
+    "@html-validate/eslint-config-jest": "5.4.11",
+    "@html-validate/prettier-config": "2.2.1",
+    "@semantic-release/npm": "9.0.1",
+    "@types/jest": "28.1.2",
     "codecov": "3.8.3",
-    "fs-extra": "10.0.0",
-    "got": "11.8.3",
-    "jest": "27.4.7",
-    "lerna": "4.0.0",
-    "prettier": "2.5.1",
-    "semantic-release": "19.0.2",
+    "fs-extra": "10.1.0",
+    "got": "11.8.5",
+    "jest": "28.1.1",
+    "lerna": "5.1.4",
+    "prettier": "2.7.1",
+    "semantic-release": "19.0.3",
     "stream-buffers": "3.0.2",
-    "verdaccio": "5.4.0"
+    "verdaccio": "5.13.0"
   },
   "peerDependencies": {
     "@semantic-release/npm": ">= 7",
-    "lerna": "^3.2 || ^4",
+    "lerna": "^3.2 || ^4 || ^5",
     "semantic-release": ">=15.0.0 <20.0.0"
   },
   "engines": {