selftune 0.2.0 → 0.2.2

package/cli/selftune/observability.ts

@@ -8,14 +8,14 @@
  * - Hook installation checks
  */
 
-import { execSync } from "node:child_process";
 import { existsSync, readFileSync } from "node:fs";
 import { homedir } from "node:os";
 import { join } from "node:path";
 import { LOG_DIR, REQUIRED_FIELDS, SELFTUNE_CONFIG_PATH } from "./constants.js";
 import type { DoctorResult, HealthCheck, HealthStatus, SelftuneConfig } from "./types.js";
+import { missingClaudeCodeHookKeys } from "./utils/hooks.js";
 
-const VALID_AGENT_TYPES = new Set(["claude_code", "codex", "opencode", "unknown"]);
+const VALID_AGENT_TYPES = new Set(["claude_code", "codex", "opencode", "openclaw", "unknown"]);
 const VALID_LLM_MODES = new Set(["agent"]);
 
 const LOG_FILES: Record<string, string> = {
@@ -25,12 +25,20 @@ const LOG_FILES: Record<string, string> = {
   evolution_audit: join(LOG_DIR, "evolution_audit_log.jsonl"),
 };
 
-const HOOK_FILES = ["prompt-log.ts", "session-stop.ts", "skill-eval.ts"];
+/**
+ * Maximum number of lines to validate in a JSONL health check.
+ * Large log files (60k+ lines) can take many seconds to fully parse,
+ * so we sample the first N lines for the health check.
+ */
+const MAX_VALIDATION_LINES = 500;
 
 /**
  * Validate a JSONL file: parse each line as JSON and check that all
  * `requiredFields` are present.  Returns a status/message pair suitable
  * for embedding in a {@link HealthCheck}.
+ *
+ * For performance, only the first {@link MAX_VALIDATION_LINES} non-blank
+ * lines are validated.  The total line count still reflects the full file.
  */
 function validateJsonlFile(
   filePath: string,
@@ -39,12 +47,15 @@ function validateJsonlFile(
   let lineCount = 0;
   let parseErrors = 0;
   let schemaErrors = 0;
+  let validatedCount = 0;
 
   const content = readFileSync(filePath, "utf-8");
   for (const line of content.split("\n")) {
     const trimmed = line.trim();
     if (!trimmed) continue;
     lineCount++;
+    if (validatedCount >= MAX_VALIDATION_LINES) continue;
+    validatedCount++;
     try {
       const record = JSON.parse(trimmed);
       const keys = new Set(Object.keys(record));
@@ -62,7 +73,7 @@ function validateJsonlFile(
   if (parseErrors > 0 || schemaErrors > 0) {
     return {
       status: "fail",
-      message: `${lineCount} records, ${parseErrors} parse errors, ${schemaErrors} schema errors`,
+      message: `${lineCount} records (${validatedCount} validated), ${parseErrors} parse errors, ${schemaErrors} schema errors`,
     };
   }
   return { status: "pass", message: `${lineCount} records, all valid` };
@@ -92,37 +103,9 @@ export function checkLogHealth(): HealthCheck[] {
 export function checkHookInstallation(): HealthCheck[] {
   const checks: HealthCheck[] = [];
 
-  // Resolve the repository root so we check the actual active hooks, not bundled source files
-  let repoRoot: string;
-  try {
-    repoRoot = execSync("git rev-parse --show-toplevel", {
-      encoding: "utf-8",
-      timeout: 5000,
-    }).trim();
-  } catch {
-    // Not inside a git repo -- fall back to cwd
-    repoRoot = process.cwd();
-  }
-
-  for (const hook of HOOK_FILES) {
-    const hookPath = join(repoRoot, ".git", "hooks", hook);
-    const check: HealthCheck = {
-      name: `hook_${hook}`,
-      path: hookPath,
-      status: "pass",
-      message: "",
-    };
-    if (existsSync(hookPath)) {
-      check.status = "pass";
-      check.message = "Hook file present";
-    } else {
-      check.status = "fail";
-      check.message = "Hook file missing";
-    }
-    checks.push(check);
-  }
-
-  // Also check if hooks are configured in Claude Code settings
+  // Check if hooks are configured in Claude Code settings.json
+  // Claude Code uses hook keys: UserPromptSubmit, PreToolUse, PostToolUse, Stop
+  // (not the old kebab-case names like prompt-submit, post-tool-use, session-stop)
   const settingsPath = join(homedir(), ".claude", "settings.json");
   const settingsCheck: HealthCheck = {
     name: "hook_settings",
@@ -142,15 +125,7 @@ export function checkHookInstallation(): HealthCheck[] {
         settingsCheck.status = "warn";
         settingsCheck.message = "No hooks section in settings.json";
       } else {
-        const hookKeys = ["prompt-submit", "post-tool-use", "session-stop"];
-        const missing = hookKeys.filter((k) => {
-          const entries = hooks[k];
-          if (!Array.isArray(entries) || entries.length === 0) return true;
-          return !entries.some(
-            (e: { command?: string }) =>
-              typeof e.command === "string" && e.command.includes("selftune"),
-          );
-        });
+        const missing = missingClaudeCodeHookKeys(hooks as Record<string, unknown>);
         if (missing.length > 0) {
           settingsCheck.status = "warn";
           settingsCheck.message = `Selftune hooks not configured for: ${missing.join(", ")}`;