selenium-webdriver 4.25.0 → 4.26.0

package/CHANGES.md

@@ -1,3 +1,10 @@
+## 4.26.0
+
+- Add CDP for Chrome 130 and remove 127
+- Fix sendKeys command fail on FileDetector.handleFile error (#14663)
+- Update dependencies to latest versions to resolve security alerts
+- Close BiDi websocket connection (#14507)
+
 ## 4.25.0
 
 - Add CDP for Chrome 129 and remove 126

package/lib/network.js

@@ -30,7 +30,7 @@ class Network {
 
   // This should be done in the constructor.
   // But since it needs to call async methods we cannot do that in the constructor.
-  // We can have a separate async method that initialises the Script instance.
+  // We can have a separate async method that initialises the Network instance.
   // However, that pattern does not allow chaining the methods as we would like the user to use it.
   // Since it involves awaiting to get the instance and then another await to call the method.
   // Using this allows the user to do this "await driver.network.addAuthenticationHandler(callback)"

package/lib/webdriver.js

@@ -789,8 +789,13 @@ class WebDriver {
       // If the websocket connection is not closed,
       // and we are running CDP sessions against the Selenium Grid,
       // the node process never exits since the websocket connection is open until the Grid is shutdown.
-      if (this._wsConnection !== undefined) {
-        this._wsConnection.close()
+      if (this._cdpWsConnection !== undefined) {
+        this._cdpWsConnection.close()
+      }
+
+      // Close the BiDi websocket connection
+      if (this._bidiConnection !== undefined) {
+        this._bidiConnection.close()
       }
     })
   }
@@ -1241,18 +1246,18 @@ class WebDriver {
     this._wsUrl = await this.getWsUrl(debuggerUrl, target, caps)
     return new Promise((resolve, reject) => {
       try {
-        this._wsConnection = new WebSocket(this._wsUrl.replace('localhost', '127.0.0.1'))
-        this._cdpConnection = new cdp.CdpConnection(this._wsConnection)
+        this._cdpWsConnection = new WebSocket(this._wsUrl.replace('localhost', '127.0.0.1'))
+        this._cdpConnection = new cdp.CdpConnection(this._cdpWsConnection)
       } catch (err) {
         reject(err)
         return
       }
 
-      this._wsConnection.on('open', async () => {
+      this._cdpWsConnection.on('open', async () => {
         await this.getCdpTargets()
       })
 
-      this._wsConnection.on('message', async (message) => {
+      this._cdpWsConnection.on('message', async (message) => {
         const params = JSON.parse(message)
         if (params.result) {
           if (params.result.targetInfos) {
@@ -1273,7 +1278,7 @@ class WebDriver {
         }
       })
 
-      this._wsConnection.on('error', (error) => {
+      this._cdpWsConnection.on('error', (error) => {
         reject(error)
       })
     })
@@ -1288,9 +1293,12 @@ class WebDriver {
    * @returns {BIDI}
    */
   async getBidi() {
-    const caps = await this.getCapabilities()
-    let WebSocketUrl = caps['map_'].get('webSocketUrl')
-    return new BIDI(WebSocketUrl.replace('localhost', '127.0.0.1'))
+    if (this._bidiConnection === undefined) {
+      const caps = await this.getCapabilities()
+      let WebSocketUrl = caps['map_'].get('webSocketUrl')
+      this._bidiConnection = new BIDI(WebSocketUrl.replace('localhost', '127.0.0.1'))
+    }
+    return this._bidiConnection
   }
 
   /**
@@ -1338,7 +1346,7 @@ class WebDriver {
    * @param connection CDP Connection
    */
   async register(username, password, connection) {
-    this._wsConnection.on('message', (message) => {
+    this._cdpWsConnection.on('message', (message) => {
       const params = JSON.parse(message)
 
       if (params.method === 'Fetch.authRequired') {
@@ -1383,7 +1391,7 @@ class WebDriver {
    * @param callback callback called when we intercept requests.
    */
   async onIntercept(connection, httpResponse, callback) {
-    this._wsConnection.on('message', (message) => {
+    this._cdpWsConnection.on('message', (message) => {
       const params = JSON.parse(message)
       if (params.method === 'Fetch.requestPaused') {
         const requestPausedParams = params['params']
@@ -1420,7 +1428,7 @@ class WebDriver {
    * @returns {Promise<void>}
    */
   async onLogEvent(connection, callback) {
-    this._wsConnection.on('message', (message) => {
+    this._cdpWsConnection.on('message', (message) => {
       const params = JSON.parse(message)
       if (params.method === 'Runtime.consoleAPICalled') {
         const consoleEventParams = params['params']
@@ -1457,7 +1465,7 @@ class WebDriver {
   async onLogException(connection, callback) {
     await connection.execute('Runtime.enable', {}, null)
 
-    this._wsConnection.on('message', (message) => {
+    this._cdpWsConnection.on('message', (message) => {
       const params = JSON.parse(message)
 
       if (params.method === 'Runtime.exceptionThrown') {
@@ -1510,7 +1518,7 @@ class WebDriver {
       null,
     )
 
-    this._wsConnection.on('message', async (message) => {
+    this._cdpWsConnection.on('message', async (message) => {
       const params = JSON.parse(message)
       if (params.method === 'Runtime.bindingCalled') {
         let payload = JSON.parse(params['params']['payload'])
@@ -2744,6 +2752,7 @@ class WebElement {
       keys = await this.driver_.fileDetector_.handleFile(this.driver_, keys.join(''))
     } catch (ex) {
       this.log_.severe('Error trying parse string as a file with file detector; sending keys instead' + ex)
+      keys = keys.join('')
     }
 
     return this.execute_(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "selenium-webdriver",
-  "version": "4.25.0",
+  "version": "4.26.0",
   "description": "The official WebDriver JavaScript bindings from the Selenium project",
   "license": "Apache-2.0",
   "keywords": [
@@ -23,30 +23,30 @@
     "node": ">= 14.21.0"
   },
   "dependencies": {
-    "@bazel/runfiles": "^5.8.1",
+    "@bazel/runfiles": "^6.3.1",
     "jszip": "^3.10.1",
     "tmp": "^0.2.3",
     "ws": "^8.18.0"
   },
   "devDependencies": {
-    "@eslint/js": "^9.8.0",
+    "@eslint/js": "^9.13.0",
     "clean-jsdoc-theme": "^4.3.0",
-    "eslint": "^9.8.0",
+    "eslint": "^9.13.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-mocha": "^10.5.0",
-    "eslint-plugin-n": "^17.10.1",
-    "eslint-plugin-no-only-tests": "^3.1.0",
+    "eslint-plugin-n": "^17.11.1",
+    "eslint-plugin-no-only-tests": "^3.3.0",
     "eslint-plugin-prettier": "^5.2.1",
-    "express": "^4.19.2",
-    "globals": "^15.9.0",
+    "express": "^4.21.1",
+    "globals": "^15.11.0",
     "has-flag": "^5.0.1",
-    "jsdoc": "^4.0.3",
-    "mocha": "^10.7.0",
+    "jsdoc": "^4.0.4",
+    "mocha": "^10.7.3",
     "mocha-junit-reporter": "^2.2.1",
     "multer": "1.4.5-lts.1",
     "prettier": "^3.3.3",
     "serve-index": "^1.9.1",
-    "sinon": "^18.0.0",
+    "sinon": "^19.0.2",
     "supports-color": "^9.4.0"
   },
   "scripts": {