sela-core 1.0.8 → 1.0.9

package/dist/fixtures/index.js

@@ -34,7 +34,7 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.createHealingExpect = exports.test = void 0;
-exports.resolveFixwrightProxy = resolveFixwrightProxy;
+exports.resolveSelaProxy = resolveSelaProxy;
 exports.createFrameLocatorProxy = createFrameLocatorProxy;
 exports.createLocatorProxy = createLocatorProxy;
 const test_1 = require("@playwright/test");
@@ -47,10 +47,10 @@ const fs = __importStar(require("fs"));
 const path = __importStar(require("path"));
 const registry = HealingRegistry_1.HealingRegistry.getInstance();
 const proxyToActiveLocator = new WeakMap();
-// Module-level resolver - moduleExpect.ts uses this to unwrap a Fixwright
+// Module-level resolver - moduleExpect.ts uses this to unwrap a Sela
 // locator proxy back to its live underlying Playwright Locator without
 // needing access to the WeakMap directly.
-function resolveFixwrightProxy(value) {
+function resolveSelaProxy(value) {
     if (!value || typeof value !== "object")
         return null;
     const getActive = proxyToActiveLocator.get(value);
@@ -475,7 +475,7 @@ function createFrameLocatorProxy(rawFrameLocator, frameSelector, rawPage, testTi
 //     born after a heal has already broadcast).
 //  2. Subscribes to registry so any future broadcast swaps
 //     activeLocator on the same tick - before the next await.
-//  3. Exposes _fixwrightUnsubscribe so the fixture can clean up.
+//  3. Exposes _selaUnsubscribe so the fixture can clean up.
 // ─────────────────────────────────────────────────────────────────
 function createLocatorProxy(rawLocator, selector, rawPage, testTitle, actionCounter, elementSelectorOnly) {
     // Defensive: Proxy ctor throws "Cannot create proxy with a non-object as target"
@@ -531,17 +531,17 @@ function createLocatorProxy(rawLocator, selector, rawPage, testTitle, actionCoun
             if (typeof prop !== "string")
                 return Reflect.get(target, prop, receiver);
             // ── Internal accessors ───────────────────────────────────
-            if (prop === "_fixwrightSelector")
+            if (prop === "_selaSelector")
                 return currentFullSelector;
-            if (prop === "_fixwrightPage")
+            if (prop === "_selaPage")
                 return rawPage;
-            if (prop === "_fixwrightTestTitle")
+            if (prop === "_selaTestTitle")
                 return testTitle;
-            if (prop === "_fixwrightActionCounter")
+            if (prop === "_selaActionCounter")
                 return actionCounter;
-            if (prop === "_fixwrightElementSelector")
+            if (prop === "_selaElementSelector")
                 return currentElementSelector;
-            if (prop === "_fixwrightUnsubscribe")
+            if (prop === "_selaUnsubscribe")
                 return unsubscribe;
             // ── getBy* ───────────────────────────────────────────────
             if (prop in GET_BY_METHODS) {
@@ -661,6 +661,21 @@ function createLocatorProxy(rawLocator, selector, rawPage, testTitle, actionCoun
 // ─────────────────────────────────────────────────────────────────
 // ─── expect - healing proxy replacing the plain baseExpect proxy ──────────────
 exports.test = test_1.test.extend({
+    // ── Worker-scoped flush anchor (auto) ───────────────────────────────
+    // Setup is a no-op; the teardown after `use()` is the suite-end flush.
+    // Aggregation spans the ENTIRE worker run because commitUpdates() is no
+    // longer called per test - the report buffer, registry heal-map, and
+    // workspace snapshot accumulate across all tests and flush once here.
+    _selaWorkerLifecycle: [
+        async ({}, use) => {
+            await use();
+            // Single suite-wide commit: saves DNA snapshots, flushes the Insights
+            // report + .sela-history.json ONCE, and writes the DX-review ledger
+            // with the full set of healed events from the whole worker run.
+            await singleton_1.sharedEngine.commitUpdates();
+        },
+        { scope: "worker", auto: true },
+    ],
     page: async ({ page }, use, testInfo) => {
         page.on("console", (msg) => {
             if (msg.text().includes("[DOM-EXTRACT]")) {
@@ -683,7 +698,7 @@ exports.test = test_1.test.extend({
                 if (prop === "locator") {
                     return (selector) => {
                         const p = createLocatorProxy(target.locator(selector), selector, rawPage, testInfo.title, actionCounter, selector);
-                        const u = p._fixwrightUnsubscribe;
+                        const u = p._selaUnsubscribe;
                         if (u)
                             unsubscribers.push(u);
                         return p;
@@ -696,7 +711,7 @@ exports.test = test_1.test.extend({
                     return (...args) => {
                         const semanticSelector = GET_BY_METHODS[prop](args);
                         const p = createLocatorProxy(target[prop](...args), semanticSelector, rawPage, testInfo.title, actionCounter, semanticSelector);
-                        const u = p._fixwrightUnsubscribe;
+                        const u = p._selaUnsubscribe;
                         if (u)
                             unsubscribers.push(u);
                         return p;
@@ -706,11 +721,16 @@ exports.test = test_1.test.extend({
             },
         });
         await use(pageProxy);
-        // ── Teardown ─────────────────────────────────────────────────
+        // ── Per-test teardown ─────────────────────────────────────────
+        // Release this test's proxy registry subscriptions and drop per-test
+        // listeners. We deliberately DO NOT call engine.commitUpdates() here -
+        // flushing per test is what produced the per-test report writes, the
+        // duplicated .sela-history.json entries (each "healed":1), and the
+        // last-test-only DX diff. The suite-wide flush lives in the
+        // worker-scoped `_selaWorkerLifecycle` teardown above.
         for (const u of unsubscribers)
             u();
         registry.clearForTest();
-        await singleton_1.sharedEngine.commitUpdates();
     },
     expect: async ({ page }, use, testInfo) => {
         const healingExpect = (0, expectProxy_1.createHealingExpect)(singleton_1.sharedEngine, page, testInfo.file, 0, 

package/dist/fixtures/moduleExpect.js

@@ -9,14 +9,14 @@ const singleton_js_1 = require("../engine/singleton.js");
 const expectProxy_js_1 = require("./expectProxy.js");
 const index_js_1 = require("./index.js");
 function extractPage(value) {
-    if (!value || typeof value !== 'object')
+    if (!value || typeof value !== "object")
         return null;
-    // Fixwright locator proxy exposes _fixwrightPage directly
-    const proxied = value._fixwrightPage;
+    // Sela locator proxy exposes _selaPage directly
+    const proxied = value._selaPage;
     if (proxied)
         return proxied;
     // Playwright public API: Locator.page()
-    if (typeof value.page === 'function') {
+    if (typeof value.page === "function") {
         try {
             return value.page();
         }
@@ -27,7 +27,7 @@ function extractPage(value) {
     return null;
 }
 function getCallerFile() {
-    const lines = new Error().stack?.split('\n') ?? [];
+    const lines = new Error().stack?.split("\n") ?? [];
     // Match BOTH frame shapes V8 emits:
     //   "    at fnName (D:\\path\\file.spec.ts:17:20)"
     //   "    at D:\\path\\file.spec.ts:17:20"
@@ -42,13 +42,13 @@ function getCallerFile() {
         if (m && m[1])
             return m[1].trim();
     }
-    return '';
+    return "";
 }
 function expect(value) {
     const page = extractPage(value);
     if (page) {
         const filePath = getCallerFile();
-        return (0, expectProxy_js_1.createHealingExpect)(singleton_js_1.sharedEngine, page, filePath, 0, index_js_1.resolveFixwrightProxy)(value);
+        return (0, expectProxy_js_1.createHealingExpect)(singleton_js_1.sharedEngine, page, filePath, 0, index_js_1.resolveSelaProxy)(value);
     }
     return (0, test_1.expect)(value);
 }

package/dist/fixtures/proxyTag.js

@@ -6,7 +6,7 @@
 // Every Sela-created Proxy (locator, frame-locator, page, expect) honors a
 // `get` trap on this symbol and returns the kind string. Consumers - the
 // surface-diff test, internal helpers, debuggers - can identify Sela
-// proxies without touching the brittle "_fixwrightSelector" heuristic.
+// proxies without touching the brittle "_selaSelector" heuristic.
 //
 // We use Symbol.for() (a registered symbol) so the identity survives
 // across module boundaries when multiple bundles end up in the same

package/dist/services/ASTSourceUpdater.d.ts

@@ -1,6 +1,9 @@
 import { SelectorSegment } from "./LLMService";
 import { AdvisoryBuffer } from "./HealingAdvisory";
 import type { SmartChainSegment } from "./LLMService";
+import { TraceOutcome } from "./TraceBackEngine";
+import { Decision } from "./DecisionEngine";
+import { FileBatch, ApplyOutcome, ApplyOptions } from "./MutationApplier";
 export interface ASTUpdateResult {
     success: boolean;
     reason: string;
@@ -21,10 +24,51 @@ interface CallerContext {
     filePath: string;
     line: number;
 }
+export interface ComposeHealInput {
+    filePath: string;
+    /** 1-based line of the failing call-site. */
+    line: number;
+    /** 0-based column; when omitted the first non-whitespace char of the line is used. */
+    column?: number;
+    /**
+     * Healed locator EXPRESSION text, e.g. `page.locator(".btn-v2")`. When
+     * omitted, it is BUILT from `newSelector` + the traced target's root
+     * receiver (internal selectors → idiomatic method form).
+     */
+    newLocatorExpr?: string;
+    /** Raw healed selector string (may be an `internal:` engine selector). */
+    newSelector?: string;
+    /** Runtime: only the failing test needs the new selector. */
+    contextSpecific?: boolean;
+    /** Runtime: selector rot is global across all consumers. */
+    globalCorrect?: boolean;
+    /** When true, write the result via MutationApplier (with the gate). */
+    apply?: boolean;
+    applyOptions?: ApplyOptions;
+}
+export interface ComposeHealResult {
+    kind: "decision" | "abort";
+    trace: TraceOutcome;
+    decision?: Decision;
+    batch?: FileBatch;
+    outcome?: ApplyOutcome;
+    /** 1-based line of the mutated target node (for report/diff). */
+    writtenLine?: number;
+}
 export declare class ASTSourceUpdater {
     private project;
     readonly advisoryBuffer: AdvisoryBuffer;
     flushAdvisories(): void;
+    /**
+     * Trace the failing call-site back to its source declaration, decide the
+     * mutation strategy (in-place / fork / prompt), and — when `apply` is set —
+     * write it to disk through the type-safety gate.
+     */
+    static composeHeal(input: ComposeHealInput): ComposeHealResult;
+    /** Drain-loop entry: apply pre-built batches through the write gate. */
+    static applyMutationBatches(batches: FileBatch[], opts?: ApplyOptions): ApplyOutcome[];
+    /** Convert a DecisionEngine result into an anchored MutationApplier batch. */
+    static decisionToBatch(filePath: string, decision: Decision): FileBatch;
     /**
      * Centralised write hook for every ts-morph `saveSync` call in this class.
      * When `SELA_DRY_RUN` is active the AST mutation stays in memory but the
@@ -86,6 +130,7 @@ export declare class ASTSourceUpdater {
     private lineToOffset;
     resolveFilePath(raw: string): string | null;
     private semanticDispatch;
+    private applyDefinitionSiteHeal;
     private handleIdentifierArg;
     private handlePropertyAccessArg;
     private handleTemplateLiteralArg;

package/dist/services/ASTSourceUpdater.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ASTSourceUpdater.d.ts","sourceRoot":"","sources":["../../src/services/ASTSourceUpdater.ts"],"names":[],"mappings":"AAgBA,OAAO,EAAE,eAAe,EAAE,MAAM,cAAc,CAAC;AAQ/C,OAAO,EAAE,cAAc,EAAgB,MAAM,mBAAmB,CAAC;AAOjE,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,cAAc,CAAC;AAMtD,MAAM,WAAW,eAAe;IAC9B,OAAO,EAAE,OAAO,CAAC;IACjB,MAAM,EAAE,MAAM,CAAC;IACf,QAAQ,EAAE,MAAM,CAAC;IACjB,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,kGAAkG;IAClG,mBAAmB,CAAC,EAAE,MAAM,CAAC;IAC7B,wEAAwE;IACxE,cAAc,CAAC,EAAE;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,IAAI,EAAE,MAAM,CAAA;KAAE,CAAC;IAChD,gFAAgF;IAChF,WAAW,CAAC,EAAE,MAAM,CAAC;CACtB;AAED,UAAU,aAAa;IACrB,QAAQ,EAAE,MAAM,CAAC;IACjB,IAAI,EAAE,MAAM,CAAC;CACd;AAk7DD,qBAAa,gBAAgB;IAC3B,OAAO,CAAC,OAAO,CAAU;IACzB,QAAQ,CAAC,cAAc,iBAAwB;IAE/C,eAAe,IAAI,IAAI;IAIvB;;;;;;OAMG;IACH,OAAO,CAAC,eAAe;IAqBvB,qBAAqB,CAAC,MAAM,EAAE,aAAa,GAAG;QAC5C,QAAQ,EAAE,OAAO,CAAC;QAClB,cAAc,CAAC,EAAE,MAAM,CAAC;QACxB,WAAW,CAAC,EAAE,MAAM,CAAC;KACtB;IAsDD;;;;OAIG;IACH,wBAAwB,CAAC,MAAM,EAAE,aAAa,GAAG,IAAI;;IAgCrD,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAcjC;IAEH,OAAO,CAAC,QAAQ,CAAC,gBAAgB,CA8B9B;IAEH,OAAO,CAAC,QAAQ,CAAC,iBAAiB,CAuB/B;IAMH,MAAM,CACJ,MAAM,EAAE,aAAa,EACrB,WAAW,EAAE,MAAM,EACnB,WAAW,EAAE,MAAM,EACnB,UAAU,CAAC,EAAE,eAAe,EAAE,EAC9B,mBAAmB,CAAC,EAAE,MAAM,EAC5B,aAAa,CAAC,EAAE;QAAE,OAAO,EAAE,MAAM,CAAC;QAAC,OAAO,EAAE,MAAM,CAAA;KAAE,EACpD,kBAAkB,CAAC,EAAE,iBAAiB,EAAE,EACxC,iBAAiB,CAAC,EAAE,iBAAiB,EAAE,GACtC,eAAe;IAkRlB,OAAO,CAAC,kBAAkB;IAuM1B,OAAO,CAAC,uBAAuB;IA8F/B,OAAO,CAAC,qBAAqB;IAyF7B,OAAO,CAAC,YAAY;IAkDpB,OAAO,CAAC,qBAAqB;IA0G7B,OAAO,CAAC,4BAA4B;IAoRpC,OAAO,CAAC,yBAAyB;IAsGjC,OAAO,CAAC,uBAAuB;IA4E/B,OAAO,CAAC,4BAA4B;IA4EpC,OAAO,CAAC,qBAAqB;IA6B7B,OAAO,CAAC,oBAAoB;IAwB5B,OAAO,CAAC,gBAAgB;IAwBxB;;;;;OAKG;IACH,OAAO,CAAC,MAAM,CAAC,iBAAiB;IAahC,OAAO,CAAC,mBAAmB;IAuC3B,OAAO,CAAC,kBAAkB;IA2B1B,OAAO,CAAC,kBAAkB;IAuB1B,OAAO,CAAC,2BAA2B;IAsCnC,OAAO,CAAC,yBAAyB;IAqCjC,OAAO,CAAC,yBAAyB;IA+CjC,OAAO,CAAC,qBAAqB;IAQ7B,OAAO,CAAC,cAAc;IAYtB,OAAO,CAAC,0BAA0B;IAmBlC,OAAO,CAAC,sBAAsB;IA2B9B,OAAO,CAAC,2BAA2B;IAoCnC,OAAO,CAAC,oBAAoB;IA2B5B,OAAO,CAAC,YAAY;IAUpB,eAAe,CAAC,GAAG,EAAE,MAAM,GAAG,MAAM,GAAG,IAAI;IAkB3C,OAAO,CAAC,gBAAgB;IAyFxB,OAAO,CAAC,mBAAmB;IAmG3B,OAAO,CAAC,uBAAuB;IAmG/B,OAAO,CAAC,wBAAwB;IA2FhC,OAAO,CAAC,mBAAmB;IAyD3B,OAAO,CAAC,uBAAuB;IA4F/B,OAAO,CAAC,kBAAkB;IA6B1B,OAAO,CAAC,kBAAkB;CAgB3B"}
+{"version":3,"file":"ASTSourceUpdater.d.ts","sourceRoot":"","sources":["../../src/services/ASTSourceUpdater.ts"],"names":[],"mappings":"AAgBA,OAAO,EAAE,eAAe,EAAE,MAAM,cAAc,CAAC;AAQ/C,OAAO,EAAE,cAAc,EAAgB,MAAM,mBAAmB,CAAC;AAOjE,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,cAAc,CAAC;AACtD,OAAO,EAAmB,YAAY,EAAE,MAAM,mBAAmB,CAAC;AAClE,OAAO,EAAkB,QAAQ,EAAE,MAAM,kBAAkB,CAAC;AAC5D,OAAO,EAEL,SAAS,EAET,YAAY,EACZ,YAAY,EACb,MAAM,mBAAmB,CAAC;AAW3B,MAAM,WAAW,eAAe;IAC9B,OAAO,EAAE,OAAO,CAAC;IACjB,MAAM,EAAE,MAAM,CAAC;IACf,QAAQ,EAAE,MAAM,CAAC;IACjB,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,kGAAkG;IAClG,mBAAmB,CAAC,EAAE,MAAM,CAAC;IAC7B,wEAAwE;IACxE,cAAc,CAAC,EAAE;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,IAAI,EAAE,MAAM,CAAA;KAAE,CAAC;IAChD,gFAAgF;IAChF,WAAW,CAAC,EAAE,MAAM,CAAC;CACtB;AAED,UAAU,aAAa;IACrB,QAAQ,EAAE,MAAM,CAAC;IACjB,IAAI,EAAE,MAAM,CAAC;CACd;AAs7DD,MAAM,WAAW,gBAAgB;IAC/B,QAAQ,EAAE,MAAM,CAAC;IACjB,6CAA6C;IAC7C,IAAI,EAAE,MAAM,CAAC;IACb,sFAAsF;IACtF,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB;;;;OAIG;IACH,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,0EAA0E;IAC1E,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,6DAA6D;IAC7D,eAAe,CAAC,EAAE,OAAO,CAAC;IAC1B,4DAA4D;IAC5D,aAAa,CAAC,EAAE,OAAO,CAAC;IACxB,uEAAuE;IACvE,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,YAAY,CAAC,EAAE,YAAY,CAAC;CAC7B;AAED,MAAM,WAAW,iBAAiB;IAChC,IAAI,EAAE,UAAU,GAAG,OAAO,CAAC;IAC3B,KAAK,EAAE,YAAY,CAAC;IACpB,QAAQ,CAAC,EAAE,QAAQ,CAAC;IACpB,KAAK,CAAC,EAAE,SAAS,CAAC;IAClB,OAAO,CAAC,EAAE,YAAY,CAAC;IACvB,iEAAiE;IACjE,WAAW,CAAC,EAAE,MAAM,CAAC;CACtB;AA4BD,qBAAa,gBAAgB;IAC3B,OAAO,CAAC,OAAO,CAAU;IACzB,QAAQ,CAAC,cAAc,iBAAwB;IAE/C,eAAe,IAAI,IAAI;IAYvB;;;;OAIG;IACH,MAAM,CAAC,WAAW,CAAC,KAAK,EAAE,gBAAgB,GAAG,iBAAiB;IAoE9D,wEAAwE;IACxE,MAAM,CAAC,oBAAoB,CACzB,OAAO,EAAE,SAAS,EAAE,EACpB,IAAI,GAAE,YAAiB,GACtB,YAAY,EAAE;IAIjB,8EAA8E;IAC9E,MAAM,CAAC,eAAe,CAAC,QAAQ,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ,GAAG,SAAS;IA8BvE;;;;;;OAMG;IACH,OAAO,CAAC,eAAe;IAqBvB,qBAAqB,CAAC,MAAM,EAAE,aAAa,GAAG;QAC5C,QAAQ,EAAE,OAAO,CAAC;QAClB,cAAc,CAAC,EAAE,MAAM,CAAC;QACxB,WAAW,CAAC,EAAE,MAAM,CAAC;KACtB;IAsDD;;;;OAIG;IACH,wBAAwB,CAAC,MAAM,EAAE,aAAa,GAAG,IAAI;;IAgCrD,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAcjC;IAEH,OAAO,CAAC,QAAQ,CAAC,gBAAgB,CA8B9B;IAEH,OAAO,CAAC,QAAQ,CAAC,iBAAiB,CAuB/B;IAMH,MAAM,CACJ,MAAM,EAAE,aAAa,EACrB,WAAW,EAAE,MAAM,EACnB,WAAW,EAAE,MAAM,EACnB,UAAU,CAAC,EAAE,eAAe,EAAE,EAC9B,mBAAmB,CAAC,EAAE,MAAM,EAC5B,aAAa,CAAC,EAAE;QAAE,OAAO,EAAE,MAAM,CAAC;QAAC,OAAO,EAAE,MAAM,CAAA;KAAE,EACpD,kBAAkB,CAAC,EAAE,iBAAiB,EAAE,EACxC,iBAAiB,CAAC,EAAE,iBAAiB,EAAE,GACtC,eAAe;IAkRlB,OAAO,CAAC,kBAAkB;IAuM1B,OAAO,CAAC,uBAAuB;IA8F/B,OAAO,CAAC,qBAAqB;IAyF7B,OAAO,CAAC,YAAY;IAkDpB,OAAO,CAAC,qBAAqB;IA0G7B,OAAO,CAAC,4BAA4B;IAoRpC,OAAO,CAAC,yBAAyB;IAsGjC,OAAO,CAAC,uBAAuB;IA4E/B,OAAO,CAAC,4BAA4B;IA4EpC,OAAO,CAAC,qBAAqB;IA6B7B,OAAO,CAAC,oBAAoB;IAwB5B,OAAO,CAAC,gBAAgB;IAwBxB;;;;;OAKG;IACH,OAAO,CAAC,MAAM,CAAC,iBAAiB;IAahC,OAAO,CAAC,mBAAmB;IAuC3B,OAAO,CAAC,kBAAkB;IA2B1B,OAAO,CAAC,kBAAkB;IAuB1B,OAAO,CAAC,2BAA2B;IAsCnC,OAAO,CAAC,yBAAyB;IAqCjC,OAAO,CAAC,yBAAyB;IA+CjC,OAAO,CAAC,qBAAqB;IAQ7B,OAAO,CAAC,cAAc;IAYtB,OAAO,CAAC,0BAA0B;IAmBlC,OAAO,CAAC,sBAAsB;IA2B9B,OAAO,CAAC,2BAA2B;IAoCnC,OAAO,CAAC,oBAAoB;IA2B5B,OAAO,CAAC,YAAY;IAUpB,eAAe,CAAC,GAAG,EAAE,MAAM,GAAG,MAAM,GAAG,IAAI;IAkB3C,OAAO,CAAC,gBAAgB;IAqGxB,OAAO,CAAC,uBAAuB;IAuE/B,OAAO,CAAC,mBAAmB;IAiF3B,OAAO,CAAC,uBAAuB;IAiF/B,OAAO,CAAC,wBAAwB;IA2FhC,OAAO,CAAC,mBAAmB;IAyD3B,OAAO,CAAC,uBAAuB;IA4F/B,OAAO,CAAC,kBAAkB;IA6B1B,OAAO,CAAC,kBAAkB;CAgB3B"}

package/dist/services/ASTSourceUpdater.js

@@ -49,6 +49,10 @@ const InitializerUpdater_1 = require("./InitializerUpdater");
 const CrossFileHealer_1 = require("./CrossFileHealer");
 const HealingAdvisory_1 = require("./HealingAdvisory");
 const ChainValidator_1 = require("./ChainValidator");
+const TraceBackEngine_1 = require("./TraceBackEngine");
+const DecisionEngine_1 = require("./DecisionEngine");
+const MutationApplier_1 = require("./MutationApplier");
+const SelectorSanitizer_1 = require("./SelectorSanitizer");
 // ═══════════════════════════════════════════════════════════════════
 // FIX #1 - normalizeSelector utility
 // ═══════════════════════════════════════════════════════════════════
@@ -1553,15 +1557,141 @@ function findAssertionsInWindow(sourceFile, locatorVarName, callerLine, windowLi
     }
     return results;
 }
-// ═══════════════════════════════════════════════════════════════════
-// MAIN CLASS
-// ═══════════════════════════════════════════════════════════════════
+/**
+ * Build a locator EXPRESSION from a raw healed selector + chain root.
+ * Internal engine selectors become their idiomatic method form
+ * (`page.getByRole(...)`); otherwise a `root.locator("selector")` call.
+ */
+function buildLocatorExpr(rawSelector, rootReceiver) {
+    const root = rootReceiver || "page";
+    if (!rawSelector)
+        return `${root}.locator("")`;
+    if ((0, SelectorSanitizer_1.isInternalEngineSelector)(rawSelector)) {
+        const method = (0, SelectorSanitizer_1.internalToMethodExpression)(rawSelector, root);
+        if (method)
+            return method;
+        const publicStr = (0, SelectorSanitizer_1.internalToPublicSelectorString)(rawSelector);
+        return `${root}.locator(${JSON.stringify(publicStr ?? rawSelector)})`;
+    }
+    return `${root}.locator(${JSON.stringify(rawSelector)})`;
+}
+/** 0-based column of the first non-whitespace char on a 1-based line. */
+function firstNonWhitespaceColumn(text, line1Based) {
+    const lines = text.split(/\r?\n/);
+    const idx = line1Based - 1;
+    if (idx < 0 || idx >= lines.length)
+        return 0;
+    const m = lines[idx].match(/^(\s*)/);
+    return m ? m[1].length : 0;
+}
 class ASTSourceUpdater {
     project;
     advisoryBuffer = new HealingAdvisory_1.AdvisoryBuffer();
     flushAdvisories() {
         this.advisoryBuffer.flush();
     }
+    // ═══════════════════════════════════════════════════════════════════
+    // STAGE 4 — end-to-end trace → decide → apply (Stages 1-3 wired in)
+    //
+    // Additive entry point. The legacy heal paths below are untouched; this
+    // is the new write-disciplined pipeline that composes AnchorResolver,
+    // TraceBackEngine, DecisionEngine and MutationApplier.
+    // ═══════════════════════════════════════════════════════════════════
+    /**
+     * Trace the failing call-site back to its source declaration, decide the
+     * mutation strategy (in-place / fork / prompt), and — when `apply` is set —
+     * write it to disk through the type-safety gate.
+     */
+    static composeHeal(input) {
+        const original = fs.readFileSync(input.filePath, "utf8");
+        const project = new ts_morph_1.Project({
+            useInMemoryFileSystem: true,
+            compilerOptions: {
+                allowJs: true,
+                noEmit: true,
+                skipLibCheck: true,
+                noResolve: true,
+            },
+        });
+        const sf = project.createSourceFile(input.filePath, original, {
+            overwrite: true,
+        });
+        // Resolve a robust position: when no explicit column is given, use the
+        // first non-whitespace char of the line (avoids landing on indentation).
+        const column = input.column ?? firstNonWhitespaceColumn(original, input.line);
+        const trace = TraceBackEngine_1.TraceBackEngine.traceFromPosition(sf, input.line, column);
+        if (trace.status !== "target") {
+            return { kind: "abort", trace };
+        }
+        // Re-resolve the node at the failing position for fork test-block lookup.
+        let failingNode;
+        try {
+            failingNode = sf.getDescendantAtPos(sf.compilerNode.getPositionOfLineAndCharacter(input.line - 1, column));
+        }
+        catch {
+            failingNode = undefined;
+        }
+        if (!failingNode)
+            failingNode = trace.target.targetNode;
+        // Build the replacement EXPRESSION. Explicit newLocatorExpr wins; else
+        // synthesise it from the raw healed selector + the traced root receiver,
+        // translating internal engine selectors to their idiomatic method form.
+        const newLocatorExpr = input.newLocatorExpr ??
+            buildLocatorExpr(input.newSelector ?? "", trace.target.rootReceiver);
+        const decision = DecisionEngine_1.DecisionEngine.decide({
+            target: trace.target,
+            failingCallSite: failingNode,
+            newLocatorExpr,
+            contextSpecific: input.contextSpecific ?? false,
+            globalCorrect: input.globalCorrect ?? false,
+        });
+        const batch = ASTSourceUpdater.decisionToBatch(input.filePath, decision);
+        const result = {
+            kind: "decision",
+            trace,
+            decision,
+            batch,
+            writtenLine: trace.target.targetNode.getStartLineNumber(),
+        };
+        if (input.apply && batch.edits.length > 0) {
+            result.outcome = MutationApplier_1.MutationApplier.applyFileBatch(batch, input.applyOptions ?? {});
+        }
+        return result;
+    }
+    /** Drain-loop entry: apply pre-built batches through the write gate. */
+    static applyMutationBatches(batches, opts = {}) {
+        return MutationApplier_1.MutationApplier.applyBatches(batches, opts);
+    }
+    /** Convert a DecisionEngine result into an anchored MutationApplier batch. */
+    static decisionToBatch(filePath, decision) {
+        const edits = decision.edits.map((e) => {
+            if (e.kind === "insert") {
+                return {
+                    kind: "insert",
+                    replacement: e.replacement,
+                    span: e.span,
+                    requireLocator: false,
+                };
+            }
+            // MUTATE_IN_PLACE replace → anchor-resolved + Locator-type-gated.
+            if (decision.strategy === "MUTATE_IN_PLACE") {
+                return {
+                    kind: "replace",
+                    replacement: e.replacement,
+                    anchor: decision.anchor,
+                    requireLocator: true,
+                };
+            }
+            // FORK call-site receiver rewrite → identifier, not a locator.
+            return {
+                kind: "replace",
+                replacement: e.replacement,
+                span: e.span,
+                requireLocator: false,
+            };
+        });
+        return { filePath, edits };
+    }
     /**
      * Centralised write hook for every ts-morph `saveSync` call in this class.
      * When `SELA_DRY_RUN` is active the AST mutation stays in memory but the
@@ -3012,6 +3142,72 @@ class ASTSourceUpdater {
             return null;
         }
     }
+    // ═══════════════════════════════════════════════════════════════════
+    // DEFINITION-SITE WRITE (with internal→public Method-Shift fallback)
+    //
+    // A `const X = "selector"` consumed by `.locator(X)` cannot hold a semantic
+    // locator (page.getByRole(...) would reference `page` out of scope at the
+    // declaration). So when the AI heals to an internal engine selector
+    // (`internal:role=…`), we DON'T abort and we DON'T leak the engine string:
+    // we translate it to a VALID PUBLIC selector string (`role=button[name="…"]`)
+    // and write THAT into the constant — keeping the developer's architecture
+    // intact — while surfacing the cleaner semantic method form (getByRole) as
+    // a suggested upgrade in the advisory/report.
+    // ═══════════════════════════════════════════════════════════════════
+    applyDefinitionSiteHeal(targetNode, targetFile, newSelector, strategy, blastRadius) {
+        const wasInternal = (0, SelectorSanitizer_1.isInternalEngineSelector)(newSelector);
+        let writeValue = newSelector;
+        if (wasInternal) {
+            const publicStr = (0, SelectorSanitizer_1.internalToPublicSelectorString)(newSelector);
+            if (!publicStr) {
+                // No public string engine (e.g. label association) → a .locator()
+                // string constant genuinely cannot express it. Preserve the call site.
+                return {
+                    success: false,
+                    reason: `semantic guard: internal selector "${newSelector.slice(0, 48)}" has no public ` +
+                        `.locator() string form - call site preserved (method-shift required)`,
+                    strategy: "semantic-guard",
+                };
+            }
+            writeValue = publicStr;
+            console.log(`[SemanticDispatch] 🔁 Method-Shift fallback: internal selector → public string "${writeValue}"`);
+        }
+        const result = InitializerUpdater_1.InitializerUpdater.apply(targetNode, targetFile, writeValue);
+        if (!result)
+            return null;
+        if (!this.validateFileSyntax(targetFile)) {
+            return {
+                success: false,
+                reason: "post-mutation syntax validation failed - reverted",
+                strategy,
+            };
+        }
+        if (wasInternal) {
+            const methodExpr = (0, SelectorSanitizer_1.internalToMethodExpression)(newSelector, "page");
+            this.advisoryBuffer.push({
+                code: HealingAdvisory_1.AdvisoryCode.SEMANTIC_UPGRADE_SUGGESTED,
+                message: `Healed constant to public selector string "${writeValue}". ` +
+                    `Cleaner semantic form: ${methodExpr ?? "a getBy* method"}.`,
+                affectedFile: targetFile.getFilePath(),
+                affectedLine: result.lineUpdated,
+                suggestedAction: `For more resilient code, rewrite the call site to ${methodExpr ?? "the semantic locator"} ` +
+                    `instead of the string constant.`,
+            });
+        }
+        return {
+            success: true,
+            reason: `definition-site heal via ${strategy} trace` +
+                (wasInternal ? " (internal→public string; semantic upgrade suggested)" : ""),
+            strategy,
+            lineUpdated: result.lineUpdated,
+            healedLocatorString: result.healedLocatorString,
+            definitionSite: {
+                file: targetFile.getFilePath(),
+                line: result.lineUpdated,
+            },
+            blastRadius,
+        };
+    }
     handleIdentifierArg(node, sourceFile, caller, newSelector) {
         const traceResult = DefinitionTracer_1.DefinitionTracer.traceIdentifier(node, sourceFile, caller.line);
         if (traceResult.found) {
@@ -3043,28 +3239,7 @@ class ASTSourceUpdater {
                     suggestedAction: "Run the full test suite to confirm all references still pass.",
                 });
             }
-            const result = InitializerUpdater_1.InitializerUpdater.apply(targetNode, targetFile, newSelector);
-            if (!result)
-                return null;
-            if (!this.validateFileSyntax(targetFile)) {
-                return {
-                    success: false,
-                    reason: "post-mutation syntax validation failed - reverted",
-                    strategy: "semantic-identifier",
-                };
-            }
-            return {
-                success: true,
-                reason: `definition-site heal via identifier trace`,
-                strategy: "semantic-identifier",
-                lineUpdated: result.lineUpdated,
-                healedLocatorString: result.healedLocatorString,
-                definitionSite: {
-                    file: targetFile.getFilePath(),
-                    line: result.lineUpdated,
-                },
-                blastRadius: blast.testFunctionCount,
-            };
+            return this.applyDefinitionSiteHeal(targetNode, targetFile, newSelector, "semantic-identifier", blast.testFunctionCount);
         }
         if (!traceResult.found && traceResult.crossFile) {
             const xResult = CrossFileHealer_1.CrossFileHealer.heal(traceResult.modulePath, traceResult.symbolName, newSelector, caller.filePath, this.project);
@@ -3111,28 +3286,7 @@ class ASTSourceUpdater {
                     suggestedAction: "Run the full test suite to confirm all references still pass.",
                 });
             }
-            const result = InitializerUpdater_1.InitializerUpdater.apply(targetNode, targetFile, newSelector);
-            if (!result)
-                return null;
-            if (!this.validateFileSyntax(targetFile)) {
-                return {
-                    success: false,
-                    reason: "post-mutation syntax validation failed - reverted",
-                    strategy: "semantic-property-access",
-                };
-            }
-            return {
-                success: true,
-                reason: `definition-site heal via property access trace`,
-                strategy: "semantic-property-access",
-                lineUpdated: result.lineUpdated,
-                healedLocatorString: result.healedLocatorString,
-                definitionSite: {
-                    file: targetFile.getFilePath(),
-                    line: result.lineUpdated,
-                },
-                blastRadius: blast.testFunctionCount,
-            };
+            return this.applyDefinitionSiteHeal(targetNode, targetFile, newSelector, "semantic-property-access", blast.testFunctionCount);
         }
         if (!traceResult.found && traceResult.crossFile) {
             const xResult = CrossFileHealer_1.CrossFileHealer.heal(traceResult.modulePath, traceResult.symbolName, newSelector, caller.filePath, this.project);