seabox 0.3.0 → 0.5.0

package/README.md

@@ -148,17 +148,19 @@ seabox automates the entire SEA build process:
    - **Config globs**: Patterns specified in `assets` array
    - **Libraries**: Platform-specific shared libraries (DLLs/SOs)
 
-3. **Native Module Rebuilding** - Rebuilds native modules for target platform
+3. **Binary Preparation** - Downloads target Node.js binary 
 
-4. **Bootstrap Injection** - Adds runtime code for asset loading and native module extraction
+4. **Native Module Rebuilding** - Rebuilds native modules using the downloaded Node.js binary, ensuring ABI compatibility
 
-5. **SEA Blob Creation** - Packages everything using Node.js SEA tooling
+5. **Bootstrap Injection** - Adds runtime code for asset loading and native module extraction
 
-6. **Binary Preparation** - Downloads target Node.js binary and removes code signature
+6. **SEA Blob Creation** - Packages everything using the target Node.js binary 
 
-7. **Injection** - Uses `postject` to inject the blob into the Node.js binary
+7. **Signature Removal** - Removes code signature from the binary before injection
 
-8. **Output** - Produces standalone executable(s) ready for distribution
+8. **Injection** - Uses `postject` to inject the blob into the Node.js binary
+
+9. **Output** - Produces standalone executable(s) ready for distribution
 
 ### Automatic Asset Detection
 

package/lib/fetch-node.mjs

@@ -9,7 +9,7 @@ import https from 'https';
 import { pipeline } from 'stream';
 import { promisify } from 'util';
 import AdmZip from 'adm-zip';
-import tar from 'tar';
+import * as tar from 'tar';
 import * as diag from './diagnostics.mjs';
 
 const pipelineAsync = promisify(pipeline);

package/lib/inject.mjs

@@ -81,15 +81,22 @@ async function applyRcedit(exePath, options, verbose) {
   diag.verbose('Applying rcedit to modify executable resources...', 2);
   diag.verbose(`Options: ${JSON.stringify(options, null, 2)}`, 2);
 
-  // Try to import rcedit - it's a peer dependency
+  // Try to import rcedit - it's a peer dependency (v5+ uses named export)
   let rcedit;
   try {
-    rcedit = (await import('rcedit')).default;
+    const rceditModule = await import('rcedit');
+    rcedit = rceditModule.rcedit;
+    if (typeof rcedit !== 'function') {
+      throw new Error(
+        `rcedit module loaded but 'rcedit' export is ${typeof rcedit}. ` +
+        'Ensure rcedit v5+ is installed: npm install rcedit@^5'
+      );
+    }
   } catch (error) {
     if (error.code === 'ERR_MODULE_NOT_FOUND') {
       throw new Error(
         'rcedit is required for Windows executable metadata but not installed. ' +
-        'Install it with: npm install rcedit'
+        'Install it with: npm install rcedit@^5'
       );
     }
     throw error;

package/lib/multi-target-builder.mjs

@@ -135,26 +135,33 @@ export class MultiTargetBuilder {
 
     diag.subheader(`[Build ${buildNumber}] Target: ${target}`);
 
-    // Step 1: Rebuild native modules for this target
+    // Step 1: Fetch Node binary FIRST - needed for all subsequent operations
+    diag.buildStep(buildNumber, 1, 'Fetching Node.js binary...');
+    const cacheDir = path.join(this.projectRoot, 'node_modules', '.cache', 'sea-node-binaries');
+    const nodeBinary = await fetchNodeBinary(nodeVersion, platform, arch, cacheDir);
+    diag.success('Node binary ready');
+
+    // Step 2: Rebuild native modules using the TARGET Node binary
     const rebuiltModules = await this.rebuildNativeModulesForTarget(
       nativeModules,
       target,
+      nodeBinary,
       buildNumber
     );
 
-    // Step 2: Collect config assets (manual globs)
+    // Step 3: Collect config assets (manual globs)
     const configAssets = await this.collectConfigAssets(
       this.config.assets || [],
       buildNumber
     );
 
-    // Step 3: Collect auto-detected assets (from path.join(__dirname, ...))
+    // Step 4: Collect auto-detected assets (from path.join(__dirname, ...))
     const autoAssets = await this.collectDetectedAssets(
       detectedAssets,
       buildNumber
     );
 
-    // Step 4: Collect platform-specific libraries (DLLs/SOs)
+    // Step 5: Collect platform-specific libraries (DLLs/SOs)
     const platformLibraries = await this.collectPlatformLibraries(
       outputConfig.libraries,
       platform,
@@ -162,13 +169,13 @@ export class MultiTargetBuilder {
       buildNumber
     );
 
-    // Step 5: Prepare bundled entry with bootstrap
+    // Step 6: Prepare bundled entry with bootstrap
     const finalEntryPath = await this.prepareFinalEntry(
       bundledEntryPath,
       buildNumber
     );
 
-    // Step 6: Combine all assets (dedupe by assetKey)
+    // Step 7: Combine all assets (dedupe by assetKey)
     const assetMap = new Map();
     
     // Add in order of priority (later overwrites earlier)
@@ -213,11 +220,12 @@ export class MultiTargetBuilder {
       }
     }
 
-    // Step 7: Generate SEA
+    // Step 8: Generate SEA using the target Node binary
     await this.generateSEAForTarget({
       assets: allAssets,
       entryPath: finalEntryPath,
       target,
+      nodeBinary,
       outputPath,
       executableName,
       platform,
@@ -244,12 +252,12 @@ export class MultiTargetBuilder {
   /**
    * Rebuild native modules for specific target
    */
-  async rebuildNativeModulesForTarget(nativeModules, target, buildNumber) {
+  async rebuildNativeModulesForTarget(nativeModules, target, nodeBinary, buildNumber) {
     if (nativeModules.size === 0) {
       return [];
     }
 
-    diag.buildStep(buildNumber, 1, `Rebuilding ${nativeModules.size} native module(s)...`);
+    diag.buildStep(buildNumber, 2, `Rebuilding ${nativeModules.size} native module(s)...`);
 
     const rebuiltAssets = [];
     const { platform, arch } = parseTarget(target);
@@ -289,7 +297,7 @@ export class MultiTargetBuilder {
         // Rebuild the module
         diag.verbose(`Rebuilding: ${moduleName} for Node.js ${parseTarget(target).nodeVersion}`, 2);
 
-        await this.rebuildNativeModule(moduleInfo.packageRoot, target);
+        await this.rebuildNativeModule(moduleInfo.packageRoot, target, nodeBinary);
 
         // Find the built binary
         const builtPath = await this.findBuiltBinary(moduleInfo, target);
@@ -317,9 +325,9 @@ export class MultiTargetBuilder {
   }
 
   /**
-   * Rebuild a single native module
+   * Rebuild a single native module using the target Node binary
    */
-  async rebuildNativeModule(packageRoot, target) {
+  async rebuildNativeModule(packageRoot, target, nodeBinary) {
     const rebuildScript = path.join(__dirname, '..', 'bin', 'seabox-rebuild.mjs');
     
     if (!fs.existsSync(rebuildScript)) {
@@ -329,8 +337,9 @@ export class MultiTargetBuilder {
     const { nodeVersion, platform, arch } = parseTarget(target);
 
     try {
-      // Always inherit stdio to show node-gyp progress (header downloads, etc.)
-      execSync(`node "${rebuildScript}" "${packageRoot}" ${nodeVersion} ${platform} ${arch}${this.verbose ? ' --verbose' : ''}`, {
+      // Use the TARGET Node.js binary (not system node) to run the rebuild script
+      // This ensures all operations use the exact Node version we'll embed in the SEA
+      execSync(`"${nodeBinary}" "${rebuildScript}" "${packageRoot}" ${nodeVersion} ${platform} ${arch}${this.verbose ? ' --verbose' : ''}`, {
         stdio: 'inherit',  // Show node-gyp output including header downloads
         cwd: this.projectRoot
       });
@@ -579,7 +588,8 @@ const SEA_ENCRYPTED_ASSETS = new Set([]);
       arch,
       nodeVersion,
       rcedit,
-      buildNumber
+      buildNumber,
+      nodeBinary
     } = options;
 
     diag.buildStep(buildNumber, 4, 'Generating SEA blob...');
@@ -616,14 +626,9 @@ const SEA_ENCRYPTED_ASSETS = new Set([]);
     const seaConfigPath = path.join(tempDir, 'sea-config.json');
     writeSeaConfigJson(seaConfig, seaConfigPath, allAssets, tempDir);
 
-    // Fetch Node binary FIRST - needed for blob generation
-    diag.buildStep(buildNumber, 5, 'Fetching Node.js binary...');
-    const cacheDir = path.join(this.projectRoot, 'node_modules', '.cache', 'sea-node-binaries');
-    const nodeBinary = await fetchNodeBinary(nodeVersion, platform, arch, cacheDir);
-    diag.success('Node binary ready');
-
-    // Generate blob using the TARGET Node.js binary (not current process.execPath)
+    // Generate blob using the TARGET Node.js binary (already fetched)
     // This is critical for snapshots - they must be built with the target Node version
+    diag.buildStep(buildNumber, 5, 'Generating SEA blob...');
     await generateBlob(seaConfigPath, nodeBinary);
     diag.success('SEA blob generated');
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "seabox",
-  "version": "0.3.0",
+  "version": "0.5.0",
   "description": "Node.js Single Executable Application (SEA) builder tool with native and library extraction",
   "main": "lib/index.mjs",
   "type": "module",
@@ -37,11 +37,11 @@
     "adm-zip": "^0.5.16",
     "glob": "^10.0.0",
     "postject": "^1.0.0-alpha.6",
-    "rolldown": "^1.0.0-beta.50",
-    "tar": "^6.2.1"
+    "rolldown": "^1.0.0-rc.2",
+    "tar": "^7.5.7"
   },
   "peerDependencies": {
-    "rcedit": "^4.0.1"
+    "rcedit": "^5"
   },
   "peerDependenciesMeta": {
     "rcedit": {
@@ -51,9 +51,10 @@
   "devDependencies": {
     "chai": "^6.2.1",
     "javascript-obfuscator": "^4.1.1",
-    "mocha": "^11.7.5",
+    "mocha": "^11.3.0",
     "node-api-headers": "^1.2.0",
-    "rimraf": "^6.0.1"
+    "rimraf": "^6.0.1",
+    "rcedit": "^5"
   },
   "engines": {
     "node": ">=18.0.0"