seabox 0.1.0 → 0.1.2

package/README.md

@@ -25,6 +25,16 @@ Note: **V8 snapshot includes and embedds the original source**, this is currentl
 npm install --save-dev seabox
 ```
 
+### Optional: Windows Executable Metadata
+
+If you want to customize Windows executable metadata (icon, version info), install `rcedit`:
+
+```bash
+npm install --save-dev rcedit
+```
+
+This is only needed if you use the `rcedit` configuration option.
+
 ## Configuration
 
 Create a `seabox.config.json` file in your project root:
@@ -217,8 +227,7 @@ You can also explicitly specify library patterns in your config:
 These files are extracted on first run (like `.node` files) since they need to be loaded from the filesystem.
 
 ### Code Signature Removal
-
-Required before SEA injection. Platform-specific tools needed:
+If you have sign tools available, the seabox will attempt to unsign the node exe before modifying it. This is to reduce issues afterward when you try to resign it. 
 - **Windows**: `signtool.exe` (from Windows SDK)
 - **macOS**: `codesign` (included with Xcode)
 - **Linux**: Not required

package/lib/bootstrap.cjs

@@ -478,6 +478,9 @@
       const nameWithoutExt = path.basename(binary.fileName, path.extname(binary.fileName));
       nativeModuleMap[nameWithoutExt] = targetPath;
       
+      // CRITICAL: Also map the asset key (the path used in requires)
+      nativeModuleMap[binary.assetKey] = targetPath;
+      
       // PHASE 2: Populate global asset map for fs overrides
       assetPathMapGlobal[binary.assetKey] = targetPath;
     }

package/lib/inject.mjs

@@ -81,8 +81,19 @@ async function applyRcedit(exePath, options, verbose) {
   diag.verbose('Applying rcedit to modify executable resources...', 2);
   diag.verbose(`Options: ${JSON.stringify(options, null, 2)}`, 2);
 
-  // Dynamic import for rcedit (it's CommonJS)
-  const rcedit = (await import('rcedit')).default;
+  // Try to import rcedit - it's a peer dependency
+  let rcedit;
+  try {
+    rcedit = (await import('rcedit')).default;
+  } catch (error) {
+    if (error.code === 'ERR_MODULE_NOT_FOUND') {
+      throw new Error(
+        'rcedit is required for Windows executable metadata but not installed. ' +
+        'Install it with: npm install rcedit'
+      );
+    }
+    throw error;
+  }
   
   try {
     await rcedit(exePath, options);

package/lib/multi-target-builder.mjs

@@ -262,11 +262,9 @@ export class MultiTargetBuilder {
         if (moduleInfo.isPrebuild) {
           diag.verbose(`Using prebuild: ${moduleName}`, 2);
           
-          const relativeFromProject = path.relative(this.projectRoot, moduleInfo.binaryPath).replace(/\\/g, '/');
-          
           rebuiltAssets.push({
             sourcePath: moduleInfo.binaryPath,
-            assetKey: relativeFromProject,
+            assetKey: moduleInfo.assetKey,  // Use original assetKey from bundler
             isBinary: true,
             hash: await this.computeHash(moduleInfo.binaryPath)
           });
@@ -279,12 +277,9 @@ export class MultiTargetBuilder {
         if (cachedBuild) {
           diag.verbose(`Using cached build: ${moduleName}`, 2);
           
-          // Use relative path from project root
-          const relativeFromProject = path.relative(this.projectRoot, cachedBuild).replace(/\\/g, '/');
-          
           rebuiltAssets.push({
             sourcePath: cachedBuild,
-            assetKey: relativeFromProject,
+            assetKey: moduleInfo.assetKey,  // Use original assetKey from bundler
             isBinary: true,
             hash: await this.computeHash(cachedBuild)
           });
@@ -303,12 +298,9 @@ export class MultiTargetBuilder {
           // Cache the build
           this.cache.cacheNativeBuild(moduleInfo.packageRoot, target, builtPath);
           
-          // Use relative path from project root
-          const relativeFromProject = path.relative(this.projectRoot, builtPath).replace(/\\/g, '/');
-          
           rebuiltAssets.push({
             sourcePath: builtPath,
-            assetKey: relativeFromProject,
+            assetKey: moduleInfo.assetKey,  // Use original assetKey from bundler
             isBinary: true,
             hash: await this.computeHash(builtPath)
           });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "seabox",
-  "version": "0.1.0",
+  "version": "0.1.2",
   "description": "Node.js Single Executable Application (SEA) builder tool with native and library extraction",
   "main": "lib/index.mjs",
   "type": "module",
@@ -34,17 +34,20 @@
   },
   "homepage": "https://github.com/MeirionHughes/seabox",
   "dependencies": {
-    "@rollup/plugin-commonjs": "^28.0.2",
-    "@rollup/plugin-json": "^6.1.0",
-    "@rollup/plugin-node-resolve": "^15.3.0",
     "adm-zip": "^0.5.16",
     "glob": "^10.0.0",
     "postject": "^1.0.0-alpha.6",
-    "rcedit": "^4.0.1",
     "rolldown": "^1.0.0-beta.50",
-    "rollup": "^4.28.1",
     "tar": "^6.2.1"
   },
+  "peerDependencies": {
+    "rcedit": "^4.0.1"
+  },
+  "peerDependenciesMeta": {
+    "rcedit": {
+      "optional": true
+    }
+  },
   "devDependencies": {
     "chai": "^6.2.1",
     "javascript-obfuscator": "^4.1.1",