sdd-full 4.8.0 → 4.8.1

package/skills/flutter-skills/tool/dart_skills_lint/test/relative_paths_test.dart

@@ -1,172 +0,0 @@
-// Copyright (c) 2026, the Dart project authors.  Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import 'dart:io';
-
-import 'package:dart_skills_lint/src/models/analysis_severity.dart';
-import 'package:dart_skills_lint/src/rules/absolute_paths_rule.dart';
-import 'package:dart_skills_lint/src/rules/relative_paths_rule.dart';
-import 'package:dart_skills_lint/src/validator.dart';
-import 'package:test/test.dart';
-
-import 'test_utils.dart';
-
-void main() {
-  group('Relative Paths Validation', () {
-    late Directory tempDir;
-
-    setUp(() async {
-      tempDir = await Directory.systemTemp.createTemp('paths_test.');
-    });
-
-    tearDown(() async {
-      if (tempDir.existsSync()) {
-        await tempDir.delete(recursive: true);
-      }
-    });
-
-    test('passes with valid relative file path (existing file)', () async {
-      final Directory skillDir = await Directory('${tempDir.path}/test-skill').create();
-      await File('${skillDir.path}/SKILL.md').writeAsString(
-        '${buildFrontmatter(name: 'test-skill')}[Link to a reference](references/DETAILS.md)\n',
-      );
-
-      final Directory refDir = await Directory('${skillDir.path}/references').create();
-      await File('${refDir.path}/DETAILS.md').writeAsString('Details here');
-
-      final validator = Validator(
-        ruleOverrides: {RelativePathsRule.ruleName: AnalysisSeverity.warning},
-      );
-      final ValidationResult result = await validator.validate(skillDir);
-
-      expect(result.isValid, isTrue);
-      expect(result.errors, isEmpty);
-      expect(result.warnings, isEmpty);
-    });
-
-    test('warns with missing relative file path', () async {
-      final Directory skillDir = await Directory('${tempDir.path}/test-skill').create();
-      await File('${skillDir.path}/SKILL.md').writeAsString(
-        '${buildFrontmatter(name: 'test-skill')}[Link to a references file missing](references/MISSING.md)\n',
-      );
-
-      final validator = Validator(
-        ruleOverrides: {RelativePathsRule.ruleName: AnalysisSeverity.warning},
-      );
-      final ValidationResult result = await validator.validate(skillDir);
-
-      expect(result.isValid, isTrue);
-      expect(result.warnings, contains(contains('Linked file does not exist')));
-    });
-
-    test('fails with absolute file path', () async {
-      final Directory skillDir = await Directory('${tempDir.path}/test-skill').create();
-      await File('${skillDir.path}/SKILL.md').writeAsString(
-        '${buildFrontmatter(name: 'test-skill')}[Absolute path link](/tmp/some_absolute_path/file.md)\n',
-      );
-
-      final validator = Validator(
-        ruleOverrides: {
-          RelativePathsRule.ruleName: AnalysisSeverity.warning,
-          AbsolutePathsRule.ruleName: AnalysisSeverity.error,
-        },
-      );
-      final ValidationResult result = await validator.validate(skillDir);
-
-      expect(result.isValid, isFalse);
-      expect(result.errors, contains(contains('Absolute filepath found in link')));
-    });
-
-    test('ignores web URLs, emails, javascript, data URIs, and anchors', () async {
-      final Directory skillDir = await Directory('${tempDir.path}/test-skill').create();
-      await File('${skillDir.path}/SKILL.md').writeAsString(
-        '${buildFrontmatter(name: 'test-skill')}- [Web link](http://example.com)\n- [Web TLS link](https://example.com)\n- [Email link](mailto:user@domain.com)\n- [JS link](javascript:alert(1))\n- [Data URI](data:image/png;base64,iVBORw)\n- [Anchor link](#section-name)\n',
-      );
-
-      final validator = Validator(
-        ruleOverrides: {RelativePathsRule.ruleName: AnalysisSeverity.warning},
-      );
-      final ValidationResult result = await validator.validate(skillDir);
-
-      expect(result.isValid, isTrue);
-      expect(result.errors, isEmpty);
-      expect(result.warnings, isEmpty); // None of these should trigger local file checks
-    });
-
-    test('passes with valid relative image path and title', () async {
-      final Directory skillDir = await Directory('${tempDir.path}/test-skill').create();
-      await File('${skillDir.path}/SKILL.md').writeAsString(
-        '${buildFrontmatter(name: 'test-skill')}![Accessible description](images/screenshot.png "Hover description")\n',
-      );
-
-      final Directory imgDir = await Directory('${skillDir.path}/images').create();
-      await File('${imgDir.path}/screenshot.png').writeAsString('image content');
-
-      final validator = Validator(
-        ruleOverrides: {RelativePathsRule.ruleName: AnalysisSeverity.warning},
-      );
-      final ValidationResult result = await validator.validate(skillDir);
-
-      expect(result.isValid, isTrue);
-      expect(result.errors, isEmpty);
-      expect(result.warnings, isEmpty);
-    });
-
-    test('passes with relative path containing line fragments', () async {
-      final Directory skillDir = await Directory(
-        '${tempDir.path}/a/b/c/test-skill',
-      ).create(recursive: true);
-      await File('${skillDir.path}/SKILL.md').writeAsString(
-        '${buildFrontmatter(name: 'test-skill')}[Link to lines](../../../CONTRIBUTING.md#L64-L80)\n',
-      );
-
-      await File('${tempDir.path}/a/CONTRIBUTING.md').create(recursive: true);
-
-      final validator = Validator(
-        ruleOverrides: {RelativePathsRule.ruleName: AnalysisSeverity.warning},
-      );
-      final ValidationResult result = await validator.validate(skillDir);
-
-      expect(result.isValid, isTrue);
-      expect(result.errors, isEmpty);
-      expect(result.warnings, isEmpty);
-    });
-
-    test('passes with relative path containing anchor fragments', () async {
-      final Directory skillDir = await Directory('${tempDir.path}/test-skill').create();
-      await File('${skillDir.path}/SKILL.md').writeAsString(
-        '${buildFrontmatter(name: 'test-skill')}[Link to section](styleguide.md#miscellaneous-languages)\n',
-      );
-
-      await File('${skillDir.path}/styleguide.md').writeAsString('Styleguide content');
-
-      final validator = Validator(
-        ruleOverrides: {RelativePathsRule.ruleName: AnalysisSeverity.warning},
-      );
-      final ValidationResult result = await validator.validate(skillDir);
-
-      expect(result.isValid, isTrue);
-      expect(result.errors, isEmpty);
-      expect(result.warnings, isEmpty);
-    });
-
-    test('passes with leading and trailing whitespace in link', () async {
-      final Directory skillDir = await Directory('${tempDir.path}/test-skill').create();
-      await File('${skillDir.path}/SKILL.md').writeAsString(
-        '${buildFrontmatter(name: 'test-skill')}[Link with whitespace]( styleguide.md )\n',
-      );
-
-      await File('${skillDir.path}/styleguide.md').writeAsString('Styleguide content');
-
-      final validator = Validator(
-        ruleOverrides: {RelativePathsRule.ruleName: AnalysisSeverity.warning},
-      );
-      final ValidationResult result = await validator.validate(skillDir);
-
-      expect(result.isValid, isTrue);
-      expect(result.errors, isEmpty);
-      expect(result.warnings, isEmpty);
-    });
-  });
-}

package/skills/flutter-skills/tool/dart_skills_lint/test/resolve_rules_test.dart

@@ -1,82 +0,0 @@
-// Copyright (c) 2026, the Dart project authors.  Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import 'package:args/args.dart';
-import 'package:dart_skills_lint/src/config_parser.dart';
-import 'package:dart_skills_lint/src/entry_point.dart';
-import 'package:dart_skills_lint/src/models/analysis_severity.dart';
-import 'package:dart_skills_lint/src/models/check_type.dart';
-import 'package:dart_skills_lint/src/rule_registry.dart';
-import 'package:dart_skills_lint/src/rules/absolute_paths_rule.dart';
-import 'package:dart_skills_lint/src/rules/description_length_rule.dart';
-import 'package:dart_skills_lint/src/rules/disallowed_field_rule.dart';
-import 'package:dart_skills_lint/src/rules/name_format_rule.dart';
-import 'package:dart_skills_lint/src/rules/relative_paths_rule.dart';
-import 'package:dart_skills_lint/src/rules/valid_yaml_metadata_rule.dart';
-import 'package:test/test.dart';
-
-void main() {
-  group('resolveRules', () {
-    ArgParser createParser() {
-      final parser = ArgParser();
-      for (final CheckType check in RuleRegistry.allChecks) {
-        parser.addFlag(check.name, defaultsTo: check.defaultSeverity != AnalysisSeverity.disabled);
-      }
-      return parser;
-    }
-
-    test('returns defaults when no args and empty config', () {
-      final ArgResults results = createParser().parse([]);
-      final config = Configuration();
-
-      final Map<String, AnalysisSeverity> resolved = resolveRules(results, config);
-
-      expect(resolved[RelativePathsRule.ruleName], RelativePathsRule.defaultSeverity);
-      expect(resolved[AbsolutePathsRule.ruleName], AbsolutePathsRule.defaultSeverity);
-      expect(resolved[DisallowedFieldRule.ruleName], DisallowedFieldRule.defaultSeverity);
-      expect(resolved[ValidYamlMetadataRule.ruleName], ValidYamlMetadataRule.defaultSeverity);
-      expect(resolved[DescriptionLengthRule.ruleName], DescriptionLengthRule.defaultSeverity);
-      expect(resolved[NameFormatRule.ruleName], NameFormatRule.defaultSeverity);
-    });
-
-    test('config overrides defaults', () {
-      final ArgResults results = createParser().parse([]);
-      final config = Configuration(
-        configuredRules: {
-          RelativePathsRule.ruleName: AnalysisSeverity.error,
-          AbsolutePathsRule.ruleName: AnalysisSeverity.warning,
-        },
-      );
-
-      final Map<String, AnalysisSeverity> resolved = resolveRules(results, config);
-
-      expect(resolved[RelativePathsRule.ruleName], AnalysisSeverity.error);
-      expect(resolved[AbsolutePathsRule.ruleName], AnalysisSeverity.warning);
-      // Others should remain default
-      expect(resolved[DisallowedFieldRule.ruleName], DisallowedFieldRule.defaultSeverity);
-    });
-
-    test('CLI flags override config and defaults', () {
-      final ArgResults results = createParser().parse(['--${RelativePathsRule.ruleName}']);
-      final config = Configuration(
-        configuredRules: {RelativePathsRule.ruleName: AnalysisSeverity.error},
-      );
-
-      final Map<String, AnalysisSeverity> resolved = resolveRules(results, config);
-
-      expect(resolved[RelativePathsRule.ruleName], AnalysisSeverity.error);
-    });
-
-    test('CLI flag disabled overrides config', () {
-      final ArgResults results = createParser().parse(['--no-${ValidYamlMetadataRule.ruleName}']);
-      final config = Configuration(
-        configuredRules: {ValidYamlMetadataRule.ruleName: AnalysisSeverity.warning},
-      );
-
-      final Map<String, AnalysisSeverity> resolved = resolveRules(results, config);
-
-      expect(resolved[ValidYamlMetadataRule.ruleName], AnalysisSeverity.disabled);
-    });
-  });
-}

package/skills/flutter-skills/tool/dart_skills_lint/test/rule_naming_test.dart

@@ -1,29 +0,0 @@
-import 'package:dart_skills_lint/dart_skills_lint.dart';
-import 'package:dart_skills_lint/src/rules/absolute_paths_rule.dart';
-import 'package:dart_skills_lint/src/rules/description_length_rule.dart';
-import 'package:dart_skills_lint/src/rules/disallowed_field_rule.dart';
-import 'package:dart_skills_lint/src/rules/name_format_rule.dart';
-import 'package:dart_skills_lint/src/rules/relative_paths_rule.dart';
-import 'package:dart_skills_lint/src/rules/valid_yaml_metadata_rule.dart';
-import 'package:test/test.dart';
-
-void main() {
-  group('Rule Naming Conventions', () {
-    final List<SkillRule> rules = [
-      AbsolutePathsRule(),
-      DescriptionLengthRule(),
-      DisallowedFieldRule(),
-      NameFormatRule(),
-      RelativePathsRule(),
-      ValidYamlMetadataRule(),
-    ];
-
-    final kebabCaseRegex = RegExp(r'^[a-z0-9]+(-[a-z0-9]+)*$');
-
-    for (final rule in rules) {
-      test('Rule "${rule.runtimeType}" has valid kebab-case name', () {
-        expect(rule.name, matches(kebabCaseRegex));
-      });
-    }
-  });
-}

package/skills/flutter-skills/tool/dart_skills_lint/test/skills_ignores_storage_test.dart

@@ -1,89 +0,0 @@
-// Copyright (c) 2026, the Dart project authors.  Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import 'dart:io';
-
-import 'package:dart_skills_lint/src/models/skills_ignores.dart';
-import 'package:dart_skills_lint/src/skills_ignores_storage.dart';
-import 'package:test/test.dart';
-
-void main() {
-  late Directory tempDir;
-  late SkillsIgnoresStorage storage;
-
-  setUp(() async {
-    tempDir = Directory.systemTemp.createTempSync('storage_test.');
-    storage = SkillsIgnoresStorage();
-  });
-
-  tearDown(() async {
-    await tempDir.delete(recursive: true);
-  });
-
-  group('SkillsIgnoresStorage.load Integration', () {
-    test('inflates empty JSON into empty skills map', () async {
-      final file = File('${tempDir.path}/empty.json');
-      await file.writeAsString('{}');
-
-      final SkillsIgnores ignores = await storage.load(file.path);
-      expect(ignores.skills.isEmpty, isTrue);
-    });
-
-    test('inflates single skill with 1 ignore', () async {
-      final file = File('${tempDir.path}/one_ignore.json');
-      await file.writeAsString('''
-{
-  "skills": {
-    "skill-a": [
-      {"rule_id": "rule1", "file_name": "file1.md"}
-    ]
-  }
-}
-''');
-
-      final SkillsIgnores ignores = await storage.load(file.path);
-      expect(ignores.skills.containsKey('skill-a'), isTrue);
-      expect(ignores.skills['skill-a']!.length, equals(1));
-    });
-
-    test('inflates single skill with 2 ignores', () async {
-      final file = File('${tempDir.path}/two_ignores.json');
-      await file.writeAsString('''
-{
-  "skills": {
-    "skill-a": [
-      {"rule_id": "rule1", "file_name": "file1.md"},
-      {"rule_id": "rule2", "file_name": "file1.md"}
-    ]
-  }
-}
-''');
-
-      final SkillsIgnores ignores = await storage.load(file.path);
-      expect(ignores.skills.containsKey('skill-a'), isTrue);
-      expect(ignores.skills['skill-a']!.length, equals(2));
-    });
-
-    test('inflates three skills with varied ignores', () async {
-      final file = File('${tempDir.path}/three_skills.json');
-      await file.writeAsString('''
-{
-  "skills": {
-    "skill-a": [{"rule_id": "rule1", "file_name": "file1.md"}],
-    "skill-b": [{"rule_id": "rule1", "file_name": "file1.md"}, {"rule_id": "rule2", "file_name": "file1.md"}],
-    "skill-c": [{"rule_id": "rule1", "file_name": "file1.md"}, {"rule_id": "rule2", "file_name": "file1.md"}, {"rule_id": "rule3", "file_name": "file1.md"}]
-  }
-}
-''');
-
-      final SkillsIgnores ignores = await storage.load(file.path);
-      expect(ignores.skills.containsKey('skill-a'), isTrue);
-      expect(ignores.skills.containsKey('skill-b'), isTrue);
-      expect(ignores.skills.containsKey('skill-c'), isTrue);
-      expect(ignores.skills['skill-a']!.length, equals(1));
-      expect(ignores.skills['skill-b']!.length, equals(2));
-      expect(ignores.skills['skill-c']!.length, equals(3));
-    });
-  });
-}

package/skills/flutter-skills/tool/dart_skills_lint/test/test_utils.dart

@@ -1,19 +0,0 @@
-// Copyright (c) 2026, the Dart project authors.  Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-String buildFrontmatter({
-  String name = 'Skill-Name',
-  String description = 'A test skill',
-  String? compatibility,
-}) {
-  final sb = StringBuffer();
-  sb.writeln('---');
-  sb.writeln('name: $name');
-  sb.writeln('description: $description');
-  if (compatibility != null) {
-    sb.writeln('compatibility: $compatibility');
-  }
-  sb.writeln('---');
-  return sb.toString();
-}

package/skills/flutter-skills/tool/dart_skills_lint/test/trailing_whitespace_test.dart

@@ -1,152 +0,0 @@
-// Copyright (c) 2026, the Dart project authors.  Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import 'dart:io';
-
-import 'package:dart_skills_lint/src/models/analysis_severity.dart';
-import 'package:dart_skills_lint/src/models/skill_context.dart';
-import 'package:dart_skills_lint/src/models/validation_error.dart';
-import 'package:dart_skills_lint/src/rules/trailing_whitespace_rule.dart';
-import 'package:test/test.dart';
-
-import 'test_utils.dart';
-
-void main() {
-  group('Trailing Whitespace Validation', () {
-    test('passes for line with no trailing whitespace', () async {
-      final rule = TrailingWhitespaceRule(severity: AnalysisSeverity.warning);
-      final context = SkillContext(
-        directory: Directory('dummy'),
-        rawContent: '${buildFrontmatter(name: 'test-skill')}Line without trailing whitespace\n',
-      );
-
-      final List<ValidationError> errors = await rule.validate(context);
-
-      expect(errors, isEmpty);
-    });
-
-    test('passes for line with exactly 2 trailing spaces (hard line break)', () async {
-      final rule = TrailingWhitespaceRule(severity: AnalysisSeverity.warning);
-      final context = SkillContext(
-        directory: Directory('dummy'),
-        rawContent: '${buildFrontmatter(name: 'test-skill')}Line with 2 spaces  \nNext line\n',
-      );
-
-      final List<ValidationError> errors = await rule.validate(context);
-
-      expect(errors, isEmpty);
-    });
-
-    test('flags line with 1 trailing space as warning', () async {
-      final rule = TrailingWhitespaceRule(severity: AnalysisSeverity.warning);
-      final context = SkillContext(
-        directory: Directory('dummy'),
-        rawContent: '${buildFrontmatter(name: 'test-skill')}Line with 1 space \n',
-      );
-
-      final List<ValidationError> errors = await rule.validate(context);
-
-      expect(errors.any((e) => e.message.contains('has 1 trailing space(s)')), isTrue);
-    });
-
-    test('flags line with 3 trailing spaces as warning', () async {
-      final rule = TrailingWhitespaceRule(severity: AnalysisSeverity.warning);
-      final context = SkillContext(
-        directory: Directory('dummy'),
-        rawContent: '${buildFrontmatter(name: 'test-skill')}Line with 3 spaces   \n',
-      );
-
-      final List<ValidationError> errors = await rule.validate(context);
-
-      expect(errors.any((e) => e.message.contains('has 3 trailing space(s)')), isTrue);
-    });
-
-    test('flags line with trailing tabs as warning', () async {
-      final rule = TrailingWhitespaceRule(severity: AnalysisSeverity.warning);
-      final context = SkillContext(
-        directory: Directory('dummy'),
-        rawContent: '${buildFrontmatter(name: 'test-skill')}Line with tab\t\n',
-      );
-
-      final List<ValidationError> errors = await rule.validate(context);
-
-      expect(errors.any((e) => e.message.contains('trailing whitespace containing tabs')), isTrue);
-    });
-
-    test('respects severity setting', () async {
-      final rule = TrailingWhitespaceRule(severity: AnalysisSeverity.error);
-      final context = SkillContext(
-        directory: Directory('dummy'),
-        rawContent: '${buildFrontmatter(name: 'test-skill')}Line with 1 space \n',
-      );
-
-      final List<ValidationError> errors = await rule.validate(context);
-
-      expect(errors.length, 1);
-      expect(errors.first.severity, AnalysisSeverity.error);
-    });
-
-    test(
-      r'flags line with 1 trailing space before Windows line ending (\r\n) as warning',
-      () async {
-        final rule = TrailingWhitespaceRule(severity: AnalysisSeverity.warning);
-        final context = SkillContext(
-          directory: Directory('dummy'),
-          rawContent: '${buildFrontmatter(name: 'test-skill')}Line with 1 space \r\n',
-        );
-
-        final List<ValidationError> errors = await rule.validate(context);
-
-        expect(errors.any((e) => e.message.contains('has 1 trailing space(s)')), isTrue);
-      },
-    );
-
-    test('flags line containing only whitespace (3 spaces) as warning', () async {
-      final rule = TrailingWhitespaceRule(severity: AnalysisSeverity.warning);
-      final context = SkillContext(
-        directory: Directory('dummy'),
-        rawContent: '${buildFrontmatter(name: 'test-skill')}   \n',
-      );
-
-      final List<ValidationError> errors = await rule.validate(context);
-
-      expect(errors.any((e) => e.message.contains('has 3 trailing space(s)')), isTrue);
-    });
-
-    test('passes for line containing only 2 spaces', () async {
-      final rule = TrailingWhitespaceRule(severity: AnalysisSeverity.warning);
-      final context = SkillContext(
-        directory: Directory('dummy'),
-        rawContent: '${buildFrontmatter(name: 'test-skill')}  \n',
-      );
-
-      final List<ValidationError> errors = await rule.validate(context);
-
-      expect(errors, isEmpty);
-    });
-
-    group('Trailing Whitespace Fix', () {
-      test('removes trailing whitespace', () {
-        final rule = TrailingWhitespaceRule();
-
-        expect(rule.fixLine('Line with 1 space '), 'Line with 1 space');
-        expect(rule.fixLine('Line with 3 spaces   '), 'Line with 3 spaces');
-        expect(rule.fixLine('Line with tab\t'), 'Line with tab');
-      });
-
-      test('keeps exactly 2 spaces', () {
-        final rule = TrailingWhitespaceRule();
-
-        expect(rule.fixLine('Line with 2 spaces  '), 'Line with 2 spaces  ');
-      });
-
-      test('handles Windows line endings', () {
-        final rule = TrailingWhitespaceRule();
-
-        expect(rule.fixLine('Line with 1 space \r'), 'Line with 1 space\r');
-        expect(rule.fixLine('Line with 3 spaces   \r'), 'Line with 3 spaces\r');
-      });
-    });
-  });
-}