sdd-full 4.6.1 → 4.8.0

package/skills/flutter-skills/tool/generator/test/markdown_table_test.dart

@@ -0,0 +1,131 @@
+// Copyright (c) 2026, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:skills/src/services/markdown_converter.dart';
+import 'package:test/test.dart';
+
+void main() {
+  group('MarkdownConverter Tables', () {
+    late MarkdownConverter converter;
+
+    setUp(() {
+      converter = MarkdownConverter();
+    });
+
+    test('converts simple table', () {
+      const html = '''
+<table>
+  <thead>
+    <tr>
+      <th>Header 1</th>
+      <th>Header 2</th>
+    </tr>
+  </thead>
+  <tbody>
+    <tr>
+      <td>Cell 1</td>
+      <td>Cell 2</td>
+    </tr>
+  </tbody>
+</table>
+''';
+      final markdown = converter.convert(html);
+      expect(markdown, contains('| Header 1 | Header 2 |'));
+      expect(markdown, contains('|---|---|'));
+      expect(markdown, contains('| Cell 1 | Cell 2 |'));
+    });
+
+    test('converts table without thead', () {
+      const html = '''
+<table>
+  <tr>
+    <td>Cell 1</td>
+    <td>Cell 2</td>
+  </tr>
+</table>
+''';
+      final markdown = converter.convert(html);
+      // Fallback: treated as table with first row as header
+      expect(markdown, contains('| Cell 1 | Cell 2 |'));
+      expect(markdown, contains('|---|---|'));
+    });
+
+    test('converts definition lists', () {
+      const html = '''
+<dl>
+  <dt>Term 1</dt>
+  <dd>Definition 1</dd>
+  <dt>Term 2</dt>
+  <dd>Definition 2</dd>
+</dl>
+''';
+      final markdown = converter.convert(html);
+      expect(markdown, contains('**Term 1**'));
+      expect(markdown, contains(': Definition 1'));
+      expect(markdown, contains('**Term 2**'));
+      expect(markdown, contains(': Definition 2'));
+    });
+
+    test('converts details/summary', () {
+      const html = '''
+<details>
+  <summary>Summary</summary>
+  Details content
+</details>
+''';
+      // We'll preserve HTML for details as it's often supported in markdown rendering
+      // OR we can just output the content.
+      // Preserving HTML is usually safer for details.
+      final markdown = converter.convert(html);
+      expect(markdown, contains('<details>'));
+      expect(markdown, contains('<summary>Summary</summary>'));
+      expect(markdown, contains('Details content'));
+      expect(markdown, contains('</details>'));
+    });
+    test('converts nested tables without flattening', () {
+      const html = '''
+<table>
+  <tr>
+    <td>Outer 1</td>
+    <td>
+      <table>
+        <tr><td>Inner 1</td></tr>
+      </table>
+    </td>
+  </tr>
+</table>
+''';
+      final markdown = converter.convert(html);
+      // Outer row should contain both outer text and inner table result.
+      expect(markdown, contains('| Outer 1 |'));
+      expect(markdown, contains('| Inner 1 |'));
+      // The outer table should not have inner cells as separate columns of the outer structure.
+    });
+    test('handles empty table gracefully', () {
+      const html = '<table></table>';
+      final markdown = converter.convert(html);
+      expect(markdown, isEmpty);
+    });
+
+    test('converts table with multiple tbodies', () {
+      const html = '''
+<table>
+  <thead>
+    <tr><th>Header</th></tr>
+  </thead>
+  <tbody>
+    <tr><td>Row 1</td></tr>
+  </tbody>
+  <tbody>
+    <tr><td>Row 2</td></tr>
+  </tbody>
+</table>
+''';
+      final markdown = converter.convert(html);
+      expect(markdown, contains('| Header |'));
+      expect(markdown, contains('| Row 1 |'));
+      expect(markdown, contains('| Row 2 |'));
+    });
+  });
+}

package/skills/flutter-skills/tool/generator/test/models/skill_params_test.dart

@@ -0,0 +1,37 @@
+// Copyright (c) 2026, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:skills/src/models/skill_params.dart';
+import 'package:test/test.dart';
+
+void main() {
+  group('SkillParams', () {
+    test('fromJson parses correctly without instructions', () {
+      final json = {
+        'name': 'test-skill',
+        'description': 'Test Description',
+        'resources': ['http://example.com'],
+      };
+      final skill = SkillParams.fromJson(json);
+      expect(skill.name, 'test-skill');
+      expect(skill.description, 'Test Description');
+      expect(skill.resources, ['http://example.com']);
+      expect(skill.instructions, isNull);
+    });
+
+    test('fromJson parses correctly with instructions', () {
+      final json = {
+        'name': 'test-skill',
+        'description': 'Test Description',
+        'instructions': 'Do not hallucinate.',
+        'resources': ['http://example.com'],
+      };
+      final skill = SkillParams.fromJson(json);
+      expect(skill.name, 'test-skill');
+      expect(skill.description, 'Test Description');
+      expect(skill.resources, ['http://example.com']);
+      expect(skill.instructions, 'Do not hallucinate.');
+    });
+  });
+}

package/skills/flutter-skills/tool/generator/test/services/gemini_service_test.dart

@@ -0,0 +1,291 @@
+// Copyright (c) 2026, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:convert';
+
+import 'package:http/http.dart' as http;
+import 'package:http/testing.dart';
+
+import 'package:skills/src/services/gemini_service.dart';
+import 'package:test/test.dart';
+
+void main() {
+  group('GeminiService', () {
+    late GeminiService service;
+
+    setUp(() {
+      service = GeminiService(
+        apiKey: 'test-api-key',
+        httpClient: http.Client(),
+      );
+    });
+
+    group('cleanContent', () {
+      test('returns null for null content', () {
+        expect(service.cleanContent(null), isNull);
+      });
+
+      test('removes markdown code blocks around content', () {
+        const content = '''
+```markdown
+# Title
+Some content
+```
+''';
+        const expected = '''
+# Title
+Some content
+''';
+        expect(service.cleanContent(content), expected);
+      });
+
+      test('removes markdown code blocks with other languages', () {
+        const content = '''
+```text
+# Title
+Some content
+```
+''';
+        const expected = '''
+# Title
+Some content
+''';
+        expect(service.cleanContent(content), expected);
+      });
+
+      test('ignores trailing markdown code block if no start block', () {
+        const content = '''
+# Title
+Some content
+```
+''';
+        const expected = '''
+# Title
+Some content
+```
+''';
+        expect(service.cleanContent(content), expected);
+      });
+
+      test('strips possible frontmatter at start', () {
+        const content = '''
+---
+key: value
+---
+# Title
+Some content
+''';
+        const expected = '''
+# Title
+Some content
+''';
+        expect(service.cleanContent(content), expected);
+      });
+
+      test('strips possible frontmatter after some noise', () {
+        const content = '''
+Here is the content:
+---
+key: value
+---
+# Title
+Some content
+''';
+        const expected = '''
+# Title
+Some content
+''';
+        expect(service.cleanContent(content), expected);
+      });
+
+      test('preserves internal code blocks', () {
+        const content = '''
+# Title
+Here is some code:
+```dart
+void main() {}
+```
+''';
+        const expected = '''
+# Title
+Here is some code:
+```dart
+void main() {}
+```
+''';
+        expect(service.cleanContent(content), expected);
+      });
+
+      test('ensures content ends with newline', () {
+        const content = 'Some content';
+        const expected = 'Some content\n';
+        expect(service.cleanContent(content), expected);
+      });
+
+      test('handles complex nested structure', () {
+        const content = '''
+```markdown
+---
+key: value
+---
+# Title
+Content with code:
+```dart
+print('hello');
+```
+```
+''';
+        const expected = '''
+# Title
+Content with code:
+```dart
+print('hello');
+```
+''';
+        expect(service.cleanContent(content), expected);
+      });
+      test('removes markdown code blocks with leading whitespace', () {
+        const content = '''
+  ```markdown
+# Title
+Some content
+```
+''';
+        const expected = '''
+# Title
+Some content
+''';
+        expect(service.cleanContent(content), expected);
+      });
+
+      test(
+        'removes markdown code blocks with trailing whitespace on fence',
+        () {
+          const content = '''
+```markdown 
+# Title
+Some content
+``` 
+''';
+          const expected = '''
+# Title
+Some content
+''';
+          expect(service.cleanContent(content), expected);
+        },
+      );
+
+      test('removes markdown code blocks with uppercase language', () {
+        const content = '''
+```MARKDOWN
+# Title
+Some content
+```
+''';
+        const expected = '''
+# Title
+Some content
+''';
+        expect(service.cleanContent(content), expected);
+      });
+    });
+
+    group('generateSkillContent front matter', () {
+      test('does not wrap metadata values with quotes', () async {
+        final mockClient = MockClient((request) async {
+          return http.Response(
+            jsonEncode({
+              'candidates': [
+                {
+                  'content': {
+                    'parts': [
+                      {'text': 'Markdown body'},
+                    ],
+                  },
+                },
+              ],
+            }),
+            200,
+          );
+        });
+
+        final serviceWithMock = GeminiService(
+          apiKey: 'test-api-key',
+          httpClient: mockClient,
+          model: 'models/test-model',
+        );
+
+        final result = await serviceWithMock.generateSkillContent(
+          'Raw Content',
+          'test-skill',
+          'Test description without quotes',
+        );
+
+        expect(result, isNotNull);
+        expect(result, contains('name: test-skill'));
+        expect(
+          result,
+          contains('description: Test description without quotes'),
+        );
+        expect(result, contains('model: models/test-model'));
+        // Make sure it doesn't contain double quotes for the fields
+        expect(result, isNot(contains('name: "test-skill"')));
+        expect(
+          result,
+          isNot(contains('description: "Test description without quotes"')),
+        );
+        expect(result, isNot(contains('model: "models/test-model"')));
+      });
+    });
+
+    group('updateSkillContent front matter', () {
+      test('does not wrap metadata values with quotes', () async {
+        final mockClient = MockClient((request) async {
+          return http.Response(
+            jsonEncode({
+              'candidates': [
+                {
+                  'content': {
+                    'parts': [
+                      {'text': 'Markdown body'},
+                    ],
+                  },
+                },
+              ],
+            }),
+            200,
+          );
+        });
+
+        final serviceWithMock = GeminiService(
+          apiKey: 'test-api-key',
+          httpClient: mockClient,
+          model: 'models/test-model',
+        );
+
+        final result = await serviceWithMock.updateSkillContent(
+          'Existing Content',
+          'Raw Content',
+          'test-skill',
+          'Test description without quotes',
+        );
+
+        expect(result, isNotNull);
+        expect(result, contains('name: test-skill'));
+        expect(
+          result,
+          contains('description: Test description without quotes'),
+        );
+        expect(result, contains('model: models/test-model'));
+        // Make sure it doesn't contain double quotes for the fields
+        expect(result, isNot(contains('name: "test-skill"')));
+        expect(
+          result,
+          isNot(contains('description: "Test description without quotes"')),
+        );
+        expect(result, isNot(contains('model: "models/test-model"')));
+      });
+    });
+  });
+}

package/skills/flutter-skills/tool/generator/test/services/markdown_converter_test.dart

@@ -0,0 +1,156 @@
+// Copyright (c) 2026, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:skills/src/services/markdown_converter.dart';
+import 'package:test/test.dart';
+
+void main() {
+  group('MarkdownConverter', () {
+    late MarkdownConverter converter;
+
+    setUp(() {
+      converter = MarkdownConverter();
+    });
+
+    test('converts headers', () {
+      expect(converter.convert('<h1>Title</h1>'), contains('# Title'));
+      expect(converter.convert('<h2>Subtitle</h2>'), contains('## Subtitle'));
+      expect(converter.convert('<h3>Section</h3>'), contains('### Section'));
+    });
+
+    test('converts paragraphs', () {
+      expect(converter.convert('<p>Hello World</p>'), contains('Hello World'));
+    });
+
+    test('converts links', () {
+      expect(
+        converter.convert('<a href="https://example.com">Link</a>'),
+        contains('[Link](https://example.com)'),
+      );
+    });
+
+    test('converts bold and italic', () {
+      expect(converter.convert('<b>Bold</b>'), contains('**Bold**'));
+      expect(
+        converter.convert('<strong>Strong</strong>'),
+        contains('**Strong**'),
+      );
+      expect(converter.convert('<i>Italic</i>'), contains('*Italic*'));
+      expect(
+        converter.convert('<em>Emphasized</em>'),
+        contains('*Emphasized*'),
+      );
+    });
+
+    test('converts code', () {
+      expect(
+        converter.convert('<code>print("hello")</code>'),
+        contains('`print("hello")`'),
+      );
+      expect(
+        converter.convert('<pre>void main() {}</pre>'),
+        allOf(contains('```'), contains('void main() {}')),
+      );
+    });
+
+    test('converts lists', () {
+      const html = '''
+        <ul>
+          <li>Item 1</li>
+          <li>Item 2</li>
+        </ul>
+      ''';
+      final md = converter.convert(html);
+      expect(md, contains('- Item 1'));
+      expect(md, contains('- Item 2'));
+
+      const htmlOl = '''
+        <ol>
+          <li>First</li>
+          <li>Second</li>
+        </ol>
+      ''';
+      final mdOl = converter.convert(htmlOl);
+      // Currently the converter uses simplified list handling (returning - for both)
+      expect(mdOl, contains('- First'));
+      expect(mdOl, contains('- Second'));
+    });
+
+    test('converts line breaks', () {
+      expect(converter.convert('Line 1<br>Line 2'), contains('Line 1\nLine 2'));
+    });
+
+    test('converts structural elements', () {
+      expect(
+        converter.convert('<div>Div Content</div>'),
+        contains('Div Content'),
+      );
+      expect(
+        converter.convert('<section>Section Content</section>'),
+        contains('Section Content'),
+      );
+      expect(
+        converter.convert('<main>Main Content</main>'),
+        contains('Main Content'),
+      );
+      expect(
+        converter.convert('<article>Article Content</article>'),
+        contains('Article Content'),
+      );
+    });
+
+    test('handles empty body', () {
+      expect(converter.convert(''), isEmpty);
+    });
+
+    test('converts table without thead or tbody', () {
+      const html = '''
+        <table>
+          <tr><td>Data 1</td><td>Data 2</td></tr>
+          <tr><td>Data 3</td><td>Data 4</td></tr>
+        </table>
+      ''';
+      expect(converter.convert(html), contains('| Data 1 | Data 2 |'));
+      expect(converter.convert(html), contains('| Data 3 | Data 4 |'));
+    });
+
+    test('converts video tag with nested source', () {
+      expect(
+        converter.convert(
+          '<video><source src="https://example.com/video.mp4"></video>',
+        ),
+        contains('[Video](https://example.com/video.mp4)'),
+      );
+    });
+
+    test('converts definition lists (dl, dt, dd)', () {
+      const html = '''
+        <dl>
+          <dt>Term 1</dt>
+          <dd>Definition 1</dd>
+        </dl>
+      ''';
+      final md = converter.convert(html);
+      expect(md, contains('**Term 1**'));
+      expect(md, contains('Definition 1'));
+    });
+
+    test('converts iframes', () {
+      expect(
+        converter.convert('<iframe src="https://example.com/embed"></iframe>'),
+        contains('[Iframe](https://example.com/embed)'),
+      );
+    });
+    test('retains details and summary as HTML', () {
+      const html = '''
+        <details>
+          <summary>Click to expand</summary>
+          Hidden content
+        </details>
+      ''';
+      final md = converter.convert(html);
+      expect(md, contains('<details>'));
+    });
+  });
+}