scv-bilara 3.200.6 → 3.201.2

package/.task-world.json

@@ -0,0 +1 @@
+{"testDefault":"update unit tests","showUpdate":false,"limit":5,"verbosity":1,"showDone":false,"taskStack":["019CBE03-BFE6-7000-8771-EECB1289BCB5"],"lineLength":80}

package/Tasks/T_AZy-A7_mc.json

@@ -0,0 +1,102 @@
+{
+  "completedActions" : [
+    {
+      "description" : "Converted exec-git.mjs (10 tests passing)",
+      "id" : "AZy-Ac01"
+    },
+    {
+      "description" : "Converted verse.mjs (7 tests passing)",
+      "id" : "AZy-Ac02"
+    },
+    {
+      "description" : "Converted de-translations.mjs (9 tests passing)",
+      "id" : "AZy-Ac03"
+    },
+    {
+      "description" : "Converted publication.mjs (7 tests passing)",
+      "id" : "AZy-Ac04"
+    },
+    {
+      "description" : "Converted bilara-path-map.mjs (11 tests passing)",
+      "id" : "AZy-Ac05"
+    },
+    {
+      "description" : "Converted 9 other smaller test files",
+      "id" : "AZy-Ac06"
+    },
+    {
+      "description" : "Converted ml-doc.mjs (24 tests passing) - largest file to date at 19K, all tests passing",
+      "id" : "AZy-Ac07"
+    },
+    {
+      "description" : "FAILED ATTEMPT on bilara-data.js: Batch sed/perl replacements corrupted should.deepEqual() calls. Syntax errors at lines 598, 612, 633, 636, 645, 648, 655. File restored from original.",
+      "id" : "AZy-Ac08"
+    },
+    {
+      "description" : "Converted bilara-data.mjs (35 tests passing) - Used BORING approach: ONE test at a time, read carefully, fix precisely, verify immediately. No global replacements. ALL tests pass. CRITICAL LESSON: Speed kills quality. Boring = attention = success.",
+      "id" : "AZy-Ac09"
+    },
+    {
+      "description" : "Organized s4r test files by function: keywordSearch/phraseSearch tests moved to s4r-core.mjs (internal methods), find() tests staged in s4r-tbd.mjs for migration to s4r-suttas.mjs (primary entry point)",
+      "id" : "AZy-Ac10"
+    },
+    {
+      "description" : "Converted all 9 keywordSearch/phraseSearch tests to s4r-core.mjs using boring approach (ONE test at a time: convert, test, delete from source). All tests passing. Tests moved: keywordSearch limits results, searches English, searches Pali not English, searches English not Pali, searches Pali not Deutsch, searches Deutsch not Pali; phraseSearch limits results, searches English, finds Deutsch results.",
+      "id" : "AZy-Ac11"
+    },
+    {
+      "description" : "Converted Tests 1-8 from s4r-tbd.mjs to s4r-suttas.mjs using boring approach (8/23 tests = 35%). Tests: (1) pli-tv-bi-vb-sk1-75 (skipped-unpublished), (2) pli-tv-bi-vb-pj7 (skipped-unpublished), (3) ignores SN46.36, (4) alles leiden (German phrase), (5) thig1.1:1.1/en/soma, (6) thig1.1/en/soma,thig1.2/en/soma, (7) Deutsch abnehmend, (8) Deutsch blind. All 8 tests passing. CRITICAL LESSON: NEVER remove guard lines like 'if (!TEST_UNPUBLISHED) { return; }' - they control test execution, not cleanup candidates.",
+      "id" : "AZy-Ac12"
+    }
+  ],
+  "createdAt" : "2026-03-05T12:40:42Z",
+  "id" : "019CBE03-BFE6-7000-8771-EECB1289BCB5",
+  "name" : "convert existing mocha tests in test/ by copying them to vtest/ and converting them for use by @sc-voice/vitest",
+  "plannedActions" : [
+    {
+      "description" : "Move remaining 15 find() tests (Tests 9-23) from s4r-tbd.mjs to s4r-suttas.mjs - Use BORING approach: ONE test at a time. (1) Read test from s4r-tbd.mjs line 63. (2) Convert: should()->expect(), .equal()->.toBe(), .deepEqual()->.toEqual(), .above()->.toBeGreaterThan(), .match()->.toMatch(). PRESERVE ALL guard lines like 'if (!TEST_UNPUBLISHED) { return; }' - they control execution, NOT cleanup. (3) Add to s4r-suttas.mjs before closing brace. (4) Test: npm run vtest -- s4r-suttas.mjs -t \"testname\". (5) Delete from s4r-tbd.mjs. CRITICAL: Never batch tests. Never remove control flow. Verify each test passes before moving to next. Progress: 8/23 done (35%).",
+      "id" : "AZy-Ap02"
+    },
+    {
+      "description" : "Delete s4r-tbd.mjs file after all tests migrated to destination files",
+      "id" : "AZy-Ap03"
+    }
+  ],
+  "references" : [
+    {
+      "id" : "AZy-Ref00",
+      "relevance" : 1.0,
+      "text" : "CRITICAL MINDSET FOR NEXT CLONE: Boring works because it forces attention to detail. Speed kills quality. You have trouble paying attention. When you try to be fast or clever, you WILL miss things and corrupt code. SLOW DOWN. Read carefully. Fix one thing at a time. Verify after each fix. DO NOT declare victory until output is actually clean (no errors, no warnings, no dismissals). Do not want to feel done - just do the work. Attention > speed."
+    },
+    {
+      "id" : "AZy-Ref01",
+      "relevance" : 1.0,
+      "text" : "Key conversion patterns: (1) Convert done() callbacks to async/await by removing wrapper and done() calls. (2) Fix expect(x, y) to expect(x).toEqual(y) for old should.js pattern. (3) Fix expect(x).match(regex) to expect(x).toMatch(regex). (4) Use expect(x).equal(y) for primitives, expect(x).toEqual(y) for arrays/objects. (5) Import from '@sc-voice/vitest' not 'vitest' for custom expect() methods like .properties(). (6) Use cp command for copying test files (more reliable). (7) Convert tests incrementally one at a time for large files."
+    },
+    {
+      "id" : "AZy-Ref02",
+      "relevance" : 0.9,
+      "text" : "Unicode smart quote issue: Source data contains Unicode smart quotes. When test expectations use straight quotes but source has smart quotes, Edit tool may garble characters. Solution: User manually edits affected test strings, or extract actual output to /tmp file for user to copy correct Unicode characters."
+    },
+    {
+      "id" : "AZy-Ref03",
+      "relevance" : 0.8,
+      "text" : "Test status: 14 test files converted, 108 tests passing total. Run tests with: npm run vtest. Most recent: ml-doc.mjs completed with all 24 tests passing."
+    },
+    {
+      "id" : "AZy-Ref04",
+      "relevance" : 0.7,
+      "text" : "Files locations: test/ (original mocha tests), vtest/ (converted vitest tests), vtest/data/bilara-data/ (test data with Unicode characters)"
+    },
+    {
+      "id" : "AZy-Ref05",
+      "relevance" : 1.0,
+      "text" : "CRITICAL PROCEDURE FOR bilara-data.js (36 tests, 1094 lines): Convert ONE test method at a time ONLY. (1) Edit ONE test method. (2) Test with: npm run vtest -- bilara-data.mjs. (3) Verify passes. (4) Move to next test. DO NOT use global sed/perl replacements - they corrupt multi-line should.deepEqual() structures. Use this pattern per test: function(done) -> async (), remove try/catch, remove done()/done(e), convert should()->expect(), .equal()->.toBe(), .deepEqual()->.toEqual(), .above()->.toBeGreaterThan(), .throws()->.toThrow(), .match()->.toMatch(). After imports converted, start with test #1 'default ctor' at line ~46."
+    }
+  ],
+  "requiredTasks" : [
+
+  ],
+  "summary" : "Convert mocha test files from test/ directory to vitest format in vtest/ directory. Use @sc-voice/vitest framework which extends vitest with custom expect() methods. CRITICAL MINDSET: Boring = attention = success. Speed kills quality. Convert ONE test at a time ONLY: read, fix, verify. No global replacements. NEVER declare victory until output is truly clean. STATUS: seeker.js (94K) organized into 4 s4r-*.mjs files: s4r-core.mjs (constructor/grep/internal methods), s4r-suttas.mjs (find() with sutta patterns), s4r-trilingual.mjs (multilingual search), s4r-tbd.mjs (staging area). COMPLETED: All keywordSearch/phraseSearch tests (9 tests) converted to s4r-core.mjs and deleted from source. NEXT: Move ~24 find() tests from s4r-tbd.mjs to s4r-suttas.mjs one at a time using boring approach. Then delete s4r-tbd.mjs.",
+  "updatedAt" : "2026-03-05T18:48:00Z"
+}

package/Tasks/T_AZzA0n33c.json

@@ -0,0 +1,69 @@
+{
+  "completedActions" : [
+    {
+      "name" : "Convert: find(...) is cached (lines 793-819) - Test memoization behavior",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Convert: RegExp knows about word boundaries (line 1172) - Regex word boundary test",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Convert: RegExp matches ubung (line 575) - Unicode regex handling",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Convert: tipitakaRegExp(tc) => regexp for paths (lines 541-574) - Tipitaka category patterns",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Convert: patternLanguage(...) => search language context (lines 302-340) - Pattern analysis",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Convert: find(...) ignores unpublished (lines 341-374) - Filtering behavior",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Convert: find(...) ignores translation stubs (lines 580-597) - Stub filtering",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Convert: find(...) ignores chinese (lines 598-606) - Chinese filtering",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Convert: find(...) scores relevance (lines 262-281) - Scoring logic",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Convert: find(...) scores relevance: on fire (lines 282-301) - Fire phrase scoring",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Convert: isExample (lines 820-841) - Example detection",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Convert: isExample (cached) (lines 842-865) - Cached example detection",
+      "test" : "update unit tests"
+    }
+  ],
+  "createdAt" : "2026-03-06T01:45:46Z",
+  "id" : "019CC0D2-7DF7-7000-B8CC-167FC309CAA5",
+  "name" : "Convert 12 core utility tests from s4r-tbd to s4r-core",
+  "plannedActions" : [
+
+  ],
+  "references" : [
+    {
+      "relevance" : 1,
+      "text" : "After each test passes in s4r-core.mjs, REMOVE the corresponding test from the commented block in vtest\/s4r-tbd.mjs. This keeps s4r-tbd.mjs clean and prevents duplicate tests. Only the DUMMY TEST should remain in s4r-tbd when done."
+    }
+  ],
+  "requiredTasks" : [
+
+  ],
+  "summary" : "Move and convert caching, regex, pattern language, filtering, scoring, and example tests from commented section of vtest\/s4r-tbd.mjs to vtest\/s4r-core.mjs. Convert should.js to @sc-voice\/vitest syntax. Use boring approach: ONE test at a time.",
+  "updatedAt" : "2026-03-06T02:26:23Z"
+}

package/Tasks/T_AZzApRbqc.json

@@ -0,0 +1,141 @@
+{
+  "completedActions" : [
+    {
+      "name" : "Remove duplicate: find(...) finds dhp2",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) finds cp35\/de",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) finds thag1.10",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) orders sutta references found",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) finds sutta references",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) finds mn1\/en\/sujato",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(maxdoc)",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) finds an1.2",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find({minLang}) => minLang 2",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find({minLang:3}) root of suffering",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find({minLang:2}) root of suffering",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) => finds jhana",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) => finds phrase",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) => finds ubung",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) => finds searchLang phrase",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) => accepts embedded options",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) => finds all keywords",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find() keywords: wurzel leidens",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) => finds segments with all keywords",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: RegExp knows about word boundaries",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) => de, Benares",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) => no first point",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: findArgs(...) => aggaḷaṃ,",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: findArgs(...) => thig1.1..., thig1.2...",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: findArgs(...) handls jpn",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: findArgs(...) handles German",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: findArgs(...) author",
+      "test" : "update unit tests"
+    },
+    {
+      "name" : "Remove duplicate: find(...) finds an1.1 all types",
+      "test" : "update unit tests"
+    }
+  ],
+  "createdAt" : "2026-03-06T00:56:10Z",
+  "id" : "019CC0A5-16EA-7000-A0AE-1A9F5EE58CF3",
+  "name" : "remove duplicates of s4r-suttas.mjs tests that are still commented out in sr4-tbd.mjs",
+  "plannedActions" : [
+
+  ],
+  "references" : [
+    {
+      "relevance" : 1,
+      "text" : "CONTEXT: s4r-tbd.mjs is a staging file (copy of test\/seeker.js). The 28 actions listed are tests already successfully converted to s4r-suttas.mjs. These duplicate tests must be removed from s4r-tbd.mjs."
+    },
+    {
+      "relevance" : 1,
+      "text" : "PROCESS: For each action, search s4r-tbd.mjs for the test name. Verify it exists (likely commented out in \/* *\/ block starting ~line 62). Delete the complete test function. Verify deletion. Never batch delete - one test at a time only."
+    },
+    {
+      "relevance" : 1,
+      "text" : "CRITICAL: Use boring approach - go slowly, verify carefully, one test at a time. Do NOT close eyes and just delete. Check each line before removal. This is how your previous clone succeeded with other files."
+    }
+  ],
+  "requiredTasks" : [
+
+  ],
+  "summary" : "",
+  "updatedAt" : "2026-03-06T01:24:46Z"
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "scv-bilara",
-  "version": "3.200.6",
+  "version": "3.201.2",
   "description": "SuttaCentral bilara-data library",
   "main": "index.js",
   "directories": {
@@ -8,22 +8,19 @@
     "test": "test"
   },
   "dependencies": {
+    "@sc-voice/vitest": "^4.0.1",
     "check-node-version": "^4.0.1",
     "js-ebt": "^1.3.0",
     "json5": "^2.1.3",
     "log-instance": "^1.9.0",
     "memo-again": "^0.13.0",
     "merkle-json": "^2.15.0",
-    "scv-esm": "^1.135.6",
+    "scv-esm": "^1.135.7",
     "suttacentral-api": "^2.25.0",
     "tmp": "^0.2.3"
   },
   "devDependencies": {
-    "eslint-plugin-html": "^4.0.5",
-    "glob": "13.0.6",
-    "minimatch": "10.2.2",
-    "mocha": "^11.7.5",
-    "should": "^13.2.3"
+    "eslint-plugin-html": "^4.0.5"
   },
   "overrides": {
     "minimatch": "10.2.2",
@@ -32,12 +29,8 @@
   "scripts": {
     "schedule-action": "scripts/schedule-action",
     "push-action": "scripts/push-action",
-    "test": "npm run test:verbose",
-    "test:test-old": "scripts/clean-test; mocha -w --watch-ignore node_modules,.git,local -R min --inline-diffs -g TESTTEST './@(src|test)/**/*.*js'",
-    "test:test": "scripts/clean-test; mocha --config test/mocha-config.json -g TESTTEST",
-    "test:verbose": "scripts/clean-test; mocha --inline-diffs",
-    "test:one": "scripts/clean-test; mocha --inline-diffs -g TESTTEST",
-    "test:watch": "mocha -w --inline-diffs",
+    "test": "vitest run --config test/vitest.config.mjs --fileParallelism=false",
+    "test:test": "vitest --config test/vitest.config.mjs --fileParallelism=false",
     "version": "node -e \"console.log(require('./package.json').version);\""
   },
   "repository": {

package/src/seg-doc.js

@@ -94,7 +94,7 @@
             scids.forEach(scid => {
                 var text = segMap[scid];
                 text.split(' ').forEach(t => {
-                    var w = unicode.stripSymbols(t.toLowerCase());
+                    let w = unicode.stripSymbols(t.toLowerCase());
                     wordMap[w] = isMember;
                     romanize && (wordMap[unicode.romanize(w)] = isMember);
                 });

package/WORK.md

@@ -1,44 +0,0 @@
-# WORK.md
-
-**Build**: v3.192.2
-**Status**: In Progress
-**Started**: 2025-12-16
-
-## Objective
-
-Fix errors found by "npm run test" one-by-one with developer
-
-## Process for Fixing Each Bug (1-7)
-
-1. **Analyze**: Run test, capture failure output, identify what's wrong
-2. **Agree**: Share analysis with developer, get agreement
-3. **Propose**: Suggest fix based on analysis, explain reasoning
-4. **Approve**: Get developer approval before making changes
-5. **Implement**: Make code changes and add TESTTEST prefix to test name
-6. **Test**: Run `npx mocha test/<file>.mjs --grep "TESTTEST"` to verify fix works
-7. **Next**: Move to next bug
-
-## Plan
-
-1. [x] Bug 1: example-v2 exampleSuttas()
-2. [x] Bug 2: example-v2 suttasOfExamples()
-3. [x] Bug 3: Seeker phraseSearch(...) finds Deutsch results
-4. [x] Bug 4: Seeker find({minLang:3}) root of suffering
-5. [x] Bug 5: Seeker find(...) => finds phrase
-6. [x] Bug 6: Seeker find() keywords: wurzel leidens
-7. [x] Bug 7: Seeker find(...) ignores translation stubs
-
-## Current Step
-
-Complete - All 7 bugs fixed, 255 tests passing
-
-## Blockers
-
-None
-
-## Notes
-
-- 248 passing, 7 failing tests
-- All failures involve unwanted inclusion of mn105 in search results
-- Bug 1 FIXED: Updated test to include mn105 in expected results
-- All bugs appear to be Content Bugs (content changed, not code broken)