screwdriver-api 8.0.17 → 8.0.18

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "screwdriver-api",
-  "version": "8.0.17",
+  "version": "8.0.18",
   "description": "API server for the Screwdriver.cd service",
   "main": "index.js",
   "scripts": {

package/plugins/builds/create.js

@@ -52,6 +52,10 @@ module.exports = () => ({
                             if (!isValidToken(pipeline.id, request.auth.credentials)) {
                                 throw boom.unauthorized('Token does not have permission to this pipeline');
                             }
+                            // for mysql backward compatibility
+                            if (!pipeline.adminUserIds) {
+                                pipeline.adminUserIds = [];
+                            }
 
                             return (
                                 user

package/plugins/events/index.js

@@ -29,6 +29,10 @@ const eventsPlugin = {
         server.expose('updateAdmins', ({ permissions, pipeline, user }) => {
             const { username, id: userId } = user;
 
+            // for mysql backward compatibility
+            if (!pipeline.adminUserIds) {
+                pipeline.adminUserIds = [];
+            }
             // Delete user from admin list if bad permissions
             if (!permissions.push) {
                 const newAdmins = pipeline.admins;

package/plugins/pipelines/sync.js

@@ -41,6 +41,10 @@ module.exports = () => ({
             if (!user) {
                 throw boom.notFound(`User ${username} does not exist`);
             }
+            // for mysql backward compatibility
+            if (!pipeline.adminUserIds) {
+                pipeline.adminUserIds = [];
+            }
 
             // Use parent's scmUri if pipeline is child pipeline and using read-only SCM
             const scmUri = await getScmUri({ pipeline, pipelineFactory });

package/plugins/pipelines/update.js

@@ -21,6 +21,10 @@ function getPermissionsForOldPipeline({ scmContexts, pipeline, user }) {
     const isPipelineSCMContextObsolete = !scmContexts.includes(pipeline.scmContext);
     const isUserFromAnotherSCMContext = user.scmContext !== pipeline.scmContext;
 
+    // for mysql backward compatibility
+    if (!pipeline.adminUserIds) {
+        pipeline.adminUserIds = [];
+    }
     // this pipeline's scmContext has been removed, allow current admin to change it
     // also allow pipeline admins from other scmContexts to change it
     if (isPipelineSCMContextObsolete || isUserFromAnotherSCMContext) {
@@ -70,6 +74,11 @@ module.exports = () => ({
                 throw boom.notFound(`Pipeline ${id} does not exist`);
             }
 
+            // for mysql backward compatibility
+            if (!oldPipeline.adminUserIds) {
+                oldPipeline.adminUserIds = [];
+            }
+
             if (oldPipeline.configPipelineId) {
                 throw boom.forbidden(
                     `Child pipeline can only be modified by config pipeline ${oldPipeline.configPipelineId}`

package/plugins/webhooks/helper.js

@@ -90,6 +90,10 @@ async function updateAdmins(userFactory, username, scmContext, pipeline, pipelin
         const user = await userFactory.get({ username, scmContext });
         const userPermissions = await user.getPermissions(pipeline.scmUri, user.scmContext, pipeline.scmRepo);
 
+        // for mysql backward compatibility
+        if (!pipeline.adminUserIds) {
+            pipeline.adminUserIds = [];
+        }
         // Delete user from admin list if bad permissions
         if (!userPermissions.push) {
             const newAdmins = pipeline.admins;