screwdriver-api 7.0.223 → 7.0.225

package/bin/server

@@ -62,6 +62,7 @@ const queueWebhookEnabled = convertToBool(config.get('queueWebhook').enabled);
 // Default cluster environment variable
 const clusterEnvConfig = config.get('build').environment; // readonly
 const clusterEnv = { ...clusterEnvConfig };
+const artifactsMaxDownloadSize = config.get('build').artifacts.maxDownloadSize;
 
 Object.keys(clusterEnv).forEach(k => {
     clusterEnv[k] = String(clusterEnv[k]);
@@ -304,7 +305,8 @@ datastore.setup(datastoreConfig.ddlSyncEnabled).then(() =>
             executor,
             queueWebhookEnabled
         },
-        unzipArtifactsEnabled
+        unzipArtifactsEnabled,
+        artifactsMaxDownloadSize
     })
         .then(instance => logger.info('Server running at %s', instance.info.uri))
         .catch(err => {

package/config/custom-environment-variables.yaml

@@ -489,6 +489,9 @@ build:
   environment:
     __name: CLUSTER_ENVIRONMENT_VARIABLES
     __format: json
+  artifacts:
+    # max artifact download size (in GB)
+    maxDownloadSize: MAX_DOWNLOAD_SIZE
 
 rateLimit:
   __name: RATE_LIMIT_VARIABLES

package/config/default.yaml

@@ -390,6 +390,9 @@ log:
 build:
   environment:
     SD_VERSION: 4
+  artifacts:
+    # max artifact download size (in GB)
+    maxDownloadSize: 2
 
 rateLimit:
   # set true to enable rate limiting on auth token

package/lib/server.js

@@ -82,6 +82,7 @@ function prettyPrintErrors(request, h) {
  * @param  {Object}      config.builds.authConfig   Configuration for auth
  * @param  {Object}      config.builds.externalJoin Flag to allow external join
  * @param  {Object}      config.unzipArtifactsEnabled  Flag to allow unzip artifacts
+ * @param  {Object}      config.artifactsMaxDownloadSize Maximum download size for artifacts
  * @param  {Function}    callback                   Callback to invoke when server has started.
  * @return {http.Server}                            A listener: NodeJS http.Server object
  */
@@ -211,6 +212,7 @@ module.exports = async config => {
                 expiresIn
             );
         server.app.buildFactory.executor.tokenGen = server.app.buildFactory.tokenGen;
+        server.app.buildFactory.maxDownloadSize = parseInt(config.artifactsMaxDownloadSize, 10) * 1024 * 1024 * 1024;
 
         server.app.jobFactory.apiUri = server.info.uri;
         server.app.jobFactory.tokenGen = (username, metadata, scmContext, scope = ['user']) =>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "screwdriver-api",
-  "version": "7.0.223",
+  "version": "7.0.225",
   "description": "API server for the Screwdriver.cd service",
   "main": "index.js",
   "scripts": {

package/plugins/builds/artifacts/get.js

@@ -31,6 +31,7 @@ module.exports = config => ({
             const { credentials } = req.auth;
             const { canAccessPipeline } = req.server.plugins.pipelines;
             const { buildFactory, eventFactory } = req.server.app;
+            const { maxDownloadSize } = buildFactory;
 
             return buildFactory.get(buildId)
                 .then(build => {
@@ -70,6 +71,23 @@ module.exports = config => ({
                             }).text();
                             const manifestArray = manifest.trim().split('\n');
                             const directoryArray = manifestArray.filter(f => f.startsWith(`./${artifact}/`));
+                            let totalSize = 0;
+
+                            // Check file sizes by fetching metadata
+                            for (const file of directoryArray) {
+                                if (file) {
+                                    const fileMetaResponse = await request.head(`${baseUrl}/${file}?token=${token}&type=download`);
+                                    const fileSize = parseInt(fileMetaResponse.headers['content-length'], 10);
+
+                                    // Accumulate total size
+                                    totalSize += fileSize;
+
+                                    // If total size exceeds allowed limit, stop further processing
+                                    if (totalSize > maxDownloadSize) {
+                                        throw new Error(`Total size of files exceeds the allowed limit of ${maxDownloadSize/1024/1024/1024}GB.`);
+                                    }
+                                }
+                            }
 
                             // Create a stream and set up archiver
                             const archive = archiver('zip', { zlib: { level: 9 } });