screwdriver-api 5.0.19 → 6.0.1

package/Dockerfile

@@ -1,4 +1,4 @@
-FROM node:12
+FROM node:18
 
 # Screwdriver Version
 ARG VERSION=latest

package/Dockerfile.local

@@ -1,4 +1,4 @@
-FROM node:12
+FROM node:18
 
 # Create our application directory
 RUN mkdir -p /usr/src/app

package/package.json

@@ -1,11 +1,12 @@
 {
   "name": "screwdriver-api",
-  "version": "5.0.19",
+  "version": "6.0.1",
   "description": "API server for the Screwdriver.cd service",
   "main": "index.js",
   "scripts": {
     "pretest": "eslint . --quiet",
     "test": "nyc --report-dir ./artifacts/coverage --reporter=lcov mocha --reporter mocha-multi-reporters --reporter-options configFile=./mocha.config.json --recursive --timeout 10000 --retries 1 --exit --allow-uncaught true --color true",
+    "test-debug": "mocha --inspect ./test/**/*.js",
     "start": "./bin/server",
     "debug": "node --nolazy ./bin/server",
     "profile": "node --prof ./bin/server",
@@ -24,7 +25,7 @@
     "url": "git@github.com:screwdriver-cd/screwdriver.git"
   },
   "engines": {
-    "node": ">=12.0.0"
+    "node": ">=18.0.0"
   },
   "greenkeeper": {
     "ignore": [
@@ -67,68 +68,67 @@
     "Jithin Emmanuel <jithin1987@gmail.com>"
   ],
   "dependencies": {
-    "@hapi/bell": "^12.3.0",
-    "@hapi/boom": "^9.1.4",
-    "@hapi/cookie": "^11.0.2",
-    "@hapi/crumb": "^8.0.1",
+    "@hapi/bell": "^13.0.0",
+    "@hapi/boom": "^10.0.0",
+    "@hapi/cookie": "^12.0.0",
+    "@hapi/crumb": "^9.0.0",
     "@hapi/good": "^9.0.1",
     "@hapi/good-console": "^9.0.1",
     "@hapi/good-squeeze": "^6.0.0",
-    "@hapi/hapi": "^20.2.1",
-    "@hapi/hoek": "^9.1.1",
-    "@hapi/inert": "^6.0.4",
-    "@hapi/vision": "^6.1.0",
-    "@promster/hapi": "^6.1.0",
+    "@hapi/hapi": "^21.1.0",
+    "@hapi/hoek": "^11.0.0",
+    "@hapi/inert": "^7.0.0",
+    "@hapi/vision": "^7.0.0",
+    "@promster/hapi": "^8.0.6",
     "async": "^3.2.4",
     "badge-maker": "^3.3.1",
-    "config": "^1.31.0",
-    "date-fns": "^1.30.1",
-    "dayjs": "^1.11.6",
+    "config": "^3.3.8",
+    "dayjs": "^1.11.7",
     "hapi-auth-bearer-token": "^8.0.0",
-    "hapi-auth-jwt2": "^10.2.0",
-    "hapi-rate-limit": "^5.0.1",
-    "hapi-swagger": "^14.5.5",
+    "hapi-auth-jwt2": "^10.4.0",
+    "hapi-rate-limit": "^6.0.0",
+    "hapi-swagger": "^15.0.0",
     "ioredis": "^5.2.3",
     "joi": "^17.7.0",
     "js-yaml": "^3.14.1",
-    "jsonwebtoken": "^8.5.1",
-    "license-checker": "^17.0.0",
+    "jsonwebtoken": "^9.0.0",
+    "license-checker": "^25.0.1",
     "lodash.mergewith": "^4.6.2",
-    "ndjson": "^1.4.3",
+    "ndjson": "^2.0.0",
     "node-env-file": "^0.1.8",
     "prom-client": "^12.0.0",
-    "redlock": "^4.1.0",
-    "screwdriver-artifact-bookend": "^1.4.0",
-    "screwdriver-build-bookend": "^3.0.0",
-    "screwdriver-cache-bookend": "^2.1.0",
-    "screwdriver-command-validator": "^2.1.0",
-    "screwdriver-config-parser": "^7.6.1",
-    "screwdriver-coverage-bookend": "^1.1.0",
-    "screwdriver-coverage-sonar": "^3.4.1",
-    "screwdriver-data-schema": "^21.28.4",
-    "screwdriver-datastore-sequelize": "^7.2.7",
-    "screwdriver-executor-base": "^8.4.0",
-    "screwdriver-executor-docker": "^5.0.1",
-    "screwdriver-executor-k8s": "^14.16.0",
+    "redlock": "^4.2.0",
+    "screwdriver-artifact-bookend": "^2.0.0",
+    "screwdriver-build-bookend": "^4.0.0",
+    "screwdriver-cache-bookend": "^3.0.0",
+    "screwdriver-command-validator": "^3.0.0",
+    "screwdriver-config-parser": "^8.0.1",
+    "screwdriver-coverage-bookend": "^2.0.0",
+    "screwdriver-coverage-sonar": "^4.0.0",
+    "screwdriver-data-schema": "^22.0.1",
+    "screwdriver-datastore-sequelize": "^8.0.0",
+    "screwdriver-executor-base": "^9.0.1",
+    "screwdriver-executor-docker": "^6.0.0",
+    "screwdriver-executor-k8s": "^15.0.1",
     "screwdriver-executor-k8s-vm": "^4.3.2",
-    "screwdriver-executor-queue": "^3.1.2",
-    "screwdriver-executor-router": "^2.3.0",
-    "screwdriver-logger": "^1.2.0",
-    "screwdriver-models": "^28.20.0",
-    "screwdriver-notifications-email": "^2.3.1",
-    "screwdriver-notifications-slack": "^3.3.0",
-    "screwdriver-request": "^1.0.3",
-    "screwdriver-scm-base": "^7.3.0",
-    "screwdriver-scm-bitbucket": "^4.5.1",
-    "screwdriver-scm-github": "^11.10.3",
-    "screwdriver-scm-gitlab": "^2.10.0",
-    "screwdriver-scm-router": "^6.3.0",
-    "screwdriver-template-validator": "^5.2.0",
-    "screwdriver-workflow-parser": "^3.2.1",
-    "sqlite3": "^5.1.2",
+    "screwdriver-executor-queue": "^4.0.0",
+    "screwdriver-executor-router": "^3.0.0",
+    "screwdriver-logger": "^2.0.0",
+    "screwdriver-models": "^29.0.0",
+    "screwdriver-notifications-email": "^3.0.0",
+    "screwdriver-notifications-slack": "^4.0.0",
+    "screwdriver-request": "^2.0.1",
+    "screwdriver-scm-base": "^8.0.0",
+    "screwdriver-scm-bitbucket": "^5.0.0",
+    "screwdriver-scm-github": "^12.0.0",
+    "screwdriver-scm-gitlab": "^3.0.0",
+    "screwdriver-scm-router": "^7.0.0",
+    "screwdriver-template-validator": "^6.0.0",
+    "screwdriver-workflow-parser": "^4.0.0",
+    "sqlite3": "^5.1.4",
     "stream": "0.0.2",
     "tinytim": "^0.1.1",
-    "uuid": "^8.3.2",
+    "uuid": "^9.0.0",
     "verror": "^1.10.1"
   },
   "release": {
@@ -138,27 +138,27 @@
     }
   },
   "devDependencies": {
-    "@octokit/rest": "^18.12.0",
-    "chai": "~3.5.0",
-    "chai-as-promised": "^6.0.0",
+    "@octokit/rest": "^19.0.5",
+    "chai": "^4.3.7",
+    "chai-as-promised": "^7.1.1",
     "chai-jwt": "^2.0.0",
     "coveralls": "^3.1.1",
-    "cucumber": "6.0.4",
-    "cucumber-pretty": "^6.0.0",
-    "eslint": "^7.32.0",
-    "eslint-config-screwdriver": "^5.0.7",
-    "form-data": "^2.5.1",
-    "mocha": "^8.4.0",
+    "cucumber": "^6.0.7",
+    "cucumber-pretty": "^6.0.1",
+    "eslint": "^8.28.0",
+    "eslint-config-screwdriver": "^7.0.0",
+    "form-data": "^4.0.0",
+    "import-fresh": "^3.3.0",
+    "mocha": "^10.1.0",
     "mocha-multi-reporters": "^1.5.1",
     "mocha-sonarqube-reporter": "^1.0.2",
-    "mockery": "^2.0.0",
-    "mz": "^2.6.0",
+    "mz": "^2.7.0",
     "nock": "^13.2.9",
-    "node-plantuml": "^0.5.0",
     "npm-auto-version": "^1.0.0",
-    "nyc": "^15.0.0",
-    "rewire": "^4.0.1",
-    "sinon": "^7.4.2",
-    "stream-to-promise": "^2.2.0"
+    "nyc": "^15.1.0",
+    "rewire": "^6.0.0",
+    "rewiremock": "^3.14.4",
+    "sinon": "^15.0.0",
+    "stream-to-promise": "^3.0.0"
   }
 }

package/plugins/auth/index.js

@@ -2,7 +2,7 @@
 
 const joi = require('joi');
 const jwt = require('jsonwebtoken');
-const uuid = require('uuid');
+const { v4: uuidv4 } = require('uuid');
 const contextsRoute = require('./contexts');
 const crumbRoute = require('./crumb');
 const keyRoute = require('./key');
@@ -12,10 +12,7 @@ const tokenRoute = require('./token');
 
 const DEFAULT_TIMEOUT = 2 * 60; // 2h in minutes
 const ALGORITHM = 'RS256';
-const JOI_BOOLEAN = joi
-    .boolean()
-    .truthy('true')
-    .falsy('false');
+const JOI_BOOLEAN = joi.boolean().truthy('true').falsy('false');
 
 /**
  *
@@ -56,18 +53,9 @@ const createDefaultCollection = async function createDefaultCollection(user, col
 const AUTH_PLUGIN_SCHEMA = joi.object().keys({
     jwtEnvironment: joi.string().default(''),
     https: JOI_BOOLEAN.required(),
-    cookiePassword: joi
-        .string()
-        .min(32)
-        .required(),
-    encryptionPassword: joi
-        .string()
-        .min(32)
-        .required(),
-    hashingPassword: joi
-        .string()
-        .min(32)
-        .required(),
+    cookiePassword: joi.string().min(32).required(),
+    encryptionPassword: joi.string().min(32).required(),
+    hashingPassword: joi.string().min(32).required(),
     allowGuestAccess: JOI_BOOLEAN.default(false),
     jwtPrivateKey: joi.string().required(),
     jwtPublicKey: joi.string().required(),
@@ -76,16 +64,9 @@ const AUTH_PLUGIN_SCHEMA = joi.object().keys({
     admins: joi.array().default([]),
     bell: joi.object().required(),
     scm: joi.object().required(),
-    sessionTimeout: joi
-        .number()
-        .integer()
-        .positive()
-        .default(120),
+    sessionTimeout: joi.number().integer().positive().default(120),
     oauthRedirectUri: joi.string().optional(),
-    sameSite: joi
-        .alternatives()
-        .try(JOI_BOOLEAN, joi.string())
-        .required(),
+    sameSite: joi.alternatives().try(JOI_BOOLEAN, joi.string()).required(),
     path: joi.string().required()
 });
 
@@ -151,7 +132,7 @@ const authPlugin = {
             jwt.sign(profile, pluginOptions.jwtPrivateKey, {
                 algorithm: ALGORITHM,
                 expiresIn: buildTimeout * 60, // must be in second
-                jwtid: uuid.v4()
+                jwtid: uuidv4()
             })
         );
 

package/plugins/auth/login.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const boom = require('@hapi/boom');
-const uuid = require('uuid');
+const { v4: uuidv4 } = require('uuid');
 
 /**
  * Add a guest route for those who want to be in read-only mode
@@ -31,7 +31,7 @@ function addGuestRoute(config) {
                         return boom.forbidden('Guest users are not allowed access');
                     }
 
-                    const username = `guest/${uuid.v4()}`;
+                    const username = `guest/${uuidv4()}`;
                     const profile = request.server.plugins.auth.generateProfile(username, null, ['user', 'guest'], {});
 
                     // Log that the user has authenticated

package/plugins/banners/create.js

@@ -47,10 +47,7 @@ module.exports = () => ({
                         pathname: `${request.path}/${banner.id}`
                     });
 
-                    return h
-                        .response(banner.toJson())
-                        .header('Location', location)
-                        .code(201);
+                    return h.response(banner.toJson()).header('Location', location).code(201);
                 })
                 .catch(err => {
                     throw err;

package/plugins/buildClusters/create.js

@@ -50,10 +50,7 @@ module.exports = () => ({
                                 pathname: `${request.path}/${buildCluster.id}`
                             });
 
-                            return h
-                                .response(buildCluster.toJson())
-                                .header('Location', location)
-                                .code(201);
+                            return h.response(buildCluster.toJson()).header('Location', location).code(201);
                         })
                         // something was botched
                         .catch(err => {
@@ -103,10 +100,7 @@ module.exports = () => ({
                             pathname: `${request.path}/${buildCluster.id}`
                         });
 
-                        return h
-                            .response(buildCluster.toJson())
-                            .header('Location', location)
-                            .code(201);
+                        return h.response(buildCluster.toJson()).header('Location', location).code(201);
                     })
                     // something was botched
                     .catch(err => {

package/plugins/buildClusters/list.js

@@ -2,10 +2,7 @@
 
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const listSchema = joi
-    .array()
-    .items(schema.models.buildCluster.get)
-    .label('List of build clusters');
+const listSchema = joi.array().items(schema.models.buildCluster.get).label('List of build clusters');
 
 module.exports = () => ({
     method: 'GET',

package/plugins/builds/artifacts/get.js

@@ -5,7 +5,7 @@ const joi = require('joi');
 const jwt = require('jsonwebtoken');
 const request = require('screwdriver-request');
 const schema = require('screwdriver-data-schema');
-const uuid = require('uuid');
+const { v4: uuidv4 } = require('uuid');
 const idSchema = schema.models.build.base.extract('id');
 const artifactSchema = joi.string().label('Artifact Name');
 const typeSchema = joi.string().default('preview').valid('download', 'preview').label('Flag to trigger type either to download or preview');
@@ -52,7 +52,7 @@ module.exports = config => ({
                     }, config.authConfig.jwtPrivateKey, {
                         algorithm: 'RS256',
                         expiresIn: '5s',
-                        jwtid: uuid.v4()
+                        jwtid: uuidv4()
                     });
 
                     let baseUrl = `${config.ecosystem.store}/v1/builds/`

package/plugins/builds/getBuildStatuses.js

@@ -3,10 +3,7 @@
 const boom = require('@hapi/boom');
 const joi = require('joi');
 const stringSchema = joi.string().regex(/^[0-9]+$/);
-const jobIdsSchema = joi
-    .alternatives()
-    .try(joi.array().items(stringSchema), stringSchema)
-    .required();
+const jobIdsSchema = joi.alternatives().try(joi.array().items(stringSchema), stringSchema).required();
 
 module.exports = () => ({
     method: 'GET',

package/plugins/builds/listSecrets.js

@@ -3,10 +3,7 @@
 const boom = require('@hapi/boom');
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const buildListSchema = joi
-    .array()
-    .items(schema.models.secret.get)
-    .label('List of secrets');
+const buildListSchema = joi.array().items(schema.models.secret.get).label('List of secrets');
 const buildIdSchema = schema.models.build.base.extract('id');
 
 module.exports = () => ({

package/plugins/builds/steps/list.js

@@ -3,10 +3,7 @@
 const boom = require('@hapi/boom');
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const listSchema = joi
-    .array()
-    .items(schema.models.build.getStep)
-    .label('List of steps');
+const listSchema = joi.array().items(schema.models.build.getStep).label('List of steps');
 
 module.exports = () => ({
     method: 'GET',

package/plugins/builds/steps/logs.js

@@ -6,7 +6,7 @@ const logger = require('screwdriver-logger');
 const ndjson = require('ndjson');
 const request = require('screwdriver-request');
 const schema = require('screwdriver-data-schema');
-const uuid = require('uuid');
+const { v4: uuidv4 } = require('uuid');
 
 const MAX_LINES_SMALL = 100;
 const MAX_LINES_BIG = 1000;
@@ -200,7 +200,7 @@ module.exports = config => ({
                         {
                             algorithm: 'RS256',
                             expiresIn: '300s',
-                            jwtid: uuid.v4()
+                            jwtid: uuidv4()
                         }
                     );
                     const { sort, type } = req.query;

package/plugins/collections/addPipelines.js

@@ -5,10 +5,7 @@ const schema = require('screwdriver-data-schema');
 const joi = require('joi');
 const idSchema = schema.models.collection.base.extract('id');
 const pipelineIdSchema = schema.models.pipeline.base.extract('id');
-const pipelineIdsSchema = joi
-    .alternatives()
-    .try(joi.array().items(pipelineIdSchema), pipelineIdSchema)
-    .required();
+const pipelineIdsSchema = joi.alternatives().try(joi.array().items(pipelineIdSchema), pipelineIdSchema).required();
 const IDS_KEY = 'ids[]';
 
 module.exports = () => ({

package/plugins/collections/create.js

@@ -78,10 +78,7 @@ module.exports = () => ({
                             pathname: `${request.path}/${collection.id}`
                         });
 
-                        return h
-                            .response(collection.toJson())
-                            .header('Location', location)
-                            .code(201);
+                        return h.response(collection.toJson()).header('Location', location).code(201);
                     })
                     // something broke, respond with error
                     .catch(err => {

package/plugins/collections/removePipelines.js

@@ -5,10 +5,7 @@ const schema = require('screwdriver-data-schema');
 const joi = require('joi');
 const idSchema = schema.models.collection.base.extract('id');
 const pipelineIdSchema = schema.models.pipeline.base.extract('id');
-const pipelineIdsSchema = joi
-    .alternatives()
-    .try(joi.array().items(pipelineIdSchema), pipelineIdSchema)
-    .required();
+const pipelineIdsSchema = joi.alternatives().try(joi.array().items(pipelineIdSchema), pipelineIdSchema).required();
 const IDS_KEY = 'ids[]';
 
 module.exports = () => ({

package/plugins/commands/create.js

@@ -190,10 +190,7 @@ module.exports = () => ({
                         pathname: `${request.path}/${command.id}`
                     });
 
-                    return h
-                        .response(command.toJson())
-                        .header('Location', location)
-                        .code(201);
+                    return h.response(command.toJson()).header('Location', location).code(201);
                 })
                 .catch(err => {
                     throw err;

package/plugins/commands/createTag.js

@@ -81,10 +81,7 @@ module.exports = () => ({
                             pathname: `${request.path}/${newTag.id}`
                         });
 
-                        return h
-                            .response(newTag.toJson())
-                            .header('Location', location)
-                            .code(201);
+                        return h.response(newTag.toJson()).header('Location', location).code(201);
                     });
                 })
                 .catch(err => {

package/plugins/commands/list.js

@@ -2,10 +2,7 @@
 
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const listSchema = joi
-    .array()
-    .items(schema.models.command.get)
-    .label('List of commands');
+const listSchema = joi.array().items(schema.models.command.get).label('List of commands');
 const listCountSchema = joi
     .object()
     .keys({
@@ -17,10 +14,7 @@ const distinctSchema = joi
     .string()
     .valid(...Object.keys(schema.models.command.fields))
     .label('Field to return unique results by');
-const compactSchema = joi
-    .string()
-    .valid('', 'false', 'true')
-    .label('Flag to return compact data');
+const compactSchema = joi.string().valid('', 'false', 'true').label('Flag to return compact data');
 const namespaceSchema = schema.models.command.base.extract('namespace');
 const namespacesSchema = joi.array().items(joi.object().keys({ namespace: namespaceSchema }));
 

package/plugins/commands/listTags.js

@@ -2,10 +2,7 @@
 
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const listSchema = joi
-    .array()
-    .items(schema.models.commandTag.base)
-    .label('List of command tags');
+const listSchema = joi.array().items(schema.models.commandTag.base).label('List of command tags');
 const namespaceSchema = schema.models.commandTag.base.extract('namespace');
 const nameSchema = schema.models.commandTag.base.extract('name');
 

package/plugins/commands/listVersions.js

@@ -3,10 +3,7 @@
 const boom = require('@hapi/boom');
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const listSchema = joi
-    .array()
-    .items(schema.models.command.get)
-    .label('List of commands');
+const listSchema = joi.array().items(schema.models.command.get).label('List of commands');
 const nameSchema = schema.models.command.base.extract('name');
 const namespaceSchema = schema.models.command.base.extract('namespace');
 

package/plugins/events/create.js

@@ -26,15 +26,8 @@ module.exports = () => ({
             const { isValidToken } = request.server.plugins.pipelines;
             const { updateAdmins } = request.server.plugins.events;
 
-            let {
-                pipelineId,
-                startFrom,
-                parentBuildId,
-                parentBuilds,
-                groupEventId,
-                parentEventId,
-                prNum
-            } = request.payload;
+            let { pipelineId, startFrom, parentBuildId, parentBuilds, groupEventId, parentEventId, prNum } =
+                request.payload;
 
             // restart case
             if (buildId) {
@@ -245,10 +238,7 @@ module.exports = () => ({
                 pathname: `${request.path}/${event.id}`
             });
 
-            return h
-                .response(event.toJson())
-                .header('Location', location)
-                .code(201);
+            return h.response(event.toJson()).header('Location', location).code(201);
         },
         validate: {
             payload: validationSchema.models.event.create

package/plugins/events/listBuilds.js

@@ -3,10 +3,7 @@
 const boom = require('@hapi/boom');
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const buildListSchema = joi
-    .array()
-    .items(schema.models.build.get)
-    .label('List of builds');
+const buildListSchema = joi.array().items(schema.models.build.get).label('List of builds');
 const eventIdSchema = schema.models.event.base.extract('id');
 
 module.exports = () => ({
@@ -53,16 +50,8 @@ module.exports = () => ({
             }),
             query: schema.api.pagination.concat(
                 joi.object({
-                    readOnly: joi
-                        .boolean()
-                        .truthy('true')
-                        .falsy('false')
-                        .default(false),
-                    fetchSteps: joi
-                        .boolean()
-                        .truthy('true')
-                        .falsy('false')
-                        .default(true),
+                    readOnly: joi.boolean().truthy('true').falsy('false').default(false),
+                    fetchSteps: joi.boolean().truthy('true').falsy('false').default(true),
                     search: joi.forbidden() // we don't support search for Event list builds
                 })
             )

package/plugins/events/stopBuilds.js

@@ -89,10 +89,7 @@ module.exports = () => ({
                 pathname: `${request.path}/${event.id}`
             });
 
-            return h
-                .response(event.toJson())
-                .header('Location', location)
-                .code(200);
+            return h.response(event.toJson()).header('Location', location).code(200);
         },
         response: {
             schema: getSchema

package/plugins/helper.js

@@ -13,11 +13,7 @@ const dayjs = require('dayjs');
  */
 function setDefaultTimeRange(start, end, maxDay) {
     const endTime = end || new Date().toISOString();
-    const startTime =
-        start ||
-        dayjs(endTime)
-            .subtract(maxDay, 'days')
-            .toISOString();
+    const startTime = start || dayjs(endTime).subtract(maxDay, 'days').toISOString();
 
     return { startTime, endTime };
 }

package/plugins/jobs/listBuilds.js

@@ -5,10 +5,7 @@ const joi = require('joi');
 const schema = require('screwdriver-data-schema');
 const jobIdSchema = schema.models.job.base.extract('id');
 const statusSchema = schema.models.build.base.extract('status');
-const buildListSchema = joi
-    .array()
-    .items(schema.models.build.get)
-    .label('List of builds');
+const buildListSchema = joi.array().items(schema.models.build.get).label('List of builds');
 
 module.exports = () => ({
     method: 'GET',
@@ -75,16 +72,8 @@ module.exports = () => ({
             }),
             query: schema.api.pagination.concat(
                 joi.object({
-                    readOnly: joi
-                        .boolean()
-                        .truthy('true')
-                        .falsy('false')
-                        .default(false),
-                    fetchSteps: joi
-                        .boolean()
-                        .truthy('true')
-                        .falsy('false')
-                        .default(true),
+                    readOnly: joi.boolean().truthy('true').falsy('false').default(false),
+                    fetchSteps: joi.boolean().truthy('true').falsy('false').default(true),
                     status: statusSchema,
                     search: joi.forbidden() // we don't support search for Job list builds
                 })

package/plugins/jobs/metrics.js

@@ -64,12 +64,9 @@ module.exports = () => ({
             query: joi.object({
                 startTime: joi.string().isoDate(),
                 endTime: joi.string().isoDate(),
-                aggregateInterval: joi
-                    .string()
-                    .valid('none', 'day', 'week', 'month', 'year')
-                    .messages({
-                        'any.only': '{{#label}} fails because it must be one of none, day, week, month, year'
-                    })
+                aggregateInterval: joi.string().valid('none', 'day', 'week', 'month', 'year').messages({
+                    'any.only': '{{#label}} fails because it must be one of none, day, week, month, year'
+                })
             })
         }
     }

package/plugins/jobs/notify.js

@@ -30,7 +30,7 @@ module.exports = () => ({
                 throw boom.notFound(`Job ${jobId} does not exist`);
             }
 
-            const pipelineId = job.pipelineId;
+            const { pipelineId } = job;
 
             if (pipelineId !== credentials.pipelineId) {
                 throw boom.forbidden('Token does not have permission for this pipeline');

package/plugins/lock.js

@@ -30,7 +30,7 @@ class Lock {
         }
 
         const redisLockConfig = config.get('redisLock.options');
-        const connectionType = redisLockConfig.connectionType;
+        const { connectionType } = redisLockConfig;
 
         if (!connectionType || (connectionType !== 'redis' && connectionType !== 'redisCluster')) {
             throw new Error(

package/plugins/pipelines/caches/delete.js

@@ -7,15 +7,8 @@ const api = require('./request');
 const { getUserPermissions, getScmUri } = require('../../helper');
 
 const SCHEMA_SCOPE_PIPELINE_ID = schema.models.pipeline.base.extract('id');
-const SCHEMA_SCOPE_NAME = joi
-    .string()
-    .valid('events', 'jobs', 'pipelines')
-    .label('Scope Name');
-const SCHEMA_SCOPE_CACHE_ID = joi
-    .number()
-    .integer()
-    .positive()
-    .label('Event/Job/Pipeline ID');
+const SCHEMA_SCOPE_NAME = joi.string().valid('events', 'jobs', 'pipelines').label('Scope Name');
+const SCHEMA_SCOPE_CACHE_ID = joi.number().integer().positive().label('Event/Job/Pipeline ID');
 
 module.exports = () => ({
     method: 'DELETE',

package/plugins/pipelines/create.js

@@ -132,10 +132,7 @@ module.exports = () => ({
             });
             const data = await results.toJson();
 
-            return h
-                .response(data)
-                .header('Location', location)
-                .code(201);
+            return h.response(data).header('Location', location).code(201);
         },
         validate: {
             payload: schema.models.pipeline.create

package/plugins/pipelines/helper.js

@@ -19,10 +19,7 @@ const formatCheckoutUrl = checkoutUrl => {
     // Check if branch name exists
     // Do not convert branch name to lowercase
     if (branchName) {
-        result = result
-            .split('#')[0]
-            .toLowerCase()
-            .concat(branchName);
+        result = result.split('#')[0].toLowerCase().concat(branchName);
     } else {
         result = result.toLowerCase();
     }

package/plugins/pipelines/list.js

@@ -3,14 +3,8 @@
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
 const idSchema = schema.models.pipeline.base.extract('id');
-const listSchema = joi
-    .array()
-    .items(schema.models.pipeline.get)
-    .label('List of Pipelines');
-const pipelineIdsSchema = joi
-    .alternatives()
-    .try(joi.array().items(idSchema), idSchema)
-    .required();
+const listSchema = joi.array().items(schema.models.pipeline.get).label('List of Pipelines');
+const pipelineIdsSchema = joi.alternatives().try(joi.array().items(idSchema), idSchema).required();
 const IDS_KEY = 'ids[]';
 
 module.exports = () => ({

package/plugins/pipelines/listEvents.js

@@ -3,10 +3,7 @@
 const boom = require('@hapi/boom');
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const eventListSchema = joi
-    .array()
-    .items(schema.models.event.get)
-    .label('List of events');
+const eventListSchema = joi.array().items(schema.models.event.get).label('List of events');
 const prNumSchema = schema.models.event.base.extract('prNum');
 const pipelineIdSchema = schema.models.pipeline.base.extract('id');
 

package/plugins/pipelines/listJobs.js

@@ -3,10 +3,7 @@
 const boom = require('@hapi/boom');
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const jobListSchema = joi
-    .array()
-    .items(schema.models.job.get)
-    .label('List of jobs');
+const jobListSchema = joi.array().items(schema.models.job.get).label('List of jobs');
 const jobNameSchema = schema.models.job.base.extract('name');
 const pipelineIdSchema = schema.models.pipeline.base.extract('id');
 
@@ -62,11 +59,7 @@ module.exports = () => ({
             }),
             query: schema.api.pagination.concat(
                 joi.object({
-                    archived: joi
-                        .boolean()
-                        .truthy('true')
-                        .falsy('false')
-                        .default(false),
+                    archived: joi.boolean().truthy('true').falsy('false').default(false),
                     jobName: jobNameSchema,
                     search: joi.forbidden() // we don't support search for Pipeline list jobs
                 })

package/plugins/pipelines/listSecrets.js

@@ -3,10 +3,7 @@
 const boom = require('@hapi/boom');
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const secretListSchema = joi
-    .array()
-    .items(schema.models.secret.get)
-    .label('List of secrets');
+const secretListSchema = joi.array().items(schema.models.secret.get).label('List of secrets');
 const pipelineIdSchema = schema.models.pipeline.base.extract('id');
 
 module.exports = () => ({

package/plugins/pipelines/listStages.js

@@ -4,10 +4,7 @@ const boom = require('@hapi/boom');
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
 const pipelineIdSchema = schema.models.pipeline.base.extract('id');
-const stageListSchema = joi
-    .array()
-    .items(schema.models.stage.base)
-    .label('List of stages');
+const stageListSchema = joi.array().items(schema.models.stage.base).label('List of stages');
 
 module.exports = () => ({
     method: 'GET',

package/plugins/pipelines/metrics.js

@@ -10,15 +10,9 @@ const DOWNTIME_STATUSES_KEY = 'downtimeStatuses[]';
 const pipelineIdSchema = schema.models.pipeline.base.extract('id');
 const pipelineMetricListSchema = joi.array().items(joi.object());
 const jobIdSchema = joi.string().regex(/^[0-9]+$/);
-const jobIdsSchema = joi
-    .alternatives()
-    .try(joi.array().items(jobIdSchema), jobIdSchema)
-    .required();
+const jobIdsSchema = joi.alternatives().try(joi.array().items(jobIdSchema), jobIdSchema).required();
 const statusSchema = schema.models.build.base.extract('status');
-const statusesSchema = joi
-    .alternatives()
-    .try(joi.array().items(statusSchema), statusSchema)
-    .required();
+const statusesSchema = joi.alternatives().try(joi.array().items(statusSchema), statusSchema).required();
 
 module.exports = () => ({
     method: 'GET',

package/plugins/pipelines/tokens/create.js

@@ -69,10 +69,7 @@ module.exports = () => ({
                 pathname: `${request.path}/${token.id}`
             });
 
-            return h
-                .response(token.toJson())
-                .header('Location', location)
-                .code(201);
+            return h.response(token.toJson()).header('Location', location).code(201);
         },
         validate: {
             params: joi.object({

package/plugins/secrets/create.js

@@ -72,10 +72,7 @@ module.exports = () => ({
 
             delete output.value;
 
-            return h
-                .response(output)
-                .header('Location', location)
-                .code(201);
+            return h.response(output).header('Location', location).code(201);
         },
         validate: {
             payload: schema.models.secret.create

package/plugins/templates/create.js

@@ -69,10 +69,7 @@ module.exports = () => ({
                         pathname: `${request.path}/${template.id}`
                     });
 
-                    return h
-                        .response(template.toJson())
-                        .header('Location', location)
-                        .code(201);
+                    return h.response(template.toJson()).header('Location', location).code(201);
                 })
                 .catch(err => {
                     throw err;

package/plugins/templates/createTag.js

@@ -60,10 +60,7 @@ module.exports = () => ({
                             pathname: `${request.path}/${newTag.id}`
                         });
 
-                        return h
-                            .response(newTag.toJson())
-                            .header('Location', location)
-                            .code(201);
+                        return h.response(newTag.toJson()).header('Location', location).code(201);
                     });
                 })
                 .catch(err => {

package/plugins/templates/list.js

@@ -2,10 +2,7 @@
 
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const listSchema = joi
-    .array()
-    .items(schema.models.template.get)
-    .label('List of templates');
+const listSchema = joi.array().items(schema.models.template.get).label('List of templates');
 const listCountSchema = joi
     .object()
     .keys({
@@ -17,10 +14,7 @@ const distinctSchema = joi
     .string()
     .valid(...Object.keys(schema.models.template.fields))
     .label('Field to return unique results by');
-const compactSchema = joi
-    .string()
-    .valid('', 'false', 'true')
-    .label('Flag to return compact data');
+const compactSchema = joi.string().valid('', 'false', 'true').label('Flag to return compact data');
 const namespaceSchema = schema.models.template.base.extract('namespace');
 const namespacesSchema = joi.array().items(joi.object().keys({ namespace: namespaceSchema }));
 

package/plugins/templates/listTags.js

@@ -2,10 +2,7 @@
 
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const listSchema = joi
-    .array()
-    .items(schema.models.templateTag.base)
-    .label('List of templates');
+const listSchema = joi.array().items(schema.models.templateTag.base).label('List of templates');
 const nameSchema = schema.models.templateTag.base.extract('name');
 
 module.exports = () => ({

package/plugins/templates/listVersions.js

@@ -3,10 +3,7 @@
 const boom = require('@hapi/boom');
 const joi = require('joi');
 const schema = require('screwdriver-data-schema');
-const listSchema = joi
-    .array()
-    .items(schema.models.template.get)
-    .label('List of templates');
+const listSchema = joi.array().items(schema.models.template.get).label('List of templates');
 const nameSchema = schema.models.template.base.extract('name');
 
 module.exports = () => ({

package/plugins/tokens/create.js

@@ -53,10 +53,7 @@ module.exports = () => ({
                             pathname: `${request.path}/${token.id}`
                         });
 
-                        return h
-                            .response(token.toJson())
-                            .header('Location', location)
-                            .code(201);
+                        return h.response(token.toJson()).header('Location', location).code(201);
                     })
                     // something broke, respond with error
                     .catch(err => {

package/plugins/versions.js

@@ -35,10 +35,7 @@ const versionsTemplate = {
                 }
                 const depArray = Object.keys(json).map(key => ({ name: key, ...json[key] }));
                 const depDisplay = depArray.map(dep => ({
-                    name: dep.name
-                        .split('@')
-                        .slice(0, -1)
-                        .join('@'),
+                    name: dep.name.split('@').slice(0, -1).join('@'),
                     repository: dep.repository || 'UNKNOWN',
                     licenses: dep.licenses || 'UNKNOWN'
                 }));

package/plugins/webhooks/helper.js

@@ -22,7 +22,7 @@ function isReleaseOrTagFilteringEnabled(action, workflowGraph) {
     let isFilteringEnabled = true;
 
     workflowGraph.edges.forEach(edge => {
-        const releaseOrTagRegExp = action === 'release' ? new RegExp('^~(release)$') : new RegExp('^~(tag)$');
+        const releaseOrTagRegExp = action === 'release' ? /^~(release)$/ : /^~(tag)$/;
 
         if (edge.src.match(releaseOrTagRegExp)) {
             isFilteringEnabled = false;

package/plugins/webhooks/index.js

@@ -29,19 +29,10 @@ const webhooksPlugin = {
             options,
             joi.object().keys({
                 username: joi.string().required(),
-                ignoreCommitsBy: joi
-                    .array()
-                    .items(joi.string())
-                    .optional(),
-                restrictPR: joi
-                    .string()
-                    .valid('all', 'none', 'branch', 'fork')
-                    .optional(),
+                ignoreCommitsBy: joi.array().items(joi.string()).optional(),
+                restrictPR: joi.string().valid('all', 'none', 'branch', 'fork').optional(),
                 chainPR: joi.boolean().optional(),
-                maxBytes: joi
-                    .number()
-                    .integer()
-                    .optional()
+                maxBytes: joi.number().integer().optional()
             }),
             'Invalid config for plugin-webhooks'
         );