screwdriver-api 4.1.281 → 4.1.284

package/lib/server.js

@@ -141,9 +141,7 @@ module.exports = async config => {
             ecosystem: config.ecosystem,
             release: config.release,
             queueWebhook: config.queueWebhook,
-            feature: {
-                unzipArtifacts: config.unzipArtifactsEnabled
-            }
+            unzipArtifacts: config.unzipArtifactsEnabled
         };
 
         const bellConfigs = await config.auth.scm.getBellConfiguration();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "screwdriver-api",
-  "version": "4.1.281",
+  "version": "4.1.284",
   "description": "API server for the Screwdriver.cd service",
   "main": "index.js",
   "scripts": {

package/plugins/builds/artifacts/unzip.js

@@ -18,7 +18,7 @@ module.exports = config => ({
         },
 
         handler: async (req, h) => {
-            if (!req.server.app.feature.unzipArtifacts) {
+            if (!req.server.app.unzipArtifacts) {
                 const data = {
                     statusCode: 200,
                     message: "This function is not enabled and will do nothing."

package/plugins/pipelines/startAll.js

@@ -41,7 +41,7 @@ module.exports = () => ({
                 }
             });
 
-            await Promise.all(
+            const createEvents = await Promise.allSettled(
                 pipelines.map(async p => {
                     const pipelineToken = await p.token;
                     const pipelineScmContext = p.scmContext;
@@ -51,6 +51,8 @@ module.exports = () => ({
                         token: pipelineToken
                     });
 
+                    await getUserPermissions({ user, scmUri: p.scmUri, level: 'push' });
+
                     await eventFactory.create({
                         pipelineId: p.id,
                         sha,
@@ -62,6 +64,12 @@ module.exports = () => ({
                 })
             );
 
+            const rejected = createEvents.filter(createEvent => createEvent.status === 'rejected');
+
+            if (rejected.length) {
+                throw boom.forbidden('Failed to start some child pipelines due to lack of permissions.');
+            }
+
             return h.response().code(201);
         },
         validate: {