screwdriver-api 4.1.194 → 4.1.195

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "screwdriver-api",
-  "version": "4.1.194",
+  "version": "4.1.195",
   "description": "API server for the Screwdriver.cd service",
   "main": "index.js",
   "scripts": {

package/plugins/webhooks/helper.js

@@ -347,6 +347,47 @@ async function triggeredPipelines(
     return currentRepoPipelines.concat(pipelinesWithSubscribedRepos);
 }
 
+/**
+ * Start Events
+ * @async  startEvents
+ * @param  {Array}  eventConfigs Array of event config objects
+ * @param  {Object} eventFactory Factory to create events
+ * @return {Promise<Array>}  Array of created events
+ */
+async function startEvents(eventConfigs, eventFactory) {
+    const events = [];
+    let errorCount = 0;
+    let eventsCount = 0;
+
+    const results = await Promise.allSettled(
+        eventConfigs.map(eventConfig => {
+            if (eventConfig && eventConfig.configPipelineSha) {
+                eventsCount += 1;
+
+                return eventFactory.create(eventConfig);
+            }
+
+            return Promise.resolve(null);
+        })
+    );
+
+    results.forEach((result, i) => {
+        if (result.status === 'fulfilled') {
+            if (result.value) events.push(result.value);
+        } else {
+            errorCount += 1;
+            logger.error(`pipeline:${eventConfigs[i].pipelineId} error in starting event`, result.value);
+        }
+    });
+
+    if (errorCount && errorCount === eventsCount) {
+        // preserve current behavior of returning 500 on error
+        throw new Error('Failed to start any events');
+    }
+
+    return events;
+}
+
 /**
  * Create events for each pipeline
  * @async  createPREvents
@@ -388,7 +429,6 @@ async function createPREvents(options, request) {
     const { eventFactory, pipelineFactory, userFactory } = request.server.app;
     const scmDisplayName = scm.getDisplayName({ scmContext: scmConfig.scmContext });
     const userDisplayName = `${scmDisplayName}:${username}`;
-    const events = [];
     let { sha } = options;
 
     scmConfig.prNum = prNum;
@@ -509,13 +549,9 @@ async function createPREvents(options, request) {
         })
     );
 
-    eventConfigs.forEach(eventConfig => {
-        if (eventConfig && eventConfig.configPipelineSha) {
-            events.push(eventFactory.create(eventConfig));
-        }
-    });
+    const events = await startEvents(eventConfigs, eventFactory);
 
-    return Promise.all(events);
+    return events;
 }
 
 /**
@@ -851,7 +887,6 @@ async function createEvents(
     scmConfigFromHook
 ) {
     const { action, branch, sha, username, scmContext, changedFiles, type, releaseName, ref } = parsed;
-    const events = [];
     const meta = createMeta(parsed);
 
     const pipelineTuples = await Promise.all(
@@ -991,13 +1026,9 @@ async function createEvents(
         })
     );
 
-    eventConfigs.forEach(eventConfig => {
-        if (eventConfig && eventConfig.configPipelineSha) {
-            events.push(eventFactory.create(eventConfig));
-        }
-    });
+    const events = await startEvents(eventConfigs, eventFactory);
 
-    return Promise.all(events);
+    return events;
 }
 
 /**