screwdriver-api 4.1.191 → 4.1.195

package/bin/server

@@ -50,6 +50,9 @@ const notificationConfig = config.get('notifications');
 // Multiple build cluster feature flag
 const multiBuildClusterEnabled = convertToBool(config.get('multiBuildCluster').enabled);
 
+// Unzip artifacts feature flag
+const unzipArtifactsEnabled = convertToBool(config.get('unzipArtifacts').enabled);
+
 // Queue Webhook feature flag
 const queueWebhookEnabled = convertToBool(config.get('queueWebhook').enabled);
 
@@ -261,7 +264,8 @@ datastore.setup(datastoreConfig.ddlSyncEnabled).then(() =>
         queueWebhook: {
             executor,
             queueWebhookEnabled
-        }
+        },
+        unzipArtifactsEnabled
     })
         .then(instance => logger.info('Server running at %s', instance.info.uri))
         .catch(err => {

package/config/custom-environment-variables.yaml

@@ -385,6 +385,10 @@ multiBuildCluster:
   # Enabled multi build cluster feature or not
   enabled: MULTI_BUILD_CLUSTER_ENABLED
 
+unzipArtifacts:
+  # Enabled unzip artifacts feature or not
+  enabled: UNZIP_ARTIFACTS_ENABLED
+
 ecosystem:
   # URL for the User Interface
   ui: ECOSYSTEM_UI

package/config/default.yaml

@@ -272,6 +272,10 @@ multiBuildCluster:
   # Enabled multi build cluster feature or not
   enabled: false
 
+unzipArtifacts:
+  # Enabled unzip artifacts feature or not
+  enabled: false
+
 bookends:
   # Plugins for build setup
   setup:

package/lib/server.js

@@ -79,6 +79,7 @@ function prettyPrintErrors(request, h) {
  * @param  {Object}      config.builds.ecosystem    List of hosts in the ecosystem
  * @param  {Object}      config.builds.authConfig   Configuration for auth
  * @param  {Object}      config.builds.externalJoin Flag to allow external join
+ * @param  {Object}      config.unzipArtifactsEnabled  Flag to allow unzip artifacts
  * @param  {Function}    callback                   Callback to invoke when server has started.
  * @return {http.Server}                            A listener: NodeJS http.Server object
  */
@@ -137,7 +138,10 @@ module.exports = async config => {
             buildClusterFactory: config.buildClusterFactory,
             ecosystem: config.ecosystem,
             release: config.release,
-            queueWebhook: config.queueWebhook
+            queueWebhook: config.queueWebhook,
+            feature: {
+                unzipArtifacts: config.unzipArtifactsEnabled
+            }
         };
 
         const bellConfigs = await config.auth.scm.getBellConfiguration();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "screwdriver-api",
-  "version": "4.1.191",
+  "version": "4.1.195",
   "description": "API server for the Screwdriver.cd service",
   "main": "index.js",
   "scripts": {

package/plugins/builds/artifacts/unzip.js

@@ -18,6 +18,13 @@ module.exports = config => ({
         },
 
         handler: async (req, h) => {
+            if (!req.server.app.feature.unzipArtifacts) {
+                const data = {
+                    statusCode: 200,
+                    message: "This function is not enabled and will do nothing."
+                }
+                return h.response(data).code(200);
+            }
             const buildId = req.params.id;
             const { username, scope } = req.auth.credentials;
             const isBuild = scope.includes('build');

package/plugins/webhooks/helper.js

@@ -347,6 +347,47 @@ async function triggeredPipelines(
     return currentRepoPipelines.concat(pipelinesWithSubscribedRepos);
 }
 
+/**
+ * Start Events
+ * @async  startEvents
+ * @param  {Array}  eventConfigs Array of event config objects
+ * @param  {Object} eventFactory Factory to create events
+ * @return {Promise<Array>}  Array of created events
+ */
+async function startEvents(eventConfigs, eventFactory) {
+    const events = [];
+    let errorCount = 0;
+    let eventsCount = 0;
+
+    const results = await Promise.allSettled(
+        eventConfigs.map(eventConfig => {
+            if (eventConfig && eventConfig.configPipelineSha) {
+                eventsCount += 1;
+
+                return eventFactory.create(eventConfig);
+            }
+
+            return Promise.resolve(null);
+        })
+    );
+
+    results.forEach((result, i) => {
+        if (result.status === 'fulfilled') {
+            if (result.value) events.push(result.value);
+        } else {
+            errorCount += 1;
+            logger.error(`pipeline:${eventConfigs[i].pipelineId} error in starting event`, result.value);
+        }
+    });
+
+    if (errorCount && errorCount === eventsCount) {
+        // preserve current behavior of returning 500 on error
+        throw new Error('Failed to start any events');
+    }
+
+    return events;
+}
+
 /**
  * Create events for each pipeline
  * @async  createPREvents
@@ -388,7 +429,6 @@ async function createPREvents(options, request) {
     const { eventFactory, pipelineFactory, userFactory } = request.server.app;
     const scmDisplayName = scm.getDisplayName({ scmContext: scmConfig.scmContext });
     const userDisplayName = `${scmDisplayName}:${username}`;
-    const events = [];
     let { sha } = options;
 
     scmConfig.prNum = prNum;
@@ -509,13 +549,9 @@ async function createPREvents(options, request) {
         })
     );
 
-    eventConfigs.forEach(eventConfig => {
-        if (eventConfig && eventConfig.configPipelineSha) {
-            events.push(eventFactory.create(eventConfig));
-        }
-    });
+    const events = await startEvents(eventConfigs, eventFactory);
 
-    return Promise.all(events);
+    return events;
 }
 
 /**
@@ -851,7 +887,6 @@ async function createEvents(
     scmConfigFromHook
 ) {
     const { action, branch, sha, username, scmContext, changedFiles, type, releaseName, ref } = parsed;
-    const events = [];
     const meta = createMeta(parsed);
 
     const pipelineTuples = await Promise.all(
@@ -991,13 +1026,9 @@ async function createEvents(
         })
     );
 
-    eventConfigs.forEach(eventConfig => {
-        if (eventConfig && eventConfig.configPipelineSha) {
-            events.push(eventFactory.create(eventConfig));
-        }
-    });
+    const events = await startEvents(eventConfigs, eventFactory);
 
-    return Promise.all(events);
+    return events;
 }
 
 /**