screwdriver-api 4.1.188 → 4.1.192

package/bin/server

@@ -50,6 +50,9 @@ const notificationConfig = config.get('notifications');
 // Multiple build cluster feature flag
 const multiBuildClusterEnabled = convertToBool(config.get('multiBuildCluster').enabled);
 
+// Unzip artifacts feature flag
+const unzipArtifactsEnabled = convertToBool(config.get('unzipArtifacts').enabled);
+
 // Queue Webhook feature flag
 const queueWebhookEnabled = convertToBool(config.get('queueWebhook').enabled);
 
@@ -261,7 +264,8 @@ datastore.setup(datastoreConfig.ddlSyncEnabled).then(() =>
         queueWebhook: {
             executor,
             queueWebhookEnabled
-        }
+        },
+        unzipArtifactsEnabled
     })
         .then(instance => logger.info('Server running at %s', instance.info.uri))
         .catch(err => {

package/config/custom-environment-variables.yaml

@@ -385,6 +385,10 @@ multiBuildCluster:
   # Enabled multi build cluster feature or not
   enabled: MULTI_BUILD_CLUSTER_ENABLED
 
+unzipArtifacts:
+  # Enabled unzip artifacts feature or not
+  enabled: UNZIP_ARTIFACTS_ENABLED
+
 ecosystem:
   # URL for the User Interface
   ui: ECOSYSTEM_UI

package/config/default.yaml

@@ -272,6 +272,10 @@ multiBuildCluster:
   # Enabled multi build cluster feature or not
   enabled: false
 
+unzipArtifacts:
+  # Enabled unzip artifacts feature or not
+  enabled: false
+
 bookends:
   # Plugins for build setup
   setup:

package/lib/server.js

@@ -79,6 +79,7 @@ function prettyPrintErrors(request, h) {
  * @param  {Object}      config.builds.ecosystem    List of hosts in the ecosystem
  * @param  {Object}      config.builds.authConfig   Configuration for auth
  * @param  {Object}      config.builds.externalJoin Flag to allow external join
+ * @param  {Object}      config.unzipArtifactsEnabled  Flag to allow unzip artifacts
  * @param  {Function}    callback                   Callback to invoke when server has started.
  * @return {http.Server}                            A listener: NodeJS http.Server object
  */
@@ -137,7 +138,10 @@ module.exports = async config => {
             buildClusterFactory: config.buildClusterFactory,
             ecosystem: config.ecosystem,
             release: config.release,
-            queueWebhook: config.queueWebhook
+            queueWebhook: config.queueWebhook,
+            feature: {
+                unzipArtifacts: config.unzipArtifactsEnabled
+            }
         };
 
         const bellConfigs = await config.auth.scm.getBellConfiguration();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "screwdriver-api",
-  "version": "4.1.188",
+  "version": "4.1.192",
   "description": "API server for the Screwdriver.cd service",
   "main": "index.js",
   "scripts": {
@@ -123,7 +123,7 @@
     "screwdriver-scm-gitlab": "^2.7.2",
     "screwdriver-scm-router": "^6.3.0",
     "screwdriver-template-validator": "^5.2.0",
-    "screwdriver-workflow-parser": "^3.2.0",
+    "screwdriver-workflow-parser": "^3.2.1",
     "sqlite3": "^5.0.1",
     "stream": "0.0.2",
     "tinytim": "^0.1.1",

package/plugins/builds/artifacts/unzip.js

@@ -18,6 +18,13 @@ module.exports = config => ({
         },
 
         handler: async (req, h) => {
+            if (!req.server.app.feature.unzipArtifacts) {
+                const data = {
+                    statusCode: 200,
+                    message: "This function is not enabled and will do nothing."
+                }
+                return h.response(data).code(200);
+            }
             const buildId = req.params.id;
             const { username, scope } = req.auth.credentials;
             const isBuild = scope.includes('build');

package/plugins/builds/index.js

@@ -410,6 +410,11 @@ function parseJobInfo({ joinObj = {}, current, nextJobName, nextPipelineId }) {
  * @return {Promise}                            All finished builds
  */
 async function getFinishedBuilds(event, buildFactory) {
+    if (!event.parentEventId) {
+        // FIXME: remove this flow to always use buildFactory.getLatestBuilds
+        return event.getBuilds();
+    }
+
     // FIXME: buildFactory.getLatestBuilds doesn't return build model
     const builds = await buildFactory.getLatestBuilds({ groupEventId: event.groupEventId });