scratch-l10n 4.0.0 → 4.0.2

package/CHANGELOG.md

@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file. See
 [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.0.2](https://github.com/scratchfoundation/scratch-l10n/compare/v4.0.1...v4.0.2) (2024-10-30)
+
+
+### Bug Fixes
+
+* stop trying to assign an array to process.exitCode ([a4b1680](https://github.com/scratchfoundation/scratch-l10n/commit/a4b16805f4b601204415f731ca8397fb9027201e))
+
+## [4.0.1](https://github.com/scratchfoundation/scratch-l10n/compare/v4.0.0...v4.0.1) (2024-10-30)
+
+
+### Bug Fixes
+
+* require is not allowed in mjs files ([fb47cd2](https://github.com/scratchfoundation/scratch-l10n/commit/fb47cd2c566ad4020953bd88d754eceb6b120a8f))
+
 # [4.0.0](https://github.com/scratchfoundation/scratch-l10n/compare/v3.18.357...v4.0.0) (2024-10-30)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "scratch-l10n",
-  "version": "4.0.0",
+  "version": "4.0.2",
   "description": "Localization for the Scratch 3.0 components",
   "main": "./dist/l10n.js",
   "browser": "./src/index.mjs",

package/scripts/tx-push-help.mjs

@@ -5,8 +5,9 @@
  * Script get Knowledge base articles from Freshdesk and push them to transifex.
  */
 
+import {txPush, txCreateResource} from '../lib/transifex.js';
+
 const args = process.argv.slice(2);
-const {txPush, txCreateResource} = require('../lib/transifex.js');
 
 const usage = `
  Pull knowledge base articles from Freshdesk and push to scratch-help project on transifex. Usage:
@@ -71,22 +72,27 @@ const txPushResource = async (name, articles, type) => {
 };
 
 /**
- * get a flattened list of folders
- * @param  {category}  categories array of categories the folders belong to
- * @return {Promise}            flattened list of folders
+ * get a flattened list of folders associated with the specified categories
+ * @param  {object[]} categories array of categories the folders belong to
+ * @return {Promise<object[]>} flattened list of folders from all requested categories
  */
 const getFolders = async (categories) => {
-    let categoryFolders = await Promise.all( // eslint-disable-line no-undef
+    const categoryFolders = await Promise.all(
         categories.map(category => FD.listFolders(category))
     );
     return [].concat(...categoryFolders);
 };
 
 const PUBLISHED = 2; // in Freshdesk, draft status = 1, and published = 2
-const saveArticles = (folder) => {
-    FD.listArticles(folder)
+
+/**
+ * Save articles in a particular folder
+ * @param {object} folder The folder object
+ */
+const saveArticles = async folder => {
+    await FD.listArticles(folder)
         .then(json => {
-            let txArticles = json.reduce((strings, current) => {
+            const txArticles = json.reduce((strings, current) => {
                 if (current.status === PUBLISHED) {
                     strings[`${current.id}`] = {
                         title: {
@@ -106,13 +112,16 @@ const saveArticles = (folder) => {
             txPushResource(`${makeTxId(folder)}_json`, txArticles, 'STRUCTURED_JSON');
         });
 };
-const getArticles = async (folders) => {
-    return Promise.all(folders.map(folder => saveArticles(folder))); // eslint-disable-line no-undef
+
+/**
+ * @param {object[]} folders Array of folders containing articles to be saved
+ */
+const saveArticleFolders = async (folders) => {
+    await Promise.all(folders.map(folder => saveArticles(folder)));
 };
 
 const syncSources = async () => {
-    let status = 0;
-    status = await FD.listCategories()
+    await FD.listCategories()
         .then(json => {
             // save category names for translation
             for (let cat of json.values()) {
@@ -130,12 +139,7 @@ const syncSources = async () => {
             txPushResource('folderNames_json', folderNames, 'KEYVALUEJSON');
             return data;
         })
-        .then(getArticles)
-        .catch((e) => {
-            process.stdout.write(`Error:${e.message}\n`);
-            return 1;
-        });
-    process.exitCode = status;
+        .then(saveArticleFolders);
 };
 
 syncSources();