scoutline 0.24.0 → 0.24.1

package/dist/index.js

@@ -17,7 +17,7 @@ import { CONFIG_HELP, configGetCommand, configSetCommand, configUnsetCommand, }
 import { usageCommand, USAGE_HELP, DEFAULT_USAGE_WINDOW_DAYS, MAX_USAGE_WINDOW_DAYS, } from "./commands/usage.js";
 import { historyCommand, historyClearCommand, historyRecallCommand, historyExportCommand, HISTORY_HELP, HISTORY_NOTE_HELP, HISTORY_RECALL_HELP, HISTORY_CLEAR_HELP, HISTORY_EXPORT_HELP, } from "./commands/history.js";
 import { handleFetch } from "./commands/fetch.js";
-import { handleArchive, parseArchiveArgs } from "./commands/archive.js";
+import { handleArchive, parseArchiveTokens } from "./commands/archive.js";
 import { handleWatch } from "./commands/watch.js";
 import { handleScience } from "./commands/science.js";
 import { investigate, INVESTIGATE_HELP, } from "./commands/investigate.js";
@@ -36,6 +36,7 @@ import { buildJournalRepeatMarker } from "./lib/journal.js";
 import { applyBudget } from "./lib/output-budget.js";
 import { persistCompaction } from "./lib/output-budget-persistence.js";
 import { ApiError, FileError, ValidationError, UnsupportedCapabilityError, CommandOptionUnsupportedError, getErrorExitCode, } from "./lib/errors.js";
+import { normalizeEqualsFormFlags } from "./lib/equals-form.js";
 import * as os from "node:os";
 import * as path from "node:path";
 import * as fs from "node:fs/promises";
@@ -245,6 +246,8 @@ export function rejectFlagPair(flags, name, makeError) {
         throw makeError();
     }
 }
+// #263: re-exported for the parser-level tests.
+export { normalizeEqualsFormFlags };
 /**
  * Collect every occurrence of a long `--<name>` flag in argv order,
  * mirroring parseArgs' value-consumption rule (the next argument is the
@@ -3642,13 +3645,10 @@ async function handleInvestigate(args, outputMode, deps) {
     if (flags.verify !== undefined && flags.context !== undefined) {
         throw new ValidationError("--verify and --context cannot be combined: --verify splits the statement into claims (verify owns planning).", "Drop --context, or run without --verify to plan from the notes file.");
     }
-    // Valueless/malformed --verify guards (the --synthesize pattern):
-    // parseArgs would swallow a following token as the value.
-    for (const token of args) {
-        if (typeof token === "string" && token.startsWith("--verify=")) {
-            throw new ValidationError(`Invalid flag "${token}": the --flag=value form is not supported; --verify takes no value.`, "Pass the bare --verify to enable claim-corroboration mode, or omit it.");
-        }
-    }
+    // Valueless --verify guard: parseArgs would swallow a following
+    // token as the value. (The `--verify=` equals-form check is GONE:
+    // #263 normalizes `--verify=foo` to `--verify foo` upstream, and this
+    // existing boolean guard rejects it with the same error.)
     if (flags.verify !== undefined && flags.verify !== true) {
         throw new ValidationError("--verify is a boolean flag and takes no value", "Pass the bare --verify to enable claim-corroboration mode, or omit it.");
     }
@@ -3662,15 +3662,9 @@ async function handleInvestigate(args, outputMode, deps) {
     rejectFlagPair(flags, "arms", () => new ValidationError("investigate has no --arms flag; the arm set IS the provider pin.", "Use --provider <tavily,exa|all> to fan out, or a single --provider id for one arm."));
     rejectFlagPair(flags, "budget-tokens", () => new ValidationError("investigate has no --budget-tokens flag; --max-chars is the budget.", "Use --max-chars <n> (characters, not tokens)."));
     // T7 (PRD AC-7): --synthesize is VALUELESS. parseArgs assigns the
-    // next non-dash token as a flag value, so `--synthesize foo` would
-    // swallow the value; the =-form parses as a garbage key and is
-    // silently dropped (#172 review F6). Both reject here, before the
+    // next non-dash token as a flag value, so `--synthesize foo` (and the
+    // #263-normalized `--synthesize=foo`) rejects here, before the
     // help-gate, like every other malformed-flag guard in this handler.
-    for (const token of args) {
-        if (typeof token === "string" && token.startsWith("--synthesize=")) {
-            throw new ValidationError(`Invalid flag "${token}": the --flag=value form is not supported; --synthesize takes no value.`, "Pass the bare --synthesize to enable it, or omit it.");
-        }
-    }
     if (flags.synthesize !== undefined && flags.synthesize !== true) {
         throw new ValidationError("--synthesize is a boolean flag and takes no value", "Pass the bare --synthesize to enable it, or omit it.");
     }
@@ -4456,12 +4450,20 @@ export async function main(args, dependencies) {
     // envelope in the output mode the argv requested (re-derived from the
     // raw argv via `bestEffortOutputMode` because the partially parsed
     // result never escapes the throw) and the error's exit code.
+    // #263: central `--flag=value` ≡ `--flag value` normalization. Runs
+    // before EVERY argv consumer below (extractGlobalOptions, the
+    // strict-flag gate, help/version checks, command handlers' parseArgs)
+    // so all token walks observe space-form tokens only. Pure and
+    // total-length-preserving plus at most the split tokens; the only
+    // behavior change is where a `--flag=value` used to be a garbage
+    // boolean key.
+    const normalizedArgs = normalizeEqualsFormFlags(args);
     let extracted;
     try {
-        extracted = extractGlobalOptions([...args]);
+        extracted = extractGlobalOptions(normalizedArgs);
     }
     catch (error) {
-        invocation.writeStderr(formatErrorOutput(error, bestEffortOutputMode(args, invocation), envSecrets));
+        invocation.writeStderr(formatErrorOutput(error, bestEffortOutputMode(normalizedArgs, invocation), envSecrets));
         return getErrorExitCode(error);
     }
     const { outputFormat, forcePretty, forceRaw, provider, noFallback, isolated, rest } = extracted;
@@ -4943,7 +4945,7 @@ export async function main(args, dependencies) {
             // the human table was never the flag's contract.
             // Determine the subcommand through the parser (not positional
             // assumption): options may precede `get`/`cdx`.
-            const archiveSubcommand = parseArchiveArgs(commandArgs).subcommand;
+            const archiveSubcommand = parseArchiveTokens(commandArgs).subcommand;
             const archiveOutputMode = forceRaw && outputFormat === undefined && archiveSubcommand === "get"
                 ? "compact"
                 : outputMode;