scorm-again 3.0.4 → 3.0.5

package/README.md

@@ -1,3 +1,22 @@
+# scorm-again
+
+A modern, fully-tested JavaScript runtime for SCORM 1.2 and SCORM 2004.
+
+---
+<details>
+<summary><b>Audits & consulting →</b></summary>
+
+I do one-week, fixed-price code audits for B2B SaaS companies on AWS:
+
+- Multi-Tenant SaaS on AWS: architecture, cost, and SOC 2 alignment
+- AI-on-AWS for Regulated SaaS: Bedrock, RAG, and guardrails under SOC 2, HIPAA, or 21 CFR Part 11
+
+Fixed price, written report, walkthrough call. Details at [audits.putney.io](https://audits.putney.io).
+
+</details>
+
+---
+
 [![Github Actions](https://img.shields.io/github/actions/workflow/status/jcputney/scorm-again/main.yml?style=for-the-badge "Build Status")](https://github.com/jcputney/scorm-again/actions)
 [![Codecov](https://img.shields.io/codecov/c/github/jcputney/scorm-again?style=for-the-badge "Code Coverage")](https://codecov.io/gh/jcputney/scorm-again)
 ![jsDelivr hits (npm)](https://img.shields.io/jsdelivr/npm/hy/scorm-again?style=for-the-badge&label=jsDelivr%20Downloads)
@@ -7,10 +26,6 @@
 ![GitHub License](https://img.shields.io/github/license/jcputney/scorm-again?style=for-the-badge)
 [![donate](https://img.shields.io/badge/paypal-donate-success?style=for-the-badge)](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=NF5MPZJAV26LE)
 
-# scorm-again
-
-A modern, fully-tested JavaScript runtime for SCORM 1.2 and SCORM 2004.
-
 > **Upgrading from v2.x?** See the [Migration Guide](MIGRATION.md) for breaking changes and migration steps.
 
 ## Overview

package/dist/esm/scorm-again.js

@@ -1160,6 +1160,11 @@ const scorm2004_regex = {
   progress_range: "0#1"
 };
 
+const PERFORMANCE_STEP_NAME = "^$|" + scorm2004_regex.CMIShortIdentifier;
+const PERFORMANCE_CHARACTERSTRING = "(?![\\s\\S]*(?:\\[,\\]|\\[\\.\\]|\\[:\\]))[\\s\\S]{1,250}";
+const PERFORMANCE_NUMERIC_RANGE = "(?:-?\\d+(?:\\.\\d+)?)?\\[:\\](?:-?\\d+(?:\\.\\d+)?)?";
+const CR_PERFORMANCE_STEP_ANSWER = "^(?:|" + PERFORMANCE_NUMERIC_RANGE + "|" + PERFORMANCE_CHARACTERSTRING + ")$";
+const LR_PERFORMANCE_STEP_ANSWER = "^(?:|" + PERFORMANCE_CHARACTERSTRING + ")$";
 const LearnerResponses = {
   "true-false": {
     format: "^true$|^false$",
@@ -1194,8 +1199,8 @@ const LearnerResponses = {
     unique: false
   },
   performance: {
-    format: "^$|" + scorm2004_regex.CMIShortIdentifier,
-    format2: scorm2004_regex.CMIDecimal + "|^$|" + scorm2004_regex.CMIShortIdentifier,
+    format: PERFORMANCE_STEP_NAME,
+    format2: LR_PERFORMANCE_STEP_ANSWER,
     max: 250,
     delimiter: "[,]",
     delimiter2: "[.]",
@@ -1271,10 +1276,10 @@ const CorrectResponses = {
     delimiter2: "[.]",
     unique: false,
     duplicate: false,
-    // step_name must be a non-empty short identifier
-    format: scorm2004_regex.CMIShortIdentifier,
-    // step_answer may be short identifier or numeric range (<decimal>[:<decimal>])
-    format2: `^(${scorm2004_regex.CMIShortIdentifier})$|^(?:\\d+(?:\\.\\d+)?(?::\\d+(?:\\.\\d+)?)?)$`
+    // step_name: optional short_identifier_type
+    format: PERFORMANCE_STEP_NAME,
+    // step_answer: optional characterstring (spaces allowed) or numeric range
+    format2: CR_PERFORMANCE_STEP_ANSWER
   },
   sequencing: {
     max: 36,
@@ -5583,7 +5588,19 @@ class CMIValueAccessService {
     if (!scorm2004) {
       if (isFinalAttribute) {
         if (typeof attribute === "undefined" || !this.context.checkObjectHasProperty(refObject, attribute)) {
-          this.context.throwSCORMError(CMIElement, invalidErrorCode, invalidErrorMessage);
+          if (attribute === "_children") {
+            this.context.throwSCORMError(
+              CMIElement,
+              getErrorCode(this.context.errorCodes, "CHILDREN_ERROR")
+            );
+          } else if (attribute === "_count") {
+            this.context.throwSCORMError(
+              CMIElement,
+              getErrorCode(this.context.errorCodes, "COUNT_ERROR")
+            );
+          } else {
+            this.context.throwSCORMError(CMIElement, invalidErrorCode, invalidErrorMessage);
+          }
           return { error: true };
         }
       }
@@ -15987,7 +16004,8 @@ class BaseAPI {
       if (errorCode === 143) returnValue = global_constants.SCORM_FALSE;
     } else {
       const result = this.storeData(false);
-      if ((result.errorCode ?? 0) > 0) {
+      const errorCode = result.errorCode ?? 0;
+      if (errorCode > 0) {
         if (result.errorMessage) {
           this.apiLog(
             "commit",
@@ -16002,12 +16020,12 @@ class BaseAPI {
             LogLevelEnum.DEBUG
           );
         }
-        this.throwSCORMError("api", result.errorCode);
+        this.throwSCORMError("api", errorCode);
       }
       const resultValue = result?.result ?? global_constants.SCORM_FALSE;
       returnValue = typeof resultValue === "boolean" ? String(resultValue) : resultValue;
       this.apiLog(callbackName, " Result: " + returnValue, LogLevelEnum.DEBUG, "HttpRequest");
-      if (checkTerminated) this.lastErrorCode = "0";
+      if (checkTerminated && errorCode === 0) this.lastErrorCode = "0";
       this.processListeners(callbackName);
       if (this.settings.enableOfflineSupport && this._offlineStorageService && this._offlineStorageService.isDeviceOnline() && this._courseId) {
         this._offlineStorageService.hasPendingOfflineData(this._courseId).then((hasPendingData) => {
@@ -18930,6 +18948,49 @@ class CMILearnerPreference extends BaseCMI {
   }
 }
 
+function stripBrackets(delim) {
+  return delim.replace(/[[\]]/g, "");
+}
+function escapeRegex(s) {
+  return s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+}
+function splitDelimited(value, bracketed) {
+  if (!bracketed) {
+    return [value];
+  }
+  if (value.includes(bracketed)) {
+    return value.split(bracketed);
+  }
+  const bare = stripBrackets(bracketed);
+  if (!bare) {
+    return [value];
+  }
+  const splitRe = new RegExp(`(?<!\\\\)${escapeRegex(bare)}`, "g");
+  const unescapeRe = new RegExp(`\\\\${escapeRegex(bare)}`, "g");
+  return value.split(splitRe).map((part) => part.replace(unescapeRe, bare));
+}
+function splitFirstDelimited(value, bracketed) {
+  if (!bracketed) {
+    return [value];
+  }
+  if (value.includes(bracketed)) {
+    const idx = value.indexOf(bracketed);
+    return [value.slice(0, idx), value.slice(idx + bracketed.length)];
+  }
+  const bare = stripBrackets(bracketed);
+  if (!bare) {
+    return [value];
+  }
+  const splitRe = new RegExp(`(?<!\\\\)${escapeRegex(bare)}`);
+  const unescapeRe = new RegExp(`\\\\${escapeRegex(bare)}`, "g");
+  const parts = value.split(splitRe);
+  const first = (parts[0] ?? "").replace(unescapeRe, bare);
+  if (parts.length === 1) {
+    return [first];
+  }
+  return [first, parts.slice(1).join(bare).replace(unescapeRe, bare)];
+}
+
 class CMIInteractions extends CMIArray {
   /**
    * Constructor for `cmi.interactions` Array
@@ -19139,8 +19200,7 @@ class CMIInteractionsObject extends BaseCMI {
       const response_type = LearnerResponses[this.type];
       if (response_type) {
         if (response_type?.delimiter) {
-          const delimiter = response_type.delimiter === "[,]" ? "," : response_type.delimiter;
-          nodes = learner_response.split(delimiter);
+          nodes = splitDelimited(learner_response, response_type.delimiter);
         } else {
           nodes[0] = learner_response;
         }
@@ -19148,10 +19208,10 @@ class CMIInteractionsObject extends BaseCMI {
           const formatRegex = new RegExp(response_type.format);
           for (let i = 0; i < nodes.length; i++) {
             if (response_type?.delimiter2) {
-              const delimiter2 = response_type.delimiter2 === "[.]" ? "." : response_type.delimiter2;
-              const values = nodes[i]?.split(delimiter2);
+              const node = nodes[i] ?? "";
+              const values = this.type === "performance" ? splitFirstDelimited(node, response_type.delimiter2) : splitDelimited(node, response_type.delimiter2);
               if (values?.length === 2) {
-                if (this.type === "performance" && (values[0] === "" || values[1] === "")) {
+                if (this.type === "performance" && values[0] === "" && values[1] === "") {
                   throw new Scorm2004ValidationError(
                     this._cmi_element + ".learner_response",
                     scorm2004_errors.TYPE_MISMATCH
@@ -19370,30 +19430,13 @@ class CMIInteractionsObjectivesObject extends BaseCMI {
     return result;
   }
 }
-function stripBrackets(delim) {
-  return delim.replace(/[[\]]/g, "");
-}
-function escapeRegex(s) {
-  return s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
-}
-function splitUnescaped(text, delim) {
-  const reDelim = escapeRegex(delim);
-  const splitRe = new RegExp(`(?<!\\\\)${reDelim}`, "g");
-  const unescapeRe = new RegExp(`\\\\${reDelim}`, "g");
-  return text.split(splitRe).map((part) => part.replace(unescapeRe, delim));
-}
-function splitFirstUnescaped(text, delim) {
-  const reDelim = escapeRegex(delim);
-  const splitRe = new RegExp(`(?<!\\\\)${reDelim}`);
-  const unescapeRe = new RegExp(`\\\\${reDelim}`, "g");
-  const parts = text.split(splitRe);
-  const firstPart = parts[0] ?? "";
-  if (parts.length === 1) {
-    return [firstPart.replace(unescapeRe, delim)];
+const RESPONSE_PREFIX_RE = /^\{(?:lang|case_matters|order_matters)=[^}]+\}/;
+function stripResponsePrefixes(node) {
+  let result = node;
+  while (RESPONSE_PREFIX_RE.test(result)) {
+    result = result.replace(RESPONSE_PREFIX_RE, "");
   }
-  const part1 = firstPart.replace(unescapeRe, delim);
-  const part2 = parts.slice(1).join(delim).replace(unescapeRe, delim);
-  return [part1, part2];
+  return result;
 }
 function validatePattern(type, pattern, responseDef) {
   if (pattern.trim() !== pattern) {
@@ -19402,8 +19445,7 @@ function validatePattern(type, pattern, responseDef) {
       scorm2004_errors.TYPE_MISMATCH
     );
   }
-  const subDelim1 = responseDef.delimiter ? stripBrackets(responseDef.delimiter) : null;
-  const rawNodes = subDelim1 ? splitUnescaped(pattern, subDelim1) : [pattern];
+  const rawNodes = responseDef.delimiter ? splitDelimited(pattern, responseDef.delimiter) : [pattern];
   for (const raw of rawNodes) {
     if (raw.trim() !== raw) {
       throw new Scorm2004ValidationError(
@@ -19415,20 +19457,14 @@ function validatePattern(type, pattern, responseDef) {
   if (type === "fill-in" && pattern === "") {
     return;
   }
-  const delim1 = responseDef.delimiter ? stripBrackets(responseDef.delimiter) : null;
-  let nodes;
-  if (delim1) {
-    nodes = splitUnescaped(pattern, delim1);
-  } else {
-    nodes = [pattern];
-  }
+  const nodes = responseDef.delimiter ? splitDelimited(pattern, responseDef.delimiter) : [pattern];
   if (!responseDef.delimiter && pattern.includes(",")) {
     throw new Scorm2004ValidationError(
       "cmi.interactions.n.correct_responses.n.pattern",
       scorm2004_errors.TYPE_MISMATCH
     );
   }
-  if (responseDef.unique || responseDef.duplicate === false) {
+  if (type !== "numeric" && (responseDef.unique || responseDef.duplicate === false)) {
     const seen = new Set(nodes);
     if (seen.size !== nodes.length) {
       throw new Scorm2004ValidationError(
@@ -19460,8 +19496,7 @@ function validatePattern(type, pattern, responseDef) {
         scorm2004_errors.TYPE_MISMATCH
       );
     }
-    const delim = stripBrackets(delimBracketed);
-    const parts = value.split(new RegExp(`(?<!\\\\)${escapeRegex(delim)}`, "g")).map((n) => n.replace(new RegExp(`\\\\${escapeRegex(delim)}`, "g"), delim));
+    const parts = splitDelimited(value, delimBracketed);
     if (parts.length !== 2 || parts[0] === "" || parts[1] === "") {
       throw new Scorm2004ValidationError(
         "cmi.interactions.n.correct_responses.n.pattern",
@@ -19478,15 +19513,17 @@ function validatePattern(type, pattern, responseDef) {
   for (const node of nodes) {
     switch (type) {
       case "numeric": {
-        const numDelim = responseDef.delimiter ? stripBrackets(responseDef.delimiter) : ":";
-        const nums = node.split(numDelim);
-        if (nums.length < 1 || nums.length > 2) {
-          throw new Scorm2004ValidationError(
-            "cmi.interactions.n.correct_responses.n.pattern",
-            scorm2004_errors.TYPE_MISMATCH
-          );
+        if (node === "") {
+          const bracketedRange = nodes.length >= 2 && !!responseDef.delimiter && pattern.includes(responseDef.delimiter);
+          if (!bracketedRange) {
+            throw new Scorm2004ValidationError(
+              "cmi.interactions.n.correct_responses.n.pattern",
+              scorm2004_errors.TYPE_MISMATCH
+            );
+          }
+          break;
         }
-        nums.forEach(checkSingle);
+        checkSingle(node);
         break;
       }
       case "performance": {
@@ -19497,8 +19534,8 @@ function validatePattern(type, pattern, responseDef) {
             scorm2004_errors.TYPE_MISMATCH
           );
         }
-        const delim = stripBrackets(delimBracketed);
-        const parts = splitFirstUnescaped(node, delim);
+        const record = stripResponsePrefixes(node);
+        const parts = splitFirstDelimited(record, delimBracketed);
         if (parts.length !== 2) {
           throw new Scorm2004ValidationError(
             "cmi.interactions.n.correct_responses.n.pattern",
@@ -19506,7 +19543,7 @@ function validatePattern(type, pattern, responseDef) {
           );
         }
         const [part1, part2] = parts;
-        if (part1 === "" || part2 === "" || part1 === part2) {
+        if (part1 === "" && part2 === "") {
           throw new Scorm2004ValidationError(
             "cmi.interactions.n.correct_responses.n.pattern",
             scorm2004_errors.TYPE_MISMATCH
@@ -22385,7 +22422,7 @@ class Scorm2004ResponseValidator {
   checkValidResponseType(CMIElement, response_type, value, interaction_type) {
     let nodes = [];
     if (response_type?.delimiter) {
-      nodes = String(value).split(response_type.delimiter);
+      nodes = splitDelimited(String(value), response_type.delimiter);
     } else {
       nodes[0] = value;
     }
@@ -22507,22 +22544,30 @@ class Scorm2004ResponseValidator {
         nodes[i] = this.removeCorrectResponsePrefixes(CMIElement, nodes[i]);
       }
       if (response?.delimiter2) {
-        const values = nodes[i].split(response.delimiter2);
+        const values = interaction_type === "performance" ? splitFirstDelimited(nodes[i], response.delimiter2) : splitDelimited(nodes[i], response.delimiter2);
         if (values.length === 2) {
-          const matches = values[0].match(formatRegex);
-          if (!matches) {
+          if (interaction_type === "performance" && values[0] === "" && values[1] === "") {
             this.context.throwSCORMError(
               CMIElement,
               scorm2004_errors.TYPE_MISMATCH,
               `${interaction_type}: ${value}`
             );
           } else {
-            if (!response.format2 || !values[1].match(new RegExp(response.format2))) {
+            const matches = values[0]?.match(formatRegex);
+            if (!matches) {
               this.context.throwSCORMError(
                 CMIElement,
                 scorm2004_errors.TYPE_MISMATCH,
                 `${interaction_type}: ${value}`
               );
+            } else {
+              if (!response.format2 || !values[1]?.match(new RegExp(response.format2))) {
+                this.context.throwSCORMError(
+                  CMIElement,
+                  scorm2004_errors.TYPE_MISMATCH,
+                  `${interaction_type}: ${value}`
+                );
+              }
             }
           }
         } else {
@@ -22533,6 +22578,9 @@ class Scorm2004ResponseValidator {
           );
         }
       } else {
+        if (interaction_type === "numeric" && nodes.length > 1 && nodes[i] === "" && !!response.delimiter && String(value).includes(response.delimiter)) {
+          continue;
+        }
         const matches = nodes[i].match(formatRegex);
         if (!matches && value !== "" || !matches && interaction_type === "true-false") {
           this.context.throwSCORMError(
@@ -22542,7 +22590,7 @@ class Scorm2004ResponseValidator {
           );
         } else {
           if (interaction_type === "numeric" && nodes.length > 1) {
-            if (Number(nodes[0]) > Number(nodes[1])) {
+            if (nodes[0] !== "" && nodes[1] !== "" && Number(nodes[0]) > Number(nodes[1])) {
               this.context.throwSCORMError(
                 CMIElement,
                 scorm2004_errors.TYPE_MISMATCH,