scimgateway 4.5.5 → 4.5.6

package/README.md

@@ -1163,6 +1163,12 @@ MIT © [Jarle Elshaug](https://www.elshaug.xyz)
 
 ## Change log  
 
+### v4.5.6  
+
+[Improved]
+
+- plugin-ldap preserve multivalue-attribute order on modify. Do not apply to groups/members.
+
 ### v4.5.5  
 
 [Fixed]

package/lib/plugin-ldap.js

@@ -1110,7 +1110,15 @@ const doRequest = async (baseEntity, method, base, ldapOptions, ctx) => {
           for (const key in options.modification) {
             const mod = {}
             mod.type = key
-            if (Array.isArray(options.modification[key])) mod.values = options.modification[key]
+            if (Array.isArray(options.modification[key])) {
+              mod.values = options.modification[key]
+              if (mod.values.length > 1) { // delete before replace to keep inbound order
+                changes.push({
+                  operation: 'delete',
+                  modification: {type: key, values: []}
+                })
+              }
+            }
             else {
               if (typeof options.modification[key] === 'string') mod.values = [options.modification[key]]
               else mod.values = [options.modification[key].toString()]

package/lib/scimgateway.js

@@ -2543,18 +2543,20 @@ ScimGateway.prototype.endpointMapper = function endpointMapper (direction, parse
           let arrIndex = null
           const arr = key.split('.') // multivalue/array - servicePlan.0.value
           const keyOrg = key
-          if (arr[arr.length - 1] === 'value') {
-            if (!isNaN(arr[arr.length - 2])) { // servicePlan.0.value => servicePlan.0
-              for (let i = 0; i < (arr.length - 2); i++) {
+          if (arr.length > 1 && arr[arr.length - 1] === 'value') {
+            const secondLast = arr.length - 2
+            if (!isNaN(arr[secondLast])) { // servicePlan.0.value => servicePlan.0
+              for (let i = 0; i < (secondLast); i++) {
                 if (i === 0) key = arr[i]
                 else key += `.${arr[i]}`
               }
-              arrIndex = arr[arr.length - 2]
-            } else if (arr[arr.length - 2].slice(-1) === ']' && arr.length - 2 === 0) { // groups[0].value => groups.value
-              const startPos = arr[0].indexOf('[')
+              arrIndex = arr[secondLast]
+            } else if (arr[secondLast].slice(-1) === ']') { // groups[0].value => groups.value
+              const prefix = arr.slice(0, -1).join('.')
+              const startPos = prefix.indexOf('[')
               if (startPos > 0) {
-                key = arr[0].substring(0, startPos) + '.value' // groups.value
-                arrIndex = arr[0].substring(startPos + 1, arr[0].length - 1) // 1
+                key = prefix.substring(0, startPos) + '.value' // groups.value
+                arrIndex = prefix.substring(startPos + 1, prefix.length - 1) // 1
               }
             }
           }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "scimgateway",
-  "version": "4.5.5",
+  "version": "4.5.6",
   "description": "Using SCIM protocol as a gateway for user provisioning to other endpoints",
   "author": "Jarle Elshaug <jarle.elshaug@gmail.com> (https://elshaug.xyz)",
   "homepage": "https://elshaug.xyz",