scimgateway 4.2.13 → 4.2.14

package/README.md

@@ -1170,6 +1170,12 @@ MIT © [Jarle Elshaug](https://www.elshaug.xyz)
 
 ## Change log  
 
+### v4.2.14
+  
+[Fixed] 
+
+- PUT now returning 404 instead of 500 when trying to update a user/group that does not exist
+
 ### v4.2.13
   
 [Fixed] 

package/lib/scimgateway.js

@@ -1370,11 +1370,21 @@ const ScimGateway = function () {
         logger.debug(`${gwName}[${pluginName}] calling "${handle.getMethod}" and awaiting result`)
         let res = await this[handle.getMethod](ctx.params.baseEntity, { attribute: 'id', operator: 'eq', value: id }, [], ctx.ctxCopy)
 
-        let currentObj = {}
-        if (res && res.Resources && Array.isArray(res.Resources) && res.Resources.length === 1) currentObj = res.Resources[0]
-        else if (Array.isArray(res) && res.length === 1) currentObj = res[0]
+        let currentObj
+        if (res && res.Resources && Array.isArray(res.Resources)) {
+          if (res.Resources.length === 1) currentObj = res.Resources[0]
+          else currentObj = {}
+        } else if (Array.isArray(res) && res.length === 1) currentObj = res[0]
         else if (res && typeof (res) === 'object' && Object.keys(res).length > 0) currentObj = res
-        else throw Error(`put using method ${handle.getMethod} got unexpected response: ${JSON.stringify(res)}`)
+        else currentObj = {}
+
+        if (typeof (currentObj) !== 'object' || Object.keys(currentObj).length === 0) {
+          ctx.status = 404
+          let err = new Error(`put using method ${handle.getMethod} error: ${handle.description.toLowerCase()} id=${id} does not exist`)
+          err = jsonErr(config.scim.version, pluginName, ctx.status, err)
+          ctx.body = err
+          return
+        }
 
         const clearedObj = clearObjectValues(currentObj)
         delete clearedObj.active

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "scimgateway",
-  "version": "4.2.13",
+  "version": "4.2.14",
   "description": "Using SCIM protocol as a gateway for user provisioning to other endpoints",
   "author": "Jarle Elshaug <jarle.elshaug@gmail.com> (https://elshaug.xyz)",
   "homepage": "https://elshaug.xyz",